Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3006
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3008
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2861
I checked the elasticsearch documentation and some user forum from ES, and
indeed it seems that they do not include any retry logic into their clients.
---
If your project is set up for it, you
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2861#discussion_r93043759
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2861#discussion_r93045771
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2861
@fpompermaier Why is throwing exceptions in close causing document losses?
As far as I can see ES is flushing all outstanding batches on close().
---
If your project is set up for it, you can
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2861#discussion_r93048695
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2861#discussion_r93049169
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2861
@fpompermaier I guess logstash is just a client to ES that implement its
own retry logic (similar to Flink).
I'll check out the JIRA.
---
If your project is set up for it, you can rep
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2767#discussion_r93052912
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch5/pom.xml
---
@@ -0,0 +1,93 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2767#discussion_r93053073
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch5/pom.xml
---
@@ -0,0 +1,93 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2767
@StephanEwen I'll start a discussion on the mailing list to decide how we
want to proceed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3029#discussion_r93206487
--- Diff: pom.xml ---
@@ -91,7 +91,6 @@ under the License.
1C
true
log4j-test.properties
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3029
I've tested the change on a YARN cluster (I know there are tests for that).
I'm currently trying out the quickstarts as well.
---
If your project is set up for it, you can reply to this
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3029
(quickstart worked as well!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3030
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2142#discussion_r68060615
--- Diff: docs/apis/streaming/connectors/kafka.md ---
@@ -198,6 +198,63 @@ Flink on YARN supports automatic restart of lost YARN
containers.
If
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2142#discussion_r68061306
--- Diff: docs/apis/streaming/connectors/kafka.md ---
@@ -198,6 +198,63 @@ Flink on YARN supports automatic restart of lost YARN
containers.
If
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2142
Thank you for opening the pull request.
There's one issue that needs addressing, once that's done, we can merge it.
---
If your project is set up for it, you can reply to this emai
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2148
[FLINK-3995] [build] Make test utils properly available and fix Maven
dependencies
This pull request subsumes https://github.com/apache/flink/pull/2092.
I added a commit to Stephan's
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2108#discussion_r68082639
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2142
Okay, merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2151
[hotfix][docs] Add warning to Cassandra documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink cassandra_doc_hotfix
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2153
[FLINK-4110] Add testing skeleton to quickstart
With this change, our quickstart archetypes will also contain some sample
code for bringing up an embedded server for testing purposes.
You can
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'll review your change now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2071#discussion_r68386857
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerThread.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68397478
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399389
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/IKinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399467
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399431
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399454
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68400596
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/IKinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68400657
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68402254
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68403594
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68403918
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68404148
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68406625
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68410216
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68413466
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2071
Yes, I would suggest to do this PR after the big one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'm not done with the review yet. I hope I find some time over the weekend
to continue with it.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
Okay, sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68453630
--- Diff: flink-streaming-connectors/flink-connector-redis/pom.xml ---
@@ -0,0 +1,92 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68453882
--- Diff: flink-streaming-connectors/flink-connector-redis/pom.xml ---
@@ -0,0 +1,92 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68454370
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,232
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68454559
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68454693
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68455103
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68455334
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSentinelClusterTest.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68455277
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSentinelClusterTest.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/1813
@mjsax, did you test the code with a redis installation / on a cluster?
(I'm not expecting those tests from a PR review, but I would not do it again if
you already did ... and I'm no
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2163
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2166
[FLINK-4099] Fix CliFrontendYarnAddressConfigurationTest failures
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink4099
Github user rmetzger closed the pull request at:
https://github.com/apache/flink/pull/2151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2151
Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68558779
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyInterface.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68560835
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68562955
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68564082
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68564678
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2166
Thank you for the review.
I'll wait until travis is passing and then merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68582306
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68583275
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
@tzulitai: I'm still not done with the review. I hope I can get it done in
the next two hours.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68594061
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68722233
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68726797
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68727843
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68729145
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'm done with my first full review. I'll test the code tomorrow.
Let me know if you need help addressing my comments.
---
If your project is set up for it, you can reply to this emai
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2175
[FLINK-4085][Kinesis] Set Flink-specific user agent
I was asked by Amazon to set a Flink specific user agent when accessing the
AWS APIs.
I've set an agent for the consumer, for the produ
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2175#discussion_r68757009
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2175#discussion_r68757090
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2175
Thank you for the review. It seems that I'm not that focused today ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2177
[FLINK-4127] Check API compatbility for 1.1 in flink-core
I checked all the newly introduced methods in public APIs by going through
the reports generated from japicmp.
I've also pu
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2180
Thanks a lot for fixing this. I'll try to review it in the next few hours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r68904562
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,211 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r68904915
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,211 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2180#discussion_r68905535
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/SequenceNumber.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r68906518
--- Diff: docs/setup/config.md ---
@@ -85,6 +85,8 @@ The default fraction for managed memory can be adjusted
using the `taskmanager.m
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2180#discussion_r68906667
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/SequenceNumber.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2180
+1 the change is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r68918991
--- Diff: docs/setup/config.md ---
@@ -85,6 +85,8 @@ The default fraction for managed memory can be adjusted
using the `taskmanager.m
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68930725
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
Okay, I'll merge the exactly once fix now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2181
Thank you for opening a PR. I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r68933286
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -269,26 +269,26 @@
* Percentage of heap space to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r68933327
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -269,26 +269,26 @@
* Percentage of heap space to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r68933356
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -269,26 +269,26 @@
* Percentage of heap space to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2174#discussion_r69100533
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -334,9 +342,11
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2174#discussion_r69102339
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -334,9 +342,11
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2187
Change looks good! +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2108
Thank you for your review @tillrohrmann and @zentol . I tried addressing
all your concerns.
Please let me know what you think about it.
---
If your project is set up for it, you can reply to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r69267193
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -269,26 +269,26 @@
* Percentage of heap space to
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2177
I addressed all comments. It seems to me that the configuration parameters
for YARN are overly complicated now because they are separated in resource
manager and YARN now.
---
If your project is
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r69274234
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/KinesisConfigConstants.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r69274851
--- Diff: docs/apis/streaming/connectors/kinesis.md ---
@@ -60,10 +60,10 @@ to setup Kinesis streams. Make sure to create the
appropriate IAM policy and use
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r69285572
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2167
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
201 - 300 of 2433 matches
Mail list logo
