[GitHub] flink pull request: FLINK-2740 Adding flink-connector-nifi module ...

2015-10-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1198#discussion_r40899178 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi

[GitHub] flink pull request: FLINK-2740 Adding flink-connector-nifi module ...

2015-10-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1198#discussion_r40899251 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java

[GitHub] flink pull request: FLINK-2740 Adding flink-connector-nifi module ...

2015-10-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1198#discussion_r40899297 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java

[GitHub] flink pull request: FLINK-2740 Adding flink-connector-nifi module ...

2015-10-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1198#discussion_r40899307 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi

[GitHub] flink pull request: FLINK-2740 Adding flink-connector-nifi module ...

2015-10-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1198#discussion_r40899440 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/pom.xml --- @@ -0,0 +1,94 @@ + + +http

[GitHub] flink pull request: [FLINK-2793] [dashboard] Redirect to leader in...

2015-10-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1202#issuecomment-144745094 +1 The change looks good to merge. (maybe we should add the JIRA id when merging) --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2793] [dashboard] Redirect to leader in...

2015-10-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1202#issuecomment-144747629 No, I didn't try it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: FLINK-2740 Adding flink-connector-nifi module ...

2015-10-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1198#issuecomment-144762615 Thank you for looking into it. Your analysis was right: I've accidentally put the port into the host parameter `nifi.remote.input.socket.host=9081`.

[GitHub] flink pull request: [FLINK-2748] accumulator fetch failure leads t...

2015-10-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1206#issuecomment-144764416 -1. Build fails ``` Results : Failed tests: AccumulatorErrorITCase.testFaultyAccumulator:97 Root cause should be: Tests in error

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-144765643 @willmiao: What is the status of this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: FLINK-2740 Adding flink-connector-nifi module ...

2015-10-02 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1198#issuecomment-144960807 Great. Thank you for your answers. I think its fine to let users deal with cases when multiple systems want to consume data from a NiFi flow. Once my in-code

[GitHub] flink pull request: FLINK-2740 Adding flink-connector-nifi module ...

2015-10-02 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1198#issuecomment-144961452 Ah, you've addressed my feedback. I should refresh my browser before commenting ;) So +1, good to merge --- If your project is set up for it, you can

[GitHub] flink pull request: [hotfix] Execute YARN integration tests only u...

2015-10-02 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1210 [hotfix] Execute YARN integration tests only upon request ...by activating the 'include-yarn-tests' profile The default Hadoop version set in Flink (2.3.0) is causing the MiniY

[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...

2015-10-03 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1219#issuecomment-145320562 Thank you for resolving the issue so quickly. I think its good to merge. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-03 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1222 [FLINK-2798] Serve static files for the new web frontend from the classloader This pull request is based on https://github.com/apache/flink/pull/1202. In order to make the new web

[GitHub] flink pull request: FLINK-2740 Adding flink-connector-nifi module ...

2015-10-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1198#issuecomment-145400455 I'm going to merge this PR ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] flink pull request: [hotfix] Execute YARN integration tests only u...

2015-10-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1210#issuecomment-145400579 Thank you for the feedback. Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2790] [yarn] [ha] Adds high availabilit...

2015-10-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1213#issuecomment-145404233 I've looked a bit over the code and it all looks like good changes. I've tested the code on a Hadoop 2.6.0 cluster and the YARN session was restartin

[GitHub] flink pull request: [FLINK-2790] [yarn] [ha] Adds high availabilit...

2015-10-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1213#issuecomment-145577205 I killed the AM using "kill" from the command line, and all the Taskmanagers were shutting down --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1223#issuecomment-145708133 Thanks a lot for your contribution to Flink! Sorry for not giving you feedback earlier. Many committers are currently busy preparing the next Flink release

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

2015-10-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1197#issuecomment-145708723 Thank you for the review @nikste! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1222#issuecomment-145733149 Thank you for the review. I'm trying to update the PR within the next 24 hours Sorry for not explaining why I changed all the request URLs to relative paths:

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-10-06 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-145863259 and it has conflicts again :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2823][yarn] throw exception on file as ...

2015-10-07 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1235#issuecomment-146303645 I don't think that we can merge this change. We can not assume that file:/// is an invalid path. Also, I don't think there is a good way to check whether

[GitHub] flink pull request: [FLINK-2731][web-dashboard] Adds access to Job...

2015-10-07 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1233#issuecomment-146322559 I have a pending pull request to enable it on YARN. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-07 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1222#issuecomment-146400367 I will wait until your pull request is merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-2731][web-dashboard] Adds access to Job...

2015-10-08 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1233#issuecomment-146737214 @sachingoel0101: my pull request (https://github.com/apache/flink/pull/1222) is actually based on @uce's PR (https://github.com/apache/flink/pull/1202). I'

[GitHub] flink pull request: [FLINK-2793] [dashboard] Redirect to leader in...

2015-10-08 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1202#issuecomment-146737613 Are there any blockers to this PR. Otherwise, I'd like to have it merged rather soon. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2780] Remove Old Windowing Logic and AP...

2015-10-08 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1242#issuecomment-146738873 +1 to get rid of the old API asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2725] Max/Min/Sum Aggregation of mutabl...

2015-10-08 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1191#discussion_r41595057 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/ValueTypeInfo.java --- @@ -51,7 +51,18 @@ public class ValueTypeInfo extends

[GitHub] flink pull request: [FLINK-2725] Max/Min/Sum Aggregation of mutabl...

2015-10-08 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1191#discussion_r41595115 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/aggregation/SumAggregationFunction.java --- @@ -113,11 +182,32 @@ public Long getAggregate

[GitHub] flink pull request: [FLINK-2793] [dashboard] Redirect to leader in...

2015-10-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1202#issuecomment-146991673 Great ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-147009266 That's indeed a good question. I don't have much time currently, but I'm trying to answer you within the next few days. --- If your project is set up

[GitHub] flink pull request: [FLINK-2842] [documentation] Remove Flink S3Fi...

2015-10-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1245#issuecomment-147009826 Great that we finally get rid of this AWS dependency. It seems that the dependency actually influenced somehow other dependencies from Hadoop. I have a

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-10-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1243#issuecomment-147625208 Hi Hilmi, thank you for your PR. We'll review it soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] flink pull request: Fix Avro getter/setter recognition

2015-10-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1252#issuecomment-148080563 Could you also add a test case that validates the fix? I'm sorry that we are requesting these things, but managing such a big project requires some stru

[GitHub] flink pull request: [FLINK-2843] Add documentation for outer joins...

2015-10-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1248#issuecomment-148328036 Thank you for documenting the feature. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-2844][jobmanager] remove old web interf...

2015-10-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1246#issuecomment-148367867 I suspect we can close https://github.com/apache/flink/pull/1222 then? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-15 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/1222 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1222#issuecomment-148369010 Max took the relevant changes from this PR into https://github.com/apache/flink/pull/1246. Closing ... --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2015-10-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/948#issuecomment-148403603 I tried running the code from this pull request again, this time using the `mesos-playa` vagrant image, and it does not work for me. I was following your

[GitHub] flink pull request: [FLINK-2898] [build] Invert Travis CI build or...

2015-11-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1290#issuecomment-153754298 -1 This change breaks the nightly deployment. I'll reopen FLINK-2898. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] flink pull request: [FLINK-2972] [JavaAPI] Remove Chill dependency...

2015-11-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1331#issuecomment-154023724 PR looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-05 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1327#discussion_r43997592 --- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee --- @@ -28,6 +28,32 @@ angular.module('fli

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1327#issuecomment-154025813 PR looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-05 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1327#discussion_r43998970 --- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee --- @@ -28,6 +28,32 @@ angular.module('fli

[GitHub] flink pull request: [doc] fix spelling mistakes in the transformat...

2015-11-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1333#issuecomment-154083197 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155059566 Thanks a lot for working on this. I've tried out your changes locally, and it was working as expected. - Why is there a 10 MB limit on the upload? Usually p

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155065545 Okay, I see. Lets not fix it as part of this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155074648 Mh, Fabian is right. In practice, jar files very often exceed 10 MB. > Does the web monitor also use heap space out of Job Manager? ] Yes, the

[GitHub] flink pull request: [FLINK-2987] Remove jersey-core and jersey-cli...

2015-11-09 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1340 [FLINK-2987] Remove jersey-core and jersey-client dependency exclusions … to make Flink on Hadoop 2.6.0+ work again. This PR is for the 0.10 release branch. Please review this

[GitHub] flink pull request: [FLINK-2987] Remove jersey-core and jersey-cli...

2015-11-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1340#issuecomment-155086171 I just verified the fix on the Azure cluster with Hadoop 2.6.0 and it's working now. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155097754 Since its probably an intentional limitation of the proxy, how about the following approach: If the web frontend is running on YARN, we show the direct URL (not

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155102201 Good idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2987] Remove jersey-core and jersey-cli...

2015-11-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1340#issuecomment-155103312 I also tested the patch on a Hadoop 2.4 machine, using the default Hadoop 2.3 build. +1 to merge for the 0.10 release --- If your project is set up for it

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-09 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1341 [FLINK-2974] Add periodic offset committer for Kafka The offset committer is only enabled when Flink's checkpointing is disabled. When checkpointing is enabled, we commit to ZK upon check

[GitHub] flink pull request: [FLINK-2987] Remove jersey-core and jersey-cli...

2015-11-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1340#issuecomment-155112495 I've merged it to the `release-0.10` branch. Once travis has passed for master, I'll merge it there as well and close the issue. --- If your project is

[GitHub] flink pull request: Remove and forbid use of SerializationUtils. F...

2015-11-10 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1343 Remove and forbid use of SerializationUtils. Fix FLINK-2992 The SerializationUtils are usually not using the right classloader, and they have some security issues. I'm using our check

[GitHub] flink pull request: Remove and forbid use of SerializationUtils. F...

2015-11-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1343#issuecomment-155412487 I tested the change on a cluster and it's working. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] flink pull request: Remove and forbid use of SerializationUtils. F...

2015-11-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1343#discussion_r44404877 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java --- @@ -167,15 +166,11 @@ public WindowedStream

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155421694 I assume the PR is ready for another round of reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155424425 Okay :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155713026 Thank you. I've tested it on a YARN cluster, but the URL it is showing is not correct. It seems to me that you are just using the current hostname + ip of th

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155732014 Thank you. Sadly, I've shut down the cluster a few minutes ago, because I was finished with the release testing. I'll try soon... --- If your project

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-155738690 I know. The problem is that MS Azure cloud needs 30 minutes to deploy a small hortonworks cluster. Google handles that in a few minutes. But I can use another

[GitHub] flink pull request: [FLINK-2989] job cancel button doesn't work on...

2015-11-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1344#issuecomment-155763996 Maybe not as part of this PR, but in the long term, we should add a integration test for cancelling a job running in a YARN session. --- If your project is set up for

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-155764769 The tests on travis are failing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1342#discussion_r44527912 --- Diff: flink-yarn/pom.xml --- @@ -63,6 +63,11 @@ under the License. test

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-155768292 Thanks a lot for working on this issue! It doesn't happen everyday that users identify issues, fix them and verify the fix so properly :) I would really

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1341#issuecomment-156372109 Thank you for the detailed review. I will address your concerns soon. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1342#discussion_r44764775 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -135,7 +138,54 @@ public static void setTokensFor(ContainerLaunchContext

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1342#discussion_r44764797 --- Diff: pom.xml --- @@ -82,6 +82,7 @@ under the License. error 1.2.1 2.3.0 + 1.1.2

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-156379250 I had some minor remarks to the PR, but overall, I'd like to merge it like this! --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1342#discussion_r44764893 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -249,7 +249,15 @@ if [ -n "$HADOOP_HOME" ]; then

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1342#discussion_r44767927 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -249,7 +249,15 @@ if [ -n "$HADOOP_HOME" ]; then

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-156388624 Thank you for addressing my concerns so quickly +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-156423600 Amazing, thank you. I'm going to merge you change as soon as Travis gives me green light ;) I've squashed and rebased your commit and will push it p

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156429370 Testing it again on YARN --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156432901 I think we need to improve a bit on the error messages. This is what I got for submitting a job without arguments on the web interface: ``` Error in

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156433498 Even with all the fields filled, it was not starting: http://i.imgur.com/5WXKw9N.png the log file also contained no helpful information --- If your project

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156450181 here is the jar file: https://transfer.sh/KNAnm/flink0.10-scala2.11-1.0-snapshot.jar it has been build from here: https://github.com/rmetzger/scratch/tree

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156476686 the jar has been build with scala 2.11 yes, flink with scala 2.10. But I still expect a good exception in the web frontend for this. --- If your project is set up

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156479850 Maybe it makes sense to just show the entire exception to the user, instead of trying to cut away parts of the stack trace? --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156494598 Okay, let me know when you are ready for another test drive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156503204 Okay, I'll test it again. This time, I'm building Flink with Scala 2.11. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156510858 Good news. Test on cluster was successful. I'll take another look at the code, but otherwise +1 from my side. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-16 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1361 [FLINK-2967] Enhance TaskManager network detection JIRA: https://issues.apache.org/jira/browse/FLINK-2967 - Increase timeout for `LOCAL_HOST` address detection strategy - give the

[GitHub] flink pull request: [FLINK-3021] Fix class loading issue for strea...

2015-11-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1368#issuecomment-157384055 +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2972] [JavaAPI] Remove Chill dependency...

2015-11-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1331#issuecomment-157383461 I can confirm that `chill-avro` was never used. I accidentally committed the dependency while trying out different approaches for handling Avro POJOs with Flink

[GitHub] flink pull request: Fix JavaDoc of ElasticsearchSink

2015-11-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1367#issuecomment-157430943 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45087435 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandler.java --- @@ -0,0 +1,70 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45087911 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -635,8 +644,18 @@ * The default number of archived

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45088017 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/PipelineErrorHandler.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45088529 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -635,8 +644,18 @@ * The default number of archived

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45088463 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java --- @@ -0,0 +1,130 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45094049 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java --- @@ -0,0 +1,130 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45094240 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandler.java --- @@ -0,0 +1,70 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45094375 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java --- @@ -0,0 +1,130 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45100162 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -635,8 +644,18 @@ * The default number of archived

[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1361#issuecomment-157503990 This has been merged, @StephanEwen probably forgot to close the PR, so I'm closing it manually. --- If your project is set up for it, you can reply to this emai

<    1   2   3   4   5   6   7   8   9   10   >