Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/264#issuecomment-68992190
Are there other opinions on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/275#issuecomment-67841095
+1 for having a clear code structure. IMO, we should either move the whole
flink-streaming module to the root folder or keep everything under flink-addons
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/243#issuecomment-67062906
Sounds good!
One thing that came to my mind. It would be good if we could keep the
user-facing parts of the old API in their original place and mark them
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/243#issuecomment-67033562
Cool, thanks! :-)
Did you extend the PR in any of the above mentioned directions (Pojos,
Scala, ...)?
Let me know, when you want somebody to have a
GitHub user fhueske opened a pull request:
https://github.com/apache/incubator-flink/pull/267
[FLINK-1236] Add local split assignment support for HadoopInputFormats
Forwards the location information from Hadoop InputSplits to Flink
InputSplits to enable local split assignment.
You
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/243#issuecomment-67014255
@he-sk are you working on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/264#issuecomment-66978329
The question is whether we want to keep the char-delimiter in the
user-facing API.
I would remove it in the long run to have the consistent data types for
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/260#issuecomment-66967968
Thanks for the quick update!
LGTM, will merge :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/260#issuecomment-66800177
Ah, OK. I got it :-)
I think we need only one method to recursively enumerate files (and compute
their length).
Not doing the `acceptFile()` check
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-66785727
Looks good. Thanks!
Will merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/258#issuecomment-66782412
Thanks for the review! Will merge it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user fhueske opened a pull request:
https://github.com/apache/incubator-flink/pull/265
[FLINK-1318] CsvInputFormat: Made quoted string parsing optional with
configurable quote character. Simplified parsing
- Parsing of quoted strings is disabled by default
- When
GitHub user fhueske opened a pull request:
https://github.com/apache/incubator-flink/pull/264
[FLINK-1168] Adds multi-char field delimiter support for CsvInputFormats
This commit includes parts of Cbro's pull request and subsumes PR #247
This closes #247
You can merge
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/260#discussion_r21667668
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java ---
@@ -506,6 +527,31 @@ public LocatableInputSplitAssigner
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/260#issuecomment-66594693
LGTM (except for one inline comment and the documentation) :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/260#discussion_r21665415
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java ---
@@ -506,6 +527,31 @@ public LocatableInputSplitAssigner
GitHub user fhueske opened a pull request:
https://github.com/apache/incubator-flink/pull/258
[FLINK-1287] LocalizableSplitAssigner prefers splits with less degrees of
freedom
The current LocalizableSplitAssigner assigns remote and local splits
without priorities, i.e., each
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/173#issuecomment-66038696
Thanks! Will merge now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/247#discussion_r21409066
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -375,7 +377,7 @@ protected int skipFields(byte
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/247#discussion_r21409043
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -358,7 +359,8 @@ protected int skipFields(byte
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/247#discussion_r21404005
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java ---
@@ -307,4 +310,75 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/247#discussion_r21404017
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java ---
@@ -307,4 +310,75 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/247#discussion_r21403969
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/StringValueParser.java
---
@@ -38,15 +38,16 @@
private StringValue result
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-65861146
Did you manage to solve the merge conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21100941
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/aggregation/AggregationOperatorFactory.java
---
@@ -0,0 +1,297
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21100873
--- Diff:
flink-examples/flink-java-examples/src/test/java/org/apache/flink/examples/java/aggregation/AggregationApi1Test.java
---
@@ -0,0 +1,448
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/209#issuecomment-65091843
Thanks for the pull request!
I added some comments in-line.
Could you also add the following tests to the Java and Scala integration
tests
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/209#discussion_r21099693
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/translation/Tuple3WrappingCollector.java
---
@@ -0,0 +1,58
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/209#discussion_r21099647
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/translation/Tuple3UnwrappingIterator.java
---
@@ -0,0 +1,73
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/209#discussion_r21094820
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/SortedGrouping.java
---
@@ -83,6 +84,30 @@ public SortedGrouping(DataSet set
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/209#discussion_r21094766
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/SortedGrouping.java
---
@@ -83,6 +84,30 @@ public SortedGrouping(DataSet set
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/209#discussion_r21094436
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/UnsortedGrouping.java
---
@@ -230,5 +231,21 @@ public UnsortedGrouping
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/209#discussion_r21094587
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/SortedGrouping.java
---
@@ -83,6 +84,30 @@ public SortedGrouping(DataSet set
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/241#issuecomment-65075554
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-65072823
Good point. I'd also prefer `ìgnoreComments()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/244#discussion_r21091377
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -348,45 +360,75 @@ public ExecutionEnvironment
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/244#discussion_r21091364
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -348,45 +360,75 @@ public ExecutionEnvironment
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/244#discussion_r21091130
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -348,45 +360,75 @@ public ExecutionEnvironment
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/244#discussion_r21091152
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -348,45 +360,75 @@ public ExecutionEnvironment
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/244#discussion_r21090988
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -285,25 +285,37 @@ public ExecutionEnvironment
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/244#discussion_r21090971
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -285,25 +285,37 @@ public ExecutionEnvironment
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/243#issuecomment-65070889
Thanks for your pull request!
Great piece of work. Well commented, plenty of tests, nice!
Apart from Scala API support, there are several ways how
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21089588
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/AggregationOperator.java
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21089508
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/AggregationOperator.java
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21088163
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/aggregation/AggregationOperatorFactory.java
---
@@ -0,0 +1,297
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21087628
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/aggregation/AggregationOperatorFactory.java
---
@@ -0,0 +1,297
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21087081
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/aggregation/AggregationReduceUdf.java
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21087064
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/aggregation/AggregationMapIntermediateUdf.java
---
@@ -0,0 +1,65
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21087046
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/aggregation/AggregationMapFinalUdf.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/220#issuecomment-65059995
I guess it just wasn't closed by the ASF Github Bot?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/243#discussion_r21083955
--- Diff:
flink-examples/flink-java-examples/src/test/java/org/apache/flink/examples/java/aggregation/AggregationApi1Test.java
---
@@ -0,0 +1,448
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-64327879
Thanks for the correction!
PR looks good to me :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20849730
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -137,6 +239,7 @@ public OUT readRecord(OUT reuse, byte
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/173#issuecomment-64325764
Only the last two commits are part of this PR. The other commit sneaked in
because the Github mirror was not synced with the Apache git.
---
If your project is
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-64274077
Thanks for the quick update cycles!
There is one more thing. I think the `lenient = false` case (strict
checking) is not working correctly, yet. Neither the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20826354
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java
---
@@ -48,6 +48,143 @@
private static final String
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20826143
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -137,6 +239,7 @@ public OUT readRecord(OUT reuse, byte
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-64166021
Why should CsvInputFormat require access to currBuffer, etc?
If configured lenient, `DelimitedInputFormat.nextRecord()` calls
`readLine()` and
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20760689
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -130,6 +216,21 @@ public OUT readRecord(OUT reuse, byte
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/173#issuecomment-64097626
Replaced exception by missing `ExecutionGraph.fail()`
Added test case with failing `finalizeOnMaster()` call.
---
If your project is set up for it, you can
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-63979680
Looks good to me. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/67#issuecomment-63958246
Agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-63952053
I'd move the check to the CSVFormat. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20707584
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -486,8 +536,42 @@ public boolean reachedEnd
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-63948901
Looks quite good. A few comments in line.
I'm not sure if we should do the comment check in the DelimitedIF or in the
CSVIF. Doing it in the DelimitedI
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20706556
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/GenericCsvInputFormatTest.java
---
@@ -271,6 +271,138 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20706109
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -486,8 +536,42 @@ public boolean reachedEnd
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20706013
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -486,8 +536,42 @@ public boolean reachedEnd
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20706010
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -486,8 +536,42 @@ public boolean reachedEnd
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20705816
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -486,8 +536,42 @@ public boolean reachedEnd
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/173#issuecomment-63943775
Any further comments? Otherwise, I'll merge it in the next days.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/194#discussion_r20704942
--- Diff:
flink-compiler/src/test/java/org/apache/flink/compiler/custompartition/CustomPartitioningGlobalOptimizationTest.java
---
@@ -49,10 +52,11
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/220#discussion_r20675793
--- Diff:
flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -23,182 +23,69 @@
import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20675590
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -130,6 +132,13 @@ public OUT readRecord(OUT reuse, byte
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/202#issuecomment-63872922
I think it would be pretty bad, if we end up having an API that is a lot!
slower than our other APIs without any potential for improvement and need to
keep the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/220#discussion_r20660555
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/RuntimeEnvironment.java
---
@@ -177,8 +177,18 @@ public RuntimeEnvironment
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/220#discussion_r20647897
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/RuntimeEnvironment.java
---
@@ -177,8 +177,18 @@ public RuntimeEnvironment
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/37#issuecomment-63813451
That would be really cool! Let me know if you need any help! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/220#discussion_r20646344
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/RuntimeEnvironment.java
---
@@ -177,8 +177,18 @@ public RuntimeEnvironment
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/37#issuecomment-63718807
I backuped the code.
Most of it went already in as part of the Hadoop function compatibility. I
will continue with the full Hadoop job integration sometime
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20606989
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -279,6 +308,9 @@ protected boolean parseRecord
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20606791
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/GenericCsvInputFormatTest.java
---
@@ -271,6 +271,138 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20606714
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -279,6 +308,9 @@ protected boolean parseRecord
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20606461
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -269,6 +283,21 @@ public void open
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20606237
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -269,6 +283,21 @@ public void open
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20606157
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -130,6 +132,13 @@ public OUT readRecord(OUT reuse, byte
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/219#issuecomment-63706703
Good to merge. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-63385024
Unfortunately, tests unpredicably fail on Travis sometimes. Three different
errors in one build is quite rare though...
Who merges this PR will double check
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20431709
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -41,6 +41,8 @@
private static
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20431715
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -41,6 +41,7 @@
public static final char
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/207#issuecomment-63283090
Oh, yes. Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/205#issuecomment-63272913
LGTM, good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/207#discussion_r20421929
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/Partitioner.java
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/207#issuecomment-63271747
Documentation needs to be adapted.
The difference of Partitioner and KeySelector might confuse users and
should be explained.
---
If your project is set
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20382695
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -130,6 +130,8 @@ public OUT readRecord(OUT reuse, byte
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-63122212
Thanks for your PR!
I think there are a few issues with your approach. For example, a CSV file
that starts with a String field will not be skipped if it
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20382595
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java
---
@@ -202,8 +203,9 @@ public void invoke() throws
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20382601
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java
---
@@ -211,8 +213,9 @@ public void invoke() throws
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20382587
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java
---
@@ -192,8 +192,9 @@ public void invoke() throws
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/47#issuecomment-62754333
I rebased this PR and added some small fixes:
https://github.com/fhueske/incubator-flink/tree/qmlmoonPrimitive
Right now, the methods are called
1 - 100 of 231 matches
Mail list logo
