Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/287#issuecomment-69120239
To clean up history of the changes, could you munge the commits into one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/286#issuecomment-68923148
@tillrohrmann, was there reason why the log file names was changed in the
RPC removal commit?
---
If your project is set up for it, you can reply to this email and have
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/272#issuecomment-68752552
Thanks @StephanEwen and @rmetzger, I could merge this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/272#issuecomment-67882737
Will push this to master EOD if no comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-flink/pull/272
Remove full package name for FlatMapOperatorBase
Simple code cleanup to remove full package name for FlatMapOperatorBase for
FlatMapOperator#translateToDataFlow method
You can merge this
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/268#discussion_r21878538
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/AbstractHadoopWrapper.java ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/268#discussion_r21857579
--- Diff:
flink-addons/flink-tachyon/src/test/java/org/apache/flink/tachyon/TachyonFileSystemWrapperTest.java
---
@@ -0,0 +1,173
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/263#issuecomment-66812856
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/263#discussion_r21694186
--- Diff:
flink-scala/src/main/java/org/apache/flink/api/scala/operators/ScalaAggregateOperator.java
---
@@ -164,18 +160,8 @@ public
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/263#discussion_r21690247
--- Diff:
flink-scala/src/main/java/org/apache/flink/api/scala/operators/ScalaAggregateOperator.java
---
@@ -164,18 +160,8 @@ public
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/262#discussion_r21689877
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/ClosureCleaner.scala ---
@@ -4,7 +4,7 @@
* distributed with this work for
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/263#discussion_r21689646
--- Diff:
flink-scala/src/main/java/org/apache/flink/api/scala/operators/ScalaAggregateOperator.java
---
@@ -164,18 +160,8 @@ public
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/262#discussion_r21689347
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/ClosureCleaner.scala ---
@@ -4,7 +4,7 @@
* distributed with this work for
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/229#issuecomment-64391429
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/227#issuecomment-64285034
@smarthi, this PR contains multiple fixes for different issues and
improvement on code styles.
Could you reduce the fix to do what the original PR want
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/149#issuecomment-64070161
Look like rebase is needed for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/215#discussion_r20676787
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/EnumComparator.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/215#discussion_r20596015
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/EnumComparator.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/200#issuecomment-63127028
To clean up the patch, could you rebase them into one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/200#discussion_r20381770
--- Diff: flink-dist/src/main/flink-bin/bin/jobmanager.sh ---
@@ -30,7 +30,12 @@ if [ "$EXECUTIONMODE" = "local" ]; then
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-flink/pull/168
Another round to remove final modifier to private methods because it is not
needed
Remove final modifier to private methods because it is not needed.
Those methods are final by
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/163#issuecomment-60627135
Thx, will merge sometimes today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-flink/pull/163
Remove unnecessary final modifier in PlanExecutor.loadExecutorClass method
Remove unnecessary final modifier in PlanExecutor.loadExecutorClass private
static method because private means
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/154#issuecomment-59589323
Thx @StephanEwen, will merge it to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-flink/pull/154
Fix the Javadoc link in DataStream class
Fix the Javadoc link for org.apache.flink.api.common.functions.RichFunction
and missing method reference in DataStream class.
You can merge this
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/127#issuecomment-56963996
Thx for merging this, Till :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-flink/pull/127
Cleanup LOG.debug to make sure no extra toString and unnecessary String
concatenation
The PR contains:
-) Remove unnecessary type check and cast for FileInputSplit in
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/122#discussion_r17822249
--- Diff:
flink-addons/flink-hadoop-compatibility/src/main/java/org/apache/flink/hadoopcompatibility/mapred/wrapper/HadoopInputSplit.java
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/123#issuecomment-56055988
Thanks! Will merge this to master today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-flink/pull/123
Remove CONTRIBUTORS file to prefer dynamically generate it
Per discussion in the dev@ list, maintaining the CONTRIBUTORS file manually
is hard to do.
Most ASF projects defer this
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/74#issuecomment-52780715
No, you were right. It caught me by surprise because most of the Java/
Scala code I have been working with use spaces for indentation.
---
If your project is
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/74#issuecomment-52734136
Do you use tab in the patch source or is it 4 spaces?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/89#discussion_r15895059
--- Diff: LICENSE ---
@@ -175,31 +175,6 @@
END OF TERMS AND CONDITIONS
- APPENDIX: How to apply the Apache License to your
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/63#issuecomment-48392105
Does it need corresponding Scala API counterpart?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-flink/pull/64
[FLINK-1007] Clean up and refactor on Scala and Java code
First cleanup attempt, mostly on Scala code, to follow guidelines from
http://docs.scala-lang.org/style:
1. Remove return
35 matches
Mail list logo
