Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/258
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/258#issuecomment-66782368
Changes look good to me.
I haven't tested it on a cluster, but Robert's tests should be fine. :)
---
If your project is set up for it, you can reply to this
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/258#issuecomment-66782412
Thanks for the review! Will merge it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/258#discussion_r21745099
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/LocatableInputSplitAssigner.java
---
@@ -184,15 +209,159 @@ private static final boole
Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/258#discussion_r21744870
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/LocatableInputSplitAssigner.java
---
@@ -36,89 +33,111 @@
/**
* The l
Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/258#discussion_r21744326
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/LocatableInputSplitAssigner.java
---
@@ -184,15 +209,159 @@ private static final boole
Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/258#discussion_r21744330
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/LocatableInputSplitAssigner.java
---
@@ -184,15 +209,159 @@ private static final boole
Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/258#discussion_r21743890
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/LocatableInputSplitAssigner.java
---
@@ -36,89 +33,111 @@
/**
* The l
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/258#issuecomment-66476877
I tested the pull request on a cluster. The split assignment is now much
better.
---
If your project is set up for it, you can reply to this email and have you
GitHub user fhueske opened a pull request:
https://github.com/apache/incubator-flink/pull/258
[FLINK-1287] LocalizableSplitAssigner prefers splits with less degrees of
freedom
The current LocalizableSplitAssigner assigns remote and local splits
without priorities, i.e., each remote
10 matches
Mail list logo
