[GitHub] incubator-flink pull request: Fixed java quickstart example

2014-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-flink/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] incubator-flink pull request: Fixed java quickstart example

2014-12-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/incubator-flink/pull/257#issuecomment-66514299 ah .. sorry. I'll try the tool. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-flink pull request: Fixed java quickstart example

2014-12-10 Thread cebe
Github user cebe commented on the pull request: https://github.com/apache/incubator-flink/pull/257#issuecomment-66492576 @rmetzger thats exactly what `hub am` does in one command, you do not need write access to this repo to fetch the commit with hub :) --- If your project is set up

[GitHub] incubator-flink pull request: Fixed java quickstart example

2014-12-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/incubator-flink/pull/257#issuecomment-66418715 Theoretically yes ;) But we don't have write permissions to this GitHub repository. The account here is a mirror of the ASF git repo. We are manually ch

[GitHub] incubator-flink pull request: Fixed java quickstart example

2014-12-09 Thread cebe
Github user cebe commented on the pull request: https://github.com/apache/incubator-flink/pull/257#issuecomment-66355044 In case you did not know, you can use `hub` to apply patches from pull requests: https://hub.github.com/ ``` hub am -3 https://github.com/apache/incubat

[GitHub] incubator-flink pull request: Fixed java quickstart example

2014-12-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/incubator-flink/pull/257#issuecomment-66349168 Thank you for the fix. I think GitHub pull requests are already quite convenient. Compared to manually uploading patches to JIRA (which you would have to ope

[GitHub] incubator-flink pull request: Fixed java quickstart example

2014-12-09 Thread cebe
GitHub user cebe opened a pull request: https://github.com/apache/incubator-flink/pull/257 Fixed java quickstart example java complains about not expecting an interface here. Needs to be `implements` instead of `extends`. You can merge this pull request into a Git repository by run