[ https://issues.apache.org/jira/browse/GEODE-8919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Burcham resolved GEODE-8919. --------------------------------- Fix Version/s: 1.15.0 Resolution: Fixed > revert renaming of GMS processMessage methods > --------------------------------------------- > > Key: GEODE-8919 > URL: https://issues.apache.org/jira/browse/GEODE-8919 > Project: Geode > Issue Type: Improvement > Components: membership > Reporter: Bruce J Schuchardt > Assignee: Ernest Burghardt > Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > [~upthewaterspout] modified methods in the membership module that process > membership methods so that they are now all named *processMessage*, but this > make it more difficult to read stack traces and know what type of message a > thread is processing. Let's make life easier for us and revert that change. > Let's name each method after the type of message it processes so that we > don't have to look at source code to figure it out. > This method, for instance, could be named *processInstallViewMessage* and we > would know, without looking at source code, which type of message is being > processed. > {noformat} > at > org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1053) > > at > > org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1330) > > at > > org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1269) > > at org.jgroups.JChannel.invokeCallback(JChannel.java:816) > > at org.jgroups.JChannel.up(JChannel.java:741) > > at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030) > > at org.jgroups.protocols.FRAG2.up(FRAG2.java:165) > > at org.jgroups.protocols.FlowControl.up(FlowControl.java:390) > > at > > org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1077) > > at > > org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:792) > > at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:433) > > at > > org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:73) > > at > > org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72) > > at org.jgroups.protocols.TP.passMessageUp(TP.java:1658) > > at > > org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1876) > > at > > org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10) > > at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1789) > > at org.jgroups.protocols.TP.receive(TP.java:1714) > > at > > org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:152) > > at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701) > > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)