[GitHub] incubator-hawq pull request #1332: HAWQ-1581. Separate PXF system parameters...

2018-01-24 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1332#discussion_r163696192 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/utilities/ProtocolData.java --- @@ -82,19 +83,26 @@ public ProtocolData(Map par

[GitHub] incubator-hawq pull request #1332: HAWQ-1581. Separate PXF system parameters...

2018-01-24 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1332#discussion_r163695957 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/utilities/ProtocolData.java --- @@ -82,19 +83,26 @@ public ProtocolData(Map par

[GitHub] incubator-hawq issue #1332: HAWQ-1581. Separate PXF system parameters from u...

2018-01-24 Thread shivzone
Github user shivzone commented on the issue: https://github.com/apache/incubator-hawq/pull/1332 @lavjain the pxf-service updated has been reverted. With this patch, we no longer need to modify the pxf-jdbc user credential parameters. No readme updates required. ---

[GitHub] incubator-hawq pull request #1332: HAWQ-1581. Separate PXF system parameters...

2018-01-24 Thread shivzone
Github user shivzone commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1332#discussion_r163680129 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/utilities/ProtocolData.java --- @@ -82,19 +83,26 @@ public ProtocolData(Map pa

[GitHub] incubator-hawq pull request #1332: HAWQ-1581. Separate PXF system parameters...

2018-01-24 Thread shivzone
Github user shivzone commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1332#discussion_r163679669 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPlugin.java --- @@ -58,8 +58,8 @@ public JdbcPlugin(InputData input) thro