[GitHub] incubator-hawq pull request #1349: HAWQ-1598. Vectorized Scan Node Framework...

2018-03-28 Thread weinan003
Github user weinan003 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1349#discussion_r177948142 --- Diff: contrib/vexecutor/vexecutor.c --- @@ -96,20 +140,70 @@ static PlanState* VExecInitNode(PlanState *node,EState *eState,int eflags)

[GitHub] incubator-hawq pull request #1349: HAWQ-1598. Vectorized Scan Node Framework...

2018-03-28 Thread weinan003
Github user weinan003 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1349#discussion_r177945087 --- Diff: contrib/vexecutor/execVScan.c --- @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] incubator-hawq pull request #1349: HAWQ-1598. Vectorized Scan Node Framework...

2018-03-28 Thread weinan003
Github user weinan003 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1349#discussion_r177944185 --- Diff: contrib/vexecutor/vexecutor.c --- @@ -66,12 +75,47 @@ _PG_fini(void) vmthd.ExecEndNode_Hook = NULL; } -static

[GitHub] incubator-hawq pull request #1349: HAWQ-1598. Vectorized Scan Node Framework...

2018-03-28 Thread wengyanqing
Github user wengyanqing commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1349#discussion_r177941951 --- Diff: contrib/vexecutor/execVScan.c --- @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] incubator-hawq pull request #1349: HAWQ-1598. Vectorized Scan Node Framework...

2018-03-28 Thread wengyanqing
Github user wengyanqing commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1349#discussion_r177942413 --- Diff: contrib/vexecutor/vexecutor.c --- @@ -66,12 +75,47 @@ _PG_fini(void) vmthd.ExecEndNode_Hook = NULL; } -static

[GitHub] incubator-hawq pull request #1349: HAWQ-1598. Vectorized Scan Node Framework...

2018-03-28 Thread wengyanqing
Github user wengyanqing commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1349#discussion_r177941676 --- Diff: contrib/vexecutor/vexecutor.c --- @@ -96,20 +140,70 @@ static PlanState* VExecInitNode(PlanState *node,EState *eState,int eflags)

[GitHub] incubator-hawq pull request #1349: HAWQ-1598. Vectorized Scan Node Framework...

2018-03-28 Thread wengyanqing
Github user wengyanqing commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1349#discussion_r177940619 --- Diff: contrib/vexecutor/vexecutor.c --- @@ -21,15 +21,23 @@ #include "vexecutor.h" #include "utils/guc.h" #include "vcheck.h"