Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq-site/pull/17
+1, LGTM. Thank you.
---
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1343
+1 LGTM. Thanks!
---
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1342
LGTM +1, Thank for your helping fixing release issues.
---
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1338
Merged into master and 2.3.0.0-incubating branches
---
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1338
---
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1338
@radarwave @huor please help to review this version update
---
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1338
HAWQ-1586. Update version from 2.2.0.0 to 2.3.0.0
postgres=# select version
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1314#discussion_r154279848
--- Diff: src/backend/access/external/plugstorage.c ---
@@ -0,0 +1,533 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1314
+1
I think it makes sense to have partial facility code checked in for
simplifying the following code merge and delivery work. Therefore, per my
understanding, it is not necessary
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1314#discussion_r154278905
--- Diff: src/backend/access/external/Makefile ---
@@ -26,7 +26,7 @@ subdir = src/backend/access/external
top_builddir = ../../../..
include
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1314#discussion_r154278719
--- Diff: src/include/access/plugstorage.h ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1310
@outofmem0ry Per my design, the first log is to output dynamic total YARN
cluster capacity change, not per node value, that log is output only when total
YARN capacity changes.
The
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1308#discussion_r149832325
--- Diff: src/backend/cdb/dispatcher.c ---
@@ -1414,9 +1415,12 @@ dispatch_cleanup(DispatchData *data)
if (dispatcher_is_state_error(data
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1308
---
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1308
@kuien please check this fix
---
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1308
HAWQ-1530. Illegally killing a JDBC select query causes locking problems
This bug root cause maybe twice FATAL error throwing, I cannot exactly
reproduce it according to this issue's co
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1308
@radarwave @linwen @changleicn please review and comment
---
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1296
Thank you ed! @edespino
+1 Look good to me .
---
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1243
+1 LGTM, in my opinion, this is a good sample fix for future potential
inter-process failure detection. Thanks.
---
If your project is set up for it, you can reply to this email and have
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1279
Please close this pr as per my understanding it has been delivered last
week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1279
+1 LGTM. Thanks for fixing this so quickly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1278
I manually tested this fix in my environment, please review and comment.
@linwen @radarwave
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1278
HAWQ-1498. Segments keep open file descriptors for deleted files
The idea is to hold a list of all connections ever used for dropping
objects in HDFS, then when the transaction ends, no
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1275
Good job ! please have it delivered asap. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1243
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1238
+1 LGTM. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1223
@paul-guo- please double check the latest changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1223
Applied @paul-guo- 's comment to change the time getting implementation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1223
Seems clock_gettime() does not work for C99.
network_utils.c:52:11: warning: implicit declaration of function
'clock_gettime' is invalid in C99 [-Wimplicit-function-d
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1223
I think as we discussed, we will do a simple fix firstly for this problem.
Changing gettime_microsec() may have side effect which is not clear yet.
---
If your project is set up for it, you
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1223
@paul-guo- @liming01 please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1223
HAWQ-1439. tolerate system time being changed to earlier point when
checking resource context timeout
You can merge this pull request into a Git repository by running:
$ git pull
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1219
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1183
comment is added to explain the sleep
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1183
Sure, I will add comment here to explain it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1183
@huor @paul-guo- @stanlyxiang Please review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1183
This is an external improvement from test tool side to make more stable CI
testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1183
HAWQ-1400. An improvement in SQL Util destructor function for feature test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1150
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1125
pushed into master branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1113
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1125
+1 LGMT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1117
+1 LGTM Thank you for improving RM component
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1113
@huor @zhangh43 @paul-guo- Please review this fix. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1113
HAWQ-1321. failNames wrongly uses memory context to build message when
ANALYZE failed
set failNames use statement level context and when it potentially
repallocs, switch memory context back
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1097
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1108
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1097
Applied comment from @huor for the log content
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1097
@huor for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1097
@wcl14 @stanlyxiang please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1097
HAWQ-1285. resource manager outputs uninitialized string as host name
When the segstat instance is created from YARN cluster report, the hostname
field is not set, so should now output it
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1093
+1 LGTM, please add some comments to explain the logic if necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1078
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1078#discussion_r95706815
--- Diff: src/backend/utils/misc/guc.c ---
@@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] =
NULL
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1078#discussion_r95522787
--- Diff: src/backend/utils/misc/guc.c ---
@@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] =
NULL
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1078#discussion_r95513917
--- Diff: src/backend/utils/misc/guc.c ---
@@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] =
NULL
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1078#discussion_r95513882
--- Diff: src/backend/utils/misc/guc.c ---
@@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] =
NULL
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1078#discussion_r95310043
--- Diff: src/backend/utils/misc/guc.c ---
@@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] =
NULL
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1078#discussion_r95294340
--- Diff: src/backend/resourcemanager/communication/rmcomm_RMSEG2RM.c ---
@@ -107,8 +107,10 @@ int sendIMAlive(int *errorcode,
if ( res
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1078#discussion_r95294321
--- Diff: src/backend/utils/misc/guc.c ---
@@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] =
NULL
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1078
@paul-guo- @linwen Please review, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1078
HAWQ-1258. segment resource manager does not switch back when it cannot
resolve standby host name
If use does not configure standby host, segment will not switch to standby
server; If
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1071
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
In fact some gucs are not used by reading from hawq-site.xml, for example,
hawq_master_directory. But for standby_addr_host, it is useful for RM as RM
switches its heart-beat to standby
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
@huor @stanlyxiang @paul-guo-
@stanlyxiang is right, the correct approach is to fix guc.c as all
external scripts and documentation are using hawq_* names.
---
If your project is
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
I find there is some python script logic using the hawq_* guc names, I will
keep those hawq_* guc names to avoid changing python scripts.
---
If your project is set up for it, you can reply
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1029
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1071
@huor @radarwave Please have a review. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1071
HAWQ-1242. hawq-site.xml default content has wrong guc variable names
Fixed the wrong names in hawq-site.xml and its template file.
You can merge this pull request into a Git repository by
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1014
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1042
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1029
@zhangh43 YARN mode, 2 segments, each segment has 75gb mem, 15core
resource, and the default queue has 25% capacity, 80% maximum capacity. Then
allocated and return 12 x 256mb vsegs, then
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1029
@huor please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1029#discussion_r89943290
--- Diff: src/backend/resourcemanager/include/resourcepool.h ---
@@ -715,6 +715,7 @@ SimpStringPtr build_segment_status_description(SegStat
segstat
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1029
@linwen @ictmalili please help to review and comment, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1029
HAWQ-1174. double type core counter of container set has precision issue
This fix is to avoid double precision problem when counting available core
resource for a container set.
You can
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1025
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1023
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1018
+1 This change is ok to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/807
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/827
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/815
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/849
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/849
HAWQ-834. Refactor goh_portals checkinstall cases using new test framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/840
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/836
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/832
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/827
HAWQ-899. Add feature test for nested null case with new test framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/815
Revert COPY checkinstall-good case because transactions and row_types need
this to prepare data
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/815
HAWQ-898. Add feature test for COPY with new test framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator-hawq HAWQ-898
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/804
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/807
HAWQ-897. Add feature test for create table distribution with new test
framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/798
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/798
HAWQ-896. Add feature test for create table with new test framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator-hawq
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/791
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/791
HAWQ-894. Add feature test for polymorphism with new test framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator-hawq
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/744
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
1 - 100 of 118 matches
Mail list logo
