[GitHub] incubator-hawq pull request #1224: HAWQ-1440. Support ANALYZE for all Hive E...

2017-04-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1224#discussion_r113817022 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java --- @@ -466,7 +466,14 @@ private boolean

[GitHub] incubator-hawq pull request #1224: HAWQ-1440. Support ANALYZE for all Hive E...

2017-04-26 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1224#discussion_r113578883 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java --- @@ -466,7 +466,14 @@ private boolean

[GitHub] incubator-hawq pull request #1224: HAWQ-1440. Support ANALYZE for all Hive E...

2017-04-26 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/1224 HAWQ-1440. Support ANALYZE for all Hive External Tables You can merge this pull request into a Git repository by running: $ git pull https://github.com/kavinderd/incubator-hawq

[GitHub] incubator-hawq pull request #1189: HAWQ-1409. Send AGG-TYPE header to PXF

2017-04-21 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/1189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #1216: HAWQ-1429. Do not use AggBridge when WHER...

2017-04-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1216#discussion_r90746 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/Utilities.java --- @@ -209,7 +209,8 @@ public static boolean useAggBridge

[GitHub] incubator-hawq pull request #1189: HAWQ-1409. Send AGG-TYPE header to PXF

2017-03-28 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1189#discussion_r108538619 --- Diff: src/backend/executor/nodeAgg.c --- @@ -1950,6 +1950,21 @@ ExecInitAgg(Agg *node, EState *estate, int eflags) * initialize child

[GitHub] incubator-hawq pull request #1189: HAWQ-1409. Send AGG-TYPE header to PXF

2017-03-24 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/1189 HAWQ-1409. Send AGG-TYPE header to PXF This change is mean to be a proof of concept that pushing down aggregate function information from HAWQ to the underlying external storage

[GitHub] incubator-hawq issue #1104: HAWQ-1306. Removed links in Javadoc referencing ...

2017-02-01 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/1104 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...

2017-02-01 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/808 @huor @paul-guo- Can you look at this PR when you get a chance. I need one more +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hawq pull request #1076: HAWQ-1228. Use profile based on file form...

2017-01-27 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1076#discussion_r98277093 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java --- @@ -432,32 +447,144 @@ public static

[GitHub] incubator-hawq pull request #1076: HAWQ-1228. Use profile based on file form...

2017-01-26 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1076#discussion_r98115361 --- Diff: src/bin/gpfusion/gpbridgeapi.c --- @@ -68,7 +68,6 @@ void free_token_resources(PxfInputData *inputData); Datum gpbridge_import

[GitHub] incubator-hawq pull request #1076: HAWQ-1228. Use profile based on file form...

2017-01-26 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1076#discussion_r98115518 --- Diff: src/backend/catalog/external/externalmd.c --- @@ -631,3 +630,79 @@ static int ComputeTypeMod(Oid typeOid, const char *colname, int

[GitHub] incubator-hawq pull request #1075: HAWQ-762. Login to kerberos if credential...

2017-01-26 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/1075 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #1102: HAWQ-1297. Make PXF install ready from so...

2017-01-26 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1102#discussion_r98057448 --- Diff: pxf/pxf-service/src/scripts/pxf-service --- @@ -193,39 +210,83 @@ function doInit() return 0 fi

[GitHub] incubator-hawq pull request #1102: HAWQ-1297. Make PXF install ready from so...

2017-01-26 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1102#discussion_r98055597 --- Diff: pxf/pxf-service/src/scripts/pxf-service --- @@ -40,6 +34,29 @@ else source $env_script fi +pxf_user=$PXF_USER

[GitHub] incubator-hawq pull request #1102: HAWQ-1297. Make PXF install ready from so...

2017-01-26 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1102#discussion_r98051363 --- Diff: pxf/Makefile --- @@ -65,3 +75,9 @@ doc: .PHONY: tomcat tomcat: ./gradlew tomcatRpm $(BUILD_PARAMS) + +install

[GitHub] incubator-hawq pull request #1102: HAWQ-1297. Make PXF install ready from so...

2017-01-26 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1102#discussion_r98055816 --- Diff: pxf/pxf-service/src/scripts/pxf-service --- @@ -193,39 +210,83 @@ function doInit() return 0 fi

[GitHub] incubator-hawq pull request #1102: HAWQ-1297. Make PXF install ready from so...

2017-01-26 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1102#discussion_r98056223 --- Diff: pxf/pxf-service/src/scripts/pxf-service --- @@ -193,39 +210,83 @@ function doInit() return 0 fi

[GitHub] incubator-hawq pull request #1102: HAWQ-1297. Make PXF install ready from so...

2017-01-26 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1102#discussion_r98058834 --- Diff: pxf/pxf-service/src/scripts/pxf-service --- @@ -193,39 +210,83 @@ function doInit() return 0 fi

[GitHub] incubator-hawq pull request #1064: HAWQ-1215. Support Complextypes with Hive...

2017-01-11 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/1064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #1075: HAWQ-762. Login to kerberos if credential...

2017-01-06 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1075#discussion_r95034235 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/utilities/SecuredHDFS.java --- @@ -53,6 +53,10 @@ public static void

[GitHub] incubator-hawq pull request #1075: HAWQ-762. Login to kerberos if credential...

2017-01-06 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/1075 HAWQ-762. Login to kerberos if credentials are no longer valid You can merge this pull request into a Git repository by running: $ git pull https://github.com/kavinderd/incubator

[GitHub] incubator-hawq pull request #1075: HAWQ-762. Login to kerberos if credential...

2017-01-06 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1075#discussion_r95010426 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/utilities/SecuredHDFS.java --- @@ -53,6 +53,10 @@ public static void

[GitHub] incubator-hawq pull request #1064: HAWQ-1215. Support Complextypes with Hive...

2017-01-04 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1064#discussion_r94677406 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveORCSerdeResolver.java --- @@ -102,11 +104,19 @@ void initSerde

[GitHub] incubator-hawq pull request #1064: HAWQ-1215. Support Complextypes with Hive...

2016-12-23 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/1064 HAWQ-1215. Support Complextypes with HiveORC Preliminary PR for complex type support in Hive You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-hawq issue #1039: HAWQ-1191. Decomissioned DELIMITER from HiveOrc ...

2016-12-07 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/1039 So the delimiter we were previously explicitly asking for in the DDL will just be retrieved internally? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-hawq pull request #1039: HAWQ-1191. Decomissioned DELIMITER from H...

2016-12-07 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1039#discussion_r91353048 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveResolver.java --- @@ -79,7 +79,7 @@ private String serdeName

[GitHub] incubator-hawq issue #1021: HAWQ-1115. Implement filter-push down for IN on ...

2016-11-22 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/1021 Nice work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1002: HAWQ-1130. Make HCatalog integration work...

2016-11-16 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1002#discussion_r88318669 --- Diff: src/backend/access/transam/varsup.c --- @@ -474,74 +483,128 @@ ResetExternalObjectId(void) /* * master_highest_used_oid

[GitHub] incubator-hawq pull request #1002: HAWQ-1130. Make HCatalog integration work...

2016-11-16 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1002#discussion_r88310416 --- Diff: src/backend/access/transam/varsup.c --- @@ -474,74 +483,128 @@ ResetExternalObjectId(void) /* * master_highest_used_oid

[GitHub] incubator-hawq pull request #981: HAWQ-1114. Implement filter-push down for ...

2016-11-15 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/981#discussion_r88100166 --- Diff: src/backend/access/external/pxffilters.c --- @@ -496,23 +629,116 @@ opexpr_to_pxffilter(OpExpr *expr, PxfFilterDesc *filter

[GitHub] incubator-hawq pull request #969: HAWQ-1100. Support for new filter string

2016-10-24 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #969: HAWQ-1100. Support for new filter string

2016-10-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/969#discussion_r84760743 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveFilterBuilder.java --- @@ -61,8 +61,11 @@ public HiveFilterBuilder

[GitHub] incubator-hawq pull request #969: HAWQ-1100. Support for new filter string

2016-10-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/969#discussion_r84744935 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java --- @@ -279,25 +296,110 @@ int safeToInt(Long value) throws

[GitHub] incubator-hawq pull request #969: HAWQ-1100. Support for new filter string

2016-10-21 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/969#discussion_r84528951 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -229,8 +233,20 @@ private

[GitHub] incubator-hawq pull request #968: HAWQ 1116

2016-10-20 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84334739 --- Diff: src/backend/access/external/pxffilters.c --- @@ -406,6 +406,22 @@ pxf_serialize_filter_list(List *expressionItems

[GitHub] incubator-hawq pull request #968: HAWQ 1116

2016-10-20 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84333580 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -507,6 +542,23 @@ void test__pxf_serialize_filter_list__oneFilter(void **state

[GitHub] incubator-hawq pull request #968: HAWQ 1116

2016-10-20 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r8414 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -323,6 +323,30 @@ OpExpr* build_op_expr(void* left, void* right, int op

[GitHub] incubator-hawq pull request #969: HAWQ-1100. Support for new filter string

2016-10-20 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/969 HAWQ-1100. Support for new filter string - constant data type is now of the form "csd" You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] incubator-hawq pull request #958: HAWQ-1048. Support OR, NOT logical operato...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/958#discussion_r83111789 --- Diff: src/backend/access/external/pxffilters.c --- @@ -31,14 +31,14 @@ #include "utils/guc.h" #include "ut

[GitHub] incubator-hawq issue #959: HAWQ-1084. Fixed memory allocation for table prin...

2016-10-12 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/959 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq pull request #959: HAWQ-1084. Fixed memory allocation for tab...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/959#discussion_r83110560 --- Diff: src/bin/psql/describe.c --- @@ -4316,10 +4316,10 @@ describePxfTable(const char *profile, const char *pattern, bool verbose

[GitHub] incubator-hawq pull request #959: HAWQ-1084. Fixed memory allocation for tab...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/959#discussion_r83109712 --- Diff: src/bin/psql/describe.c --- @@ -4316,10 +4316,10 @@ describePxfTable(const char *profile, const char *pattern, bool verbose

[GitHub] incubator-hawq pull request #958: HAWQ-1048. Support OR, NOT logical operato...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/958#discussion_r83108994 --- Diff: src/backend/access/external/pxffilters.c --- @@ -135,7 +135,40 @@ dbop_pxfop_map pxf_supported_opr[] = {1097 /* date_gt

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r83103736 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java --- @@ -404,24 +411,41 @@ private String

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r83101774 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -122,25 +130,23 @@ public Filter

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r83100399 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -52,12 +52,15 @@ */ public class

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r83098043 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java --- @@ -396,4 +387,12 @@ private Operation reverseOp(Operation

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r83097937 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java --- @@ -396,4 +387,12 @@ private Operation reverseOp(Operation

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-12 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r83097391 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java --- @@ -396,4 +387,12 @@ private Operation reverseOp(Operation

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-05 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r82033272 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java --- @@ -396,4 +387,12 @@ private Operation reverseOp(Operation

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-05 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r82033359 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java --- @@ -220,6 +193,24 @@ public Object parse(String filter) throws

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-05 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r82032792 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -71,14 +74,19 @@ public HBaseFilterBuilder

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-05 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r82032692 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -71,14 +74,19 @@ public HBaseFilterBuilder

[GitHub] incubator-hawq issue #949: HAWQ-1080. Fixed unit-tests on local environment.

2016-10-04 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/949 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq issue #949: HAWQ-1080. Fixed unit-tests on local environment.

2016-10-04 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/949 The issue was a bunch of missing function prototypes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq pull request #951: HAWQ-1083

2016-10-04 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/951#discussion_r81869294 --- Diff: src/backend/access/external/libchurl.c --- @@ -312,16 +313,29 @@ CHURL_HANDLE churl_init(const char* url, CHURL_HEADERS headers

[GitHub] incubator-hawq pull request #951: HAWQ-1083

2016-10-04 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/951#discussion_r81863084 --- Diff: src/backend/access/external/pxfutils.c --- @@ -133,3 +137,60 @@ static void process_request(ClientContext* client_context, char *uri

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-10-04 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/906#discussion_r81858427 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/FilterParser.java --- @@ -81,6 +88,8 @@ * @throws Exception if building

[GitHub] incubator-hawq issue #951: HAWQ-1083

2016-10-04 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/951 +1 aside from comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-hawq pull request #951: HAWQ-1083

2016-10-04 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/951#discussion_r81802588 --- Diff: src/backend/access/external/libchurl.c --- @@ -312,16 +313,29 @@ CHURL_HANDLE churl_init(const char* url, CHURL_HEADERS headers

[GitHub] incubator-hawq pull request #951: HAWQ-1083

2016-10-04 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/951#discussion_r81798661 --- Diff: src/backend/access/external/libchurl.c --- @@ -312,16 +313,29 @@ CHURL_HANDLE churl_init(const char* url, CHURL_HEADERS headers

[GitHub] incubator-hawq pull request #951: HAWQ-1083

2016-10-04 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/951#discussion_r81801521 --- Diff: src/backend/access/external/pxfutils.c --- @@ -133,3 +137,60 @@ static void process_request(ClientContext* client_context, char *uri

[GitHub] incubator-hawq pull request #951: HAWQ-1083

2016-10-04 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/951#discussion_r81800773 --- Diff: src/backend/access/external/pxfutils.c --- @@ -133,3 +137,60 @@ static void process_request(ClientContext* client_context, char *uri

[GitHub] incubator-hawq pull request #935: HAWQ-1055. Fix to handle decimal with prec...

2016-09-23 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/935#discussion_r80351715 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java --- @@ -45,7 +45,7 @@ BinaryType

[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...

2016-09-20 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/915#discussion_r79740844 --- Diff: src/backend/access/external/pxfheaders.c --- @@ -66,8 +66,13 @@ void build_http_header(PxfInputData *input) if (proj_info != NULL

[GitHub] incubator-hawq issue #915: HAWQ-1052. Fixed extraction logic for boolean dat...

2016-09-20 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/915 Aside from my confusion with my comment, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request #915: HAWQ-1052. Fixed extraction logic for bool...

2016-09-20 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/915#discussion_r79740167 --- Diff: src/backend/access/external/pxfheaders.c --- @@ -66,8 +66,13 @@ void build_http_header(PxfInputData *input) if (proj_info != NULL

[GitHub] incubator-hawq pull request #906: HAWQ-964. Support for OR and NOT Logical O...

2016-09-16 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/906 HAWQ-964. Support for OR and NOT Logical Operators Signed-off-by: Leslie Chang You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-hawq pull request #905: HAWQ-964. Support for OR and NOT Logical O...

2016-09-16 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/905 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #905: HAWQ-964. Support for OR and NOT Logical O...

2016-09-16 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/905#discussion_r79261601 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -71,14 +74,19 @@ public HBaseFilterBuilder

[GitHub] incubator-hawq pull request #905: HAWQ-964. Support for OR and NOT Logical O...

2016-09-16 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/905#discussion_r79261531 --- Diff: pxf/pxf-hive/src/test/java/org/apache/hawq/pxf/plugins/hive/HiveORCSearchArgumentExample.java --- @@ -0,0 +1,87 @@ +package

[GitHub] incubator-hawq pull request #905: HAWQ-964. Support for OR and NOT Logical O...

2016-09-16 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/905#discussion_r79261543 --- Diff: pxf/pxf-hive/src/test/java/org/apache/hawq/pxf/plugins/hive/HiveFilterBuilderTest.java --- @@ -20,11 +20,14

[GitHub] incubator-hawq pull request #905: HAWQ-964. Support for OR and NOT Logical O...

2016-09-16 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/905#discussion_r79261518 --- Diff: pxf/pxf-hive/src/test/java/org/apache/hawq/pxf/plugins/hive/HiveORCSearchArgumentExample.java --- @@ -0,0 +1,87 @@ +package

[GitHub] incubator-hawq pull request #905: HAWQ-964. Support for OR and NOT Logical O...

2016-09-16 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/905 HAWQ-964. Support for OR and NOT Logical Operators Signed-off-by: Leslie Chang You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-hawq issue #902: HAWQ-1053. Fixed extraction logic for varchar typ...

2016-09-16 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/902 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq issue #895: HAWQ 971

2016-09-09 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/895 Can you remove all references to `Vectorized` Hive classes since they are not yet being used --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-hawq pull request #895: HAWQ 971

2016-09-09 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/895#discussion_r78207962 --- Diff: pxf/pxf-hive/src/test/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenterTest.java --- @@ -52,55 +52,55

[GitHub] incubator-hawq issue #894: HAWQ-1042. Fixed NPE.

2016-09-08 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/894 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq pull request #821: HAWQ-931. ORC optimized profile for PPD/CP

2016-09-07 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/821#discussion_r77913853 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveColumnarSerdeResolver.java --- @@ -76,6 +77,8 @@ void parseUserData

[GitHub] incubator-hawq issue #873: HAWQ-992. PXF Hive data type check in Fragmenter ...

2016-08-31 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/873 Overall LGTM, but I'd like to spend more time reviewing. This is a lot of code --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77096574 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java --- @@ -110,4 +122,68 @@ public static

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77082531 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/EnumHawqType.java --- @@ -43,37 +45,40 @@ public void serialize(EnumHawqType

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77082166 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/EnumHawqType.java --- @@ -43,37 +45,40 @@ public void serialize(EnumHawqType

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77047856 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/ColumnDescriptor.java --- @@ -26,10 +26,11 @@ */ public class

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

2016-08-31 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r77047594 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -165,6 +165,14 @@ private Filter

[GitHub] incubator-hawq issue #854: HAWQ-997. HAWQ doesn't send PXF data type with pr...

2016-08-24 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/854 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq issue #853: HAWQ-967. Extend Projection info to include filte...

2016-08-24 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/853 Nice work! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-hawq pull request #853: HAWQ-967. Extend Projection info to includ...

2016-08-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/853#discussion_r76100388 --- Diff: src/backend/access/external/pxffilters.c --- @@ -451,6 +452,51 @@ opexpr_to_pxffilter(OpExpr *expr, PxfFilterDesc *filter) return

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

2016-08-24 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r76098154 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1146,7 +1146,7 @@ static char** create_pxf_plan(char **segdb_file_map, RelOptInfo *rel

[GitHub] incubator-hawq issue #848: HAWQ-1006. Fix RPM compliance in Redhat Satellite...

2016-08-16 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/848 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

2016-08-10 Thread kavinderd
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r74286229 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -61,7 +62,7 @@ test__supported_filter_type(void **state) /* go

[GitHub] incubator-hawq pull request #830: HAWQ-973. Check pi_varList before adding p...

2016-08-02 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/830 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #830: HAWQ-973. Check pi_varList before adding p...

2016-08-01 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/830 HAWQ-973. Check pi_varList before adding proj headers You can merge this pull request into a Git repository by running: $ git pull https://github.com/kavinderd/incubator-hawq HAWQ

[GitHub] incubator-hawq pull request #829: HAWQ-972.Setup multi handle after setting ...

2016-08-01 Thread kavinderd
GitHub user kavinderd opened a pull request: https://github.com/apache/incubator-hawq/pull/829 HAWQ-972.Setup multi handle after setting all conf You can merge this pull request into a Git repository by running: $ git pull https://github.com/kavinderd/incubator-hawq HAWQ-972

[GitHub] incubator-hawq issue #812: HAWQ-949. Revert serializing floats in pxf string...

2016-07-28 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/812 Already reverted --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-hawq issue #817: HAWQ-954. Check that ExternalSelectDesc reference...

2016-07-28 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/817 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-hawq pull request #812: HAWQ-949. Revert serializing floats in pxf...

2016-07-28 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #817: HAWQ-954. Check that ExternalSelectDesc re...

2016-07-28 Thread kavinderd
Github user kavinderd closed the pull request at: https://github.com/apache/incubator-hawq/pull/817 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...

2016-07-28 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/808 Added `INT32_CHAR_SIZE` to `configure.in` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

  1   2   >