[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-07-12 Thread outofmem0ry
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 Thank you @linwen @radarwave . Closing this PR, will also submit a PR for documentation changes to apache/incubator-hawq-docs repo. --- If your project is set up for it, you can reply t

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-07-11 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 Thanks for @outofmem0ry 's contribution, I have squashed and merged this commit. Please close this PR. Welcome to do more contributions. --- If your project is set up for it, you

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-07-11 Thread linwen
Github user linwen commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-07-08 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-07-07 Thread outofmem0ry
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @radarwave - Fixed and incorporated above comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-07-03 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 Need to fix: run 'hawq reload' without any other arguments: hawq reload Traceback (most recent call last): File "/usr/local/hawq/bin/hawq", line 215, in main(

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-07-03 Thread outofmem0ry
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @radarwave committed the final changes, doc changes pending. Will submit a PR in docs repo. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-22 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @outofmem0ry Please check the cases in below folder as example: incubator-hawq/src/test/feature/ManagementTool --- If your project is set up for it, you can reply to this email an

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-22 Thread outofmem0ry
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @radarwave - am in the process of making final changes for this pull request, I don't see any existing test infrastructure for management utilities, am I missing something here. Can you

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-14 Thread outofmem0ry
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @linwen @stanlyxiang @radarwave - Thank you for the comments and suggestions. @radarwave - Please see the comments inline 1. I think we should keep the legacy command to

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-14 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 Thanks @outofmem0ry to contribute this, please check below comments. 1. I think we should keep the legacy command to do reload in case it's hard coded in some user cases, print a deprec

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-13 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 If we add "hawq reload-config", I think there is no need for "hawq stop cluster -u". 2 commands have same function make me more confused. --- If your project is set up for it, you can

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-13 Thread linwen
Github user linwen commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 Shubham, I think what you've done in this PR is to add a command for hawq, which can reload GUC configs without restarting the system. Currently, this is done by this command "hawq stop clust

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-13 Thread outofmem0ry
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 Scoped out some documentation changes which are detailed below - [Files with hawq stop cluster -u](https://github.com/apache/incubator-hawq-docs/search?utf8=%E2%9C%93&q=%22hawq+