[GitHub] incubator-hawq issue #803: HAWQ-932. Added pxf service address to curl resol...

2016-07-21 Thread shivzone
Github user shivzone commented on the issue: https://github.com/apache/incubator-hawq/pull/803 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq issue #803: HAWQ-932. Added pxf service address to curl resol...

2016-07-20 Thread kavinderd
Github user kavinderd commented on the issue: https://github.com/apache/incubator-hawq/pull/803 LGTM. Agree with @GodenYao on refactoring out the common code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-hawq issue #803: HAWQ-932. Added pxf service address to curl resol...

2016-07-19 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/803 churl_init_upload and churl_init_download only has 1 tag difference ( context->upload = true vs. false) probably worth refactoring to a single function and invoked by these 2, which will m