[
https://issues.apache.org/jira/browse/HAWQ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358338#comment-15358338
]
ASF GitHub Bot commented on HAWQ-885:
-------------------------------------
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/763#discussion_r69244453
--- Diff: src/backend/access/common/reloptions.c ---
@@ -515,22 +515,20 @@ default_reloptions(Datum reloptions, bool validate,
char relkind,
compresstype = values[5];
--- End diff --
The code is not just for hacking here. Even we remove quicklz from system
tables in the future, this code could be still kept to educate users for some
time.
> Should fail earlier at creating for a table with quicklz compression.
> ---------------------------------------------------------------------
>
> Key: HAWQ-885
> URL: https://issues.apache.org/jira/browse/HAWQ-885
> Project: Apache HAWQ
> Issue Type: Bug
> Reporter: Paul Guo
> Assignee: Paul Guo
>
> We've removed quicklz compression in
> HAWQ-780 (Remove quicklz compression related code but keep related meta data
> in short term), but as that JIRA description says, we keep the quicklz
> metadata. That means currently user still could be able to create a
> quicklz-compression table with the current code, but still will fail to do
> insert/select, etc.
> Discussed this with several developers, we agree that we should fail earlier
> at creating tables, even with hack code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
