[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342477#comment-16342477
]
Appy commented on HBASE-19873:
--
But yeah, get a good QA run, because i suspect that it's a m
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342474#comment-16342474
]
Duo Zhang commented on HBASE-19873:
---
Anyway, I tried to add a RunListener in the surefi
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342464#comment-16342464
]
Appy commented on HBASE-19873:
--
Ah, you already looked in that direction...nice!
Sad that th
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342420#comment-16342420
]
Duo Zhang commented on HBASE-19873:
---
I was also thinking about doing this by some suref
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342419#comment-16342419
]
Appy commented on HBASE-19873:
--
But i agree with chia, good stuff and great patch!
> Add a
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342413#comment-16342413
]
Appy commented on HBASE-19873:
--
I was thinking about this approach more during skiing, and g
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342413#comment-16342413
]
Appy edited comment on HBASE-19873 at 1/28/18 2:57 AM:
---
I was think
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342411#comment-16342411
]
Hadoop QA commented on HBASE-19873:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342393#comment-16342393
]
Duo Zhang commented on HBASE-19873:
---
Change the name to HBaseClassTestRule. Remove redu
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-19873:
--
Attachment: HBASE-19873-v1.patch
> Add a CategoryBasedTimeout ClassRule for all UTs
> -
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-19873:
--
Attachment: (was: HBASE-19873.patch)
> Add a CategoryBasedTimeout ClassRule for all UTs
> -
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342386#comment-16342386
]
Duo Zhang commented on HBASE-19873:
---
[~stack] That would be good. There is a RuleChain
[
https://issues.apache.org/jira/browse/HBASE-19870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342384#comment-16342384
]
Duo Zhang commented on HBASE-19870:
---
And maybe the testNotCloseZkWhenPending is enough
[
https://issues.apache.org/jira/browse/HBASE-19870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342383#comment-16342383
]
Duo Zhang commented on HBASE-19870:
---
You can see the code in testNotCloseZkWhenPending?
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342321#comment-16342321
]
stack commented on HBASE-19873:
---
{{Minor comment. Should CategoryBasedTimeout be called HBa
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342317#comment-16342317
]
Chia-Ping Tsai commented on HBASE-19873:
+1 to this great and beautiful patch.
[
https://issues.apache.org/jira/browse/HBASE-19803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342309#comment-16342309
]
stack commented on HBASE-19803:
---
{quote}Maybe a possible way is to do it at once first, and
[
https://issues.apache.org/jira/browse/HBASE-19803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342307#comment-16342307
]
stack commented on HBASE-19803:
---
The issue by [~Apache9] that explores adding CategoryBased
[
https://issues.apache.org/jira/browse/HBASE-19870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342300#comment-16342300
]
stack commented on HBASE-19870:
---
LGTM. Need [~Apache9] buy-off. Thanks for fix [~chia7712]
[
https://issues.apache.org/jira/browse/HBASE-19870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342252#comment-16342252
]
Hadoop QA commented on HBASE-19870:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-19870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342240#comment-16342240
]
Chia-Ping Tsai commented on HBASE-19870:
{quote}Can we just use mockito to make a
[
https://issues.apache.org/jira/browse/HBASE-19870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19870:
---
Attachment: (was: HBASE-19870.v0.patch)
> Fix the NPE in ReadOnlyZKClient#run
> -
[
https://issues.apache.org/jira/browse/HBASE-19870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19870:
---
Attachment: HBASE-19870.v1.patch
> Fix the NPE in ReadOnlyZKClient#run
>
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342229#comment-16342229
]
Hadoop QA commented on HBASE-19873:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-19867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342226#comment-16342226
]
Hudson commented on HBASE-19867:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342185#comment-16342185
]
Duo Zhang commented on HBASE-19873:
---
Review board link:
https://reviews.apache.org/r/6
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342182#comment-16342182
]
Duo Zhang commented on HBASE-19873:
---
[~stack] [~appy] FYI.
> Add a CategoryBasedTimeou
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-19873:
--
Assignee: Duo Zhang
Fix Version/s: 2.0.0-beta-2
Status: Patch Available (was: Open)
[
https://issues.apache.org/jira/browse/HBASE-19873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-19873:
--
Attachment: HBASE-19873.patch
> Add a CategoryBasedTimeout ClassRule for all UTs
>
[
https://issues.apache.org/jira/browse/HBASE-19870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342174#comment-16342174
]
Duo Zhang commented on HBASE-19870:
---
I'm OK with the fix but I do not like the test. It
[
https://issues.apache.org/jira/browse/HBASE-19870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342117#comment-16342117
]
Chia-Ping Tsai commented on HBASE-19870:
[~Apache9] Would you please take a look?
[
https://issues.apache.org/jira/browse/HBASE-19713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-19713:
---
Issue Type: Sub-task (was: Task)
Parent: HBASE-19147
> Enable TestInterfaceAudienceA
[
https://issues.apache.org/jira/browse/HBASE-19866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342084#comment-16342084
]
Ted Yu commented on HBASE-19866:
Lgtm
> TestRegionServerReportForDuty doesn't timeout
>
Duo Zhang created HBASE-19873:
-
Summary: Add a CategoryBasedTimeout ClassRule for all UTs
Key: HBASE-19873
URL: https://issues.apache.org/jira/browse/HBASE-19873
Project: HBase
Issue Type: Sub-ta
[
https://issues.apache.org/jira/browse/HBASE-19867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-19867:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Pushe
[
https://issues.apache.org/jira/browse/HBASE-19867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-19867:
--
Component/s: test
> Split TestStochasticLoadBalancer into several small tests
> ---
[
https://issues.apache.org/jira/browse/HBASE-19803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342071#comment-16342071
]
Duo Zhang commented on HBASE-19803:
---
{quote}
The easiest way to do might be using junit
[
https://issues.apache.org/jira/browse/HBASE-19872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342024#comment-16342024
]
Chia-Ping Tsai commented on HBASE-19872:
{quote}
hbase.bucketcache.io
[
https://issues.apache.org/jira/browse/HBASE-19803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342022#comment-16342022
]
Appy commented on HBASE-19803:
--
Sounds good.
The easiest way to do might be using junit's Ru
39 matches
Mail list logo
