[jira] [Commented] (HBASE-22871) Move the DirScanPool out and do not use static field

2019-08-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909899#comment-16909899 ] Hudson commented on HBASE-22871: Results for branch branch-2.1 [build #1495 on

[jira] [Updated] (HBASE-22872) Don't create normalization plan unnecesarily when split and merge both are disabled

2019-08-17 Thread Aman Poonia (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Poonia updated HBASE-22872: Status: Patch Available (was: Open) > Don't create normalization plan unnecesarily when split

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909897#comment-16909897 ] Hadoop QA commented on HBASE-22601: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Updated] (HBASE-22760) Stop/Resume Snapshot Auto-Cleanup activity with shell command

2019-08-17 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22760: - Attachment: HBASE-22760.master.003.patch > Stop/Resume Snapshot Auto-Cleanup activity with

[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522293124 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HBASE-22760) Stop/Resume Snapshot Auto-Cleanup activity with shell command

2019-08-17 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22760: - Fix Version/s: 1.4.11 2.2.1 2.3.0 1.5.0

[jira] [Work started] (HBASE-22760) Stop/Resume Snapshot Auto-Cleanup activity with shell command

2019-08-17 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22760 started by Viraj Jasani. > Stop/Resume Snapshot Auto-Cleanup activity with shell command >

[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314968185 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6

[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314968185 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6

[jira] [Updated] (HBASE-22870) reflection fails to access a private nested class

2019-08-17 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22870: -- Fix Version/s: (was: 2.2.2) 2.2.1 > reflection fails to access a private

[jira] [Resolved] (HBASE-22870) reflection fails to access a private nested class

2019-08-17 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-22870. --- Resolution: Fixed Fix Version/s: (was: 2.1.5) 2.2.2

[jira] [Commented] (HBASE-22870) reflection fails to access a private nested class

2019-08-17 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909895#comment-16909895 ] Reid Chan commented on HBASE-22870: --- Pushed to master, branch-2, branch-2.1, branch-2.2 > reflection

[GitHub] [hbase] virajjasani commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException

2019-08-17 Thread GitBox
virajjasani commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#discussion_r314968514 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909894#comment-16909894 ] Hadoop QA commented on HBASE-22601: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522291957 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522291730 Let me provide the full dependency tree for Jackson1 with this patch: ``` [INFO] ---

[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314968185 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6

[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314968185 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6

[GitHub] [hbase] shahrs87 commented on a change in pull request #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
shahrs87 commented on a change in pull request #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#discussion_r314968060 ## File path:

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909887#comment-16909887 ] Hadoop QA commented on HBASE-22601: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522290267 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522290007 That is already included from hadoop-minicluster only, but at test scop: ``` [INFO]

[GitHub] [hbase] Apache9 commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
Apache9 commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522289943 So what about our own UTs? How do we include the jackson1 dependencies for hbase-server test

[GitHub] [hbase] virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522289864 > So we need to add the jackson dependency explicitly as a test dependency in our own pom

[GitHub] [hbase] Apache9 commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
Apache9 commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522289721 So we need to add the jackson dependency explicitly as a test dependency in our own pom as we

[GitHub] [hbase] Apache9 commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
Apache9 commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314967542 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16

[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314967499 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6

[GitHub] [hbase] Apache9 commented on a change in pull request #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache9 commented on a change in pull request #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#discussion_r314967330 ## File path:

[GitHub] [hbase] Apache9 commented on a change in pull request #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache9 commented on a change in pull request #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#discussion_r314967196 ## File path:

[GitHub] [hbase] virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522288323 > Is it safe to just exclude these transitive dependencies? At least hadoop adds them as

[GitHub] [hbase] Apache9 commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache9 commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522288040 Seems `TestReplicationProcedureRetry` fails consistently?

[GitHub] [hbase] virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
virajjasani commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314966956 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6

[GitHub] [hbase] Apache9 commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
Apache9 commented on a change in pull request #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#discussion_r314966824 ## File path: hbase-zookeeper/pom.xml ## @@ -274,6 +284,16

[GitHub] [hbase] Apache9 commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException

2019-08-17 Thread GitBox
Apache9 commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#discussion_r314966430 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java ##

[GitHub] [hbase] Apache9 commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException

2019-08-17 Thread GitBox
Apache9 commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#discussion_r314966368 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java ##

[GitHub] [hbase] Apache9 commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException

2019-08-17 Thread GitBox
Apache9 commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#discussion_r314966450 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java ##

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909875#comment-16909875 ] Hadoop QA commented on HBASE-22601: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522286296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions

2019-08-17 Thread GitBox
Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions URL: https://github.com/apache/hbase/pull/487#issuecomment-522286273 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-08-17 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-522286105 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException

2019-08-17 Thread GitBox
Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-522286059 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#issuecomment-522284964 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965467 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + *

[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965225 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + *

[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965517 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + *

[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965370 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + *

[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965340 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + *

[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965238 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + *

[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965269 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + *

[GitHub] [hbase] openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
openinx commented on a change in pull request #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#discussion_r314965281 ## File path: src/main/asciidoc/_chapters/snapshot_scanner.adoc ## @@ -0,0 +1,138 @@ + +/** + * + *

[GitHub] [hbase] Reidddddd merged pull request #503: HBASE-22870 reflection fails to access a private nested class

2019-08-17 Thread GitBox
Reidd merged pull request #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] openinx commented on issue #494: HBASE-22380 break circle replication when doing bulkload

2019-08-17 Thread GitBox
openinx commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-522283367 OK, we have added the UT... Will take a look This is an

[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-17 Thread GitBox
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#discussion_r314965000 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/CompositeRefCnt.java

[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-17 Thread GitBox
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#discussion_r314965005 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java

[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-17 Thread GitBox
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#discussion_r314964870 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java ##

[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-17 Thread GitBox
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#discussion_r314965110 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/CompositeRefCnt.java

[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-17 Thread GitBox
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#discussion_r314964982 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/CompositeRefCnt.java

[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-17 Thread GitBox
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#discussion_r314964906 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/CompositeRefCnt.java

[GitHub] [hbase] openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-17 Thread GitBox
openinx commented on a change in pull request #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#discussion_r314965031 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java

[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop

2019-08-17 Thread GitBox
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-522282837 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 72 |

[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…

2019-08-17 Thread GitBox
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-522282693 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class

2019-08-17 Thread GitBox
Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503#issuecomment-522281842 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-17 Thread GitBox
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-522281000 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…

2019-08-17 Thread GitBox
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-522280406 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility

2019-08-17 Thread GitBox
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-522280250 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch

2019-08-17 Thread GitBox
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-522279295 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation

2019-08-17 Thread GitBox
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-522279090 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-08-17 Thread GitBox
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-522278730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22871) Move the DirScanPool out and do not use static field

2019-08-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909852#comment-16909852 ] Hudson commented on HBASE-22871: Results for branch branch-2 [build #2175 on

[jira] [Commented] (HBASE-22871) Move the DirScanPool out and do not use static field

2019-08-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909850#comment-16909850 ] Hudson commented on HBASE-22871: Results for branch branch-2.2 [build #523 on

[GitHub] [hbase] Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

2019-08-17 Thread GitBox
Apache-HBase commented on issue #505: HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728) URL: https://github.com/apache/hbase/pull/505#issuecomment-522277530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime |

[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload

2019-08-17 Thread GitBox
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-522276581 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class

2019-08-17 Thread GitBox
Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503#issuecomment-522273240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop

2019-08-17 Thread GitBox
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-522273261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 157 |

[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…

2019-08-17 Thread GitBox
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-522273212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…

2019-08-17 Thread GitBox
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-522273203 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522272907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909833#comment-16909833 ] Hadoop QA commented on HBASE-22601: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-17 Thread GitBox
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-522272704 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation

2019-08-17 Thread GitBox
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-522272383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility

2019-08-17 Thread GitBox
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-522272297 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909828#comment-16909828 ] Hadoop QA commented on HBASE-22601: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache-HBase commented on issue #500: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/500#issuecomment-522271158 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-08-17 Thread GitBox
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-522269493 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909826#comment-16909826 ] Hadoop QA commented on HBASE-22601: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hbase] Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-17 Thread GitBox
Apache-HBase commented on issue #499: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/499#issuecomment-522268848 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload

2019-08-17 Thread GitBox
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-522264687 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions

2019-08-17 Thread GitBox
Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions URL: https://github.com/apache/hbase/pull/487#issuecomment-522264386 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-08-17 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-522264222 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException

2019-08-17 Thread GitBox
Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-522264112 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature

2019-08-17 Thread GitBox
Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature URL: https://github.com/apache/hbase/pull/496#issuecomment-522262288 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22873) Typo in block caching docs

2019-08-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909796#comment-16909796 ] Hudson commented on HBASE-22873: Results for branch master [build #1342 on

[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment

2019-08-17 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909792#comment-16909792 ] Wellington Chevreuil commented on HBASE-22618: -- Latest test failures are unrelated. Had

[GitHub] [hbase] satanson commented on issue #503: HBASE-22870 reflection fails to access a private nested class

2019-08-17 Thread GitBox
satanson commented on issue #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503#issuecomment-522259837 commit This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…

2019-08-17 Thread GitBox
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-522258867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class

2019-08-17 Thread GitBox
Apache-HBase commented on issue #503: HBASE-22870 reflection fails to access a private nested class URL: https://github.com/apache/hbase/pull/503#issuecomment-522257563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility

2019-08-17 Thread GitBox
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-522256950 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch

2019-08-17 Thread GitBox
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-522255010 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Comment Edited] (HBASE-22862) Region Server crash with: Added a key not lexically larger than previous

2019-08-17 Thread Alex Batyrshin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909770#comment-16909770 ] Alex Batyrshin edited comment on HBASE-22862 at 8/17/19 5:15 PM: - Error

[jira] [Commented] (HBASE-22862) Region Server crash with: Added a key not lexically larger than previous

2019-08-17 Thread Alex Batyrshin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909770#comment-16909770 ] Alex Batyrshin commented on HBASE-22862: Error occurs on MemStore flush. Looks like replay from

  1   2   >