[jira] [Commented] (HBASE-23674) Too many rit page Numbers show confusion

2020-01-13 Thread dingbaosheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014890#comment-17014890 ] dingbaosheng commented on HBASE-23674: -- HBASE-23674.master.0002.patch   add  pages.

[jira] [Commented] (HBASE-23674) Too many rit page Numbers show confusion

2020-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014885#comment-17014885 ] Michael Stack commented on HBASE-23674: --- Whats the different [~dingbaosheng]? I'm

[jira] [Commented] (HBASE-23674) Too many rit page Numbers show confusion

2020-01-13 Thread dingbaosheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014881#comment-17014881 ] dingbaosheng commented on HBASE-23674: -- I've uploaded a new file, please help revie

[jira] [Updated] (HBASE-23674) Too many rit page Numbers show confusion

2020-01-13 Thread dingbaosheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dingbaosheng updated HBASE-23674: - Attachment: HBASE-23674.master.0002.patch > Too many rit page Numbers show confusion > -

[jira] [Commented] (HBASE-23383) [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014867#comment-17014867 ] Michael Stack commented on HBASE-23383: --- PR is merged. Should we close this [~ndim

[jira] [Commented] (HBASE-23664) Upgrade JUnit to 4.13

2020-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014865#comment-17014865 ] Michael Stack commented on HBASE-23664: --- bq. What happens is this. Good one. >

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366157431 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/hamcrest/BytesMatchers.java #

[jira] [Commented] (HBASE-23669) ZNodeClearer#clear() throws IllegalArgumentException

2020-01-13 Thread kangkang.guo (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014842#comment-17014842 ] kangkang.guo commented on HBASE-23669: -- I think this is an obvious problem. Can any

[GitHub] [hbase] Gkkkk302 commented on issue #1006: HBASE-23045.currentPath may be stitched in a loop in replication source code.

2020-01-13 Thread GitBox
G302 commented on issue #1006: HBASE-23045.currentPath may be stitched in a loop in replication source code. URL: https://github.com/apache/hbase/pull/1006#issuecomment-573979252 Yes, I agree. I will try to provide unit tests next. Thank you @virajjasani --

[GitHub] [hbase] WenFeiYi opened a new pull request #1033: HBASE-23677 region.jsp returns 500/NPE when provided encoded region name is not online

2020-01-13 Thread GitBox
WenFeiYi opened a new pull request #1033: HBASE-23677 region.jsp returns 500/NPE when provided encoded region name is not online URL: https://github.com/apache/hbase/pull/1033 This is an automated message from the Apache Git

[GitHub] [hbase] bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#discussion_r366123331 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.j

[GitHub] [hbase] bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#discussion_r366123523 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManag

[GitHub] [hbase] joshelser commented on issue #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-13 Thread GitBox
joshelser commented on issue #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#issuecomment-573965516 I have some Text nits from Andrew, Wellington's suggestion for an `init(Configuration)`, and some removal of SASL from name/s

[GitHub] [hbase] joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-13 Thread GitBox
joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#discussion_r366122791 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/security/provider/SaslAuthenticati

[GitHub] [hbase] joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-13 Thread GitBox
joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#discussion_r366122076 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/SaslServerAuthen

[GitHub] [hbase] binlijin commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible

2020-01-13 Thread GitBox
binlijin commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible URL: https://github.com/apache/hbase/pull/1027#issuecomment-573959305 Agree with Bharath, others are good. This is an au

[jira] [Commented] (HBASE-23665) TestTableName is both a test class and a TestRule

2020-01-13 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014780#comment-17014780 ] HBase QA commented on HBASE-23665: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[GitHub] [hbase] Apache-HBase commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-13 Thread GitBox
Apache-HBase commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1032#issuecomment-573957118 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366112963 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -127,8 +147,11 @

[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366111041 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java #

[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366106432 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366110661 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366109181 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366108162 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366112562 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-13 Thread GitBox
joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#discussion_r366113519 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/security/provider/AuthenticationPr

[GitHub] [hbase] joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-13 Thread GitBox
joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#discussion_r366113087 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/security/AbstractHBaseSaslRpcClien

[jira] [Resolved] (HBASE-23664) Upgrade JUnit to 4.13

2020-01-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-23664. -- Resolution: Fixed > Upgrade JUnit to 4.13 > - > > Key: HBA

[GitHub] [hbase] joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-13 Thread GitBox
joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#discussion_r366105868 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java ##

[GitHub] [hbase] joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-13 Thread GitBox
joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#discussion_r366105224 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java ##

[GitHub] [hbase] joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-13 Thread GitBox
joshelser commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#discussion_r366105089 ## File path: dev-support/design-docs/HBASE-23347-pluggable-authentication.md ## @@ -0,0 +

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366105313 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -47,46 +52,63 @@

[jira] [Updated] (HBASE-23383) [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23383: - Fix Version/s: 3.0.0 > [hbck2] `fixHoles` should queue assignment procedures for any regions its

[GitHub] [hbase] ndimiduk merged pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-13 Thread GitBox
ndimiduk merged pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917 This is an automated message from the Apache Git S

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366091518 ## File path: hbase-server/pom.xml ## @@ -436,6 +436,11 @@ hamcrest-core test +

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366092986 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366091737 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/LimitIterator.java #

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366098608 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/ClearUserNamespacesAndTablesRule.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366094019 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366093095 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366099209 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/hamcrest/BytesMatchers.java ###

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366096964 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java #

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366096720 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java #

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366092854 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[jira] [Created] (HBASE-23685) indicates a last flushed sequence id ... that is less than the previous last flushed sequence id

2020-01-13 Thread Michael Stack (Jira)
Michael Stack created HBASE-23685: - Summary: indicates a last flushed sequence id ... that is less than the previous last flushed sequence id Key: HBASE-23685 URL: https://issues.apache.org/jira/browse/HBASE-23685

[jira] [Resolved] (HBASE-23679) FileSystem instance leaks due to bulk loads with Kerberos enabled

2020-01-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-23679. Hadoop Flags: Reviewed Release Note: This issues fixes an issue with Bulk Loading on installat

[jira] [Updated] (HBASE-23679) FileSystem instance leaks due to bulk loads with Kerberos enabled

2020-01-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-23679: --- Fix Version/s: 2.2.4 2.1.9 2.3.0 3.0.0 > Fi

[GitHub] [hbase] asfgit closed pull request #1029: HBASE-23679 FileSystem objects leak when cleaned up in cleanupBulkLoad

2020-01-13 Thread GitBox
asfgit closed pull request #1029: HBASE-23679 FileSystem objects leak when cleaned up in cleanupBulkLoad URL: https://github.com/apache/hbase/pull/1029 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366074950 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/LimitIterator.java ###

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366080164 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java #

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366082414 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java ###

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366083750 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/ClearUserNamespacesAndTablesRule.java ##

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366074442 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/RegionLocations.java ## @@ -31,

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366080981 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java #

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366083808 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/ConnectionRule.java ## @@ -0,0

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366084083 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/hamcrest/BytesMatchers.java #

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366081807 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java #

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366082204 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java ###

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366080344 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java #

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366083062 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -47,46 +52,63

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366074628 ## File path: hbase-server/pom.xml ## @@ -436,6 +436,11 @@ hamcrest-core test

[GitHub] [hbase] saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366082645 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java ###

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366064862 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/ClearUserNamespacesAndTablesRule.java

[GitHub] [hbase] virajjasani commented on issue #1023: HBASE-23675 Move to Apache parent POM version 22

2020-01-13 Thread GitBox
virajjasani commented on issue #1023: HBASE-23675 Move to Apache parent POM version 22 URL: https://github.com/apache/hbase/pull/1023#issuecomment-573898701 cc: @apurtell @busbey This is an automated message from the Apache

[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client

2020-01-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014698#comment-17014698 ] Hudson commented on HBASE-18095: Results for branch HBASE-18095/client-locate-meta-no-zo

[GitHub] [hbase] virajjasani commented on a change in pull request #1023: HBASE-23675 Move to Apache parent POM version 22

2020-01-13 Thread GitBox
virajjasani commented on a change in pull request #1023: HBASE-23675 Move to Apache parent POM version 22 URL: https://github.com/apache/hbase/pull/1023#discussion_r366057091 ## File path: pom.xml ## @@ -1374,6 +1344,9 @@ ${project.build.directory}/test-classes

[GitHub] [hbase] Apache-HBase commented on issue #1031: Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)"

2020-01-13 Thread GitBox
Apache-HBase commented on issue #1031: Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)" URL: https://github.com/apache/hbase/pull/1031#issuecomment-573891568 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|

[jira] [Commented] (HBASE-23569) Validate that the log cleaner actually cleans oldWALs as expected

2020-01-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014685#comment-17014685 ] Viraj Jasani commented on HBASE-23569: -- [~apurtell] With the attached patch, tried

[jira] [Commented] (HBASE-23349) Low refCount preventing archival of compacted away files

2020-01-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014683#comment-17014683 ] Viraj Jasani commented on HBASE-23349: -- Sure [~apurtell] I will get back on this in

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366046820 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -129,6 +151,7 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366045795 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java #

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366047470 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterRule.java ## @@ -0,0 +

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366027154 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366040013 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366022509 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-13 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366019408 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/LimitIterator.java #

[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation

2020-01-13 Thread GitBox
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-573888707 > @apurtell, @saintstack no further comments? I'd like to merge this one today. Just had an offline chat with @apurtell about this

[GitHub] [hbase] bharathv commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-13 Thread GitBox
bharathv commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1032#issuecomment-573887230 @ndimiduk Thats a good point. I missed that it is actually testing just the table names and not the rule. Fixed it

[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common

2020-01-13 Thread GitBox
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common URL: https://github.com/apache/hbase/pull/1030#issuecomment-573881666 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #1029: HBASE-23679 FileSystem objects leak when cleaned up in cleanupBulkLoad

2020-01-13 Thread GitBox
Apache-HBase commented on issue #1029: HBASE-23679 FileSystem objects leak when cleaned up in cleanupBulkLoad URL: https://github.com/apache/hbase/pull/1029#issuecomment-573871716 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[jira] [Assigned] (HBASE-23665) TestTableName is both a test class and a TestRule

2020-01-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-23665: Assignee: Bharath Vissapragada > TestTableName is both a test class and a TestRule >

[GitHub] [hbase] ndimiduk commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-13 Thread GitBox
ndimiduk commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1032#issuecomment-573857127 I think the `@Test` methods in the class are testing `TableName`. I was thinking we should keep `TestTableName` as

[jira] [Commented] (HBASE-23665) TestTableName is both a test class and a TestRule

2020-01-13 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014639#comment-17014639 ] HBase QA commented on HBASE-23665: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || V

[GitHub] [hbase] Apache-HBase commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-13 Thread GitBox
Apache-HBase commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1032#issuecomment-573854222 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hbase] ndimiduk merged pull request #1031: Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)"

2020-01-13 Thread GitBox
ndimiduk merged pull request #1031: Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)" URL: https://github.com/apache/hbase/pull/1031 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [hbase] saintstack commented on a change in pull request #1011: HBASE-23055 Alter hbase:meta

2020-01-13 Thread GitBox
saintstack commented on a change in pull request #1011: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/1011#discussion_r365998779 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -666,42 +667,55

[GitHub] [hbase] Apache-HBase commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible

2020-01-13 Thread GitBox
Apache-HBase commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible URL: https://github.com/apache/hbase/pull/1027#issuecomment-573842497 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hbase] bharathv commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible URL: https://github.com/apache/hbase/pull/1027#discussion_r365994648 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver

[GitHub] [hbase] bharathv commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible

2020-01-13 Thread GitBox
bharathv commented on a change in pull request #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible URL: https://github.com/apache/hbase/pull/1027#discussion_r365994362 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver

[GitHub] [hbase] Apache-HBase commented on issue #1000: HBASE-23661 Reduced number of Checkstyle violations in hbase-rest

2020-01-13 Thread GitBox
Apache-HBase commented on issue #1000: HBASE-23661 Reduced number of Checkstyle violations in hbase-rest URL: https://github.com/apache/hbase/pull/1000#issuecomment-573837388 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[jira] [Commented] (HBASE-23664) Upgrade JUnit to 4.13

2020-01-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014607#comment-17014607 ] Nick Dimiduk commented on HBASE-23664: -- I believe I understand why this is broken.

[GitHub] [hbase] ndimiduk commented on issue #1031: Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)"

2020-01-13 Thread GitBox
ndimiduk commented on issue #1031: Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)" URL: https://github.com/apache/hbase/pull/1031#issuecomment-573834869 I believe I understand the problem. See https://issues.apache.org/jira/browse/HBASE-23664?focusedCommentId=17014607&page=com.atlassian

[GitHub] [hbase] joshelser commented on issue #1029: HBASE-23679 FileSystem objects leak when cleaned up in cleanupBulkLoad

2020-01-13 Thread GitBox
joshelser commented on issue #1029: HBASE-23679 FileSystem objects leak when cleaned up in cleanupBulkLoad URL: https://github.com/apache/hbase/pull/1029#issuecomment-573831673 Thanks for the quick reviews, folks. > Maybe as future work, if it is indeed worth due to potential perform

[GitHub] [hbase] bharathv opened a new pull request #1032: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-13 Thread GitBox
bharathv opened a new pull request #1032: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1032 …-only class. This is an automated message from the Apache Git Se

[jira] [Updated] (HBASE-23684) NPE HFilesOutputSink

2020-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23684: -- Description: Enabling the new split to hfiles feature, HBASE-23286, running branch-2 tip, I s

[jira] [Commented] (HBASE-23684) NPE HFilesOutputSink

2020-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014582#comment-17014582 ] Michael Stack commented on HBASE-23684: --- Here is another instance: {code} 2020-0

[GitHub] [hbase] ndimiduk commented on issue #792: HBASE-23254 Release replication buffer quota correctly, when batch includes bulk loaded hfiles

2020-01-13 Thread GitBox
ndimiduk commented on issue #792: HBASE-23254 Release replication buffer quota correctly, when batch includes bulk loaded hfiles URL: https://github.com/apache/hbase/pull/792#issuecomment-573810336 FYI #1031 This is an automa

[jira] [Updated] (HBASE-23664) Upgrade JUnit to 4.13

2020-01-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23664: - Fix Version/s: (was: 1.6.0) > Upgrade JUnit to 4.13 > - > >

[GitHub] [hbase] ndimiduk commented on issue #1031: Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)"

2020-01-13 Thread GitBox
ndimiduk commented on issue #1031: Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)" URL: https://github.com/apache/hbase/pull/1031#issuecomment-573807319 I can reproduce test failures in TestCompactionState locally. The symptoms are very strange -- it seems the client's thread pool is te

[jira] [Reopened] (HBASE-23664) Upgrade JUnit to 4.13

2020-01-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-23664: -- Looks like this upgrade produces repeatable breakage on branch-1. Reopening for revert. > Upgrad

  1   2   >