[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2020-02-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042379#comment-17042379 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #281 on

[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195#issuecomment-589918372 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:--

[jira] [Commented] (HBASE-23854) Documentation update of external_apis.adoc#example-scala-code

2020-02-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042371#comment-17042371 ] Hudson commented on HBASE-23854: Results for branch branch-2.1 [build #1812 on

[jira] [Commented] (HBASE-22040) Add mergeRegionsAsync with a List of region names method in AsyncAdmin

2020-02-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042359#comment-17042359 ] Duo Zhang commented on HBASE-22040: --- I'm OK with backporting this if you want. Adding

[GitHub] [hbase] busbey commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc

2020-02-21 Thread GitBox
busbey commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc URL: https://github.com/apache/hbase/pull/1196#issuecomment-589910940 let's delete the section instead? and update the htrace note in the upgrade paths section to note that it's broken?

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382879831 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382872894 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382878329 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/RingBufferEnvelope.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382879845 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382878645 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382878529 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382874132 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382872128 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382879850 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382878572 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382876386 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -3410,4

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382871376 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3874,4 +3

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382873543 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382878387 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java ##

[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382879258 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogRecorder.java ## @@

[GitHub] [hbase] Apache-HBase commented on issue #1194: HBASE-23882: Experimenting with low config settings.

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1194: HBASE-23882: Experimenting with low config settings. URL: https://github.com/apache/hbase/pull/1194#issuecomment-589907430 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[jira] [Commented] (HBASE-23882) Scale *MiniCluster config for the environment it runs in.

2020-02-21 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042339#comment-17042339 ] HBase QA commented on HBASE-23882: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-589906501 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:---

[GitHub] [hbase] Apache-HBase commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4 URL: https://github.com/apache/hbase/pull/1186#issuecomment-589905767 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hbase] Apache-HBase commented on issue #754: HBASE-22978 : Online slow response log

2020-02-21 Thread GitBox
Apache-HBase commented on issue #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#issuecomment-589904797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| |

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042336#comment-17042336 ] Bharath Vissapragada commented on HBASE-23881: -- Can you confirm if the foll

[GitHub] [hbase] Apache-HBase commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc URL: https://github.com/apache/hbase/pull/1196#issuecomment-589904376 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042333#comment-17042333 ] Josh Elser commented on HBASE-23881: {quote}To further simplify it, please try it ou

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042326#comment-17042326 ] Bharath Vissapragada commented on HBASE-23881: -- To further simplify it, ple

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042325#comment-17042325 ] Bharath Vissapragada commented on HBASE-23881: -- This is my local run, just

[jira] [Commented] (HBASE-23854) Documentation update of external_apis.adoc#example-scala-code

2020-02-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042323#comment-17042323 ] Hudson commented on HBASE-23854: Results for branch branch-2 [build #2497 on bu

[jira] [Updated] (HBASE-23755) [OpenTracing] Declare HTrace is unusable in the user doc

2020-02-21 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HBASE-23755: Attachment: Screen Shot 2020-02-21 at 5.18.12 PM.png > [OpenTracing] Declare HTrace is unu

[jira] [Commented] (HBASE-23755) [OpenTracing] Declare HTrace is unusable in the user doc

2020-02-21 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042322#comment-17042322 ] Wei-Chiu Chuang commented on HBASE-23755: - This is how it's rendered: !Screen S

[GitHub] [hbase] jojochuang opened a new pull request #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc

2020-02-21 Thread GitBox
jojochuang opened a new pull request #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc URL: https://github.com/apache/hbase/pull/1196 Add a NOTE in Appendix L warning that users are advised not to follow the instructions.

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042321#comment-17042321 ] Josh Elser commented on HBASE-23881: [~bharathv], are you running tests concurrently

[GitHub] [hbase] ndimiduk commented on a change in pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit

2020-02-21 Thread GitBox
ndimiduk commented on a change in pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#discussion_r382868840 ## File path: dev-support/Jenkinsfile_GitHub ## @@ -144,8 +143,9 @@ pipeli

[GitHub] [hbase] ndimiduk commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job

2020-02-21 Thread GitBox
ndimiduk commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195#issuecomment-589896310 I pushed a [feature branch](https://github.com/apache/hbase/tree/HBASE-23876/jdk11-nightly-master) that sho

[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195#issuecomment-589896037 (!) A patch to the testing environment has been detected. Re-executing against the patched versions t

[GitHub] [hbase] ndimiduk commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job

2020-02-21 Thread GitBox
ndimiduk commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195#issuecomment-589895771 @busbey comments like https://github.com/apache/hbase/blob/b53e9a325cffee0a2dba53de5afd5e63084c334e/dev-supp

[GitHub] [hbase] ndimiduk opened a new pull request #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job

2020-02-21 Thread GitBox
ndimiduk opened a new pull request #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195 This PR provides changes necessary to run JDK11 checks during nightlies. It depends on HBASE-23767/#1183. -

[jira] [Commented] (HBASE-23862) Fix flaky TestSnapshotFromMaster in 1.x versions

2020-02-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042300#comment-17042300 ] Hudson commented on HBASE-23862: FAILURE: Integrated in Jenkins build HBase-1.3-IT #677

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042292#comment-17042292 ] Bharath Vissapragada commented on HBASE-23881: -- No worries, reassigning to

[jira] [Assigned] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada reassigned HBASE-23881: Assignee: Josh Elser (was: Bharath Vissapragada) > TestShadeSaslAuthenti

[jira] [Commented] (HBASE-23862) Fix flaky TestSnapshotFromMaster in 1.x versions

2020-02-21 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042283#comment-17042283 ] Sakthi commented on HBASE-23862: branch-1 pom currently aims at 1.7.0-snapshot hence put

[jira] [Updated] (HBASE-23862) Fix flaky TestSnapshotFromMaster in 1.x versions

2020-02-21 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi updated HBASE-23862: --- Fix Version/s: 1.4.13 1.7.0 1.3.7 > Fix flaky TestSnapshotFromMaster i

[jira] [Commented] (HBASE-23862) Fix flaky TestSnapshotFromMaster in 1.x versions

2020-02-21 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042281#comment-17042281 ] Sakthi commented on HBASE-23862: pushed to branch-1.4 and branch-1.3. Let me close out t

[jira] [Commented] (HBASE-22827) Expose multi-region merge in shell and Admin API

2020-02-21 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042279#comment-17042279 ] Sakthi commented on HBASE-22827: Sure [~busbey]. I think we can work on getting this fe

[jira] [Commented] (HBASE-22040) Add mergeRegionsAsync with a List of region names method in AsyncAdmin

2020-02-21 Thread Sakthi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042277#comment-17042277 ] Sakthi commented on HBASE-22040: I think it's fine to not include this in 2.1 now. Never

[GitHub] [hbase] jatsakthi merged pull request #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions

2020-02-21 Thread GitBox
jatsakthi merged pull request #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions URL: https://github.com/apache/hbase/pull/1190 This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Created] (HBASE-23883) HBase Precommit builds are broken due to some docker/java issue.

2020-02-21 Thread Sakthi (Jira)
Sakthi created HBASE-23883: -- Summary: HBase Precommit builds are broken due to some docker/java issue. Key: HBASE-23883 URL: https://issues.apache.org/jira/browse/HBASE-23883 Project: HBase Issue T

[jira] [Updated] (HBASE-23875) Add JDK11 compilation and unit test support to Jira attached patch precommit

2020-02-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23875: - Attachment: (was: HBASE-23875.0.patch) > Add JDK11 compilation and unit test support to Jira

[jira] [Updated] (HBASE-23875) Add JDK11 compilation and unit test support to Jira attached patch precommit

2020-02-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23875: - Status: Open (was: Patch Available) > Add JDK11 compilation and unit test support to Jira attac

[GitHub] [hbase] jatsakthi commented on issue #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions

2020-02-21 Thread GitBox
jatsakthi commented on issue #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions URL: https://github.com/apache/hbase/pull/1190#issuecomment-589888620 Yes @virajjasani this is covered in branch-1 already. @busbey just create HBASE-23883 for tracking that. -

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042271#comment-17042271 ] Josh Elser commented on HBASE-23881: Thanks, Bharath. Let me look. > TestShadeSaslA

[jira] [Commented] (HBASE-23823) Run maven with more than default single thread (--threads=0.5C)

2020-02-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042263#comment-17042263 ] Michael Stack commented on HBASE-23823: --- [~busbey] Duh. Thanks. It takes a while

[GitHub] [hbase] jatsakthi commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit

2020-02-21 Thread GitBox
jatsakthi commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-589884570 Thanks for taking up this one @ndimiduk the results look great. Will review ---

[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-589884666 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to

[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge

2020-02-21 Thread GitBox
ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1183#issuecomment-589884011 Before this can be merged, the other jobs that depend on the Dockerfile will need to be updated. ---

[jira] [Commented] (HBASE-23882) Scale *MiniCluster config for the environment it runs in.

2020-02-21 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042245#comment-17042245 ] Mark Robert Miller commented on HBASE-23882: Here is some initial experiment

[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge

2020-02-21 Thread GitBox
ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1183#issuecomment-589883543 Okay, this patch looks ready. The bit where I tickle the pom.xml will be removed before final commit. For an example of the results, see https://github.com/

[GitHub] [hbase] markrmiller opened a new pull request #1194: HBASE-23882: Experimenting with low config settings.

2020-02-21 Thread GitBox
markrmiller opened a new pull request #1194: HBASE-23882: Experimenting with low config settings. URL: https://github.com/apache/hbase/pull/1194 Here is some initial experimentation with bringing mini cluster settings down to scale. To start, I've been shooting for pretty minimal.

[GitHub] [hbase] ndimiduk commented on a change in pull request #1183: HBASE-23767 WIP do not merge

2020-02-21 Thread GitBox
ndimiduk commented on a change in pull request #1183: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1183#discussion_r382845753 ## File path: dev-support/docker/Dockerfile ## @@ -14,47 +14,173 @@ # See the License for the specific language governin

[GitHub] [hbase] martin-g commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4

2020-02-21 Thread GitBox
martin-g commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4 URL: https://github.com/apache/hbase/pull/1186#issuecomment-589868417 BTW src/main/asciidoc/_chapters/troubleshooting.adoc has an item named `trouble.hbasezerocopybytestring`. I think it should be removed with this PR.

[GitHub] [hbase-thirdparty] martin-g opened a new pull request #14: HBASE-19146 Update Protobuf to 3.11.4

2020-02-21 Thread GitBox
martin-g opened a new pull request #14: HBASE-19146 Update Protobuf to 3.11.4 URL: https://github.com/apache/hbase-thirdparty/pull/14 Remove duplicate entry of maven-source-plugin. It was causing a warning in Maven builds. Th

[GitHub] [hbase] martin-g commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4

2020-02-21 Thread GitBox
martin-g commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4 URL: https://github.com/apache/hbase/pull/1186#issuecomment-589867787 > Also, IIRC, we actually patch our pb (see build over in hbase-thirdparty https://github.com/apache/hbase-thirdparty/pull/14 Do I need to

[jira] [Commented] (HBASE-23880) [Flakey Test] TestRegionReplicaFailover fails frequently

2020-02-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042209#comment-17042209 ] Hudson commented on HBASE-23880: Results for branch branch-2 [build #2496 on bu

[jira] [Commented] (HBASE-23849) Harden small and medium tests for lots of parallel runs with re-used jvms.

2020-02-21 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042204#comment-17042204 ] Mark Robert Miller commented on HBASE-23849: HBASE-23882 is will be useful h

[jira] [Created] (HBASE-23882) Scale *MiniCluster config for the environment it runs in.

2020-02-21 Thread Mark Robert Miller (Jira)
Mark Robert Miller created HBASE-23882: -- Summary: Scale *MiniCluster config for the environment it runs in. Key: HBASE-23882 URL: https://issues.apache.org/jira/browse/HBASE-23882 Project: HBase

[jira] [Commented] (HBASE-23639) Change InterfaceAudience for ClusterManager interface and HBaseClusterManager class public

2020-02-21 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042177#comment-17042177 ] Andrew Kyle Purtell commented on HBASE-23639: - I made a comment on the doc.

[GitHub] [hbase] Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-589839667 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:

[jira] [Commented] (HBASE-23823) Run maven with more than default single thread (--threads=0.5C)

2020-02-21 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042168#comment-17042168 ] Sean Busbey commented on HBASE-23823: - It's in this set of versions in the footer:

[jira] [Updated] (HBASE-23854) Documentation update of external_apis.adoc#example-scala-code

2020-02-21 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-23854: Fix Version/s: 2.1.10 2.2.4 2.3.0 3.0.0

[jira] [Commented] (HBASE-23854) Documentation update of external_apis.adoc#example-scala-code

2020-02-21 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042163#comment-17042163 ] Sean Busbey commented on HBASE-23854: - Hi [~michaelheil] and welcome to HBase! I've

[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-589831578 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hbase] Apache-HBase commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/1146#issuecomment-589825882 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment

[jira] [Comment Edited] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042112#comment-17042112 ] Bharath Vissapragada edited comment on HBASE-23881 at 2/21/20 7:46 PM: ---

[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan

2020-02-21 Thread GitBox
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-589806116 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:

[GitHub] [hbase] jojochuang commented on issue #1179: HBASE-23861. Reconcile Hadoop version.

2020-02-21 Thread GitBox
jojochuang commented on issue #1179: HBASE-23861. Reconcile Hadoop version. URL: https://github.com/apache/hbase/pull/1179#issuecomment-589805344 I think the patch doesn't require additional change to support hadoop-2 profile... mvn clean install -Dhadoop-two.version=2.10.1-SNAPSHOT m

[GitHub] [hbase] busbey commented on issue #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions

2020-02-21 Thread GitBox
busbey commented on issue #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions URL: https://github.com/apache/hbase/pull/1190#issuecomment-589792789 > HBase nightly builds are broken due to some docker/java issue. Is there a jira for this already?

[GitHub] [hbase-thirdparty] jojochuang commented on a change in pull request #13: HBASE-23811. [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty.

2020-02-21 Thread GitBox
jojochuang commented on a change in pull request #13: HBASE-23811. [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty. URL: https://github.com/apache/hbase-thirdparty/pull/13#discussion_r382754747 ## File path: hbase-shaded-jaeger/pom.xml ## @@ -0,0 +1,176 @

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042112#comment-17042112 ] Bharath Vissapragada commented on HBASE-23881: -- Ok.. I should've clarified

[GitHub] [hbase-thirdparty] jojochuang commented on a change in pull request #13: HBASE-23811. [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty.

2020-02-21 Thread GitBox
jojochuang commented on a change in pull request #13: HBASE-23811. [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty. URL: https://github.com/apache/hbase-thirdparty/pull/13#discussion_r382754826 ## File path: hbase-shaded-jaeger/pom.xml ## @@ -0,0 +1,176 @

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042096#comment-17042096 ] Josh Elser commented on HBASE-23881: Expects a DNRIOE because the user provides an i

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042095#comment-17042095 ] Bharath Vissapragada commented on HBASE-23881: -- [~elserj] The ShadeSaslAuth

[jira] [Resolved] (HBASE-23863) [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication improvements

2020-02-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23863. --- Assignee: Michael Stack Resolution: Fixed Resolving. Pushed on branch-2 only. Not on m

[GitHub] [hbase] HorizonNet commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility

2020-02-21 Thread GitBox
HorizonNet commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/1146#issuecomment-589776705 Fixed the remaining Checkstyle violation. The test failing in the last build passes locally. ---

[jira] [Created] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-02-21 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-23881: Summary: TestShadeSaslAuthenticationProvider failures Key: HBASE-23881 URL: https://issues.apache.org/jira/browse/HBASE-23881 Project: HBase

[GitHub] [hbase] HorizonNet commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan

2020-02-21 Thread GitBox
HorizonNet commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-589767036 Fixed a failure in `TestScanWithBloomError`. All other tests are passing locally.

[jira] [Updated] (HBASE-23863) [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication

2020-02-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23863: -- Fix Version/s: (was: 3.0.0) > [Flakey Test] > TestReplicationEndpointWithMultipleWAL#test

[jira] [Updated] (HBASE-23863) [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication improvements

2020-02-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23863: -- Summary: [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication impr

[jira] [Resolved] (HBASE-23880) [Flakey Test] TestRegionReplicaFailover fails frequently

2020-02-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23880. --- Resolution: Incomplete Resolving as 'incomplete' after reverting patch pushed yesterday. Thi

[jira] [Commented] (HBASE-23880) [Flakey Test] TestRegionReplicaFailover fails frequently

2020-02-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042063#comment-17042063 ] Michael Stack commented on HBASE-23880: --- Build has gone a bit wonky. Let me revert

[GitHub] [hbase] HorizonNet commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan

2020-02-21 Thread GitBox
HorizonNet commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-589746950 Test failures from latest build pass locally, except `TestShadeSaslAuthenticationProvider`, which seems to be unrelated. ---

[jira] [Resolved] (HBASE-23561) Look up of Region in Master by encoded region name is O(n)

2020-02-21 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-23561. -- Resolution: Fixed Merged into master. Thanks for the contribution, [~minwoo.ka

[jira] [Updated] (HBASE-23561) Look up of Region in Master by encoded region name is O(n)

2020-02-21 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23561: - Affects Version/s: 3.0.0 > Look up of Region in Master by encoded region name is

[jira] [Updated] (HBASE-23561) Look up of Region in Master by encoded region name is O(n)

2020-02-21 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23561: - Fix Version/s: 3.0.0 > Look up of Region in Master by encoded region name is O(n

[GitHub] [hbase] wchevreuil merged pull request #1193: HBASE-23561 Look up of Region in Master by encoded region name is O(n)

2020-02-21 Thread GitBox
wchevreuil merged pull request #1193: HBASE-23561 Look up of Region in Master by encoded region name is O(n) URL: https://github.com/apache/hbase/pull/1193 This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] HorizonNet commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan

2020-02-21 Thread GitBox
HorizonNet commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-589727451 Latest test failures were related. Updated the patch to include a fix. --

[GitHub] [hbase] wchevreuil commented on issue #1193: HBASE-23561 Look up of Region in Master by encoded region name is O(n)

2020-02-21 Thread GitBox
wchevreuil commented on issue #1193: HBASE-23561 Look up of Region in Master by encoded region name is O(n) URL: https://github.com/apache/hbase/pull/1193#issuecomment-589727097 Got a green, let me merge this PR. Thanks for the contribution, @mwkang ! --

[jira] [Commented] (HBASE-23880) [Flakey Test] TestRegionReplicaFailover fails frequently

2020-02-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041995#comment-17041995 ] Michael Stack commented on HBASE-23880: --- This doesn't seem to have helped. Build

  1   2   >