[GitHub] [hbase] bharathv commented on a change in pull request #1821: HBASE-24480: Deflake TestRSGroupsBasics#testClearDeadServers

2020-05-31 Thread GitBox
bharathv commented on a change in pull request #1821: URL: https://github.com/apache/hbase/pull/1821#discussion_r433054824 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java ## @@ -385,7 +386,7 @@ public RSGroupInfoManager

[GitHub] [hbase] bharathv merged pull request #1820: HBASE-24479: Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread GitBox
bharathv merged pull request #1820: URL: https://github.com/apache/hbase/pull/1820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636623642 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636622847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing edu.umd.cs.findbugs.annotations dependency

2020-05-31 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120761#comment-17120761 ] Matthew Foley commented on HBASE-24482: --- Interesting, grepping the branch-2.3 of HBase, I see the

[jira] [Updated] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing edu.umd.cs.findbugs.annotations dependency

2020-05-31 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Foley updated HBASE-24482: -- Description: If we do a local build of the current HBase branch-2.3 as version

[jira] [Updated] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing edu.umd.cs.findbugs.annotations dependency

2020-05-31 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Foley updated HBASE-24482: -- Description: If we do a local build of the current HBase branch-2.3 as version

[jira] [Updated] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing edu.umd.cs.findbugs.annotations dependency

2020-05-31 Thread Matthew Foley (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Foley updated HBASE-24482: -- Attachment: HBASE-24482_compile_error.log > [hbase-operator-tools] build of hbck2 fails with

[jira] [Created] (HBASE-24482) [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing edu.umd.cs.findbugs.annotations dependency

2020-05-31 Thread Matthew Foley (Jira)
Matthew Foley created HBASE-24482: - Summary: [hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing edu.umd.cs.findbugs.annotations dependency Key: HBASE-24482 URL:

[GitHub] [hbase] songxincun commented on pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
songxincun commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636613454 @anoopsjohn Thank you for your suggestion and review, thanks a lot : ) This is an automated message from

[jira] [Created] (HBASE-24481) HBase Rest: Request for region detail of a table which doesn't exits is success(200 success code) instead of 403

2020-05-31 Thread Ajeet Rai (Jira)
Ajeet Rai created HBASE-24481: - Summary: HBase Rest: Request for region detail of a table which doesn't exits is success(200 success code) instead of 403 Key: HBASE-24481 URL:

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
anoopsjohn commented on a change in pull request #1801: URL: https://github.com/apache/hbase/pull/1801#discussion_r433034825 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -379,6 +379,9 @@ private MemStore getMemstore() {

[jira] [Commented] (HBASE-24472) Enhanced version of KeyPrefixRegionSplitPolicy

2020-05-31 Thread Anil Sadineni (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120748#comment-17120748 ] Anil Sadineni commented on HBASE-24472: --- Thanks [~anoop.hbase] for response. I will work on patch

[jira] [Commented] (HBASE-24472) Enhanced version of KeyPrefixRegionSplitPolicy

2020-05-31 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120743#comment-17120743 ] Anoop Sam John commented on HBASE-24472: It make sense. You might not need new Split policy. To

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2020-05-31 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120737#comment-17120737 ] Anoop Sam John commented on HBASE-24440: When 2 such mutate reqs comes and applied at same TS,

[GitHub] [hbase] Apache-HBase commented on pull request #1821: HBASE-24480: Deflake TestRSGroupsBasics#testClearDeadServers

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1821: URL: https://github.com/apache/hbase/pull/1821#issuecomment-636588211 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Reidddddd commented on a change in pull request #1821: HBASE-24480: Deflake TestRSGroupsBasics#testClearDeadServers

2020-05-31 Thread GitBox
Reidd commented on a change in pull request #1821: URL: https://github.com/apache/hbase/pull/1821#discussion_r433021673 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java ## @@ -385,7 +386,7 @@ public RSGroupInfoManager

[jira] [Commented] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120707#comment-17120707 ] Bharath Vissapragada commented on HBASE-21905: -- Repros pretty frequently for me actually,

[jira] [Updated] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-21905: - Attachment: testFIFOCompactionPolicyExpiredEmptyHFiles-failure-log.txt >

[jira] [Commented] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120704#comment-17120704 ] Bharath Vissapragada commented on HBASE-21905: -- [~taklwu] Do you have a patch for this? If

[GitHub] [hbase] bharathv opened a new pull request #1821: HBASE-24480: Deflake TestRSGroupsBasics#testClearDeadServers

2020-05-31 Thread GitBox
bharathv opened a new pull request #1821: URL: https://github.com/apache/hbase/pull/1821 More details about the flakiness in the jira comments. This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120697#comment-17120697 ] Hudson commented on HBASE-24454: Results for branch branch-2 [build #2686 on

[jira] [Commented] (HBASE-24475) Clean up the master thread name getting in SplitLogManager and AssignmentManager

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120698#comment-17120698 ] Hudson commented on HBASE-24475: Results for branch branch-2 [build #2686 on

[jira] [Commented] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in old

2020-05-31 Thread Chao Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120694#comment-17120694 ] Chao Wang commented on HBASE-23340: --- Thanck you for this issue.I seem my code of 1.3.1 has merged this

[jira] [Commented] (HBASE-24480) Deflake TestRSGroupsBasics#testClearDeadServers

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120691#comment-17120691 ] Bharath Vissapragada commented on HBASE-24480: -- I think the root cause is this. The problem

[GitHub] [hbase] Apache-HBase commented on pull request #1820: HBASE-24479: Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1820: URL: https://github.com/apache/hbase/pull/1820#issuecomment-636572186 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[jira] [Created] (HBASE-24480) Deflake TestRSGroupsBasics#testClearDeadServers

2020-05-31 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-24480: Summary: Deflake TestRSGroupsBasics#testClearDeadServers Key: HBASE-24480 URL: https://issues.apache.org/jira/browse/HBASE-24480 Project: HBase

[jira] [Commented] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120655#comment-17120655 ] Hudson commented on HBASE-24454: Results for branch branch-2.2 [build #881 on

[GitHub] [hbase] mmpataki commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
mmpataki commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r432997789 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1727,6 +1727,15 @@ possible configurations would overwhelm and obscure the

[jira] [Updated] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24479: - Labels: compaction (was: ) > Deflake TestCompaction#testStopStartCompaction >

[GitHub] [hbase] bharathv commented on pull request #1820: HBASE-24479: Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread GitBox
bharathv commented on pull request #1820: URL: https://github.com/apache/hbase/pull/1820#issuecomment-636543041 I have branch-1 checked out locally, so I submitted a PR for branch-1 now, will forward port this to other branches after this is merged. This applies to all branches AFAICT.

[GitHub] [hbase] bharathv opened a new pull request #1820: HBASE-24479: Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread GitBox
bharathv opened a new pull request #1820: URL: https://github.com/apache/hbase/pull/1820 Polling of active compaction count is racy. Tightened the asserts to be more reliable. This is an automated message from the Apache

[jira] [Commented] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120648#comment-17120648 ] Bharath Vissapragada commented on HBASE-24479: -- I think the test is racy.. (following

[jira] [Created] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction

2020-05-31 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-24479: Summary: Deflake TestCompaction#testStopStartCompaction Key: HBASE-24479 URL: https://issues.apache.org/jira/browse/HBASE-24479 Project: HBase

[GitHub] [hbase] bharathv merged pull request #1755: HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

2020-05-31 Thread GitBox
bharathv merged pull request #1755: URL: https://github.com/apache/hbase/pull/1755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HBASE-24477) Move ConfigurationObserver and related classes to hbase-common

2020-05-31 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada resolved HBASE-24477. -- Fix Version/s: 2.4.0 1.7.0 2.3.0

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 9:18 PM: - All

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120565#comment-17120565 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 8:44 PM: - Seems

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 8:43 PM: - All

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636525402 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636524347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120565#comment-17120565 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 8:06 PM: - Seems

[GitHub] [hbase] saintstack commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
saintstack commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r432978537 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1727,6 +1727,15 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] saintstack commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox
saintstack commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-636519732 Sorry you didn't response on mailing list. Yeah, i think it should be optional opt-in. We publish metrics on the /metrics servlet, we then also publish to jmx, we also

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636519452 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636519476 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636519538 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636515170 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636515189 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636515004 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636514608 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv merged pull request #1815: HBASE-24477: Move ConfigurationObserver and related classes to hbase-c…

2020-05-31 Thread GitBox
bharathv merged pull request #1815: URL: https://github.com/apache/hbase/pull/1815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 5:27 PM: - All

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoB…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636501303 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120599#comment-17120599 ] Hudson commented on HBASE-24454: Results for branch branch-2.3 [build #115 on

[jira] [Commented] (HBASE-24475) Clean up the master thread name getting in SplitLogManager and AssignmentManager

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120600#comment-17120600 ] Hudson commented on HBASE-24475: Results for branch branch-2.3 [build #115 on

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636500690 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636499260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 5:05 PM: - All

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 5:01 PM: - All

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 4:56 PM: - All

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy edited comment on HBASE-23887 at 5/31/20, 4:55 PM: - All

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120591#comment-17120591 ] Danil Lipovoy commented on HBASE-23887: --- All tests below have done on: _AMD Ryzen 7 2700X

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: requests_100p.png > BlockCache performance improve by reduce eviction rate >

[jira] [Issue Comment Deleted] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Comment: was deleted (was: All tests below have done on: _AMD Ryzen 7 2700X Eight-Core

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120590#comment-17120590 ] Danil Lipovoy commented on HBASE-23887: --- All tests below have done on: _AMD Ryzen 7 2700X

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: eviction_100p.png > BlockCache performance improve by reduce eviction rate >

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoB…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636495194 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636495075 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636494911 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636494729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636494546 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: gc_100p.png > BlockCache performance improve by reduce eviction rate >

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoB…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636494325 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636493877 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: eviction_100p.png > BlockCache performance improve by reduce eviction rate >

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: eviction_100p.png > BlockCache performance improve by reduce eviction rate >

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636490239 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636490011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-636489567 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danil Lipovoy updated HBASE-23887: -- Attachment: requests_100p.png > BlockCache performance improve by reduce eviction rate >

[jira] [Updated] (HBASE-24478) The regionInfo parameter for MasterProcedureScheduler#waitRegions and MasterProcedureScheduler#wakeRegions should be plural

2020-05-31 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] song XinCun updated HBASE-24478: Description: MasterProcedureScheduler#waitRegions and MasterProcedureScheduler#wakeRegions deal

[jira] [Updated] (HBASE-24478) The regionInfo parameter for MasterProcedureScheduler#waitRegions and MasterProcedureScheduler#wakeRegions should be plural

2020-05-31 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] song XinCun updated HBASE-24478: Summary: The regionInfo parameter for MasterProcedureScheduler#waitRegions and

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-31 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120565#comment-17120565 ] Danil Lipovoy commented on HBASE-23887: --- Seems like our trouble with the servers for a long time

[jira] [Commented] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120557#comment-17120557 ] Hudson commented on HBASE-24454: Results for branch master [build #1742 on

[jira] [Commented] (HBASE-24475) Clean up the master thread name getting in SplitLogManager and AssignmentManager

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120558#comment-17120558 ] Hudson commented on HBASE-24475: Results for branch master [build #1742 on

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-636478352 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24478) The regionInfo parameter for MasterProcedureScheduler#waitRegions should be plural

2020-05-31 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120545#comment-17120545 ] song XinCun commented on HBASE-24478: - Same so for MasterProcedureScheduler#wakeRegions > The

[GitHub] [hbase] Apache-HBase commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636474521 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] songxincun opened a new pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-05-31 Thread GitBox
songxincun opened a new pull request #1819: URL: https://github.com/apache/hbase/pull/1819 …tRegions should be plural This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (HBASE-24478) The regionInfo parameter for MasterProcedureScheduler#waitRegions should be plural

2020-05-31 Thread song XinCun (Jira)
song XinCun created HBASE-24478: --- Summary: The regionInfo parameter for MasterProcedureScheduler#waitRegions should be plural Key: HBASE-24478 URL: https://issues.apache.org/jira/browse/HBASE-24478

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoB…

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-636467951 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24456) Immutable Scan as unmodifiable subclass or wrapper of Scan

2020-05-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24456: - Status: Patch Available (was: In Progress) > Immutable Scan as unmodifiable subclass or

[jira] [Work started] (HBASE-24456) Immutable Scan as unmodifiable subclass or wrapper of Scan

2020-05-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24456 started by Viraj Jasani. > Immutable Scan as unmodifiable subclass or wrapper of Scan >

[GitHub] [hbase] Apache-HBase commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636462817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani opened a new pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoB…

2020-05-31 Thread GitBox
virajjasani opened a new pull request #1818: URL: https://github.com/apache/hbase/pull/1818 …uilder This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] songxincun commented on a change in pull request #1801: [HBASE-24441]CacheConfig details logged at Store open is not really u…

2020-05-31 Thread GitBox
songxincun commented on a change in pull request #1801: URL: https://github.com/apache/hbase/pull/1801#discussion_r432919519 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -379,6 +379,9 @@ private MemStore getMemstore() {

[jira] [Commented] (HBASE-24454) BucketCache disabled instantly before error duration toleration is reached due to timing issue

2020-05-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120507#comment-17120507 ] Hudson commented on HBASE-24454: Results for branch branch-1 [build #1304 on

[GitHub] [hbase] songxincun commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-05-31 Thread GitBox
songxincun commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636457128 @anoopsjohn Thanks for the review. This is an automated message from the Apache Git Service. To respond to the

[jira] [Issue Comment Deleted] (HBASE-24441) CacheConfig details logged at Store open is not really useful

2020-05-31 Thread song XinCun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] song XinCun updated HBASE-24441: Comment: was deleted (was: Log after patch would look like: {code:java} 2020-05-28 21:35:46,842

  1   2   >