[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-637972556 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

2020-06-02 Thread Ravi Kishore Valeti (Jira)
Ravi Kishore Valeti created HBASE-24499: --- Summary: Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5) Key: HBASE-24499 URL: https://issues.apache.org/jira/browse/HBASE-24499

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-637968009 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24492: - Fix Version/s: (was: 2.3.0) 2.4.0 > ProtobufLogReader.readNext does not

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124619#comment-17124619 ] Viraj Jasani commented on HBASE-24492: -- [~stack] sure I am definitely fine with restricting this

[jira] [Commented] (HBASE-24486) Remove the unused method online in admin.rb

2020-06-02 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124617#comment-17124617 ] Zheng Wang commented on HBASE-24486: Thanks. > Remove the unused method online in admin.rb >

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-637952509 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-637951567 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1839: URL: https://github.com/apache/hbase/pull/1839#issuecomment-637951232 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-02 Thread GitBox
ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434304891 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java ## @@ -0,0 +1,60 @@ +/** + *

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-02 Thread GitBox
ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434304818 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java ## @@ -170,4 +170,15 @@ * all

[GitHub] [hbase] Apache-HBase commented on pull request #1838: HBASE-24498: Include jetty-schemas so that xml parsing does not need …

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1838: URL: https://github.com/apache/hbase/pull/1838#issuecomment-637949388 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-02 Thread GitBox
ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434304384 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java ## @@ -53,6 +53,10 @@ String

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-02 Thread GitBox
ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434304341 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java ## @@ -53,6 +53,10 @@ String

[GitHub] [hbase] Apache-HBase commented on pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1839: URL: https://github.com/apache/hbase/pull/1839#issuecomment-637948015 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1838: HBASE-24498: Include jetty-schemas so that xml parsing does not need …

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1838: URL: https://github.com/apache/hbase/pull/1838#issuecomment-637943298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1839: URL: https://github.com/apache/hbase/pull/1839#issuecomment-637943036 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #1838: HBASE-24498: Include jetty-schemas so that xml parsing does not need …

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1838: URL: https://github.com/apache/hbase/pull/1838#issuecomment-637942885 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1805: HBASE-24467 Backport HBASE-23963: Split TestFromClientSide; it takes …

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1805: URL: https://github.com/apache/hbase/pull/1805#issuecomment-637942479 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] markrmiller opened a new pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

2020-06-02 Thread GitBox
markrmiller opened a new pull request #1839: URL: https://github.com/apache/hbase/pull/1839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] markrmiller opened a new pull request #1838: HBASE-24498: Include jetty-schemas so that xml parsing does not need …

2020-06-02 Thread GitBox
markrmiller opened a new pull request #1838: URL: https://github.com/apache/hbase/pull/1838 …to hit sun/oracle urls. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-637940900 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-24498) Include jetty-schemas so that xml parsing does not need to hit sun/oracle urls.

2020-06-02 Thread Mark Miller (Jira)
Mark Miller created HBASE-24498: --- Summary: Include jetty-schemas so that xml parsing does not need to hit sun/oracle urls. Key: HBASE-24498 URL: https://issues.apache.org/jira/browse/HBASE-24498

[jira] [Created] (HBASE-24497) Close one off connections in RawSyncHBaseAdmin.

2020-06-02 Thread Mark Miller (Jira)
Mark Miller created HBASE-24497: --- Summary: Close one off connections in RawSyncHBaseAdmin. Key: HBASE-24497 URL: https://issues.apache.org/jira/browse/HBASE-24497 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #1837: HBASE-24496 The tag of Base Stats not actived by default in table.jsp

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-637940134 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24474) Rename LocalRegion to MasterRegion

2020-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124585#comment-17124585 ] Hudson commented on HBASE-24474: Results for branch branch-2.3 [build #119 on

[GitHub] [hbase] bsglz opened a new pull request #1837: HBASE-24496 The tag of Base Stats not actived by default in table.jsp

2020-06-02 Thread GitBox
bsglz opened a new pull request #1837: URL: https://github.com/apache/hbase/pull/1837 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-637932246 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Updated] (HBASE-24496) The tag of Base Stats not actived by default in table.jsp

2020-06-02 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24496: --- Description: This bug was introduced by HBASE-21404, it expect to resovle the active issue of nav

[jira] [Updated] (HBASE-24496) The tag of Base Stats not actived by default in table.jsp

2020-06-02 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24496: --- Description: This bug was introduced by HBASE-21404, it expect to resovle the active issue of nav

[jira] [Created] (HBASE-24496) The tag of Base Stats not actived by default in table.jsp

2020-06-02 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-24496: -- Summary: The tag of Base Stats not actived by default in table.jsp Key: HBASE-24496 URL: https://issues.apache.org/jira/browse/HBASE-24496 Project: HBase Issue

[GitHub] [hbase] sguggilam commented on pull request #1835: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-02 Thread GitBox
sguggilam commented on pull request #1835: URL: https://github.com/apache/hbase/pull/1835#issuecomment-637924783 @virajjasani This is change for branch-1 . Please review This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-637923895 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-637921918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1835: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1835: URL: https://github.com/apache/hbase/pull/1835#issuecomment-637921765 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-637921101 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-637919708 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24474) Rename LocalRegion to MasterRegion

2020-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124540#comment-17124540 ] Hudson commented on HBASE-24474: Results for branch branch-2 [build #2688 on

[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-02 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124538#comment-17124538 ] niuyulin commented on HBASE-24412: -- [~claraxiong]  1.Could you provide some info on the use case to

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-637915195 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-02 Thread GitBox
bsglz commented on pull request #1822: URL: https://github.com/apache/hbase/pull/1822#issuecomment-637912746 > LGTM. Shouldn't cause log spam. So, can you approve it? Thanks. This is an automated message from the

[GitHub] [hbase] binlijin commented on pull request #1803: HBASE-24468 Add region info when log meessages in HStore.

2020-06-02 Thread GitBox
binlijin commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-637912142 @saintstack sir, have any comment? if not i will merge. This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-637911694 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1834: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1834: URL: https://github.com/apache/hbase/pull/1834#issuecomment-637911668 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache9 commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-02 Thread GitBox
Apache9 commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-637907073 Overall LGTM. Please fix the checkstyle issues so I can merge it? Thanks. This is an

[GitHub] [hbase] Apache9 commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox
Apache9 commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-637905684 The method too long checkstyle warning is not introduced by the PR here. Can open a follow on issue to remove HBaseTestCase and rewrite TestHStoreFile.

[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-02 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124513#comment-17124513 ] Guanghao Zhang commented on HBASE-24412: BTW: Comment on PR directly may be better. > Canary

[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-02 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124512#comment-17124512 ] Guanghao Zhang commented on HBASE-24412: [~claraxiong] Sorry. I didn't noticed your comment

[jira] [Updated] (HBASE-24420) BulkLoad Will Fall Into Unbelievable Retry Attempt in Some case

2020-06-02 Thread wuchang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuchang updated HBASE-24420: Attachment: 24420.patch Status: Patch Available (was: Open) > BulkLoad Will Fall Into

[GitHub] [hbase] z-york commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
z-york commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434256730 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java ## @@ -93,12 +94,17 @@ public void setConf(final

[jira] [Updated] (HBASE-24403) FsDelegationToken should cache Token

2020-06-02 Thread wuchang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuchang updated HBASE-24403: Attachment: 24403.patch Status: Patch Available (was: Open) > FsDelegationToken should cache

[jira] [Commented] (HBASE-24452) Try github ci for hbase-connectors

2020-06-02 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124501#comment-17124501 ] Guanghao Zhang commented on HBASE-24452: Yes. So this is just a try and the try not work

[GitHub] [hbase] Apache9 commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox
Apache9 commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-637897472 > Seems the ut was not trigger in previous HBase QA? There are failurs for small tests so the medium and large tests are skipped. Let me take a look.

[GitHub] [hbase] Apache9 commented on a change in pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox
Apache9 commented on a change in pull request #1830: URL: https://github.com/apache/hbase/pull/1830#discussion_r434257702 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -2345,14 +2345,6 @@ public static TableName

[GitHub] [hbase] infraio merged pull request #1817: HBASE-24412 Canary support check only one column family per RegionTask

2020-06-02 Thread GitBox
infraio merged pull request #1817: URL: https://github.com/apache/hbase/pull/1817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio commented on a change in pull request #1792: HBASE-24447: Contribute a Test class that shows some examples for usi…

2020-06-02 Thread GitBox
infraio commented on a change in pull request #1792: URL: https://github.com/apache/hbase/pull/1792#discussion_r434255385 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/AsyncClientExamplesTest.java ## @@ -0,0 +1,713 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] infraio commented on a change in pull request #1722: HBASE-24359 Optionally ignore edits for deleted CFs for replication

2020-06-02 Thread GitBox
infraio commented on a change in pull request #1722: URL: https://github.com/apache/hbase/pull/1722#discussion_r434253468 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java ## @@ -279,28 +296,148

[GitHub] [hbase] infraio commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox
infraio commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-637888725 Seems the ut was not trigger in previous HBase QA? This is an automated message from the Apache Git Service. To

[GitHub] [hbase] infraio commented on a change in pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox
infraio commented on a change in pull request #1830: URL: https://github.com/apache/hbase/pull/1830#discussion_r434247656 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -2345,14 +2345,6 @@ public static TableName

[jira] [Commented] (HBASE-22738) Fallback to default group to choose RS when there are no RS in current group

2020-06-02 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124479#comment-17124479 ] Guanghao Zhang commented on HBASE-22738: [~Ddupg] The patch for master cannot apply to

[GitHub] [hbase] infraio closed pull request #711: HBASE-22738 Add fallback groups to choose RS when there are no …

2020-06-02 Thread GitBox
infraio closed pull request #711: URL: https://github.com/apache/hbase/pull/711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] infraio removed a comment on pull request #1789: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-06-02 Thread GitBox
infraio removed a comment on pull request #1789: URL: https://github.com/apache/hbase/pull/1789#issuecomment-637883778 Signed-off-by: Guanghao Zhang This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] infraio merged pull request #1789: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-06-02 Thread GitBox
infraio merged pull request #1789: URL: https://github.com/apache/hbase/pull/1789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio commented on pull request #1789: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-06-02 Thread GitBox
infraio commented on pull request #1789: URL: https://github.com/apache/hbase/pull/1789#issuecomment-637883778 Signed-off-by: Guanghao Zhang This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] infraio commented on pull request #1805: HBASE-24467 Backport HBASE-23963: Split TestFromClientSide; it takes …

2020-06-02 Thread GitBox
infraio commented on pull request #1805: URL: https://github.com/apache/hbase/pull/1805#issuecomment-637882848 Ok. All ut passed. Fix checkstyle problem and retry. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] infraio commented on a change in pull request #1823: HBASE-24485 Backport to branch-1 HBASE-17738 BucketCache startup is slow

2020-06-02 Thread GitBox
infraio commented on a change in pull request #1823: URL: https://github.com/apache/hbase/pull/1823#discussion_r434242486 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferArray.java ## @@ -102,8 +170,8 @@ public int getMultiple(long start, int

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-637878987 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-24442) Test coverage for HBASE-23202 - ExportSnapshot (import) will fail if copying files to root directory takes longer than cleaner TTL

2020-06-02 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun resolved HBASE-24442. -- Fix Version/s: 2.3.0 Resolution: Duplicate There are enough test cases to cover it in

[jira] [Created] (HBASE-24495) ExportSnapshot which does not honor the case that working dir/root dir are from different filesystem

2020-06-02 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-24495: Summary: ExportSnapshot which does not honor the case that working dir/root dir are from different filesystem Key: HBASE-24495 URL:

[GitHub] [hbase] huaxiangsun commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
huaxiangsun commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-637869217 @z-york @ndimiduk I updated the patch based on your comments. Here is a summary of the changes: 1. The major changes are addressing SNAPSHOT_WORKING_DIR config, added a new

[GitHub] [hbase] Apache-HBase commented on pull request #1836: HBASE-24494 Wrap long lines in `_chapters/configuration.adoc`

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1836: URL: https://github.com/apache/hbase/pull/1836#issuecomment-637863143 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124459#comment-17124459 ] Michael Stack commented on HBASE-24492: --- I went back to the cited issue. It was a bit messy in the

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-637857386 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1836: HBASE-24494 Wrap long lines in `_chapters/configuration.adoc`

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1836: URL: https://github.com/apache/hbase/pull/1836#issuecomment-637856296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Work started] (HBASE-23997) Consider JDK11 in our support matrix

2020-06-02 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23997 started by Nick Dimiduk. > Consider JDK11 in our support matrix >

[jira] [Assigned] (HBASE-23997) Consider JDK11 in our support matrix

2020-06-02 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-23997: Assignee: Nick Dimiduk > Consider JDK11 in our support matrix >

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434223497 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java ## @@ -251,6 +260,25 @@ private void

[jira] [Commented] (HBASE-23785) Update docs re: Hadoop compatibility of 2.3.x release

2020-06-02 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124451#comment-17124451 ] Nick Dimiduk commented on HBASE-23785: -- Looks like Duo took care of this already with HBASE-23989.

[jira] [Updated] (HBASE-23785) Update docs re: Hadoop compatibility of 2.3.x release

2020-06-02 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23785: - Fix Version/s: (was: 2.3.0) (was: 3.0.0-alpha-1) > Update docs re:

[jira] [Resolved] (HBASE-23785) Update docs re: Hadoop compatibility of 2.3.x release

2020-06-02 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-23785. -- Resolution: Not A Problem > Update docs re: Hadoop compatibility of 2.3.x release >

[GitHub] [hbase] ndimiduk opened a new pull request #1836: HBASE-24494 Wrap long lines in `_chapters/configuration.adoc`

2020-06-02 Thread GitBox
ndimiduk opened a new pull request #1836: URL: https://github.com/apache/hbase/pull/1836 Trying to make doc changes is pretty awful, with lines running on for hundreds of columns. At least for this time, clean up with line breaks where asciidoc will let us.

[jira] [Created] (HBASE-24494) Wrap long lines in `_chapters/configuration.adoc`

2020-06-02 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24494: Summary: Wrap long lines in `_chapters/configuration.adoc` Key: HBASE-24494 URL: https://issues.apache.org/jira/browse/HBASE-24494 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #1832: HBASE-24493 WIP Increase hadoop logging

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1832: URL: https://github.com/apache/hbase/pull/1832#issuecomment-637850168 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1832: HBASE-24493 WIP Increase hadoop logging

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1832: URL: https://github.com/apache/hbase/pull/1832#issuecomment-637849426 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434218196 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotHFileCleaner.java ## @@ -156,7 +164,29 @@ public void

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434218061 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotHFileCleaner.java ## @@ -156,7 +164,29 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #1832: HBASE-24493 WIP Increase hadoop logging

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1832: URL: https://github.com/apache/hbase/pull/1832#issuecomment-637847395 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124446#comment-17124446 ] Michael Stack commented on HBASE-24205: --- I can see value in how many reads come from memstore vs

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434213835 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotHFileCleaner.java ## @@ -137,8 +138,15 @@ public void

[GitHub] [hbase] saintstack commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-02 Thread GitBox
saintstack commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434207957 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java ## @@ -402,6 +402,8 @@ String

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-02 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434210245 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java ## @@ -133,6 +145,71 @@ public void

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124427#comment-17124427 ] Hudson commented on HBASE-11288: Results for branch HBASE-11288.splittable-meta [build #3 on

[GitHub] [hbase] saintstack commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-02 Thread GitBox
saintstack commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434206117 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java ## @@ -402,6 +402,8 @@ String

[jira] [Updated] (HBASE-23202) ExportSnapshot (import) will fail if copying files to root directory takes longer than cleaner TTL

2020-06-02 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-23202: - Fix Version/s: 2.3.0 > ExportSnapshot (import) will fail if copying files to root directory

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-637828937 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-24224) Update GC config examples in hbase-env.sh for G1GC

2020-06-02 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-24224: Assignee: Clara Xiong > Update GC config examples in hbase-env.sh for G1GC >

[GitHub] [hbase] Apache-HBase commented on pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-02 Thread GitBox
Apache-HBase commented on pull request #1828: URL: https://github.com/apache/hbase/pull/1828#issuecomment-637828445 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-23997) Consider JDK11 in our support matrix

2020-06-02 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23997: - Fix Version/s: 2.3.0 > Consider JDK11 in our support matrix >

[jira] [Commented] (HBASE-24051) When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting

2020-06-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124335#comment-17124335 ] Michael Stack commented on HBASE-24051: --- Unscheduled for now. Shout if you are up for working on

[jira] [Updated] (HBASE-24051) When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting in

2020-06-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24051: -- Fix Version/s: (was: 2.3.0) (was: 3.0.0-alpha-1) > When the data

  1   2   3   >