[GitHub] [hbase] mmpataki commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-22 Thread GitBox
mmpataki commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r443990900 ## File path: hbase-http/src/main/java/org/apache/hadoop/hbase/http/prom/PrometheusMetricsSink.java ## @@ -0,0 +1,103 @@ +/** + * Licensed to the Apache S

[GitHub] [hbase] mmpataki commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-22 Thread GitBox
mmpataki commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r443991072 ## File path: hbase-http/src/main/java/org/apache/hadoop/hbase/http/prom/PrometheusMetricsSink.java ## @@ -0,0 +1,103 @@ +/** + * Licensed to the Apache S

[GitHub] [hbase] mmpataki commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-22 Thread GitBox
mmpataki commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r443990799 ## File path: hbase-http/src/main/java/org/apache/hadoop/hbase/http/prom/PrometheusMetricsSink.java ## @@ -0,0 +1,103 @@ +/** + * Licensed to the Apache S

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-22 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142647#comment-17142647 ] Guanghao Zhang commented on HBASE-24205: {quote}I'm surprised this was added to

[jira] [Commented] (HBASE-23739) BoundedRecoveredHFilesOutputSink should read the table descriptor directly

2020-06-22 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142645#comment-17142645 ] Guanghao Zhang commented on HBASE-23739: {quote}This is a good idea and need som

[jira] [Updated] (HBASE-24619) Try compact the recovered hfiles firstly after region online

2020-06-22 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24619: --- Issue Type: Improvement (was: Bug) > Try compact the recovered hfiles firstly after region

[jira] [Created] (HBASE-24619) Try compact the recovered hfiles firstly after region online

2020-06-22 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24619: -- Summary: Try compact the recovered hfiles firstly after region online Key: HBASE-24619 URL: https://issues.apache.org/jira/browse/HBASE-24619 Project: HBase

[jira] [Commented] (HBASE-24102) RegionMover should exclude draining/decommissioning nodes from target RSs

2020-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142641#comment-17142641 ] Hudson commented on HBASE-24102: Results for branch branch-2.3 [build #150 on b

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-22 Thread GitBox
anoopsjohn commented on a change in pull request #1955: URL: https://github.com/apache/hbase/pull/1955#discussion_r443967906 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java ## @@ -191,50 +186,22 @@ public boolean keepR

[GitHub] [hbase] Apache9 commented on a change in pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-22 Thread GitBox
Apache9 commented on a change in pull request #1955: URL: https://github.com/apache/hbase/pull/1955#discussion_r443946747 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java ## @@ -191,50 +186,22 @@ public boolean keepRegi

[GitHub] [hbase] infraio commented on a change in pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-22 Thread GitBox
infraio commented on a change in pull request #1955: URL: https://github.com/apache/hbase/pull/1955#discussion_r443942436 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java ## @@ -191,50 +186,22 @@ public boolean keepRegi

[GitHub] [hbase] infraio commented on a change in pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-22 Thread GitBox
infraio commented on a change in pull request #1955: URL: https://github.com/apache/hbase/pull/1955#discussion_r443942069 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/RSProcedureHandler.java ## @@ -48,7 +48,7 @@ public void process() {

[GitHub] [hbase] infraio commented on a change in pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-22 Thread GitBox
infraio commented on a change in pull request #1955: URL: https://github.com/apache/hbase/pull/1955#discussion_r443941820 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -2037,8 +2037,7 @@ private void startServices() thro

[jira] [Commented] (HBASE-24585) Failed start recovering crash in standalone mode if procedure-based distributed WAL split & hbase.wal.split.to.hfile=true

2020-06-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142590#comment-17142590 ] Michael Stack commented on HBASE-24585: --- HBASE-24616 has suggested fix for Bounded

[jira] [Resolved] (HBASE-23055) Alter hbase:meta

2020-06-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23055. --- Resolution: Fixed Pushed addendum on branch-2.3+ > Alter hbase:meta > > >

[GitHub] [hbase] saintstack merged pull request #1956: HBASE-23055 Alter hbase:meta

2020-06-22 Thread GitBox
saintstack merged pull request #1956: URL: https://github.com/apache/hbase/pull/1956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted

2020-06-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142587#comment-17142587 ] Duo Zhang commented on HBASE-24595: --- It's HBASE-22681 HBASE-22684, but seems we alread

[jira] [Commented] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted

2020-06-22 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142563#comment-17142563 ] Yu Wang commented on HBASE-24595: - Thanks for your answer [~anoop.hbase] I think this sc

[jira] [Commented] (HBASE-24102) RegionMover should exclude draining/decommissioning nodes from target RSs

2020-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142568#comment-17142568 ] Hudson commented on HBASE-24102: Results for branch branch-2 [build #2715 on bu

[GitHub] [hbase] bsglz commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…

2020-06-22 Thread GitBox
bsglz commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-647871195 @wchevreuil @virajjasani Skimed the comments of the thread, seems the #3 is mostly supported, should we continue discussion or do as #3? ---

[GitHub] [hbase] bsglz commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp

2020-06-22 Thread GitBox
bsglz commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-647869966 @wchevreuil @virajjasani Could you help to review this one, thanks. This is an automated message from the Apache Git

[jira] [Resolved] (HBASE-24605) Break long region names in the web UI

2020-06-22 Thread Guangxu Cheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng resolved HBASE-24605. --- Fix Version/s: 2.2.6 2.4.0 2.3.1 3.0

[jira] [Assigned] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-06-22 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 reassigned HBASE-24615: --- Assignee: wenfeiyi666 > MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate

[GitHub] [hbase] guangxuCheng merged pull request #1942: HBASE-24605 Break long region names in the web UI

2020-06-22 Thread GitBox
guangxuCheng merged pull request #1942: URL: https://github.com/apache/hbase/pull/1942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-22504) Optimize the MultiByteBuff#get(ByteBuffer, offset, len)

2020-06-22 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142525#comment-17142525 ] Zheng Hu commented on HBASE-22504: -- [~ndimiduk], Well, when i write this patch , I chec

[jira] [Updated] (HBASE-24618) Backport HBASE-21204 to branch-1

2020-06-22 Thread Abhishek Singh Chouhan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated HBASE-24618: --- Fix Version/s: 1.7.0 > Backport HBASE-21204 to branch-1 > --

[jira] [Created] (HBASE-24618) Backport HBASE-21204 to branch-1

2020-06-22 Thread Abhishek Singh Chouhan (Jira)
Abhishek Singh Chouhan created HBASE-24618: -- Summary: Backport HBASE-21204 to branch-1 Key: HBASE-24618 URL: https://issues.apache.org/jira/browse/HBASE-24618 Project: HBase Issue Ty

[GitHub] [hbase] Apache-HBase commented on pull request #1956: HBASE-23055 Alter hbase:meta

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1956: URL: https://github.com/apache/hbase/pull/1956#issuecomment-647849808 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] Apache-HBase commented on pull request #1956: HBASE-23055 Alter hbase:meta

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1956: URL: https://github.com/apache/hbase/pull/1956#issuecomment-647849971 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29

[GitHub] [hbase] Apache-HBase commented on pull request #1956: HBASE-23055 Alter hbase:meta

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1956: URL: https://github.com/apache/hbase/pull/1956#issuecomment-647848873 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29

[GitHub] [hbase] Apache-HBase commented on pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1955: URL: https://github.com/apache/hbase/pull/1955#issuecomment-647845364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[jira] [Created] (HBASE-24617) Enable injecting build start time value as part of build

2020-06-22 Thread Matthew Foley (Jira)
Matthew Foley created HBASE-24617: - Summary: Enable injecting build start time value as part of build Key: HBASE-24617 URL: https://issues.apache.org/jira/browse/HBASE-24617 Project: HBase Is

[jira] [Commented] (HBASE-23055) Alter hbase:meta

2020-06-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142504#comment-17142504 ] Michael Stack commented on HBASE-23055: --- I put up an addendum > Alter hbase:m

[GitHub] [hbase] saintstack opened a new pull request #1956: HBASE-23055 Alter hbase:meta

2020-06-22 Thread GitBox
saintstack opened a new pull request #1956: URL: https://github.com/apache/hbase/pull/1956 Addendum to fix illegal removal of unused constant w/o a deprecation cycle. This is an automated message from the Apache Git Servic

[GitHub] [hbase] saintstack opened a new pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-22 Thread GitBox
saintstack opened a new pull request #1955: URL: https://github.com/apache/hbase/pull/1955 …ableDescriptor Logging cleanup. hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java Undo fetching Table Descriptor. Not reliably available a

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-06-22 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-647831826 @bharathv Thanks. making some changes now to download double conversion and gsasl2. will mark as ready for review after. thanks! ---

[jira] [Commented] (HBASE-23739) BoundedRecoveredHFilesOutputSink should read the table descriptor directly

2020-06-22 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142494#comment-17142494 ] Michael Stack commented on HBASE-23739: --- bq. Sir, can you explain more about this?

[jira] [Created] (HBASE-24616) Remove BoundedRecoveredHFilesOutputSink dependency on a TableDescriptor

2020-06-22 Thread Michael Stack (Jira)
Michael Stack created HBASE-24616: - Summary: Remove BoundedRecoveredHFilesOutputSink dependency on a TableDescriptor Key: HBASE-24616 URL: https://issues.apache.org/jira/browse/HBASE-24616 Project: H

[GitHub] [hbase] Apache-HBase commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-647827260 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s

[GitHub] [hbase] ndimiduk closed pull request #1832: HBASE-24493 WIP Increase hadoop logging

2020-06-22 Thread GitBox
ndimiduk closed pull request #1832: URL: https://github.com/apache/hbase/pull/1832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (HBASE-15161) Umbrella: Miscellaneous improvements from production usage

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-15161: - Affects Version/s: (was: 2.3.0) (was: 3.0.0-alpha-1) > Umbrella:

[jira] [Resolved] (HBASE-15161) Umbrella: Miscellaneous improvements from production usage

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-15161. -- Fix Version/s: 2.3.0 3.0.0-alpha-1 Resolution: Fixed > Umbrella: Mis

[jira] [Updated] (HBASE-15161) Umbrella: Miscellaneous improvements from production usage

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-15161: - Release Note: This ticket summarizes significant improvements and expansion to the metrics

[jira] [Commented] (HBASE-15595) Document new metrics improvements

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142486#comment-17142486 ] Nick Dimiduk commented on HBASE-15595: -- So what do we want to mention exactly? Look

[GitHub] [hbase] ndimiduk commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-22 Thread GitBox
ndimiduk commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r443876595 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean skip

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-22 Thread GitBox
huaxiangsun commented on a change in pull request #1933: URL: https://github.com/apache/hbase/pull/1933#discussion_r443875648 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1957,17 +1959,27 @@ public boolean normalizeRegions() throw

[GitHub] [hbase] Apache-HBase commented on pull request #1924: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1924: URL: https://github.com/apache/hbase/pull/1924#issuecomment-647813718 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39

[GitHub] [hbase] ndimiduk commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-22 Thread GitBox
ndimiduk commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r443873027 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/MergeNormalizationPlan.java ## @@ -78,4 +82,30 @@ public void execute(A

[GitHub] [hbase] ndimiduk commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-22 Thread GitBox
ndimiduk commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r443871798 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/MergeNormalizationPlan.java ## @@ -78,4 +82,30 @@ public void execute(A

[jira] [Commented] (HBASE-24102) RegionMover should exclude draining/decommissioning nodes from target RSs

2020-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142472#comment-17142472 ] Hudson commented on HBASE-24102: Results for branch branch-2.2 [build #900 on b

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142471#comment-17142471 ] Hudson commented on HBASE-24205: Results for branch branch-2.2 [build #900 on b

[jira] [Commented] (HBASE-24603) Zookeeper sync() call is async

2020-06-22 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142469#comment-17142469 ] Bharath Vissapragada commented on HBASE-24603: -- Some tests have regressed w

[GitHub] [hbase] Apache-HBase commented on pull request #1952: HBASE-24612: Consider allowing a separate EventLoopGroup for acceptin…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1952: URL: https://github.com/apache/hbase/pull/1952#issuecomment-647807928 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[jira] [Commented] (HBASE-24611) Bring back old constructor of SnapshotDescription

2020-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142468#comment-17142468 ] Hudson commented on HBASE-24611: Results for branch branch-2 [build #2714 on bu

[GitHub] [hbase] Apache-HBase commented on pull request #1924: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1924: URL: https://github.com/apache/hbase/pull/1924#issuecomment-647806839 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[jira] [Commented] (HBASE-24611) Bring back old constructor of SnapshotDescription

2020-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142465#comment-17142465 ] Hudson commented on HBASE-24611: Results for branch branch-2.3 [build #149 on b

[GitHub] [hbase] Apache-HBase commented on pull request #1954: HBASE-24231 Add hadoop 3.2.x in our support matrix

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1954: URL: https://github.com/apache/hbase/pull/1954#issuecomment-647804434 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[jira] [Commented] (HBASE-24446) Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142462#comment-17142462 ] Nick Dimiduk commented on HBASE-24446: -- Sorry for the delay [~vjasani]. I review h

[GitHub] [hbase] Apache-HBase commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-647803397 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s

[jira] [Created] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-06-22 Thread Rushabh Shah (Jira)
Rushabh Shah created HBASE-24615: Summary: MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket. Key: HBASE-24615 URL: https://issues.apache.org/jira/browse/HBASE-246

[jira] [Updated] (HBASE-24567) Create release should url-encode all characters when building git uri

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24567: - Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed Status: Resolved (was: Patch Av

[GitHub] [hbase] ndimiduk merged pull request #1907: HBASE-24567 Create release should url-encode all characters when building git uri

2020-06-22 Thread GitBox
ndimiduk merged pull request #1907: URL: https://github.com/apache/hbase/pull/1907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase-operator-tools] ndimiduk commented on a change in pull request #69: HBASE-24587 hbck2 command should accept one or more files containing …

2020-06-22 Thread GitBox
ndimiduk commented on a change in pull request #69: URL: https://github.com/apache/hbase-operator-tools/pull/69#discussion_r443855362 ## File path: hbase-hbck2/README.md ## @@ -137,12 +138,13 @@ Command: Returns the pid(s) of the created AssignProcedure(s) or -1 if none.

[GitHub] [hbase] Apache-HBase commented on pull request #1954: HBASE-24231 Add hadoop 3.2.x in our support matrix

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1954: URL: https://github.com/apache/hbase/pull/1954#issuecomment-647796904 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #1954: HBASE-24231 Add hadoop 3.2.x in our support matrix

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1954: URL: https://github.com/apache/hbase/pull/1954#issuecomment-647797030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36

[jira] [Reopened] (HBASE-24144) Update docs from master

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24144: -- Reopening so as to include HBASE-24231. > Update docs from master > --- > >

[GitHub] [hbase] ndimiduk opened a new pull request #1954: HBASE-24231 Add hadoop 3.2.x in our support matrix

2020-06-22 Thread GitBox
ndimiduk opened a new pull request #1954: URL: https://github.com/apache/hbase/pull/1954 Add a line for hadoop-3.2.x. Values are based on the if-statement in our personality file, ``` if [[ "${PATCH_BRANCH}" = branch-1* ]]; then yetus_info "Setting Hadoop 3 versions to

[jira] [Work started] (HBASE-24231) Add hadoop 3.2.x in our support matrix

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24231 started by Nick Dimiduk. > Add hadoop 3.2.x in our support matrix >

[jira] [Assigned] (HBASE-24231) Add hadoop 3.2.x in our support matrix

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-24231: Assignee: Nick Dimiduk > Add hadoop 3.2.x in our support matrix > ---

[GitHub] [hbase] Apache-HBase commented on pull request #1952: HBASE-24612: Consider allowing a separate EventLoopGroup for acceptin…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1952: URL: https://github.com/apache/hbase/pull/1952#issuecomment-647791783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s

[jira] [Updated] (HBASE-24581) Skip compaction request/check for replica regions at the early stage.

2020-06-22 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24581: - Summary: Skip compaction request/check for replica regions at the early stage. (was: Skip compa

[jira] [Updated] (HBASE-24581) Skip compaction request/check for replica regions at the

2020-06-22 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24581: - Summary: Skip compaction request/check for replica regions at the (was: Replica regions should

[jira] [Updated] (HBASE-24581) Replica regions should not trigger any compaction

2020-06-22 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24581: - Issue Type: Improvement (was: Bug) Priority: Major (was: Critical) Debugged more, found

[GitHub] [hbase] Apache-HBase commented on pull request #1924: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1924: URL: https://github.com/apache/hbase/pull/1924#issuecomment-647765625 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 7

[GitHub] [hbase] ndimiduk commented on a change in pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-22 Thread GitBox
ndimiduk commented on a change in pull request #1933: URL: https://github.com/apache/hbase/pull/1933#discussion_r443804878 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -1304,8 +1304,8 @@ private void checkAndGetTableName

[GitHub] [hbase] ndimiduk commented on a change in pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-22 Thread GitBox
ndimiduk commented on a change in pull request #1933: URL: https://github.com/apache/hbase/pull/1933#discussion_r443803523 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1957,17 +1959,27 @@ public boolean normalizeRegions() throws I

[GitHub] [hbase] Apache-HBase commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-647747299 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1924: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-22 Thread GitBox
huaxiangsun commented on a change in pull request #1924: URL: https://github.com/apache/hbase/pull/1924#discussion_r443796817 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java ## @@ -338,6 +345,35 @@ protected F

[jira] [Commented] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected

2020-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142379#comment-17142379 ] Hudson commented on HBASE-24550: Results for branch branch-1.4 [build #1229 on

[GitHub] [hbase] Apache-HBase commented on pull request #1952: HBASE-24612: Consider allowing a separate EventLoopGroup for acceptin…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1952: URL: https://github.com/apache/hbase/pull/1952#issuecomment-647734557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hbase] virajjasani commented on a change in pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-22 Thread GitBox
virajjasani commented on a change in pull request #1933: URL: https://github.com/apache/hbase/pull/1933#discussion_r443783539 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1957,17 +1959,27 @@ public boolean normalizeRegions() throw

[GitHub] [hbase] sguggilam commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-22 Thread GitBox
sguggilam commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r443775794 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -595,9 +604,28 @@ private void connectionEvent(Watched

[GitHub] [hbase] Apache-HBase commented on pull request #1939: HBASE-24597 : Backport HBASE-24380 (Provide WAL splitting journal logging) (#1860)

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1939: URL: https://github.com/apache/hbase/pull/1939#issuecomment-647723738 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38

[GitHub] [hbase] Apache-HBase commented on pull request #1952: HBASE-24612: Consider allowing a separate EventLoopGroup for acceptin…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1952: URL: https://github.com/apache/hbase/pull/1952#issuecomment-647718498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20

[GitHub] [hbase] Apache-HBase commented on pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1953: URL: https://github.com/apache/hbase/pull/1953#issuecomment-647716294 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15

[GitHub] [hbase] Apache-HBase commented on pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1953: URL: https://github.com/apache/hbase/pull/1953#issuecomment-647716111 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40

[GitHub] [hbase] Apache-HBase commented on pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

2020-06-22 Thread GitBox
Apache-HBase commented on pull request #1953: URL: https://github.com/apache/hbase/pull/1953#issuecomment-647713880 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39

[GitHub] [hbase] ndimiduk commented on pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-22 Thread GitBox
ndimiduk commented on pull request #1620: URL: https://github.com/apache/hbase/pull/1620#issuecomment-647710176 > the object directory messages are a side effect of using the shared objects. It shouldn't be listed as an error since git then immediately checks the alternates we provide and

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142350#comment-17142350 ] Nick Dimiduk commented on HBASE-24205: -- I updated the fixVersion to include 2.3.0 s

[jira] [Updated] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24205: - Fix Version/s: 2.3.0 > Create metric to know the number of reads that happens from memstore > --

[GitHub] [hbase] ndimiduk commented on a change in pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

2020-06-22 Thread GitBox
ndimiduk commented on a change in pull request #1953: URL: https://github.com/apache/hbase/pull/1953#discussion_r443757191 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java ## @@ -137,6 +137,103 @@ public Job createSubmittableJob(Con

[GitHub] [hbase] HorizonNet commented on a change in pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

2020-06-22 Thread GitBox
HorizonNet commented on a change in pull request #1953: URL: https://github.com/apache/hbase/pull/1953#discussion_r443755808 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java ## @@ -137,6 +137,103 @@ public Job createSubmittableJob(C

[GitHub] [hbase] virajjasani commented on a change in pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

2020-06-22 Thread GitBox
virajjasani commented on a change in pull request #1953: URL: https://github.com/apache/hbase/pull/1953#discussion_r443753904 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java ## @@ -137,6 +137,103 @@ public Job createSubmittableJob(

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-22 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142327#comment-17142327 ] ramkrishna.s.vasudevan commented on HBASE-24205: Thanks [~ndimiduk] . Ya

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-22 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142324#comment-17142324 ] Nick Dimiduk commented on HBASE-24205: -- The 2.3.0RC failed, so i'm okay with this o

[jira] [Commented] (HBASE-21773) rowcounter utility should respond to pleas for help

2020-06-22 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142323#comment-17142323 ] Wellington Chevreuil commented on HBASE-21773: -- Created addendum [PR|https:

[GitHub] [hbase] wchevreuil opened a new pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

2020-06-22 Thread GitBox
wchevreuil opened a new pull request #1953: URL: https://github.com/apache/hbase/pull/1953 …bleJob(Configuration conf, String[] args)" for compatibility reasons. This is an automated message from the Apache Git Service. To re

[GitHub] [hbase] virajjasani merged pull request #1939: HBASE-24597 : Backport HBASE-24380 (Provide WAL splitting journal logging) (#1860)

2020-06-22 Thread GitBox
virajjasani merged pull request #1939: URL: https://github.com/apache/hbase/pull/1939 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hbase] bharathv commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-22 Thread GitBox
bharathv commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r443737875 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -595,9 +604,28 @@ private void connectionEvent(WatchedE

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1924: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-22 Thread GitBox
huaxiangsun commented on a change in pull request #1924: URL: https://github.com/apache/hbase/pull/1924#discussion_r443735473 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java ## @@ -338,6 +345,35 @@ protected F

  1   2   >