[GitHub] [hbase] infraio commented on pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
infraio commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-669911621 > I think this is a Xiaomi specific problem? Seems you have compiled with a customized hadoop library but then someone introduces a official library? Yes. But we still have

[GitHub] [hbase] Apache9 commented on pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
Apache9 commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-669909506 I think this is a Xiaomi specific problem? Seems you have compiled with a customized hadoop library but then someone introduces a official library?

[jira] [Created] (HBASE-24827) BackPort HBASE-11554 Remove Reusable poolmap Rpc client type.

2020-08-06 Thread niuyulin (Jira)
niuyulin created HBASE-24827: Summary: BackPort HBASE-11554 Remove Reusable poolmap Rpc client type. Key: HBASE-24827 URL: https://issues.apache.org/jira/browse/HBASE-24827 Project: HBase Issue

[GitHub] [hbase] nyl3532016 commented on pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
nyl3532016 commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-669899867 > Mind exlaining the reason a bit? Yes, I add a description This is an automated message from the

[GitHub] [hbase] nyl3532016 commented on a change in pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
nyl3532016 commented on a change in pull request #2206: URL: https://github.com/apache/hbase/pull/2206#discussion_r466377751 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -178,7 +179,7 @@ private void

[GitHub] [hbase] nyl3532016 removed a comment on pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
nyl3532016 removed a comment on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-669898422 > LGTM. Would other parts of the connection attempt catching only IOException also benefit from this change? I think other parts catching only IOException is just

[GitHub] [hbase] nyl3532016 commented on pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
nyl3532016 commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-669898422 > LGTM. Would other parts of the connection attempt catching only IOException also benefit from this change? I think other parts catching only IOException is just fine, the

[GitHub] [hbase] Apache-HBase commented on pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2196: URL: https://github.com/apache/hbase/pull/2196#issuecomment-669877792 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24807) Backport HBASE-20417 to branch-1

2020-08-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172278#comment-17172278 ] Hudson commented on HBASE-24807: Results for branch branch-1 [build #1339 on

[jira] [Commented] (HBASE-20417) Do not read wal entries when peer is disabled

2020-08-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172279#comment-17172279 ] Hudson commented on HBASE-20417: Results for branch branch-1 [build #1339 on

[GitHub] [hbase] Apache-HBase commented on pull request #2208: BackPort HBASE-11554 Remove Reusable poolmap Rpc client type.

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2208: URL: https://github.com/apache/hbase/pull/2208#issuecomment-669860739 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2208: BackPort HBASE-11554 Remove Reusable poolmap Rpc client type.

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2208: URL: https://github.com/apache/hbase/pull/2208#issuecomment-669859831 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2208: BackPort HBASE-11554 Remove Reusable poolmap Rpc client type.

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2208: URL: https://github.com/apache/hbase/pull/2208#issuecomment-669858295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-06 Thread GitBox
virajjasani commented on a change in pull request #2196: URL: https://github.com/apache/hbase/pull/2196#discussion_r466317865 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java ## @@ -200,70 +201,7 @@ public static ThreadPoolExecutor

[GitHub] [hbase] Apache9 commented on pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
Apache9 commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-669851299 Mind exlaining the reason a bit? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] nyl3532016 commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-08-06 Thread GitBox
nyl3532016 commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-669848165 @saintstack please have a look, thanks This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] nyl3532016 opened a new pull request #2208: BackPort HBASE-11554 Remove Reusable poolmap Rpc client type.

2020-08-06 Thread GitBox
nyl3532016 opened a new pull request #2208: URL: https://github.com/apache/hbase/pull/2208 Since PoolType.Reusable is no longer used, It is better removed, otherwise will confuse people This is an automated message from

[GitHub] [hbase] wchevreuil commented on a change in pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
wchevreuil commented on a change in pull request #2206: URL: https://github.com/apache/hbase/pull/2206#discussion_r466283735 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -178,7 +179,7 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2207: HBASE-24826 Add some comments for processlist in hbase shell

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2207: URL: https://github.com/apache/hbase/pull/2207#issuecomment-669821756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2207: HBASE-24826 Add some comments for processlist in hbase shell

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2207: URL: https://github.com/apache/hbase/pull/2207#issuecomment-669821982 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2207: HBASE-24826 Add some comments for processlist in hbase shell

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2207: URL: https://github.com/apache/hbase/pull/2207#issuecomment-669814258 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz opened a new pull request #2207: HBASE-24826 Add some comments for processlist in hbase shell

2020-08-06 Thread GitBox
bsglz opened a new pull request #2207: URL: https://github.com/apache/hbase/pull/2207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HBASE-24826) Add some comments for processlist in hbase shell

2020-08-06 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24826: --- Summary: Add some comments for processlist in hbase shell (was: Add some comments for command of

[jira] [Created] (HBASE-24826) Add some comments for command of processlist

2020-08-06 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-24826: -- Summary: Add some comments for command of processlist Key: HBASE-24826 URL: https://issues.apache.org/jira/browse/HBASE-24826 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-669806026 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-669805523 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-669802342 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] nyl3532016 opened a new pull request #2206: HBASE-24825 NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread GitBox
nyl3532016 opened a new pull request #2206: URL: https://github.com/apache/hbase/pull/2206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (HBASE-24825) NettyRpcConnection.scheduleRelogin method should catch Throwable exception

2020-08-06 Thread niuyulin (Jira)
niuyulin created HBASE-24825: Summary: NettyRpcConnection.scheduleRelogin method should catch Throwable exception Key: HBASE-24825 URL: https://issues.apache.org/jira/browse/HBASE-24825 Project: HBase

[jira] [Resolved] (HBASE-24819) Fix flaky test TestRaceBetweenSCPAndDTP and TestRaceBetweenSCPAndTRSP for branch-2.2

2020-08-06 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24819. Fix Version/s: 2.2.6 Resolution: Fixed Pushed. Thanks [~meiyi] for reviewing. >

[GitHub] [hbase] infraio merged pull request #2199: HBASE-24819 Fix flaky test TestRaceBetweenSCPAndDTP and TestRaceBetwe…

2020-08-06 Thread GitBox
infraio merged pull request #2199: URL: https://github.com/apache/hbase/pull/2199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

2020-08-06 Thread GitBox
Apache-HBase commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-669729667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

<    1   2