[GitHub] [hbase] Apache-HBase commented on pull request #2214: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2214: URL: https://github.com/apache/hbase/pull/2214#issuecomment-671006864 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] nyl3532016 edited a comment on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
nyl3532016 edited a comment on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-671005863 > Do you think using default UncaughtExceptionHandler will provide better warn logs if something goes wrong with relogin()? Maybe try creating a custom

[GitHub] [hbase] nyl3532016 commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
nyl3532016 commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-671005863 > Do you think using default UncaughtExceptionHandler will provide better warn logs if something goes wrong with relogin()? Maybe try creating a custom

[GitHub] [hbase] nyl3532016 commented on a change in pull request #2196: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-08 Thread GitBox
nyl3532016 commented on a change in pull request #2196: URL: https://github.com/apache/hbase/pull/2196#discussion_r467535276 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java ## @@ -197,83 +198,14 @@ public static ThreadPoolExecutor

[GitHub] [hbase] Apache-HBase commented on pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #1635: URL: https://github.com/apache/hbase/pull/1635#issuecomment-671001757 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-08-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173736#comment-17173736 ] Duo Zhang commented on HBASE-11288: --- Hi [~toffer], so your patch just adds a root table, without

[GitHub] [hbase] Apache-HBase commented on pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #1635: URL: https://github.com/apache/hbase/pull/1635#issuecomment-670997968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] tedyu commented on a change in pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.

2020-08-08 Thread GitBox
tedyu commented on a change in pull request #1635: URL: https://github.com/apache/hbase/pull/1635#discussion_r467527897 ## File path: hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/master/TestMetricsMasterProcSourceImpl.java ## @@ -48,4 +69,11 @@ public void

[jira] [Updated] (HBASE-24833) Bootstrap should not delete the META table directory if it's not partial

2020-08-08 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-24833: - Parent: HBASE-24286 Issue Type: Sub-task (was: Umbrella) > Bootstrap

[GitHub] [hbase] Apache-HBase commented on pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #1635: URL: https://github.com/apache/hbase/pull/1635#issuecomment-670988954 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2211: HBASE-24830 Some tests involving RS crash fail with NullPointerExcept…

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2211: URL: https://github.com/apache/hbase/pull/2211#issuecomment-670987306 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 20m

[jira] [Commented] (HBASE-24788) Fix the connection leaks on getting hbase admin from unclosed connection

2020-08-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173717#comment-17173717 ] Hudson commented on HBASE-24788: Results for branch branch-2.3 [build #204 on

[GitHub] [hbase] taklwu commented on a change in pull request #2211: HBASE-24830 Some tests involving RS crash fail with NullPointerExcept…

2020-08-08 Thread GitBox
taklwu commented on a change in pull request #2211: URL: https://github.com/apache/hbase/pull/2211#discussion_r467514589 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java ## @@ -104,7 +104,8 @@ static Status splitLog(String

[jira] [Assigned] (HBASE-24833) Bootstrap should not delete the META table directory if it's not partial

2020-08-08 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-24833: Assignee: Tak-Lon (Stephen) Wu > Bootstrap should not delete the META

[jira] [Commented] (HBASE-24833) Bootstrap should not delete the META table directory if it's not partial

2020-08-08 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173716#comment-17173716 ] Tak-Lon (Stephen) Wu commented on HBASE-24833: -- I'm on this issue, will provide a patch the

[GitHub] [hbase] tedyu commented on pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.

2020-08-08 Thread GitBox
tedyu commented on pull request #1635: URL: https://github.com/apache/hbase/pull/1635#issuecomment-670983640 Yes, please. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] sanjeetnishad95 commented on pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.

2020-08-08 Thread GitBox
sanjeetnishad95 commented on pull request #1635: URL: https://github.com/apache/hbase/pull/1635#issuecomment-670983273 It is an old PR. Sorry, I can't recollect any particular objective for publishing the failure count. Seems unnecessary. Want me to update this?

[GitHub] [hbase] Apache-HBase commented on pull request #2211: HBASE-24830 Some tests involving RS crash fail with NullPointerExcept…

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2211: URL: https://github.com/apache/hbase/pull/2211#issuecomment-670981520 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] tedyu commented on pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.

2020-08-08 Thread GitBox
tedyu commented on pull request #1635: URL: https://github.com/apache/hbase/pull/1635#issuecomment-670979637 Thanks for the PR. I am a bit curious: previously there were incrSplitRequest and the success count. In the PR, there is also failure count which can be deduced from the other

[jira] [Commented] (HBASE-24788) Fix the connection leaks on getting hbase admin from unclosed connection

2020-08-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173713#comment-17173713 ] Hudson commented on HBASE-24788: Results for branch branch-2.2 [build #929 on

[GitHub] [hbase] sanjeetnishad95 commented on pull request #1635: HBASE-23996 Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.

2020-08-08 Thread GitBox
sanjeetnishad95 commented on pull request #1635: URL: https://github.com/apache/hbase/pull/1635#issuecomment-670972949 Hi @tedyu Checkstyle warnings have been handled in the latest push. This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #2211: HBASE-24830 Some tests involving RS crash fail with NullPointerExcept…

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2211: URL: https://github.com/apache/hbase/pull/2211#issuecomment-670971765 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #2211: HBASE-24830 Some tests involving RS crash fail with NullPointerExcept…

2020-08-08 Thread GitBox
saintstack commented on pull request #2211: URL: https://github.com/apache/hbase/pull/2211#issuecomment-670968604 One (unrelated) test failed. It passes locally. Rerunning just in case. This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #2221: HBASE-24395 ServerName#getHostname() is case sensitive

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2221: URL: https://github.com/apache/hbase/pull/2221#issuecomment-670954215 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] virajjasani commented on a change in pull request #2215: HBASE-24627 Normalize one table at a time

2020-08-08 Thread GitBox
virajjasani commented on a change in pull request #2215: URL: https://github.com/apache/hbase/pull/2215#discussion_r467486796 ## File path: hbase-shell/src/main/ruby/hbase_constants.rb ## @@ -32,75 +32,79 @@ java_import('java.lang.Boolean') { |_package, name| "J#{name}" }

[GitHub] [hbase] Apache-HBase commented on pull request #2220: HBASE-21721 reduce write#syncs() times

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2220: URL: https://github.com/apache/hbase/pull/2220#issuecomment-670953689 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on a change in pull request #2215: HBASE-24627 Normalize one table at a time

2020-08-08 Thread GitBox
virajjasani commented on a change in pull request #2215: URL: https://github.com/apache/hbase/pull/2215#discussion_r467484336 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3279,13 +3279,22 @@ private void

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-08-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173693#comment-17173693 ] Michael Stack commented on HBASE-11288: --- After adding the priority patch, my ITBLL run from last

[GitHub] [hbase] Apache-HBase commented on pull request #2214: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2214: URL: https://github.com/apache/hbase/pull/2214#issuecomment-670950992 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-21721) FSHLog : reduce write#syncs() times

2020-08-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173674#comment-17173674 ] Hudson commented on HBASE-21721: Results for branch branch-2.3 [build #203 on

[GitHub] [hbase] virajjasani commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
virajjasani commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-670949728 Do you think using default UncaughtExceptionHandler will provide better warn logs if something goes wrong with relogin()? Maybe try creating a custom UncaughtExceptionHandler

[GitHub] [hbase] virajjasani commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
virajjasani commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-670949206 > @virajjasani when submitting this patch, I find maybe the default UncaughtExceptionHandler (Threads.LOGGING_EXCEPTION_HANDLER) will unset in ThreadFactoryBuilder.dobuild

[GitHub] [hbase] Apache-HBase commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-670942049 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 42m

[GitHub] [hbase] Apache-HBase commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-670938496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-670938349 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] cuibo01 opened a new pull request #2221: HBASE-24395 ServerName#getHostname() is case sensitive

2020-08-08 Thread GitBox
cuibo01 opened a new pull request #2221: URL: https://github.com/apache/hbase/pull/2221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] cuibo01 opened a new pull request #2220: HBASE-21721 reduce write#syncs() times

2020-08-08 Thread GitBox
cuibo01 opened a new pull request #2220: URL: https://github.com/apache/hbase/pull/2220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] cuibo01 closed pull request #2143: HBASE-21721 reduce write#syncs() times

2020-08-08 Thread GitBox
cuibo01 closed pull request #2143: URL: https://github.com/apache/hbase/pull/2143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] nyl3532016 commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
nyl3532016 commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-670934971 @virajjasani when submitting this patch, I find maybe the default UncaughtExceptionHandler (Threads.LOGGING_EXCEPTION_HANDLER) will unset in ThreadFactoryBuilder.dobuild

[jira] [Resolved] (HBASE-24785) [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 3.4.0

2020-08-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24785. --- Resolution: Fixed Merged addendum to master. > [hbase-thirdparty] Generate CHANGES.md and

[GitHub] [hbase-thirdparty] Apache9 merged pull request #30: HBASE-24785 Addendum add new issues since RC0

2020-08-08 Thread GitBox
Apache9 merged pull request #30: URL: https://github.com/apache/hbase-thirdparty/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Reopened] (HBASE-24785) [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 3.4.0

2020-08-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-24785: --- > [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 3.4.0 >

[GitHub] [hbase-thirdparty] Apache9 opened a new pull request #30: HBASE-24785 Addendum add new issues since RC0

2020-08-08 Thread GitBox
Apache9 opened a new pull request #30: URL: https://github.com/apache/hbase-thirdparty/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HBASE-24820) [hbase-thirdparty] Add jersey-hk2 when shading jersey and bump jetty to 9.4.31

2020-08-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24820: -- Hadoop Flags: Reviewed Release Note: Jetty 9.4.30 -> 9.4.31 Shade jersey-hk2 in

[jira] [Resolved] (HBASE-24820) [hbase-thirdparty] Add jersey-hk2 when shading jersey and bump jetty to 9.4.31

2020-08-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24820. --- Resolution: Fixed Merged to master. Thanks [~psomogyi] for reviewing. > [hbase-thirdparty] Add

[GitHub] [hbase-thirdparty] Apache9 merged pull request #29: HBASE-24820 [hbase-thirdparty] Add jersey-hk2 when shading jersey and…

2020-08-08 Thread GitBox
Apache9 merged pull request #29: URL: https://github.com/apache/hbase-thirdparty/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-24788) Fix the connection leaks on getting hbase admin from unclosed connection

2020-08-08 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173652#comment-17173652 ] Sean Busbey commented on HBASE-24788: - Thanks for the quick fix! > Fix the connection leaks on

[GitHub] [hbase] Apache-HBase commented on pull request #2218: HBASE-24694 Support flush a single column family of table

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2218: URL: https://github.com/apache/hbase/pull/2218#issuecomment-670927266 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Updated] (HBASE-24825) Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24825: - Summary: Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread (was:

[jira] [Assigned] (HBASE-24755) [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2020-08-08 Thread mokai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mokai reassigned HBASE-24755: - Assignee: mokai > [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup >

[GitHub] [hbase] Apache-HBase commented on pull request #2219: HBASE-24686 [LOG] Log improvement in Connection#close

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2219: URL: https://github.com/apache/hbase/pull/2219#issuecomment-670852720 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2219: HBASE-24686 [LOG] Log improvement in Connection#close

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2219: URL: https://github.com/apache/hbase/pull/2219#issuecomment-670852390 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2219: HBASE-24686 [LOG] Log improvement in Connection#close

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2219: URL: https://github.com/apache/hbase/pull/2219#issuecomment-670852412 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] cuibo01 commented on a change in pull request #2143: HBASE-21721 reduce write#syncs() times

2020-08-08 Thread GitBox
cuibo01 commented on a change in pull request #2143: URL: https://github.com/apache/hbase/pull/2143#discussion_r467419075 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1317,8 +1317,12 @@ public void run() {

[GitHub] [hbase] mokai87 opened a new pull request #2219: HBASE-24686 [LOG] Log improvement in Connection#close

2020-08-08 Thread GitBox
mokai87 opened a new pull request #2219: URL: https://github.com/apache/hbase/pull/2219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (HBASE-24788) Fix the connection leaks on getting hbase admin from unclosed connection

2020-08-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24788. -- Hadoop Flags: Reviewed Resolution: Fixed > Fix the connection leaks on getting hbase

[jira] [Commented] (HBASE-24788) Fix the connection leaks on getting hbase admin from unclosed connection

2020-08-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173612#comment-17173612 ] Viraj Jasani commented on HBASE-24788: -- Updated master, branch-2, branch-2.3 and branch-2.2 with

[GitHub] [hbase] Apache-HBase commented on pull request #2214: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2214: URL: https://github.com/apache/hbase/pull/2214#issuecomment-670841777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24788) Fix the connection leaks on getting hbase admin from unclosed connection

2020-08-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173601#comment-17173601 ] Viraj Jasani commented on HBASE-24788: -- Oh yes, this was an oversight, apologies. Let me fix this

[GitHub] [hbase] Apache-HBase commented on pull request #2218: HBASE-24694 Support flush a single column family of table

2020-08-08 Thread GitBox
Apache-HBase commented on pull request #2218: URL: https://github.com/apache/hbase/pull/2218#issuecomment-670830003 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m