[GitHub] [hbase] WenFeiYi commented on a change in pull request #2239: HBASE-24844 Exception on standalone (master) shutdown

2020-08-12 Thread GitBox
WenFeiYi commented on a change in pull request #2239: URL: https://github.com/apache/hbase/pull/2239#discussion_r469164856 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -692,12 +692,12 @@ public void

[jira] [Updated] (HBASE-24750) All executor service should start using guava ThreadFactory

2020-08-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24750: - Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [hbase] virajjasani merged pull request #2214: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-12 Thread GitBox
virajjasani merged pull request #2214: URL: https://github.com/apache/hbase/pull/2214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani commented on pull request #2214: HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder

2020-08-12 Thread GitBox
virajjasani commented on pull request #2214: URL: https://github.com/apache/hbase/pull/2214#issuecomment-672789586 TestRegionServerReportForDuty is passing locally. This is an automated message from the Apache Git Service.

[GitHub] [hbase] Apache-HBase commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-672787767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-672787996 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
virajjasani commented on a change in pull request #2241: URL: https://github.com/apache/hbase/pull/2241#discussion_r469152741 ## File path: hbase-shell/src/main/ruby/shell/commands/assign.rb ## @@ -22,8 +22,8 @@ module Commands class Assign < Command def help

[GitHub] [hbase] eomiks edited a comment on pull request #1993: HBASE-24652 master-status UI, make date type fields sortable

2020-08-12 Thread GitBox
eomiks edited a comment on pull request #1993: URL: https://github.com/apache/hbase/pull/1993#issuecomment-651465347 @saintstack this is screenshot of my patched master ui. thank you.

[GitHub] [hbase] virajjasani commented on a change in pull request #2239: HBASE-24844 Exception on standalone (master) shutdown

2020-08-12 Thread GitBox
virajjasani commented on a change in pull request #2239: URL: https://github.com/apache/hbase/pull/2239#discussion_r469131166 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -692,12 +692,12 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2250: HBASE-24872 refactor valueOf PoolType

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2250: URL: https://github.com/apache/hbase/pull/2250#issuecomment-672764785 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2250: HBASE-24872 refactor valueOf PoolType

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2250: URL: https://github.com/apache/hbase/pull/2250#issuecomment-672760652 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2250: HBASE-24872 refactor valueOf PoolType

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2250: URL: https://github.com/apache/hbase/pull/2250#issuecomment-672758692 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ddupg commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-12 Thread GitBox
ddupg commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-672741439 > Add a UT for this case? OK, I'll try it. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] nyl3532016 opened a new pull request #2250: HBASE-24872 refactor valueOf PoolType

2020-08-12 Thread GitBox
nyl3532016 opened a new pull request #2250: URL: https://github.com/apache/hbase/pull/2250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Assigned] (HBASE-24872) refactor valueOf PoolType

2020-08-12 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin reassigned HBASE-24872: Assignee: niuyulin > refactor valueOf PoolType > - > >

[jira] [Updated] (HBASE-24872) refactor valueOf PoolType

2020-08-12 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24872: - Summary: refactor valueOf PoolType (was: re) > refactor valueOf PoolType > - >

[jira] [Created] (HBASE-24872) re

2020-08-12 Thread niuyulin (Jira)
niuyulin created HBASE-24872: Summary: re Key: HBASE-24872 URL: https://issues.apache.org/jira/browse/HBASE-24872 Project: HBase Issue Type: Improvement Reporter: niuyulin --

[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica

2020-08-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176155#comment-17176155 ] Duo Zhang commented on HBASE-18070: --- I think HBASE-15867 has a conflict with the approach here. In

[GitHub] [hbase] Apache-HBase commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-672718443 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24856) Fix error prone error in FlushTableSubprocedure

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176131#comment-17176131 ] Hudson commented on HBASE-24856: Results for branch branch-2 [build #5 on

[jira] [Commented] (HBASE-24843) Sort the constants in `hbase_constants.rb`

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176130#comment-17176130 ] Hudson commented on HBASE-24843: Results for branch branch-2 [build #5 on

[GitHub] [hbase] infraio commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-12 Thread GitBox
infraio commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-672706004 Add a UT for this case? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] anoopsjohn commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-12 Thread GitBox
anoopsjohn commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-672701120 Ya the biggest issue now is the META FS dir delete which happens after such a cluster recreate. An HBCK kind of tool to recreate the META data is too much IMO. Also we many

[jira] [Assigned] (HBASE-24847) Backport HBASE-23956: Use less resources running tests to branch-2.2

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24847: -- Assignee: Guanghao Zhang > Backport HBASE-23956: Use less resources running tests to

[GitHub] [hbase] ddupg opened a new pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-12 Thread GitBox
ddupg opened a new pull request #2249: URL: https://github.com/apache/hbase/pull/2249 …ion sources This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #2245: HBASE-24857:Fix several problems when starting webUI

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2245: URL: https://github.com/apache/hbase/pull/2245#issuecomment-672656740 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] infraio opened a new pull request #2248: HBASE-24870 Ignore TestAsyncTableRSCrashPublish

2020-08-12 Thread GitBox
infraio opened a new pull request #2248: URL: https://github.com/apache/hbase/pull/2248 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-24871) Replication may loss data when refresh recovered replication sources

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176074#comment-17176074 ] Guanghao Zhang commented on HBASE-24871: [~ndimiduk] Take a look about this sir. Should be a

[jira] [Comment Edited] (HBASE-24871) Replication may loss data when refresh recovered replication sources

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176074#comment-17176074 ] Guanghao Zhang edited comment on HBASE-24871 at 8/12/20, 6:55 AM: --

[jira] [Assigned] (HBASE-24871) Replication may loss data when refresh recovered replication sources

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24871: -- Assignee: Sun Xin > Replication may loss data when refresh recovered replication

[jira] [Updated] (HBASE-24871) Replication may loss data when refresh recovered replication sources

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24871: --- Affects Version/s: 3.0.0-alpha-1 2.3.0 2.2.5

[jira] [Created] (HBASE-24871) Replication may loss data when refresh recovered replication sources

2020-08-12 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24871: -- Summary: Replication may loss data when refresh recovered replication sources Key: HBASE-24871 URL: https://issues.apache.org/jira/browse/HBASE-24871 Project:

[jira] [Created] (HBASE-24870) Ignore TestAsyncTableRSCrashPublish

2020-08-12 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24870: -- Summary: Ignore TestAsyncTableRSCrashPublish Key: HBASE-24870 URL: https://issues.apache.org/jira/browse/HBASE-24870 Project: HBase Issue Type: Sub-task

[jira] [Reopened] (HBASE-23987) NettyRpcClientConfigHelper will not share event loop by default which is incorrect

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reopened HBASE-23987: Reopen for cherry-pick to branch-2.2. Will push this after HBASE-24847. >

[GitHub] [hbase] infraio opened a new pull request #2247: HBASE-24847 Backport HBASE-23956: Use less resources running tests to…

2020-08-12 Thread GitBox
infraio opened a new pull request #2247: URL: https://github.com/apache/hbase/pull/2247 … branch-2.2 Add being able to configure netty thread counts. Enable socket reuse (should not have any impact).

[GitHub] [hbase] Apache-HBase commented on pull request #2215: HBASE-24627 Normalize one table at a time

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2215: URL: https://github.com/apache/hbase/pull/2215#issuecomment-672631812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-22524) Refactor TestReplicationSyncUpTool

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-22524. Fix Version/s: 2.2.6 Resolution: Fixed > Refactor TestReplicationSyncUpTool >

[jira] [Commented] (HBASE-22524) Refactor TestReplicationSyncUpTool

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176038#comment-17176038 ] Guanghao Zhang commented on HBASE-22524: Pushed to branch-2.2. > Refactor

[GitHub] [hbase] infraio merged pull request #2230: HBASE-22524 Refactor TestReplicationSyncUpTool

2020-08-12 Thread GitBox
infraio merged pull request #2230: URL: https://github.com/apache/hbase/pull/2230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2215: HBASE-24627 Normalize one table at a time

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2215: URL: https://github.com/apache/hbase/pull/2215#issuecomment-672626397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

<    1   2