[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-19 Thread GitBox
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677365924 Seems it is ok, will add a unit test for CurrentHourProvider later. This is an automated message from the Apache Git

[GitHub] [hbase] bsglz edited a comment on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-19 Thread GitBox
bsglz edited a comment on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677353645 Maybe we can set the time. >Calendar calendar = new GregorianCalendar(); > calendar.setTimeInMillis(EnvironmentEdgeManager.currentTime()); -

[GitHub] [hbase] ddupg commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-19 Thread GitBox
ddupg commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-677355961 > Add a UT for this case? Thank @huaxiangsun for reviewing, I've added an UT for this case. This is an automa

[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-19 Thread GitBox
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677353645 Maybe we could set the time. >Calendar calendar = new GregorianCalendar(); > calendar.setTimeInMillis(EnvironmentEdgeManager.currentTime()); --

[GitHub] [hbase] Apache9 commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-19 Thread GitBox
Apache9 commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r473656744 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterAddressRefresher.java ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Sof

[GitHub] [hbase] Apache-HBase commented on pull request #2285: HBASE-24912 Enalrge MemstoreFlusherChore/CompactionChecker period for…

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-677340963 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 13

[GitHub] [hbase] infraio commented on a change in pull request #2149: HBASE-24760 Allow system tables fallback to any rs groups

2020-08-19 Thread GitBox
infraio commented on a change in pull request #2149: URL: https://github.com/apache/hbase/pull/2149#discussion_r473659089 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java ## @@ -88,9 +87,15 @@ */ public static final

[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-19 Thread GitBox
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677324748 > But I'm not sure if we could control the return value of CurrentHourProvider? In nextTick method, we will not use EnvironmentEdge.currentTime() so it will still return the current

[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-677319783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 54s

[GitHub] [hbase] Apache9 commented on pull request #2189: HBASE-24811 Use class access static filed or method

2020-08-19 Thread GitBox
Apache9 commented on pull request #2189: URL: https://github.com/apache/hbase/pull/2189#issuecomment-677306742 I think there is a typo in the title? 'filed' -> 'field'? This is an automated message from the Apache Git Serv

[GitHub] [hbase] Apache9 commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-19 Thread GitBox
Apache9 commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677291674 But I'm not sure if we could control the return value of CurrentHourProvider? In nextTick method, we will not use EnvironmentEdge.currentTime() so it will still return the current

[GitHub] [hbase] Apache-HBase commented on pull request #2279: HBASE-24908 Correct the description of hbase.offpeak.end.hour

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2279: URL: https://github.com/apache/hbase/pull/2279#issuecomment-677288602 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 55

[GitHub] [hbase] Apache9 commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-19 Thread GitBox
Apache9 commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677266826 > ``` > Could this really solve the problem? > ``` > > Problem is hard to reproduce. > > Reasoning, this patch shoud reduce likelihood of our encountering this

[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-19 Thread GitBox
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677264516 Thanks for the help here. The last push implements @virajjasani 's suggestion. It moves the MutableRegionInfo out of RegionInfoBuilder to be standalone. This allows brea

[GitHub] [hbase] Apache-HBase commented on pull request #2265: HBASE-24892 config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2265: URL: https://github.com/apache/hbase/pull/2265#issuecomment-677246835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 49

[jira] [Resolved] (HBASE-24895) Speed up TestFromClientSide3 by reduce the table regions number

2020-08-19 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24895. Fix Version/s: 2.2.6 Resolution: Fixed > Speed up TestFromClientSide3 by reduce the

[GitHub] [hbase] infraio opened a new pull request #2285: HBASE-24912 Enalrge MemstoreFlusherChore/CompactionChecker period for…

2020-08-19 Thread GitBox
infraio opened a new pull request #2285: URL: https://github.com/apache/hbase/pull/2285 … unit test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (HBASE-24912) Enalrge MemstoreFlusherChore/CompactionChecker period for unit test

2020-08-19 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24912: -- Summary: Enalrge MemstoreFlusherChore/CompactionChecker period for unit test Key: HBASE-24912 URL: https://issues.apache.org/jira/browse/HBASE-24912 Project: HBas

[jira] [Resolved] (HBASE-24907) Turn off the balancer when test region admin api

2020-08-19 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24907. Fix Version/s: 2.2.6 Resolution: Fixed > Turn off the balancer when test region adm

[jira] [Assigned] (HBASE-24907) Turn off the balancer when test region admin api

2020-08-19 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24907: -- Assignee: Guanghao Zhang > Turn off the balancer when test region admin api > ---

[GitHub] [hbase] infraio merged pull request #2278: HBASE-24907 Turn off the balancer when test region admin api

2020-08-19 Thread GitBox
infraio merged pull request #2278: URL: https://github.com/apache/hbase/pull/2278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache-HBase commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-677080450 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 43

[GitHub] [hbase] Apache-HBase commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-677056251 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 1

[GitHub] [hbase] bsglz commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

2020-08-19 Thread GitBox
bsglz commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-677044948 > I am a bit busy recently. > > Please find another committer to review. > > Thanks Ok, thanks all the same for the comments. --

[jira] [Commented] (HBASE-24282) 'scandetail' log message is missing when responseTooSlow happens on the first scan rpc call

2020-08-19 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180955#comment-17180955 ] Anoop Sam John commented on HBASE-24282: [~songxincun] can u pls put a link t

[jira] [Commented] (HBASE-23956) Use less resources running tests

2020-08-19 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180953#comment-17180953 ] Guanghao Zhang commented on HBASE-23956: Ok. MemstoreFlusherChore and Compaction

[GitHub] [hbase] Apache-HBase commented on pull request #2276: HBASE-24904 Speed up TestAsyncTableAdminApi/TestSnapshotTemporaryDirectoryWithRegionReplicas/TestRegionReplicaFailover

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2276: URL: https://github.com/apache/hbase/pull/2276#issuecomment-677031651 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] tedyu commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

2020-08-19 Thread GitBox
tedyu commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-677026633 I am a bit busy recently. Please find another committer to review. Thanks This is an automated messa

[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-19 Thread GitBox
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677022356 `Wondering if moving MutableRegionInfo impl class to separate outer class could help us by any chance (It's static init that is causing issue, not static subclass. ` I c

[GitHub] [hbase] Apache-HBase commented on pull request #2265: HBASE-24892 config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2265: URL: https://github.com/apache/hbase/pull/2265#issuecomment-676986149 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41

[jira] [Commented] (HBASE-23956) Use less resources running tests

2020-08-19 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180946#comment-17180946 ] Michael Stack commented on HBASE-23956: --- [~zghao] Looking at the PR, it looks like

[GitHub] [hbase] bsglz commented on pull request #2263: HBASE-24890 The command regioninfo is not available

2020-08-19 Thread GitBox
bsglz commented on pull request #2263: URL: https://github.com/apache/hbase/pull/2263#issuecomment-676885377 Ping. @virajjasani This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] bsglz commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…

2020-08-19 Thread GitBox
bsglz commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-676882950 Ping. @tedyu This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] bsglz commented on pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-19 Thread GitBox
bsglz commented on pull request #2254: URL: https://github.com/apache/hbase/pull/2254#issuecomment-676880955 Ping. @busbey This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-08-19 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-676876548 Ping. @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [hbase] Apache-HBase commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-676869072 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 11

[GitHub] [hbase] Apache-HBase commented on pull request #2279: HBASE-24908 Correct the description of hbase.offpeak.end.hour

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2279: URL: https://github.com/apache/hbase/pull/2279#issuecomment-676857970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 55

[GitHub] [hbase] bsglz commented on pull request #2279: HBASE-24908 Correct the description of hbase.offpeak.end.hour

2020-08-19 Thread GitBox
bsglz commented on pull request #2279: URL: https://github.com/apache/hbase/pull/2279#issuecomment-676847626 > `hbase-default.xml` changes are included by mistake? Oh, yeah, sorry. This is an automated message from the

[jira] [Updated] (HBASE-24904) HBASE-24904 Speed up TestAsyncTableAdminApi/TestSnapshotTemporaryDirectoryWithRegionReplicas/TestRegionReplicaFailover

2020-08-19 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24904: --- Summary: HBASE-24904 Speed up TestAsyncTableAdminApi/TestSnapshotTemporaryDirectoryWithRegio

[jira] [Comment Edited] (HBASE-23956) Use less resources running tests

2020-08-19 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180893#comment-17180893 ] Guanghao Zhang edited comment on HBASE-23956 at 8/20/20, 12:43 AM: ---

[jira] [Commented] (HBASE-23956) Use less resources running tests

2020-08-19 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180893#comment-17180893 ] Guanghao Zhang commented on HBASE-23956: Sir, I found HBASE-23956 changed hbase.

[GitHub] [hbase] z-york commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-19 Thread GitBox
z-york commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-676829830 I have been watching this for a while, and I still don't have good clarity on the following case. > > > [update] I will follow your suggestion and throws a exception if w

[jira] [Commented] (HBASE-24884) BulkLoadHFilesTool/LoadIncrementalHFiles should accept -D options from command line parameters

2020-08-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180891#comment-17180891 ] Hudson commented on HBASE-24884: Results for branch branch-2 [build #11 on buil

[jira] [Commented] (HBASE-24884) BulkLoadHFilesTool/LoadIncrementalHFiles should accept -D options from command line parameters

2020-08-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180888#comment-17180888 ] Hudson commented on HBASE-24884: Results for branch branch-2.2 [build #28 on bu

[jira] [Commented] (HBASE-24897) RegionReplicaFlushHandler should handle NoServerForRegionException to avoid aborting RegionServer

2020-08-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180887#comment-17180887 ] Hudson commented on HBASE-24897: Results for branch branch-2.2 [build #28 on bu

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-676819438 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[GitHub] [hbase] Apache-HBase commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-676818729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 3

[GitHub] [hbase] apurtell commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-19 Thread GitBox
apurtell commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r473435176 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -4006,9 +4007,9 @@ private void getProcedureResult(l

[GitHub] [hbase] Apache-HBase commented on pull request #2283: HBASE-24885 STUCK RIT by hbck2 assigns

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2283: URL: https://github.com/apache/hbase/pull/2283#issuecomment-676803057 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35

[GitHub] [hbase] Apache-HBase commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-676801030 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s

[jira] [Commented] (HBASE-24911) Configure a max global timeout for HMaster to wait for RS to check in

2020-08-19 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180880#comment-17180880 ] Sandeep Guggilam commented on HBASE-24911: -- FYI [~apurtell] > Configure a max

[jira] [Created] (HBASE-24911) Configure a max global timeout for HMaster to wait for RS to check in

2020-08-19 Thread Sandeep Guggilam (Jira)
Sandeep Guggilam created HBASE-24911: Summary: Configure a max global timeout for HMaster to wait for RS to check in Key: HBASE-24911 URL: https://issues.apache.org/jira/browse/HBASE-24911 Project

[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-676796895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-676780847 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6

[GitHub] [hbase] saintstack commented on a change in pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-19 Thread GitBox
saintstack commented on a change in pull request #2282: URL: https://github.com/apache/hbase/pull/2282#discussion_r473326356 ## File path: hbase-shell/src/main/ruby/hbase/taskmonitor.rb ## @@ -107,88 +107,5 @@ def tasksOnHost(filter, host) tasks end - - #-

[GitHub] [hbase] bitoffdev commented on a change in pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-19 Thread GitBox
bitoffdev commented on a change in pull request #2282: URL: https://github.com/apache/hbase/pull/2282#discussion_r473322464 ## File path: hbase-shell/src/main/ruby/shell/formatter.rb ## @@ -192,6 +199,56 @@ def footer(row_count = nil, is_stale = false) end end +

[GitHub] [hbase] bitoffdev commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-19 Thread GitBox
bitoffdev commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-676704552 > Skimmed. Its lovely. > > How does json formatter deal w/ binary chars? The JSON formatter takes advantage of Ruby's builtin `JSON.dump` method to serialize _indiv

[GitHub] [hbase] bitoffdev commented on a change in pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-19 Thread GitBox
bitoffdev commented on a change in pull request #2282: URL: https://github.com/apache/hbase/pull/2282#discussion_r473316648 ## File path: hbase-shell/src/main/ruby/hbase/taskmonitor.rb ## @@ -107,88 +107,5 @@ def tasksOnHost(filter, host) tasks end - - #--

[jira] [Resolved] (HBASE-24837) Ignore... check what fails when zk-based WAL splitter enabled

2020-08-19 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24837. --- Resolution: Not A Problem Tests passed. Old system seems to work still at least as according

[GitHub] [hbase] saintstack closed pull request #2223: HBASE-24837 Ignore... check what fails when zk-based WAL splitter ena…

2020-08-19 Thread GitBox
saintstack closed pull request #2223: URL: https://github.com/apache/hbase/pull/2223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack commented on pull request #2223: HBASE-24837 Ignore... check what fails when zk-based WAL splitter ena…

2020-08-19 Thread GitBox
saintstack commented on pull request #2223: URL: https://github.com/apache/hbase/pull/2223#issuecomment-676697802 Closing. Seems like old behavior still works at least according to our tests. This is an automated message f

[GitHub] [hbase] saintstack commented on a change in pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-19 Thread GitBox
saintstack commented on a change in pull request #2282: URL: https://github.com/apache/hbase/pull/2282#discussion_r473307133 ## File path: hbase-shell/src/main/ruby/hbase/taskmonitor.rb ## @@ -107,88 +107,5 @@ def tasksOnHost(filter, host) tasks end - - #-

[jira] [Commented] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-19 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180815#comment-17180815 ] Elliot Miller commented on HBASE-24901: --- {quote}Lovely. What determines the widths

[jira] [Updated] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-19 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-24901: -- Description: As a user, I would like a simple interface for shell output that can be expresse

[jira] [Commented] (HBASE-24884) BulkLoadHFilesTool/LoadIncrementalHFiles should accept -D options from command line parameters

2020-08-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180809#comment-17180809 ] Hudson commented on HBASE-24884: Results for branch branch-2.3 [build #7 on bui

[GitHub] [hbase] Apache-HBase commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-676669995 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[jira] [Commented] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-19 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180806#comment-17180806 ] Michael Stack commented on HBASE-24901: --- Lovely. What determines the widths? Is it

[jira] [Comment Edited] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-19 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180806#comment-17180806 ] Michael Stack edited comment on HBASE-24901 at 8/19/20, 8:32 PM: -

[jira] [Updated] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-19 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-24901: -- Description: As a user, I would like a simple interface for shell output that can be expresse

[jira] [Commented] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-19 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180796#comment-17180796 ] Elliot Miller commented on HBASE-24901: --- Another benefit of this patch is that it

[GitHub] [hbase] Apache-HBase commented on pull request #2283: HBASE-24885 STUCK RIT by hbck2 assigns

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2283: URL: https://github.com/apache/hbase/pull/2283#issuecomment-676640835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36

[jira] [Commented] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-19 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180792#comment-17180792 ] Elliot Miller commented on HBASE-24901: --- This new table formatter will be useful f

[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-676638197 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 40

[jira] [Updated] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-19 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-24901: -- Attachment: HBASE-24901_scan_output_comparison.png > Create versatile hbase-shell table format

[GitHub] [hbase] Apache-HBase commented on pull request #2283: HBASE-24885 STUCK RIT by hbck2 assigns

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2283: URL: https://github.com/apache/hbase/pull/2283#issuecomment-676634104 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 25s

[GitHub] [hbase] Apache-HBase commented on pull request #2278: HBASE-24907 Turn off the balancer when test region admin api

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2278: URL: https://github.com/apache/hbase/pull/2278#issuecomment-676632908 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 56

[GitHub] [hbase] ankitjain64 commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-19 Thread GitBox
ankitjain64 commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-676630230 @bharathv : Can you please have a look ? Thanks This is an automated message from the Apache Git Service. To r

[GitHub] [hbase] ankitjain64 opened a new pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-19 Thread GitBox
ankitjain64 opened a new pull request #2284: URL: https://github.com/apache/hbase/pull/2284 JIRA: https://issues.apache.org/jira/browse/HBASE-24764 JIRA Description: Currently, if a user needs to apply some common peer configs to all the default replication peers, the only

[jira] [Updated] (HBASE-24764) Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-19 Thread Ankit Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated HBASE-24764: --- Attachment: HBASE-24764-master.patch > Add support of adding default peer configs via hbase-site.xml

[jira] [Work started] (HBASE-24764) Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-19 Thread Ankit Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24764 started by Ankit Jain. -- > Add support of adding default peer configs via hbase-site.xml for all > replicat

[jira] [Commented] (HBASE-24885) STUCK RIT by hbck2 assigns

2020-08-19 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180777#comment-17180777 ] Michael Stack commented on HBASE-24885: --- I put up a PR > STUCK RIT by hbck2 a

[GitHub] [hbase] saintstack opened a new pull request #2283: HBASE-24885 STUCK RIT by hbck2 assigns

2020-08-19 Thread GitBox
saintstack opened a new pull request #2283: URL: https://github.com/apache/hbase/pull/2283 Adds region state check on hbck2 assigns/unassigns. Returns pid of -1 if in inappropriate state with logging explaination which suggests passing override if operator wants to assign/unassign anyw

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-676617693 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6

[GitHub] [hbase] Apache-HBase commented on pull request #2276: HBASE-24904 Speed up TestAsyncTableAdminApi and TestSnapshotTemporary…

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2276: URL: https://github.com/apache/hbase/pull/2276#issuecomment-676616232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s

[GitHub] [hbase] bitoffdev opened a new pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-19 Thread GitBox
bitoffdev opened a new pull request #2282: URL: https://github.com/apache/hbase/pull/2282 Resolves https://issues.apache.org/jira/browse/HBASE-24901 ## Changelog - Add new abstract ::Shell::Formatter::TableFormatter implemented by AlignedTableFormatter, UnalignedTableFormatter

[GitHub] [hbase] Apache-HBase commented on pull request #2281: HBASE-24867 Add 2.3.1 to the downloads page

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2281: URL: https://github.com/apache/hbase/pull/2281#issuecomment-676606181 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #2281: HBASE-24867 Add 2.3.1 to the downloads page

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2281: URL: https://github.com/apache/hbase/pull/2281#issuecomment-676592875 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #2281: HBASE-24867 Add 2.3.1 to the downloads page

2020-08-19 Thread GitBox
Apache-HBase commented on pull request #2281: URL: https://github.com/apache/hbase/pull/2281#issuecomment-676592735 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] ndimiduk opened a new pull request #2281: HBASE-24867 Add 2.3.1 to the downloads page

2020-08-19 Thread GitBox
ndimiduk opened a new pull request #2281: URL: https://github.com/apache/hbase/pull/2281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Work started] (HBASE-24867) Add 2.3.1 to the downloads page

2020-08-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24867 started by Nick Dimiduk. > Add 2.3.1 to the downloads page > --- > >

[jira] [Resolved] (HBASE-24866) Update reporter tool with new release

2020-08-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24866. -- Resolution: Done > Update reporter tool with new release > ---

[jira] [Created] (HBASE-24910) Promote RC artifacts in svn

2020-08-19 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24910: Summary: Promote RC artifacts in svn Key: HBASE-24910 URL: https://issues.apache.org/jira/browse/HBASE-24910 Project: HBase Issue Type: Sub-task

[jira] [Resolved] (HBASE-24910) Promote RC artifacts in svn

2020-08-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24910. -- Resolution: Done > Promote RC artifacts in svn > --- > >

[jira] [Resolved] (HBASE-24864) Push signed release tag

2020-08-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24864. -- Resolution: Done > Push signed release tag > --- > > Key:

[jira] [Resolved] (HBASE-24863) "Release" staged nexus repository

2020-08-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24863. -- Resolution: Done > "Release" staged nexus repository > - > >

[jira] [Resolved] (HBASE-24865) Release version 2.3.1 in Jira

2020-08-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24865. -- Resolution: Done > Release version 2.3.1 in Jira > - > >

[jira] [Updated] (HBASE-24892) config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24892: - Fix Version/s: (was: 2.3.1) 2.3.2 > config 'hbase.hregion.memstore.mslab.

[GitHub] [hbase] virajjasani edited a comment on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-19 Thread GitBox
virajjasani edited a comment on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-676578737 Wondering if moving `MutableRegionInfo` impl class to separate outer class could help us by any chance (It's static init that is causing issue, not static subclass. How

[GitHub] [hbase] virajjasani commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-19 Thread GitBox
virajjasani commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-676578737 Wondering if moving `MutableRegionInfo` impl class to separate outer class could help us by any chance (It's static init that is causing issue, not static subclass. However, e

[jira] [Resolved] (HBASE-24862) Spin RCs

2020-08-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24862. -- Resolution: Done > Spin RCs > > > Key: HBASE-24862 >

  1   2   >