[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-678597232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] utf7 commented on pull request #2189: HBASE-24811 Use class access static field or method

2020-08-21 Thread GitBox
utf7 commented on pull request #2189: URL: https://github.com/apache/hbase/pull/2189#issuecomment-678589676 mind have a look ,thanks @anoopsjohn This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-24890) The command regioninfo is not available

2020-08-21 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182242#comment-17182242 ] Zheng Wang commented on HBASE-24890: Thanks for all the comments. [~vjasani] [~stack] > The command

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-678589066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24890) The command regioninfo is not available

2020-08-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182241#comment-17182241 ] Michael Stack commented on HBASE-24890: --- Merged. Thanks for the fix [~filtertip] > The command

[GitHub] [hbase] saintstack merged pull request #2263: HBASE-24890 The command regioninfo is not available

2020-08-21 Thread GitBox
saintstack merged pull request #2263: URL: https://github.com/apache/hbase/pull/2263 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] infraio commented on a change in pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-21 Thread GitBox
infraio commented on a change in pull request #2249: URL: https://github.com/apache/hbase/pull/2249#discussion_r475038124 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRefreshRecoveredReplication.java ## @@ -0,0 +1,161 @@ +/* +

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182209#comment-17182209 ] Hudson commented on HBASE-24686: Results for branch branch-2.3 [build #12 on

[jira] [Commented] (HBASE-24926) Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182210#comment-17182210 ] Hudson commented on HBASE-24926: Results for branch branch-2.3 [build #12 on

[jira] [Commented] (HBASE-24918) Make RegionInfo#UNDEFINED IA.Private

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182211#comment-17182211 ] Hudson commented on HBASE-24918: Results for branch branch-2.3 [build #12 on

[jira] [Comment Edited] (HBASE-24890) The command regioninfo is not available

2020-08-21 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182206#comment-17182206 ] Zheng Wang edited comment on HBASE-24890 at 8/22/20, 1:21 AM: -- Added, this

[jira] [Commented] (HBASE-24890) The command regioninfo is not available

2020-08-21 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182206#comment-17182206 ] Zheng Wang commented on HBASE-24890: Added, this issue caused by that we refactor the client and

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-21 Thread mokai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182203#comment-17182203 ] mokai commented on HBASE-24686: --- [~vjasani] Thanks for your work.  I think ConnectionImplementation#close

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-678555460 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-678554185 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-678473922 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182117#comment-17182117 ] Hudson commented on HBASE-24686: Results for branch branch-2.2 [build #32 on

[jira] [Commented] (HBASE-24926) Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182118#comment-17182118 ] Hudson commented on HBASE-24926: Results for branch branch-2.2 [build #32 on

[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-678461940 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-21 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182104#comment-17182104 ] Elliot Miller commented on HBASE-24901: --- I updated the default TableFormatter to look and behave

[jira] [Updated] (HBASE-24901) Create versatile hbase-shell table formatter

2020-08-21 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-24901: -- Attachment: HBase Shell Default TableFormatter hb9e903.png > Create versatile hbase-shell

[GitHub] [hbase] apurtell commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-21 Thread GitBox
apurtell commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-678450344 By API, I mean Admin.java . The RPC stuff (Request/Response classes) is not user facing. This is an automated

[jira] [Commented] (HBASE-24890) The command regioninfo is not available

2020-08-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182072#comment-17182072 ] Michael Stack commented on HBASE-24890: --- Did we not add the regioninfo command to master branch?

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-678408411 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678408287 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bitoffdev commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-21 Thread GitBox
bitoffdev commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-678407628 I updated the patch so that the default table formatter is much closer in output to the old style. The output is aligned, but with no borders and no values will be truncated.

[GitHub] [hbase] huaxiangsun commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-21 Thread GitBox
huaxiangsun commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-678404831 @infraio and @wchevreuil, any more comments before I merge the changes? Thanks. This is an automated message

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678382450 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)

2020-08-21 Thread GitBox
bharathv commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-678381679 Back ported until the commit that implements all the server side RPCs needed by the registry. The build is clean so far. Next step is to back port the registry changes. I might

[jira] [Resolved] (HBASE-24915) Improve BlockCache read performance by specifying BlockType

2020-08-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24915. --- Hadoop Flags: Reviewed Resolution: Fixed Added you as a contributor [~fanrui]  .

[jira] [Assigned] (HBASE-24915) Improve BlockCache read performance by specifying BlockType

2020-08-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reassigned HBASE-24915: - Assignee: fanrui > Improve BlockCache read performance by specifying BlockType >

[GitHub] [hbase] saintstack merged pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-21 Thread GitBox
saintstack merged pull request #2288: URL: https://github.com/apache/hbase/pull/2288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] utf7 commented on pull request #2189: HBASE-24811 Use class access static field or method

2020-08-21 Thread GitBox
utf7 commented on pull request #2189: URL: https://github.com/apache/hbase/pull/2189#issuecomment-678380093 title typo error has fixed This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] saintstack commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-21 Thread GitBox
saintstack commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-678379917 Thank you for your notes on perf. Makes sense. Would suggest you put them on the JIRA itself @1996fanrui .

[jira] [Resolved] (HBASE-24918) Make RegionInfo#UNDEFINED IA.Private

2020-08-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24918. --- Hadoop Flags: Reviewed Resolution: Fixed Merged PR. Thanks for patience and reivews

[GitHub] [hbase] saintstack merged pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private

2020-08-21 Thread GitBox
saintstack merged pull request #2289: URL: https://github.com/apache/hbase/pull/2289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HBASE-24861) Release 2.3.1

2020-08-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24861. -- Resolution: Done > Release 2.3.1 > - > > Key: HBASE-24861 >

[jira] [Resolved] (HBASE-24868) Send announce email

2020-08-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24868. -- Resolution: Done > Send announce email > --- > > Key:

[jira] [Updated] (HBASE-24811) Use class access static field or method

2020-08-21 Thread Yechao Chen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yechao Chen updated HBASE-24811: Description: we should use class to access static field or method ,not instance (was: we should

[jira] [Updated] (HBASE-24811) Use class access static field or method

2020-08-21 Thread Yechao Chen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yechao Chen updated HBASE-24811: Summary: Use class access static field or method (was: Use class access static filed or method)

[GitHub] [hbase] saintstack commented on a change in pull request #2283: HBASE-24885 STUCK RIT by hbck2 assigns

2020-08-21 Thread GitBox
saintstack commented on a change in pull request #2283: URL: https://github.com/apache/hbase/pull/2283#discussion_r474781380 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNode.java ## @@ -190,10 +190,11 @@ public ServerName

[jira] [Commented] (HBASE-24906) Enlarge the wait time in TestReplicationEndpoint#testInterClusterReplication

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181958#comment-17181958 ] Hudson commented on HBASE-24906: Results for branch branch-2.2 [build #31 on

[jira] [Commented] (HBASE-24904) Speed up some unit tests

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181960#comment-17181960 ] Hudson commented on HBASE-24904: Results for branch branch-2.2 [build #31 on

[jira] [Commented] (HBASE-24907) Turn off the balancer when test region admin api

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181957#comment-17181957 ] Hudson commented on HBASE-24907: Results for branch branch-2.2 [build #31 on

[jira] [Commented] (HBASE-24912) Enlarge MemstoreFlusherChore/CompactionChecker period for unit test

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181959#comment-17181959 ] Hudson commented on HBASE-24912: Results for branch branch-2.2 [build #31 on

[GitHub] [hbase] Apache-HBase commented on pull request #2111: HBASE-24683 Add a basic ReplicationServer which only implement Replic…

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2111: URL: https://github.com/apache/hbase/pull/2111#issuecomment-678344844 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2111: HBASE-24683 Add a basic ReplicationServer which only implement Replic…

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2111: URL: https://github.com/apache/hbase/pull/2111#issuecomment-678344787 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24912) Enlarge MemstoreFlusherChore/CompactionChecker period for unit test

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181927#comment-17181927 ] Hudson commented on HBASE-24912: Results for branch branch-2.3 [build #11 on

[jira] [Commented] (HBASE-24912) Enlarge MemstoreFlusherChore/CompactionChecker period for unit test

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181925#comment-17181925 ] Hudson commented on HBASE-24912: Results for branch branch-2 [build #14 on

[jira] [Resolved] (HBASE-24926) Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false

2020-08-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24926. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.2+. Thanks [~vjasani] for

[jira] [Updated] (HBASE-24926) Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false

2020-08-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24926: -- Fix Version/s: 2.3.2 2.2.6 2.4.0

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678321644 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 merged pull request #2290: HBASE-24926 Should call setFailure in MergeTableRegionsProcedure when…

2020-08-21 Thread GitBox
Apache9 merged pull request #2290: URL: https://github.com/apache/hbase/pull/2290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678301250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181901#comment-17181901 ] Viraj Jasani commented on HBASE-24686: -- Changes merged to master, branch-2, branch-2.3, branch-2.2.

[jira] [Resolved] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24686. -- Fix Version/s: 2.3.2 2.2.7 2.4.0

[GitHub] [hbase] Apache-HBase commented on pull request #2290: HBASE-24926 Should call setFailure in MergeTableRegionsProcedure when…

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2290: URL: https://github.com/apache/hbase/pull/2290#issuecomment-678291402 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678287488 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani merged pull request #2219: HBASE-24686 [LOG] Log improvement in Connection#close

2020-08-21 Thread GitBox
virajjasani merged pull request #2219: URL: https://github.com/apache/hbase/pull/2219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] 1996fanrui commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-21 Thread GitBox
1996fanrui commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-678283076 @virajjasani Thx. I have checked all the callers of getBlock, and other callers cannot get the benefits. This

[GitHub] [hbase] Apache-HBase commented on pull request #2290: HBASE-24926 Should call setFailure in MergeTableRegionsProcedure when…

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2290: URL: https://github.com/apache/hbase/pull/2290#issuecomment-678282092 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2111: HBASE-24683 Add a basic ReplicationServer which only implement Replic…

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2111: URL: https://github.com/apache/hbase/pull/2111#issuecomment-678280008 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2276: HBASE-24904 Speed up some unit tests

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2276: URL: https://github.com/apache/hbase/pull/2276#issuecomment-678278867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24914) Remove duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181866#comment-17181866 ] Hudson commented on HBASE-24914: Results for branch master [build #13 on

[jira] [Commented] (HBASE-24867) Add 2.3.1 to the downloads page

2020-08-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181865#comment-17181865 ] Hudson commented on HBASE-24867: Results for branch master [build #13 on

[GitHub] [hbase] Apache-HBase commented on pull request #2010: HBASE-24391 Implement meta split

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2010: URL: https://github.com/apache/hbase/pull/2010#issuecomment-678261531 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2095: HBASE-24459 Move the locateMeta logic from AsyncMetaRegionTableLocato…

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2095: URL: https://github.com/apache/hbase/pull/2095#issuecomment-678258600 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678238632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2290: HBASE-24926 Should call setFailure in MergeTableRegionsProcedure when…

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2290: URL: https://github.com/apache/hbase/pull/2290#issuecomment-678233269 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2095: HBASE-24459 Move the locateMeta logic from AsyncMetaRegionTableLocato…

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2095: URL: https://github.com/apache/hbase/pull/2095#issuecomment-678215295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #40: Add rdd function for snapshot read

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #40: URL: https://github.com/apache/hbase-connectors/pull/40#issuecomment-678187192 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #59: HBASE-23606 Removed deprecations of external dependencies

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #59: URL: https://github.com/apache/hbase-connectors/pull/59#issuecomment-678185028 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #41: URL: https://github.com/apache/hbase-connectors/pull/41#issuecomment-678174980 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #57: HBASE-23592 Refactored tests in hbase-kafka-proxy

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #57: URL: https://github.com/apache/hbase-connectors/pull/57#issuecomment-678168980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #66: HBASE-24230 Support user-defined version timestamp when bulk load data

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #66: URL: https://github.com/apache/hbase-connectors/pull/66#issuecomment-678167537 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181779#comment-17181779 ] Duo Zhang commented on HBASE-24924: --- You still do not answer my question... How could this happen

[jira] [Comment Edited] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-21 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181776#comment-17181776 ] Bo Cui edited comment on HBASE-24924 at 8/21/20, 10:00 AM: --- yeah, The root

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-21 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181776#comment-17181776 ] Bo Cui commented on HBASE-24924: yeah, The root cause is the same:meta znode doest not exist but after 

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #61: HBASE-23608 Removed redundant groupId from spark module

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #61: URL: https://github.com/apache/hbase-connectors/pull/61#issuecomment-678160856 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181766#comment-17181766 ] Duo Zhang commented on HBASE-24924: --- Then the problem is stil the same {quote} if procWAL has

[GitHub] [hbase] Apache9 opened a new pull request #2290: HBASE-24926 Should call setFailure in MergeTableRegionsProcedure when…

2020-08-21 Thread GitBox
Apache9 opened a new pull request #2290: URL: https://github.com/apache/hbase/pull/2290 … isMergeable returns false This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] WenFeiYi commented on a change in pull request #2265: HBASE-24892 config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-21 Thread GitBox
WenFeiYi commented on a change in pull request #2265: URL: https://github.com/apache/hbase/pull/2265#discussion_r474586834 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java ## @@ -52,8 +52,8 @@ String CHUNK_SIZE_KEY =

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-21 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181757#comment-17181757 ] Bo Cui commented on HBASE-24924: thx [~zhangduo]  my question and the PR have a little different in

[jira] [Assigned] (HBASE-24926) Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false

2020-08-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24926: - Assignee: Duo Zhang > Should call setFailure in MergeTableRegionsProcedure when isMergeable

[jira] [Work started] (HBASE-24926) Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false

2020-08-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24926 started by Duo Zhang. - > Should call setFailure in MergeTableRegionsProcedure when isMergeable returns >

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #69: HBASE-24452 Try github ci for hbase-connectors

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #69: URL: https://github.com/apache/hbase-connectors/pull/69#issuecomment-678140722 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Resolved] (HBASE-24883) Migrate hbase-connectors testing to ci-hadoop

2020-08-21 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-24883. --- Fix Version/s: connector-1.0.1 Resolution: Fixed Merged to master and changed

[GitHub] [hbase-connectors] petersomogyi merged pull request #70: HBASE-24883 Migrate hbase-connectors testing to ci-hadoop

2020-08-21 Thread GitBox
petersomogyi merged pull request #70: URL: https://github.com/apache/hbase-connectors/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HBASE-24904) Speed up some unit tests

2020-08-21 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24904: --- Description: See 

[GitHub] [hbase] infraio merged pull request #2276: HBASE-24904 Speed up some unit tests

2020-08-21 Thread GitBox
infraio merged pull request #2276: URL: https://github.com/apache/hbase/pull/2276 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181740#comment-17181740 ] Duo Zhang commented on HBASE-24924: --- So the corruption is from outside our control, this means there

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-21 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181738#comment-17181738 ] Bo Cui commented on HBASE-24924: {quote} The problem is who deletes the meta znode? Why? {quote} actual

[jira] [Created] (HBASE-24926) Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false

2020-08-21 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24926: - Summary: Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false Key: HBASE-24926 URL: https://issues.apache.org/jira/browse/HBASE-24926

[GitHub] [hbase] wchevreuil commented on a change in pull request #2255: HBASE-24877 Add option to avoid aborting RS process upon uncaught exc…

2020-08-21 Thread GitBox
wchevreuil commented on a change in pull request #2255: URL: https://github.com/apache/hbase/pull/2255#discussion_r474544355 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -583,16 +617,27 @@ private void

[GitHub] [hbase] wchevreuil commented on a change in pull request #2255: HBASE-24877 Add option to avoid aborting RS process upon uncaught exc…

2020-08-21 Thread GitBox
wchevreuil commented on a change in pull request #2255: URL: https://github.com/apache/hbase/pull/2255#discussion_r474533514 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -583,16 +617,27 @@ private void

[GitHub] [hbase] bsglz commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-21 Thread GitBox
bsglz commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r474533415 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestCurrentHourProvider.java ## @@ -0,0 +1,71 @@ +/** + * Licensed

[GitHub] [hbase] Apache-HBase commented on pull request #2276: HBASE-24904 Speed up some unit tests

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2276: URL: https://github.com/apache/hbase/pull/2276#issuecomment-678120415 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181716#comment-17181716 ] Duo Zhang commented on HBASE-24924: --- The problem is who deletes the meta znode? Why? > stuck

[GitHub] [hbase] Apache-HBase commented on pull request #2010: HBASE-24391 Implement meta split

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2010: URL: https://github.com/apache/hbase/pull/2010#issuecomment-678113714 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2095: HBASE-24459 Move the locateMeta logic from AsyncMetaRegionTableLocato…

2020-08-21 Thread GitBox
Apache-HBase commented on pull request #2095: URL: https://github.com/apache/hbase/pull/2095#issuecomment-678112720 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >