[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182595#comment-17182595 ] Hudson commented on HBASE-24898: Results for branch branch-2.3 [build #13 on bu

[jira] [Updated] (HBASE-24930) Reduce the number builds to keep for our jenkins jobs

2020-08-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24930: -- Component/s: scripts build > Reduce the number builds to keep for our jenkins jobs >

[jira] [Created] (HBASE-24930) Reduce the number builds to keep for our jenkins jobs

2020-08-22 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24930: - Summary: Reduce the number builds to keep for our jenkins jobs Key: HBASE-24930 URL: https://issues.apache.org/jira/browse/HBASE-24930 Project: HBase Issue Type: T

[GitHub] [hbase] infraio commented on a change in pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table

2020-08-22 Thread GitBox
infraio commented on a change in pull request #2292: URL: https://github.com/apache/hbase/pull/2292#discussion_r475166414 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -1064,19 +1065,26 @@ private boolean isTableInGr

[GitHub] [hbase] Apache9 merged pull request #2189: HBASE-24811 Use class access static field or method

2020-08-22 Thread GitBox
Apache9 merged pull request #2189: URL: https://github.com/apache/hbase/pull/2189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache-HBase commented on pull request #2291: HBASE-24776 [hbtop] Support Batch mode

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2291: URL: https://github.com/apache/hbase/pull/2291#issuecomment-678722747 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 5

[GitHub] [hbase] Apache-HBase commented on pull request #2291: HBASE-24776 [hbtop] Support Batch mode

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2291: URL: https://github.com/apache/hbase/pull/2291#issuecomment-678722306 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2291: HBASE-24776 [hbtop] Support Batch mode

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2291: URL: https://github.com/apache/hbase/pull/2291#issuecomment-678722085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1

[jira] [Commented] (HBASE-24915) Improve BlockCache read performance by specifying BlockType

2020-08-22 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182566#comment-17182566 ] fanrui commented on HBASE-24915: Hi [~stack], Thanks for your review. > Improve BlockCa

[GitHub] [hbase] 1996fanrui commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-22 Thread GitBox
1996fanrui commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-678720298 @saintstack Thanks for your review and merge. I have put the performance test report to JIRA. This is an autom

[jira] [Commented] (HBASE-24915) Improve BlockCache read performance by specifying BlockType

2020-08-22 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182563#comment-17182563 ] fanrui commented on HBASE-24915: This is a simple test report: h3. Test Conditions: {cod

[GitHub] [hbase] Apache-HBase commented on pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2292: URL: https://github.com/apache/hbase/pull/2292#issuecomment-678671758 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0

[GitHub] [hbase] Apache-HBase commented on pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2292: URL: https://github.com/apache/hbase/pull/2292#issuecomment-678670111 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182458#comment-17182458 ] Hudson commented on HBASE-24898: Results for branch branch-2.2 [build #36 on bu

[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182415#comment-17182415 ] Hudson commented on HBASE-24898: Results for branch branch-1 [build #8 on build

[GitHub] [hbase] Apache-HBase commented on pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2292: URL: https://github.com/apache/hbase/pull/2292#issuecomment-678655411 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[jira] [Created] (HBASE-24929) Introduce a special CellComparator for master local region

2020-08-22 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24929: - Summary: Introduce a special CellComparator for master local region Key: HBASE-24929 URL: https://issues.apache.org/jira/browse/HBASE-24929 Project: HBase Issue Ty

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-678651779 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s

[GitHub] [hbase] nyl3532016 opened a new pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table

2020-08-22 Thread GitBox
nyl3532016 opened a new pull request #2292: URL: https://github.com/apache/hbase/pull/2292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (HBASE-24608) Introduce a CatalogAccessor

2020-08-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24608. --- Resolution: Duplicate > Introduce a CatalogAccessor > --- > >

[jira] [Assigned] (HBASE-24607) Implement CatalogJanitor for 'root table'

2020-08-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24607: - Assignee: Duo Zhang > Implement CatalogJanitor for 'root table' > -

[jira] [Updated] (HBASE-24928) balanceRSGroup should skip generating balance plan for disabled table

2020-08-22 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24928: - Description: now ,we generate balance plan for disabled tables, which is useless {code:java} 2020-08-20,

[GitHub] [hbase] Apache9 commented on a change in pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-22 Thread GitBox
Apache9 commented on a change in pull request #2228: URL: https://github.com/apache/hbase/pull/2228#discussion_r475098463 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -742,36 +741,35 @@ private Result increment(final HR

[jira] [Updated] (HBASE-24928) balanceRSGroup should skip generating balance plan for disabled table

2020-08-22 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24928: - Description: {code:java} 2020-08-20,20:47:54,702 WARN [RpcServer.default.RWQ.Fifo.read.handler=310,queu

[jira] [Updated] (HBASE-24928) balanceRSGroup should skip generating balance plan for disabled table

2020-08-22 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24928: - Component/s: Balancer Fix Version/s: 3.0.0-alpha-1 > balanceRSGroup should skip generating balance

[jira] [Created] (HBASE-24928) balanceRSGroup should skip generating balance plan for disabled table

2020-08-22 Thread niuyulin (Jira)
niuyulin created HBASE-24928: Summary: balanceRSGroup should skip generating balance plan for disabled table Key: HBASE-24928 URL: https://issues.apache.org/jira/browse/HBASE-24928 Project: HBase

[jira] [Commented] (HBASE-24606) Implement meta merge

2020-08-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182400#comment-17182400 ] Duo Zhang commented on HBASE-24606: --- https://github.com/Apache9/hbase/tree/HBASE-24606

[jira] [Assigned] (HBASE-24606) Implement meta merge

2020-08-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24606: - Assignee: Duo Zhang > Implement meta merge > > > Key: HBAS

[GitHub] [hbase] infraio commented on a change in pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-22 Thread GitBox
infraio commented on a change in pull request #2286: URL: https://github.com/apache/hbase/pull/2286#discussion_r475093446 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java ## @@ -56,39 +58,47 @@ private static Configuration conf =

[GitHub] [hbase] Apache-HBase commented on pull request #2291: HBASE-24776 [hbtop] Support Batch mode

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2291: URL: https://github.com/apache/hbase/pull/2291#issuecomment-678643632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[GitHub] [hbase] Apache-HBase commented on pull request #2291: HBASE-24776 [hbtop] Support Batch mode

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2291: URL: https://github.com/apache/hbase/pull/2291#issuecomment-678643498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24

[GitHub] [hbase] Apache-HBase commented on pull request #2291: HBASE-24776 [hbtop] Support Batch mode

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2291: URL: https://github.com/apache/hbase/pull/2291#issuecomment-678643237 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-678638980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[jira] [Commented] (HBASE-24926) Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false

2020-08-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182354#comment-17182354 ] Hudson commented on HBASE-24926: Results for branch master [build #14 on builds

[jira] [Commented] (HBASE-24890) The command regioninfo is not available

2020-08-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182357#comment-17182357 ] Hudson commented on HBASE-24890: Results for branch master [build #14 on builds

[jira] [Commented] (HBASE-24918) Make RegionInfo#UNDEFINED IA.Private

2020-08-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182355#comment-17182355 ] Hudson commented on HBASE-24918: Results for branch master [build #14 on builds

[jira] [Commented] (HBASE-24915) Improve BlockCache read performance by specifying BlockType

2020-08-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182356#comment-17182356 ] Hudson commented on HBASE-24915: Results for branch master [build #14 on builds

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182353#comment-17182353 ] Hudson commented on HBASE-24686: Results for branch master [build #14 on builds

[jira] [Commented] (HBASE-24912) Enlarge MemstoreFlusherChore/CompactionChecker period for unit test

2020-08-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182352#comment-17182352 ] Hudson commented on HBASE-24912: Results for branch master [build #14 on builds

[GitHub] [hbase] Apache-HBase commented on pull request #2291: HBASE-24776 [hbtop] Support Batch mode

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2291: URL: https://github.com/apache/hbase/pull/2291#issuecomment-678637600 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] Apache-HBase commented on pull request #2291: HBASE-24776 [hbtop] Support Batch mode

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2291: URL: https://github.com/apache/hbase/pull/2291#issuecomment-678637048 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5

[jira] [Updated] (HBASE-24776) [hbtop] Support Batch mode

2020-08-22 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24776: - Issue Type: New Feature (was: Bug) > [hbtop] Support Batch mode > -

[GitHub] [hbase] brfrn169 opened a new pull request #2291: HBASE-24776 [hbtop] Support Batch mode

2020-08-22 Thread GitBox
brfrn169 opened a new pull request #2291: URL: https://github.com/apache/hbase/pull/2291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-678628648 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 6

[jira] [Updated] (HBASE-24927) clean out-of-date mob files even if the mob is disabled for now

2020-08-22 Thread Junhong Xu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhong Xu updated HBASE-24927: --- Summary: clean out-of-date mob files even if the mob is disabled for now (was: clean out-of-date mo

[jira] [Updated] (HBASE-24927) clean out-of-date mob files even if the mob is disabled

2020-08-22 Thread Junhong Xu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhong Xu updated HBASE-24927: --- Summary: clean out-of-date mob files even if the mob is disabled (was: clean out-of-date mob files

[jira] [Created] (HBASE-24927) clean out-of-date mod files even if the mob is disabled for now

2020-08-22 Thread Junhong Xu (Jira)
Junhong Xu created HBASE-24927: -- Summary: clean out-of-date mod files even if the mob is disabled for now Key: HBASE-24927 URL: https://issues.apache.org/jira/browse/HBASE-24927 Project: HBase

[jira] [Resolved] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24898. -- Fix Version/s: 2.3.2 2.2.7 2.4.0 1.7.0

[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-22 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182312#comment-17182312 ] Zheng Wang commented on HBASE-24898: Thanks for all the comments. > Use Environment

[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182311#comment-17182311 ] Viraj Jasani commented on HBASE-24898: -- Thanks for the contribution [~filtertip]. M

[jira] [Commented] (HBASE-24887) Remove Row.compareTo

2020-08-22 Thread Junhong Xu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182307#comment-17182307 ] Junhong Xu commented on HBASE-24887: {quote}Please fill the release note? Junhong Xu

[jira] [Updated] (HBASE-24887) Remove Row.compareTo

2020-08-22 Thread Junhong Xu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhong Xu updated HBASE-24887: --- Release Note: Remove Row.compareTo > Remove Row.compareTo > > >

[GitHub] [hbase] virajjasani closed pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-22 Thread GitBox
virajjasani closed pull request #2272: URL: https://github.com/apache/hbase/pull/2272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-22 Thread GitBox
virajjasani commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r475073514 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -4006,9 +4007,9 @@ private void getProcedureResul

[jira] [Comment Edited] (HBASE-24890) The command regioninfo is not available

2020-08-22 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182282#comment-17182282 ] Zheng Wang edited comment on HBASE-24890 at 8/22/20, 9:11 AM:

[jira] [Commented] (HBASE-24890) The command regioninfo is not available

2020-08-22 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182282#comment-17182282 ] Zheng Wang commented on HBASE-24890: Yeah, i think so, this issue seems caused by HB

[GitHub] [hbase] Apache-HBase commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-22 Thread GitBox
Apache-HBase commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-678612083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[jira] [Resolved] (HBASE-24890) The command regioninfo is not available

2020-08-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24890. -- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed > The comman