[GitHub] [hbase] Apache-HBase commented on pull request #2337: HBASE-24973 Remove read point parameter in StoreFlush#performFlush

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2337: URL: https://github.com/apache/hbase/pull/2337#issuecomment-684261066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-684224901 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Abhey opened a new pull request #2338: [HBASE-24893] Fix failing TestLogLevel Unit Test

2020-08-31 Thread GitBox
Abhey opened a new pull request #2338: URL: https://github.com/apache/hbase/pull/2338 This PR introduces changes to fix the failing `testLogLevelByHttp` and `testLogLevelByHttpWithSpnego` unit tests. This is an automated

[GitHub] [hbase] Apache-HBase commented on pull request #2337: HBASE-24973 Remove read point parameter in StoreFlush#performFlush

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2337: URL: https://github.com/apache/hbase/pull/2337#issuecomment-684163265 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] yuqi1129 opened a new pull request #2337: HBASE-24973 Remove read point parameter in StoreFlush#performFlush

2020-08-31 Thread GitBox
yuqi1129 opened a new pull request #2337: URL: https://github.com/apache/hbase/pull/2337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-24973) Remove read point parameter in StoreFlush#performFlush

2020-08-31 Thread yuqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi updated HBASE-24973: - Description: Currently, read point parameter in method StoreFlush#performFlush is useless and can be safely

[jira] [Created] (HBASE-24973) Remove read point parameter in StoreFlush#performFlush

2020-08-31 Thread yuqi (Jira)
yuqi created HBASE-24973: Summary: Remove read point parameter in StoreFlush#performFlush Key: HBASE-24973 URL: https://issues.apache.org/jira/browse/HBASE-24973 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2327: URL: https://github.com/apache/hbase/pull/2327#issuecomment-684137266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-24809) Yetus IA Javadoc links are no longer available

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188063#comment-17188063 ] Hudson commented on HBASE-24809: Results for branch master [build #30 on

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-08-31 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188056#comment-17188056 ] Tak-Lon (Stephen) Wu commented on HBASE-24749: -- {quote} # When (re)open, ROOT region only

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-31 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r480476762 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -968,6 +968,19 @@ private RegionLocations

[jira] [Commented] (HBASE-24913) Refactor TestJMXConnectorServer

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188040#comment-17188040 ] Hudson commented on HBASE-24913: Results for branch branch-2.2 [build #52 on

[jira] [Commented] (HBASE-24920) A tool to rewrite corrupted HFiles

2020-08-31 Thread Andrey Elenskiy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188033#comment-17188033 ] Andrey Elenskiy commented on HBASE-24920: - Was away for a week and just attempted to write a

[GitHub] [hbase] Apache-HBase commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-684075408 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2323: URL: https://github.com/apache/hbase/pull/2323#issuecomment-684073809 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-684065119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-filesystem] joshelser commented on a change in pull request #14: HBASE-24961 [HBOSS] HBaseObjectStoreSemantics.close should call super.close to make sure its own instance always get re

2020-08-31 Thread GitBox
joshelser commented on a change in pull request #14: URL: https://github.com/apache/hbase-filesystem/pull/14#discussion_r480416248 ## File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java ## @@ -121,9 +120,26 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2336: HBASE-24971 Upgrade JQuery to 3.5.1

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2336: URL: https://github.com/apache/hbase/pull/2336#issuecomment-684046879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24968) One of static initializers of CellComparatorImpl referring to subclass MetaCellComparator

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188000#comment-17188000 ] Hudson commented on HBASE-24968: Results for branch branch-2.3 [build #24 on

[GitHub] [hbase] Apache-HBase commented on pull request #2336: HBASE-24971 Upgrade JQuery to 3.5.1

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2336: URL: https://github.com/apache/hbase/pull/2336#issuecomment-684010950 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2323: URL: https://github.com/apache/hbase/pull/2323#issuecomment-683968431 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683950498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] arshadmohammad commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
arshadmohammad commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683950188 I run TestRSGroupsFallback locally three times. Every time it passed. This is an automated message from

[jira] [Updated] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2020-08-31 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Guggilam updated HBASE-24972: - Description: {color:#1d1c1d}Creating the connection with ZK  is asynchronous and

[jira] [Updated] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2020-08-31 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Guggilam updated HBASE-24972: - Issue Type: Bug (was: Improvement) Priority: Minor (was: Major) > Wait for

[jira] [Commented] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2020-08-31 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187923#comment-17187923 ] Sandeep Guggilam commented on HBASE-24972: -- FYI [~apurtell] > Wait for connection attempt to

[jira] [Created] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2020-08-31 Thread Sandeep Guggilam (Jira)
Sandeep Guggilam created HBASE-24972: Summary: Wait for connection attempt to succeed before performing operations on ZK Key: HBASE-24972 URL: https://issues.apache.org/jira/browse/HBASE-24972

[GitHub] [hbase] virajjasani commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
virajjasani commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683930218 TestRSGroupsFallback is failing consistently, can you check locally? In the meanwhile, let me trigger another build.

[jira] [Commented] (HBASE-24893) TestLogLevel failing on hadoop-ci (branch-1)

2020-08-31 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187907#comment-17187907 ] Andrew Kyle Purtell commented on HBASE-24893: - [~UselessCoder] thank you! > TestLogLevel

[jira] [Assigned] (HBASE-24893) TestLogLevel failing on hadoop-ci (branch-1)

2020-08-31 Thread Abhey Rana (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhey Rana reassigned HBASE-24893: -- Assignee: Abhey Rana > TestLogLevel failing on hadoop-ci (branch-1) >

[jira] [Commented] (HBASE-24893) TestLogLevel failing on hadoop-ci (branch-1)

2020-08-31 Thread Abhey Rana (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187904#comment-17187904 ] Abhey Rana commented on HBASE-24893: [~apurtell] I would like to work on this JIRA. > TestLogLevel

[GitHub] [hbase] apurtell commented on pull request #2336: HBASE-24971 Upgrade JQuery to 3.5.1

2020-08-31 Thread GitBox
apurtell commented on pull request #2336: URL: https://github.com/apache/hbase/pull/2336#issuecomment-683916346 Built master with this patch applied, poked around the UI a bit, no observed problems. This is an automated

[GitHub] [hbase] Apache-HBase commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683911179 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2336: HBASE-24971 Upgrade JQuery to 3.5.1

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2336: URL: https://github.com/apache/hbase/pull/2336#issuecomment-683909297 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell opened a new pull request #2336: HBASE-24971 Upgrade JQuery to 3.5.1

2020-08-31 Thread GitBox
apurtell opened a new pull request #2336: URL: https://github.com/apache/hbase/pull/2336 - Update embedded minimized jquery to 3.5.1 - Update embedded minimized jquery.tablesorter to 2.31.3 This is an automated message

[jira] [Created] (HBASE-24971) Upgrade JQuery to 3.5.1

2020-08-31 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-24971: --- Summary: Upgrade JQuery to 3.5.1 Key: HBASE-24971 URL: https://issues.apache.org/jira/browse/HBASE-24971 Project: HBase Issue Type: Bug

[jira] [Commented] (HBASE-24809) Yetus IA Javadoc links are no longer available

2020-08-31 Thread Abhey Rana (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187861#comment-17187861 ] Abhey Rana commented on HBASE-24809: [~vjasani] Thanks a lot for merging the patch. > Yetus IA

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-31 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r480240959 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/LockTimeoutException.java ## @@ -0,0 +1,32 @@ +/** + * + * Licensed to the Apache

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-31 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r480239457 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/LockTimeoutException.java ## @@ -0,0 +1,32 @@ +/** + * + * Licensed to the Apache

[GitHub] [hbase] bharathv commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-31 Thread GitBox
bharathv commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r480226179 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/LockTimeoutException.java ## @@ -0,0 +1,32 @@ +/** + * + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683868408 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 commented on a change in pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-31 Thread GitBox
shahrs87 commented on a change in pull request #2323: URL: https://github.com/apache/hbase/pull/2323#discussion_r480226831 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java ## @@ -1492,4 +1487,16 @@ public void testMergeRegions() throws

[jira] [Commented] (HBASE-24688) AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META for meta region

2020-08-31 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187836#comment-17187836 ] Huaxiang Sun commented on HBASE-24688: -- Let me backport it to branch-2 and branch-2.3.   >

[GitHub] [hbase] bharathv commented on a change in pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-31 Thread GitBox
bharathv commented on a change in pull request #2323: URL: https://github.com/apache/hbase/pull/2323#discussion_r480220638 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java ## @@ -1492,4 +1487,16 @@ public void testMergeRegions() throws

[jira] [Resolved] (HBASE-24809) Yetus IA Javadoc links are no longer available

2020-08-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24809. -- Fix Version/s: 2.4.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[jira] [Commented] (HBASE-24809) Yetus IA Javadoc links are no longer available

2020-08-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187815#comment-17187815 ] Viraj Jasani commented on HBASE-24809: -- Thanks for the patch [~UselessCoder]. Merged to master and

[jira] [Commented] (HBASE-24964) Remove MetaTableAccessor.tableExists

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187806#comment-17187806 ] Hudson commented on HBASE-24964: Results for branch branch-2 [build #28 on

[jira] [Commented] (HBASE-24894) [Flakey Test] TestStochasticLoadBalancer.testMoveCostMultiplier

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187807#comment-17187807 ] Hudson commented on HBASE-24894: Results for branch branch-2 [build #28 on

[GitHub] [hbase] virajjasani closed pull request #2335: [HBASE-24809] Fix broken Apache Yetus documentation links

2020-08-31 Thread GitBox
virajjasani closed pull request #2335: URL: https://github.com/apache/hbase/pull/2335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HBASE-24957) ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-31 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-24957: - Fix Version/s: 1.4.14 1.7.0 > ZKTableStateClientSideReader#isDisabledTable

[GitHub] [hbase] shahrs87 commented on pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-31 Thread GitBox
shahrs87 commented on pull request #2323: URL: https://github.com/apache/hbase/pull/2323#issuecomment-683846784 > +1, please take care of checkstyle warnings, it's related to import order. The checkstyle errors in hbase-client were due to my changes, fixed that but the errors in

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-31 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r480197093 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -968,6 +968,19 @@ private RegionLocations

[GitHub] [hbase] shahrs87 commented on pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-31 Thread GitBox
shahrs87 commented on pull request #2323: URL: https://github.com/apache/hbase/pull/2323#issuecomment-683840914 @virajjasani Could you please take a final look ? Thank you ! This is an automated message from the Apache Git

[jira] [Updated] (HBASE-24968) One of static initializers of CellComparatorImpl referring to subclass MetaCellComparator

2020-08-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24968: - Fix Version/s: 2.3.2 2.4.0 3.0.0-alpha-1 Hadoop

[jira] [Commented] (HBASE-24968) One of static initializers of CellComparatorImpl referring to subclass MetaCellComparator

2020-08-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187789#comment-17187789 ] Viraj Jasani commented on HBASE-24968: -- Thanks for the review [~zhangduo]. Merged to master,

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683820139 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24964) Remove MetaTableAccessor.tableExists

2020-08-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187771#comment-17187771 ] Viraj Jasani commented on HBASE-24964: -- [~zhangduo] On branch-2, 

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-683809010 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24916) Region hole contains wrong regions pair when hole is created by first region deletion

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187761#comment-17187761 ] Hudson commented on HBASE-24916: Results for branch branch-2.3 [build #23 on

[jira] [Commented] (HBASE-24916) Region hole contains wrong regions pair when hole is created by first region deletion

2020-08-31 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187763#comment-17187763 ] Mohammad Arshad commented on HBASE-24916: - Thanks [~stack] for reviewing and merging it.

[jira] [Commented] (HBASE-24913) Refactor TestJMXConnectorServer

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187762#comment-17187762 ] Hudson commented on HBASE-24913: Results for branch branch-2.3 [build #23 on

[GitHub] [hbase] virajjasani merged pull request #2333: HBASE-24968 : Move META_COMPARATOR to subclass MetaCellComparator

2020-08-31 Thread GitBox
virajjasani merged pull request #2333: URL: https://github.com/apache/hbase/pull/2333 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani commented on pull request #2332: HBASE-24968 : Move META_COMPARATOR to subclass MetaCellComparator

2020-08-31 Thread GitBox
virajjasani commented on pull request #2332: URL: https://github.com/apache/hbase/pull/2332#issuecomment-683809261 TestMetaTableMetrics test failure is not relevant. This is an automated message from the Apache Git Service.

[GitHub] [hbase] virajjasani merged pull request #2332: HBASE-24968 : Move META_COMPARATOR to subclass MetaCellComparator

2020-08-31 Thread GitBox
virajjasani merged pull request #2332: URL: https://github.com/apache/hbase/pull/2332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683779542 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #68: HBASE-20999 Move hbase-REST to new hbase-connectors repository

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #68: URL: https://github.com/apache/hbase-connectors/pull/68#issuecomment-683777278 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase commented on pull request #2335: [HBASE-24809] Fix broken Apache Yetus documentation links

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2335: URL: https://github.com/apache/hbase/pull/2335#issuecomment-683768889 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683767501 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24968) One of static initializers of CellComparatorImpl referring to subclass MetaCellComparator

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187711#comment-17187711 ] Hudson commented on HBASE-24968: Results for branch master [build #29 on

[jira] [Commented] (HBASE-24916) Region hole contains wrong regions pair when hole is created by first region deletion

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187712#comment-17187712 ] Hudson commented on HBASE-24916: Results for branch master [build #29 on

[jira] [Commented] (HBASE-24913) Refactor TestJMXConnectorServer

2020-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187713#comment-17187713 ] Hudson commented on HBASE-24913: Results for branch master [build #29 on

[GitHub] [hbase] Apache-HBase commented on pull request #2335: [HBASE-24809] Fix broken Apache Yetus documentation links

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2335: URL: https://github.com/apache/hbase/pull/2335#issuecomment-683759446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2335: [HBASE-24809] Fix broken Apache Yetus documentation links

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2335: URL: https://github.com/apache/hbase/pull/2335#issuecomment-683759003 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Abhey opened a new pull request #2335: [HBASE-24809] Fix broken Apache Yetus documentation links

2020-08-31 Thread GitBox
Abhey opened a new pull request #2335: URL: https://github.com/apache/hbase/pull/2335 This PR introduces changes to fix the broken Apache Yetus documentation links. Testing Details - * Verified that the links are working as expected in the ascii doc and readme doc rendered by

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #68: HBASE-20999 Move hbase-REST to new hbase-connectors repository

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #68: URL: https://github.com/apache/hbase-connectors/pull/68#issuecomment-683755937 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Commented] (HBASE-24809) Yetus IA Javadoc links are no longer available

2020-08-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187673#comment-17187673 ] Viraj Jasani commented on HBASE-24809: -- [~UselessCoder] done, all yours. Going forward, you can

[jira] [Assigned] (HBASE-24809) Yetus IA Javadoc links are no longer available

2020-08-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24809: Assignee: Abhey Rana > Yetus IA Javadoc links are no longer available >

[jira] [Commented] (HBASE-24809) Yetus IA Javadoc links are no longer available

2020-08-31 Thread Abhey Rana (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187670#comment-17187670 ] Abhey Rana commented on HBASE-24809: [~vjasani]I would like to take this task up. Can you please

[GitHub] [hbase] arshadmohammad commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
arshadmohammad commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683733360 > -1 ❌ | unit | 239m 44s | hbase-server in the patch failed. -- | -- | -- | -- Failed test cases not related to PR

[GitHub] [hbase] Apache-HBase commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683725923 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2334: HBASE-24970 Backport HBASE-20985 to branch-1

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2334: URL: https://github.com/apache/hbase/pull/2334#issuecomment-683722501 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m

[GitHub] [hbase] Apache-HBase commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683721922 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-683719937 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] cuibo01 closed pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-08-31 Thread GitBox
cuibo01 closed pull request #2324: URL: https://github.com/apache/hbase/pull/2324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] arshadmohammad commented on pull request #2074: HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…

2020-08-31 Thread GitBox
arshadmohammad commented on pull request #2074: URL: https://github.com/apache/hbase/pull/2074#issuecomment-683702854 This is pending for commit from long time. Can someone please commit it. This is an automated message from

[GitHub] [hbase] arshadmohammad commented on pull request #1592: HBASE-24244 Move Region Command fails to move region of a table to another RS which is a part of different RSGroup without giving error

2020-08-31 Thread GitBox
arshadmohammad commented on pull request #1592: URL: https://github.com/apache/hbase/pull/1592#issuecomment-683702999 This is pending for commit from long time. Can someone please commit it. This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683695690 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-24970) Backport HBASE-20985 to branch-1

2020-08-31 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187581#comment-17187581 ] Aman Poonia commented on HBASE-24970: - [~sandeep.guggilam]    [~vjasani]  FYI > Backport

[GitHub] [hbase] Apache-HBase commented on pull request #2074: HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2074: URL: https://github.com/apache/hbase/pull/2074#issuecomment-683625356 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2074: HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2074: URL: https://github.com/apache/hbase/pull/2074#issuecomment-683624874 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2074: HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2074: URL: https://github.com/apache/hbase/pull/2074#issuecomment-683624167 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] mnpoonia opened a new pull request #2334: HBASE-24970 Backport HBASE-20985 to branch-1

2020-08-31 Thread GitBox
mnpoonia opened a new pull request #2334: URL: https://github.com/apache/hbase/pull/2334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683620538 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] arshadmohammad commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
arshadmohammad commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683616915 Re based the PR to resolve build issue This is an automated message from the Apache Git Service. To

[GitHub] [hbase] arshadmohammad edited a comment on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
arshadmohammad edited a comment on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683616277 When previous scan is progress return value is 0. This 0 indicates that no items are garbage collected. This is wrong because in actual there was not attempt to

[GitHub] [hbase] arshadmohammad commented on pull request #2331: HBASE-24940: runCatalogJanitor() API should return -1 to indicate already running status

2020-08-31 Thread GitBox
arshadmohammad commented on pull request #2331: URL: https://github.com/apache/hbase/pull/2331#issuecomment-683616277 When previous scan is progress return value is 0. This 0 indicates that no items are garbage collected. This is wrong because in actual there was not attempt to garbage

[GitHub] [hbase] brfrn169 commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-31 Thread GitBox
brfrn169 commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-683613568 Looks the QA is okay. I moved the nonce operation logic to HRegion.batchMutate() to keep the behavior of the nonce operation. Can you please review this when you have

[GitHub] [hbase] Apache-HBase commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-683612260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-31 Thread GitBox
Apache-HBase commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-683605072 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m