[GitHub] [hbase] Apache-HBase commented on pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2496: URL: https://github.com/apache/hbase/pull/2496#issuecomment-704040855 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #2499: test yetus 0.12.0

2020-10-05 Thread GitBox
saintstack commented on pull request #2499: URL: https://github.com/apache/hbase/pull/2499#issuecomment-704038740 Did it work? This work related to #1531 ? If so close it out? This is an automated message from the

[GitHub] [hbase] saintstack commented on a change in pull request #1496: HBASE-23742 Document that with split-to-hfile data over the MOB threshold will be treated as normal data

2020-10-05 Thread GitBox
saintstack commented on a change in pull request #1496: URL: https://github.com/apache/hbase/pull/1496#discussion_r500015038 ## File path: src/main/asciidoc/_chapters/hbase_mob.adoc ## @@ -613,6 +613,13 @@ $ hdfs dfs -count /hbase/mobdir/data/default/some_table This data is

[GitHub] [hbase] saintstack commented on pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile

2020-10-05 Thread GitBox
saintstack commented on pull request #1380: URL: https://github.com/apache/hbase/pull/1380#issuecomment-704037536 @HuiHang-Yu Those kind of failures are often the test crashing out not writing the xml report properly... Its a while since this PR ran. Try a new push to trip the UTs

[GitHub] [hbase] saintstack commented on pull request #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API

2020-10-05 Thread GitBox
saintstack commented on pull request #1549: URL: https://github.com/apache/hbase/pull/1549#issuecomment-704036236 Maybe try pushing again @arshadmohammad to get a new test fun? This is an automated message from the Apache

[GitHub] [hbase] ramkrish86 commented on pull request #2419: HBASE-25050 - We initialize Filesystems more than once.

2020-10-05 Thread GitBox
ramkrish86 commented on pull request #2419: URL: https://github.com/apache/hbase/pull/2419#issuecomment-704036427 Ping for reviews @busbey , @Apache9 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] saintstack commented on pull request #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API

2020-10-05 Thread GitBox
saintstack commented on pull request #1549: URL: https://github.com/apache/hbase/pull/1549#issuecomment-704035792 Related to #1321 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-704034999 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #1201: HBASE-23639 : Moving classes out of hbase-it /test for direct API use of chaos.

2020-10-05 Thread GitBox
saintstack commented on pull request #1201: URL: https://github.com/apache/hbase/pull/1201#issuecomment-704034180 @lokiore See queries above? Any chance of landing this one. You've done a load of work on it. This is an

[GitHub] [hbase] saintstack commented on pull request #1174: HBASE-23827 [HBCK2] Add mergeRegions method to hbck service

2020-10-05 Thread GitBox
saintstack commented on pull request #1174: URL: https://github.com/apache/hbase/pull/1174#issuecomment-704033071 Any movement here @jatsakthi ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] saintstack closed pull request #1113: HBASE-21110 Remove `Illegal reflective access` warning for `java.nio.Bits.unaligned()`

2020-10-05 Thread GitBox
saintstack closed pull request #1113: URL: https://github.com/apache/hbase/pull/1113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #1113: HBASE-21110 Remove `Illegal reflective access` warning for `java.nio.Bits.unaligned()`

2020-10-05 Thread GitBox
saintstack commented on pull request #1113: URL: https://github.com/apache/hbase/pull/1113#issuecomment-704032779 Closing abandoned PR This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-704016910 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2496: URL: https://github.com/apache/hbase/pull/2496#issuecomment-704003930 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2496: URL: https://github.com/apache/hbase/pull/2496#issuecomment-703999420 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-703987864 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-703979187 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-05 Thread GitBox
saintstack commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-703978412 @nkalmar yes, I think so. Any luck w/ the prompt? Thanks. This is an automated message from the Apache

[GitHub] [hbase] saintstack commented on pull request #2007: HBASE-23634 Enable "Split WAL to HFile" by default

2020-10-05 Thread GitBox
saintstack commented on pull request #2007: URL: https://github.com/apache/hbase/pull/2007#issuecomment-703976981 Let me resolve this PR. It works but the split-to-hfile needs more research before we'd enable it as default. See JIRA.

[GitHub] [hbase] saintstack closed pull request #2007: HBASE-23634 Enable "Split WAL to HFile" by default

2020-10-05 Thread GitBox
saintstack closed pull request #2007: URL: https://github.com/apache/hbase/pull/2007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack closed pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…

2020-10-05 Thread GitBox
saintstack closed pull request #1374: URL: https://github.com/apache/hbase/pull/1374 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…

2020-10-05 Thread GitBox
saintstack commented on pull request #1374: URL: https://github.com/apache/hbase/pull/1374#issuecomment-703976281 Addressed by HBASE-24079 (thanks for reviews) This is an automated message from the Apache Git Service. To

[GitHub] [hbase] saintstack closed pull request #1961: HBASE-24623 SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2020-10-05 Thread GitBox
saintstack closed pull request #1961: URL: https://github.com/apache/hbase/pull/1961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #1647: add IntelliJ project files

2020-10-05 Thread GitBox
saintstack commented on pull request #1647: URL: https://github.com/apache/hbase/pull/1647#issuecomment-703971336 Should I close this out? We done w/ this? This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #2502: HBASE-25154 Set java.io.tmpdir to project build directory to avoid wr…

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2502: URL: https://github.com/apache/hbase/pull/2502#issuecomment-703971333 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack closed pull request #1440: HBASE-23113: Improve and add additional Netty configuration for RPC.

2020-10-05 Thread GitBox
saintstack closed pull request #1440: URL: https://github.com/apache/hbase/pull/1440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #1440: HBASE-23113: Improve and add additional Netty configuration for RPC.

2020-10-05 Thread GitBox
saintstack commented on pull request #1440: URL: https://github.com/apache/hbase/pull/1440#issuecomment-703970049 Abandoned PR This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HBASE-25155) Flaky Test Dashboard scripts are blocked

2020-10-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208440#comment-17208440 ] Duo Zhang commented on HBASE-25155: --- It is disabled by the current version of jenkins we use. Please

[jira] [Resolved] (HBASE-23951) Avoid high speed recursion trap in AsyncRequestFutureImpl.

2020-10-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23951. --- Resolution: Incomplete > Avoid high speed recursion trap in AsyncRequestFutureImpl. >

[GitHub] [hbase] saintstack commented on pull request #1259: HBASE-23951: Avoid high speed recursion trap in AsyncRequestFutureImpl.

2020-10-05 Thread GitBox
saintstack commented on pull request #1259: URL: https://github.com/apache/hbase/pull/1259#issuecomment-703968832 Closing abandoned PR This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] saintstack closed pull request #1259: HBASE-23951: Avoid high speed recursion trap in AsyncRequestFutureImpl.

2020-10-05 Thread GitBox
saintstack closed pull request #1259: URL: https://github.com/apache/hbase/pull/1259 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack closed pull request #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1

2020-10-05 Thread GitBox
saintstack closed pull request #1251: URL: https://github.com/apache/hbase/pull/1251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1

2020-10-05 Thread GitBox
saintstack commented on pull request #1251: URL: https://github.com/apache/hbase/pull/1251#issuecomment-703968461 Closing back port to EOL'd branch. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache9 commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-10-05 Thread GitBox
Apache9 commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-703967647 The pre commit job is still on the old Hadoop nodes, so it should not be effected by the new nodes. Maybe the problem is that our replication related tests are all hanging

[jira] [Resolved] (HBASE-24447) Contribute a Test class that shows some examples for using the Async Client API

2020-10-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24447. --- Resolution: Incomplete > Contribute a Test class that shows some examples for using the

[GitHub] [hbase] Apache-HBase commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-703967636 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-24497) Close one off connections in RawSyncHBaseAdmin.

2020-10-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24497. --- Resolution: Incomplete > Close one off connections in RawSyncHBaseAdmin. >

[jira] [Resolved] (HBASE-24498) Include jetty-schemas so that xml parsing does not need to hit sun/oracle urls.

2020-10-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24498. --- Resolution: Incomplete > Include jetty-schemas so that xml parsing does not need to hit

[jira] [Updated] (HBASE-25154) Set java.io.tmpdir to project build directory to avoid writing std*deferred files to /tmp

2020-10-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25154: -- Release Note: Change the java.io.tmpdir to project.build.directory in surefire-maven-plugin, to avoid

[jira] [Updated] (HBASE-25154) Set java.io.tmpdir to project build directory to avoid writing std*deferred files to /tmp

2020-10-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25154: -- Fix Version/s: 2.2.7 1.4.14 2.4.0 1.7.0

[GitHub] [hbase] saintstack commented on pull request #1541: HBASE-24206 Unsupported rollback should not be logged as CODE-BUG

2020-10-05 Thread GitBox
saintstack commented on pull request #1541: URL: https://github.com/apache/hbase/pull/1541#issuecomment-703963876 Was going to close out this PR if no more progress @petersomogyi ... ok by you sir? This is an automated

[GitHub] [hbase] saintstack commented on pull request #1653: HBASE-24327: TestMasterShutdown#testMasterShutdownBeforeStartingAnyRe…

2020-10-05 Thread GitBox
saintstack commented on pull request #1653: URL: https://github.com/apache/hbase/pull/1653#issuecomment-703963552 Closing abandoned PR This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] saintstack closed pull request #1653: HBASE-24327: TestMasterShutdown#testMasterShutdownBeforeStartingAnyRe…

2020-10-05 Thread GitBox
saintstack closed pull request #1653: URL: https://github.com/apache/hbase/pull/1653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #988: Made DemoClient python 3.0 compatible ..

2020-10-05 Thread GitBox
saintstack commented on pull request #988: URL: https://github.com/apache/hbase/pull/988#issuecomment-703963387 Closing abandoned PR This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] saintstack closed pull request #988: Made DemoClient python 3.0 compatible ..

2020-10-05 Thread GitBox
saintstack closed pull request #988: URL: https://github.com/apache/hbase/pull/988 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HBASE-24054) The Jetty's version number leak occurred while using the thrift service

2020-10-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24054. --- Fix Version/s: 2.4.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[GitHub] [hbase] saintstack merged pull request #1369: HBASE-24054

2020-10-05 Thread GitBox
saintstack merged pull request #1369: URL: https://github.com/apache/hbase/pull/1369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache9 merged pull request #2502: HBASE-25154 Set java.io.tmpdir to project build directory to avoid wr…

2020-10-05 Thread GitBox
Apache9 merged pull request #2502: URL: https://github.com/apache/hbase/pull/2502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-25147) Should store the regionNames field in state data for ReopenTableRegionsProcedure

2020-10-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208434#comment-17208434 ] Hudson commented on HBASE-25147: Results for branch branch-2.3 [build #76 on

[GitHub] [hbase] saintstack closed pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

2020-10-05 Thread GitBox
saintstack closed pull request #1839: URL: https://github.com/apache/hbase/pull/1839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

2020-10-05 Thread GitBox
saintstack commented on pull request #1839: URL: https://github.com/apache/hbase/pull/1839#issuecomment-703961568 Closing abandoned PR This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] saintstack commented on pull request #1838: HBASE-24498: Include jetty-schemas so that xml parsing does not need …

2020-10-05 Thread GitBox
saintstack commented on pull request #1838: URL: https://github.com/apache/hbase/pull/1838#issuecomment-703961360 Closing abandoned PR This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] saintstack closed pull request #1838: HBASE-24498: Include jetty-schemas so that xml parsing does not need …

2020-10-05 Thread GitBox
saintstack closed pull request #1838: URL: https://github.com/apache/hbase/pull/1838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack closed pull request #1792: HBASE-24447: Contribute a Test class that shows some examples for usi…

2020-10-05 Thread GitBox
saintstack closed pull request #1792: URL: https://github.com/apache/hbase/pull/1792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HBASE-25149) Profiling servlet ensure output directory exists and is writable

2020-10-05 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25149: - Summary: Profiling servlet ensure output directory exists and is writable (was: Profiling

[GitHub] [hbase] saintstack commented on pull request #1792: HBASE-24447: Contribute a Test class that shows some examples for usi…

2020-10-05 Thread GitBox
saintstack commented on pull request #1792: URL: https://github.com/apache/hbase/pull/1792#issuecomment-703961056 Closing abandoned PR This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] saintstack commented on pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2020-10-05 Thread GitBox
saintstack commented on pull request #251: URL: https://github.com/apache/hbase/pull/251#issuecomment-703960522 Oh, had a push 13 days ago so not so old This is an automated message from the Apache Git Service. To

[GitHub] [hbase] saintstack commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
saintstack commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-703957143 Sorry. Missed that. Compared the JIRAs. Let me move over. This is an automated message from the Apache Git

[jira] [Updated] (HBASE-22976) [HBCK2] Add RecoveredEditsPlayer

2020-10-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-22976: -- Attachment: 22976.txt > [HBCK2] Add RecoveredEditsPlayer > >

[jira] [Commented] (HBASE-22976) [HBCK2] Add RecoveredEditsPlayer

2020-10-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208428#comment-17208428 ] Michael Stack commented on HBASE-22976: --- Something like the attached patch? > [HBCK2] Add

[jira] [Commented] (HBASE-25048) [HBCK2] Bypassed parent procedures are not updated in store

2020-10-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208425#comment-17208425 ] Hudson commented on HBASE-25048: Results for branch master [build #82 on

[jira] [Commented] (HBASE-25121) Refactor MetaTableAccessor.addRegionsToMeta and its usage places

2020-10-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208427#comment-17208427 ] Hudson commented on HBASE-25121: Results for branch master [build #82 on

[jira] [Commented] (HBASE-25147) Should store the regionNames field in state data for ReopenTableRegionsProcedure

2020-10-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208426#comment-17208426 ] Hudson commented on HBASE-25147: Results for branch master [build #82 on

[GitHub] [hbase] ndimiduk commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r499937265 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerManager.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r499935707 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java ## @@ -354,6 +353,13 @@ long splitRegion( */ boolean

[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
ndimiduk commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-703952605 > How they relate @ndimiduk ? Should this be closed? I can move over but seems like you getting good review there. Saw this and saw it lonely so started in From the

[GitHub] [hbase] saintstack commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
saintstack commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r499932863 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerManager.java ## @@ -0,0 +1,153 @@ +/* + * Licensed

[jira] [Commented] (HBASE-22976) [HBCK2] Add RecoveredEditsPlayer

2020-10-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208418#comment-17208418 ] Michael Stack commented on HBASE-22976: --- hbck doesn't work properly against hbase2. Have you

[GitHub] [hbase] Apache-HBase commented on pull request #2502: HBASE-25154 Set java.io.tmpdir to project build directory to avoid wr…

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2502: URL: https://github.com/apache/hbase/pull/2502#issuecomment-703945513 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25144) Add Hadoop-3.3.0 to personality hadoopcheck

2020-10-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208411#comment-17208411 ] Michael Stack commented on HBASE-25144: --- {quote}In practice, this should add maybe 5 minutes to

[GitHub] [hbase] saintstack commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
saintstack commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-703939981 How they relate @ndimiduk ? Should this be closed? I can move over but seems like you getting good review there. Saw this and saw it lonely so started in

[GitHub] [hbase] ndimiduk commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r499920654 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerManager.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to

[GitHub] [hbase] Apache-HBase commented on pull request #2497: HBASE-25124 Support changing meta replica count without disabling table

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2497: URL: https://github.com/apache/hbase/pull/2497#issuecomment-703936785 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
ndimiduk commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-703930337 Hey @saintstack most of your comments here should be over on #2454 , where the refactoring happened. This is an

[GitHub] [hbase] ndimiduk commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r499913399 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerManager.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to

[GitHub] [hbase] ndimiduk commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r499913092 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java ## @@ -570,8 +569,10 @@ private void

[GitHub] [hbase] ndimiduk commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r499912755 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -1953,20 +1952,27 @@ public

[GitHub] [hbase] ndimiduk commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r499912573 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -3003,18 +2933,20 @@ public double getAverageLoad() {

[GitHub] [hbase] Apache-HBase commented on pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2496: URL: https://github.com/apache/hbase/pull/2496#issuecomment-703926742 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-703926016 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2497: HBASE-25124 Support changing meta replica count without disabling table

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2497: URL: https://github.com/apache/hbase/pull/2497#issuecomment-703925512 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25144) Add Hadoop-3.3.0 to personality hadoopcheck

2020-10-05 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208381#comment-17208381 ] Nick Dimiduk commented on HBASE-25144: -- bq. What'll it do to our nightlies? This adds one

[GitHub] [hbase] ndimiduk commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
ndimiduk commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-703913381 Rebased onto master and addressed PR feedback. Fixed `TestMasterChoreScheduled`. Filed [HBASE-25156](https://issues.apache.org/jira/browse/HBASE-25156) for

[GitHub] [hbase] Apache-HBase commented on pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2496: URL: https://github.com/apache/hbase/pull/2496#issuecomment-703909159 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 13m

[GitHub] [hbase] ndimiduk commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
ndimiduk commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-703906574 > As for TestMasterChoreScheduled test, it tries to retrieve all default (unconditional) chores of HMaster by retrieving singleton objects of chores using reflection from

[jira] [Created] (HBASE-25157) TestMasterRegionCompaction is flaky

2020-10-05 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25157: Summary: TestMasterRegionCompaction is flaky Key: HBASE-25157 URL: https://issues.apache.org/jira/browse/HBASE-25157 Project: HBase Issue Type: Test

[jira] [Created] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-05 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25156: Summary: TestMasterFailover.testSimpleMasterFailover is flaky Key: HBASE-25156 URL: https://issues.apache.org/jira/browse/HBASE-25156 Project: HBase Issue

[jira] [Updated] (HBASE-25155) Flaky Test Dashboard scripts are blocked

2020-10-05 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25155: - Attachment: 25155.png > Flaky Test Dashboard scripts are blocked >

[jira] [Created] (HBASE-25155) Flaky Test Dashboard scripts are blocked

2020-10-05 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25155: Summary: Flaky Test Dashboard scripts are blocked Key: HBASE-25155 URL: https://issues.apache.org/jira/browse/HBASE-25155 Project: HBase Issue Type: Task

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r499870148 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorker.java ## @@ -0,0 +1,254 @@ +/* + * Licensed to

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r499865060 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorkQueue.java ## @@ -0,0 +1,244 @@ +/* + * Licensed

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r499863287 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -1953,20 +1952,27 @@ public

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r498413708 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -371,7 +358,11 @@ private boolean

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-05 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r499859137 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -371,7 +358,11 @@ private boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2497: HBASE-25124 Support changing meta replica count without disabling table

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2497: URL: https://github.com/apache/hbase/pull/2497#issuecomment-703865496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25145) WALReader quits if nothing to replicate (and won't restart)

2020-10-05 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208286#comment-17208286 ] Huaxiang Sun commented on HBASE-25145: -- Yeah, [~zhangduo] is right as metaWal always maintains an

[GitHub] [hbase] Apache-HBase commented on pull request #2502: HBASE-25154 Set java.io.tmpdir to project build directory to avoid wr…

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2502: URL: https://github.com/apache/hbase/pull/2502#issuecomment-703845072 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2497: HBASE-25124 Support changing meta replica count without disabling table

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2497: URL: https://github.com/apache/hbase/pull/2497#issuecomment-703841058 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2502: HBASE-25154 Set java.io.tmpdir to project build directory to avoid wr…

2020-10-05 Thread GitBox
Apache-HBase commented on pull request #2502: URL: https://github.com/apache/hbase/pull/2502#issuecomment-703833479 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox
saintstack commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r499790081 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -406,11 +396,8 @@ public void run() { private final

  1   2   >