[GitHub] [hbase] bharathv commented on a change in pull request #2555: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-21 Thread GitBox
bharathv commented on a change in pull request #2555: URL: https://github.com/apache/hbase/pull/2555#discussion_r509864934 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -101,7 +107,7 @@ * Basic constructor that simply

[jira] [Commented] (HBASE-25029) Resolve the TODO of AssignmentManager's loadMeta() method.

2020-10-21 Thread Sanjeet Nishad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218764#comment-17218764 ] Sanjeet Nishad commented on HBASE-25029: [~GeorryHuang] Will share a patch by this weekend. >

[jira] [Commented] (HBASE-25029) Resolve the TODO of AssignmentManager's loadMeta() method.

2020-10-21 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218762#comment-17218762 ] Zhuoyue Huang commented on HBASE-25029: --- [~sanjeetnishad] still working on it? > Resolve the TODO

[jira] [Commented] (HBASE-25090) CompactionConfiguration logs unrealistic store file sizes

2020-10-21 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218756#comment-17218756 ] Zhuoyue Huang commented on HBASE-25090: --- Let me handle this issue > CompactionConfiguration logs

[jira] [Assigned] (HBASE-25090) CompactionConfiguration logs unrealistic store file sizes

2020-10-21 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang reassigned HBASE-25090: - Assignee: Zhuoyue Huang > CompactionConfiguration logs unrealistic store file sizes >

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-714233013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-714232829 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2577: HBASE-25186 Addendum remove extra sleep to fix TestMasterRegionWALCle…

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2577: URL: https://github.com/apache/hbase/pull/2577#issuecomment-714231373 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714230243 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-714229883 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-714223685 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2577: HBASE-25186 Addendum remove extra sleep to fix TestMasterRegionWALCle…

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2577: URL: https://github.com/apache/hbase/pull/2577#issuecomment-714223315 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714212342 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
bharathv commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r509864069 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8748,6 +8863,11 @@ public void

[GitHub] [hbase] bharathv commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
bharathv commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r509861954 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,78 @@ static final

[GitHub] [hbase] Apache-HBase commented on pull request #2578: HBASE-24768 Clear cached service kerberos ticket in case of SASL fail…

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2578: URL: https://github.com/apache/hbase/pull/2578#issuecomment-714197769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25186) TestMasterRegionOnTwoFileSystems is failing after HBASE-25065

2020-10-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25186. --- Resolution: Fixed > TestMasterRegionOnTwoFileSystems is failing after HBASE-25065 >

[GitHub] [hbase] Apache9 merged pull request #2577: HBASE-25186 Addendum remove extra sleep to fix TestMasterRegionWALCle…

2020-10-21 Thread GitBox
Apache9 merged pull request #2577: URL: https://github.com/apache/hbase/pull/2577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (HBASE-20998) Move hbase-thrift to hbase-connectors repository

2020-10-21 Thread yuqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuqi reassigned HBASE-20998: Assignee: yuqi > Move hbase-thrift to hbase-connectors repository >

[GitHub] [hbase] Apache-HBase commented on pull request #2577: HBASE-25186 Addendum remove extra sleep to fix TestMasterRegionWALCle…

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2577: URL: https://github.com/apache/hbase/pull/2577#issuecomment-714187021 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-714186037 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Joseph295 commented on a change in pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-21 Thread GitBox
Joseph295 commented on a change in pull request #2568: URL: https://github.com/apache/hbase/pull/2568#discussion_r509847080 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -5301,7 +5301,11 @@ private long

[GitHub] [hbase] Apache-HBase commented on pull request #1531: HBASE-24200 Upgrade to Yetus 0.12.0

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #1531: URL: https://github.com/apache/hbase/pull/1531#issuecomment-714185514 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sguggilam opened a new pull request #2578: HBASE-24768 Clear cached service kerberos ticket in case of SASL fail…

2020-10-21 Thread GitBox
sguggilam opened a new pull request #2578: URL: https://github.com/apache/hbase/pull/2578 …ures thrown from server side This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache9 commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
Apache9 commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r509840637 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -1174,7 +1178,7 @@ public HStore call() throws

[GitHub] [hbase] Joseph295 commented on a change in pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-21 Thread GitBox
Joseph295 commented on a change in pull request #2568: URL: https://github.com/apache/hbase/pull/2568#discussion_r509842639 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -5324,22 +5328,25 @@ private long

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r509841246 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -435,6 +475,14 @@ private void

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r509841481 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -577,6 +627,15 @@ private void

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r509840556 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java ## @@ -130,8 +133,12 @@ public

[GitHub] [hbase] Apache9 opened a new pull request #2577: HBASE-25186 Addendum remove extra sleep to fix TestMasterRegionWALCle…

2020-10-21 Thread GitBox
Apache9 opened a new pull request #2577: URL: https://github.com/apache/hbase/pull/2577 …aner This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Reopened] (HBASE-25186) TestMasterRegionOnTwoFileSystems is failing after HBASE-25065

2020-10-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-25186: --- TestMasterRegionWALCleaner is still failing. Just a typo, let me open an addendum PR. >

[GitHub] [hbase] Apache-HBase commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-714175334 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-714173519 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714172243 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-714170697 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25212) Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25212: Status: Patch Available (was: Open) > Optionally abort requests in progress

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-714159949 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell opened a new pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
apurtell opened a new pull request #2576: URL: https://github.com/apache/hbase/pull/2576 If hbase.regionserver.close.wait.abort is set to true, interrupt RPC handler threads holding the region close lock. Until requests in progress can be aborted, wait on the region close lock

[GitHub] [hbase] apurtell opened a new pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
apurtell opened a new pull request #2575: URL: https://github.com/apache/hbase/pull/2575 If hbase.regionserver.close.wait.abort is set to true, interrupt RPC handler threads holding the region close lock. Until requests in progress can be aborted, wait on the region close lock

[GitHub] [hbase] infraio commented on pull request #2565: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.2

2020-10-21 Thread GitBox
infraio commented on pull request #2565: URL: https://github.com/apache/hbase/pull/2565#issuecomment-714119345 Seems these patch not go into branch-2.3, too? I thought these should go into 2.3 firstly. This is an automated

[GitHub] [hbase] apurtell opened a new pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread GitBox
apurtell opened a new pull request #2574: URL: https://github.com/apache/hbase/pull/2574 If hbase.regionserver.close.wait.abort is set to true, interrupt RPC handler threads holding the region close lock. Until requests in progress can be aborted, wait on the region close lock

[jira] [Updated] (HBASE-25212) Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25212: Description: After deciding a region should be closed, the regionserver will set

[jira] [Updated] (HBASE-25212) Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25212: Description: After deciding a region should be closed, the regionserver will set

[jira] [Created] (HBASE-25212) Optionally abort requests in progress after deciding a region should close

2020-10-21 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25212: --- Summary: Optionally abort requests in progress after deciding a region should close Key: HBASE-25212 URL: https://issues.apache.org/jira/browse/HBASE-25212

[GitHub] [hbase] Apache9 commented on pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
Apache9 commented on pull request #2570: URL: https://github.com/apache/hbase/pull/2570#issuecomment-714062524 > Do you think "fallback to primary" logic needs to be passed down from rpc retrying caller? Then it needs to be aware of this feature and needs to maintain some state. Was

[GitHub] [hbase] Apache-HBase commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-714048462 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #2571: HBASE-25207 Revisit the implementation and usage of RegionStates.include

2020-10-21 Thread GitBox
Apache9 commented on pull request #2571: URL: https://github.com/apache/hbase/pull/2571#issuecomment-714044695 @brfrn169 Mind taking a look? Let's get this in first and then work on HBASE-25206. Thanks. This is an

[GitHub] [hbase] Apache-HBase commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-714040832 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1531: HBASE-24200 Upgrade to Yetus 0.12.0

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #1531: URL: https://github.com/apache/hbase/pull/1531#issuecomment-714034437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2555: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2555: URL: https://github.com/apache/hbase/pull/2555#issuecomment-714017351 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-713984113 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-713923552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
ndimiduk commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r509778357 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,81 @@ static final

[GitHub] [hbase] ndimiduk commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
ndimiduk commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r509774334 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,81 @@ static final

[GitHub] [hbase] ndimiduk commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
ndimiduk commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r509773168 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,81 @@ static final

[GitHub] [hbase] ndimiduk commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
ndimiduk commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r509749819 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-713906972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-713900751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] HorizonNet commented on a change in pull request #2558: HBASE-25174 Remove deprecated fields in HConstants

2020-10-21 Thread GitBox
HorizonNet commented on a change in pull request #2558: URL: https://github.com/apache/hbase/pull/2558#discussion_r509734109 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -661,10 +660,8 @@ * Timestamp to use when we want to refer to

[GitHub] [hbase] HorizonNet commented on a change in pull request #2562: HBASE-25199 Remove deprecated HStore#getStoreHomedir methods

2020-10-21 Thread GitBox
HorizonNet commented on a change in pull request #2562: URL: https://github.com/apache/hbase/pull/2562#discussion_r509731682 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -511,32 +511,6 @@ public OptionalLong

[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox
ndimiduk commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-713876958 Rebased. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] ndimiduk commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox
ndimiduk commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r509692111 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -315,35 +316,60 @@ private boolean

[GitHub] [hbase] ndimiduk commented on pull request #1531: HBASE-24200 Upgrade to Yetus 0.12.0

2020-10-21 Thread GitBox
ndimiduk commented on pull request #1531: URL: https://github.com/apache/hbase/pull/1531#issuecomment-713873295 Removed change to `audience-annotations.version` in pom.xml This is an automated message from the Apache Git

[GitHub] [hbase] gvprathyusha6 commented on a change in pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-21 Thread GitBox
gvprathyusha6 commented on a change in pull request #2542: URL: https://github.com/apache/hbase/pull/2542#discussion_r509689995 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -466,13 +466,31 @@ */ protected String

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r509649990 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -315,35 +316,60 @@ private

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r509648091 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -315,35 +316,60 @@ private

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2490: URL: https://github.com/apache/hbase/pull/2490#discussion_r509644400 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -315,35 +316,60 @@ private

[GitHub] [hbase] Apache-HBase commented on pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-713840444 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] huaxiangsun commented on pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
huaxiangsun commented on pull request #2570: URL: https://github.com/apache/hbase/pull/2570#issuecomment-713833194 Forgot to mention that patch against master, the only nit is testing cases as there is no meta replication support in master, will check the tests and see how much test can

[GitHub] [hbase] Apache-HBase commented on pull request #1531: HBASE-24200 Upgrade to Yetus 0.12.0

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #1531: URL: https://github.com/apache/hbase/pull/1531#issuecomment-713832360 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713831199 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713830268 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713829628 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
huaxiangsun commented on pull request #2570: URL: https://github.com/apache/hbase/pull/2570#issuecomment-713829326 > On a high level design, we used to have a `hbase.meta.replicas.use` config to control whether to make use meta replicas at client side. Do we want to deprecate this config

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-713829224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-713827334 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-713826510 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r509607895 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java ## @@ -130,8 +133,12 @@ public

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r509607454 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] busbey commented on a change in pull request #1531: HBASE-24200 Upgrade to Yetus 0.12.0

2020-10-21 Thread GitBox
busbey commented on a change in pull request #1531: URL: https://github.com/apache/hbase/pull/1531#discussion_r509605959 ## File path: pom.xml ## @@ -1593,7 +1593,7 @@ comes in via hbase-thirdparty hbase-shaded-netty--> 3.10.5.Final -0.5.0 +0.12.0

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r509605617 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] virajjasani commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
virajjasani commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r509599484 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,81 @@ static final

[jira] [Resolved] (HBASE-23894) [JDK11] build with -PerrorProne silently fails

2020-10-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-23894. -- Resolution: Won't Fix I don't think we can solve this. ErrorProne's maven configurations are

[jira] [Assigned] (HBASE-23894) [JDK11] build with -PerrorProne silently fails

2020-10-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-23894: Assignee: (was: Nick Dimiduk) > [JDK11] build with -PerrorProne silently fails >

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-21 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r509598756 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaChooser.java ## @@ -0,0 +1,53 @@ +/** + *

[GitHub] [hbase] ndimiduk commented on pull request #1547: HBASE-23894 Support ErrorProne for both JDK8 and JDK11

2020-10-21 Thread GitBox
ndimiduk commented on pull request #1547: URL: https://github.com/apache/hbase/pull/1547#issuecomment-713814829 I don't think this is feasible; given how we mask its use behind a profile, we're going to have to run ErrorProne on only one JVM configuration. Closing old/stale PR.

[GitHub] [hbase] ndimiduk closed pull request #1547: HBASE-23894 Support ErrorProne for both JDK8 and JDK11

2020-10-21 Thread GitBox
ndimiduk closed pull request #1547: URL: https://github.com/apache/hbase/pull/1547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox
ndimiduk commented on pull request #2490: URL: https://github.com/apache/hbase/pull/2490#issuecomment-713813965 Bump. The last build-bot run was all greens, I'm not sure why the GitHub status didn't update. This is

[jira] [Updated] (HBASE-25193) Add support for row prefix and type in the WAL Pretty Printer

2020-10-21 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-25193: Description: Currently, the WAL Pretty Printer has an option to filter the keys with an exact

[jira] [Updated] (HBASE-25193) Add support for row prefix and type in the WAL Pretty Printer and some minor fixes

2020-10-21 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-25193: Summary: Add support for row prefix and type in the WAL Pretty Printer and some minor fixes

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713779840 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713778287 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
ndimiduk commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r509554540 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,81 @@ static final

[GitHub] [hbase] ndimiduk commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
ndimiduk commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-713776373 Rebase and remove taking the ReadLock from `SimpleRegionNormalizer#setConf`. This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713776445 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-21 Thread GitBox
sandeepvinayak commented on a change in pull request #2556: URL: https://github.com/apache/hbase/pull/2556#discussion_r509548831 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -301,15 +318,12 @@ public void processFile(final

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-21 Thread GitBox
sandeepvinayak commented on a change in pull request #2556: URL: https://github.com/apache/hbase/pull/2556#discussion_r509545829 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -326,15 +340,19 @@ public void processFile(final

[GitHub] [hbase] ndimiduk commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-21 Thread GitBox
ndimiduk commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r509538496 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,81 @@ static final

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713759128 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-21 Thread GitBox
Apache-HBase commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-71371 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >