[GitHub] [hbase] ramkrish86 opened a new pull request #2582: Hbase 25187 master

2020-10-22 Thread GitBox
ramkrish86 opened a new pull request #2582: URL: https://github.com/apache/hbase/pull/2582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HBASE-25187) Improve SizeCachedKV variants initialization

2020-10-22 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219459#comment-17219459 ] ramkrishna.s.vasudevan commented on HBASE-25187: This patch along with the removal of

[jira] [Commented] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-22 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219457#comment-17219457 ] Anoop Sam John commented on HBASE-25206: Tks. [~brfrn169] So even if snapshot cloned to new

[GitHub] [hbase] Apache-HBase commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-714895398 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-714894728 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-22 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219440#comment-17219440 ] Toshihiro Suzuki edited comment on HBASE-25206 at 10/23/20, 3:38 AM: -

[jira] [Commented] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-22 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219440#comment-17219440 ] Toshihiro Suzuki commented on HBASE-25206: -- [~anoop.hbase] Sorry. I just noticed your comment.

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714886902 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-22 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-25206: - Description: Steps to reproduce are as follows: 1. Create a table and put some data

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-714878901 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-22 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218830#comment-17218830 ] Anoop Sam John edited comment on HBASE-25206 at 10/23/20, 3:01 AM: ---

[GitHub] [hbase] Apache-HBase commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-714877013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] brfrn169 commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-22 Thread GitBox
brfrn169 commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-714874912 @Apache9 I just modified the patch for your review. Can you please review it when you get a chance? Thanks.

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714867315 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-714860665 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache9 commented on a change in pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-22 Thread GitBox
Apache9 commented on a change in pull request #2556: URL: https://github.com/apache/hbase/pull/2556#discussion_r510549322 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -301,15 +318,12 @@ public void processFile(final

[GitHub] [hbase] Apache-HBase commented on pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2542: URL: https://github.com/apache/hbase/pull/2542#issuecomment-714852038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25207) Revisit the implementation and usage of RegionStates.include

2020-10-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219400#comment-17219400 ] Hudson commented on HBASE-25207: Results for branch branch-2.2 [build #105 on

[GitHub] [hbase] Apache-HBase commented on pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2542: URL: https://github.com/apache/hbase/pull/2542#issuecomment-714849144 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-25110) Add heartbeat for ReplicationServer and dispatch replication sources to ReplicationServer

2020-10-22 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-25110: -- Assignee: Guanghao Zhang > Add heartbeat for ReplicationServer and dispatch

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-714841827 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25128) RSGroupInfo's toString() and hashCode() does not take into account configuration map.

2020-10-22 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-25128. Fix Version/s: 2.4.0 3.0.0-alpha-1 Resolution: Fixed Pushed to

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-714838976 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio merged pull request #2484: HBASE-25128 RSGroupInfo's toString() and hashCode() does not take int…

2020-10-22 Thread GitBox
infraio merged pull request #2484: URL: https://github.com/apache/hbase/pull/2484 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714834407 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-714833531 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-714827709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-22 Thread GitBox
sandeepvinayak commented on a change in pull request #2556: URL: https://github.com/apache/hbase/pull/2556#discussion_r510491746 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -301,15 +318,12 @@ public void processFile(final

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-714822872 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2542: URL: https://github.com/apache/hbase/pull/2542#issuecomment-714820058 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714818860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714814627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-714802738 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bharathv commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
bharathv commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714801212 > Also, what do you think to the idea of making the configuration setting that controls this default to TRUE on master branch and FALSE on branch-2 and branch-1 (and derived

[GitHub] [hbase] Apache-HBase commented on pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2542: URL: https://github.com/apache/hbase/pull/2542#issuecomment-714799563 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-714797194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2542: URL: https://github.com/apache/hbase/pull/2542#issuecomment-714796129 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-22 Thread GitBox
sandeepvinayak commented on a change in pull request #2556: URL: https://github.com/apache/hbase/pull/2556#discussion_r510492497 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -301,15 +318,12 @@ public void processFile(final

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-22 Thread GitBox
sandeepvinayak commented on a change in pull request #2556: URL: https://github.com/apache/hbase/pull/2556#discussion_r510491746 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ## @@ -301,15 +318,12 @@ public void processFile(final

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-714785183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-714781691 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714766806 Back soon to fix the other checkstyle nits. Also, what do you think to the idea of making the configuration setting that controls this default to TRUE on master branch

[GitHub] [hbase] huaxiangsun commented on pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on pull request #2570: URL: https://github.com/apache/hbase/pull/2570#issuecomment-714760677 > > Do you think "fallback to primary" logic needs to be passed down from rpc retrying caller? Then it needs to be aware of this feature and needs to maintain some state. Was

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-714749549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-714742876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2542: URL: https://github.com/apache/hbase/pull/2542#issuecomment-714739401 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714732011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510415238 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestMetaRegionReplicaReplicationEndpoint.java ## @@ -63,17

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510414632 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocatorWithMetaReplicaLoadBalance.java ## @@ -0,0 +1,84

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510413345 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -198,6 +208,36 @@ private boolean

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510413507 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -198,6 +208,36 @@ private boolean

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510412906 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java ## @@ -392,6 +406,16 @@ public Connection

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510412431 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510412184 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510411776 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1128,6 +1128,9 @@ /** Conf key for enabling meta

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510410275 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaChooser.java ## @@ -0,0 +1,53 @@ +/** + *

[GitHub] [hbase] gkanade commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
gkanade commented on a change in pull request #2483: URL: https://github.com/apache/hbase/pull/2483#discussion_r510389863 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -3075,6 +3080,13 @@ private RegionScannerImpl

[GitHub] [hbase] gkanade commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
gkanade commented on a change in pull request #2483: URL: https://github.com/apache/hbase/pull/2483#discussion_r510383502 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -7699,6 +7710,14 @@ public void run() throws IOException

[GitHub] [hbase] gkanade commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
gkanade commented on a change in pull request #2483: URL: https://github.com/apache/hbase/pull/2483#discussion_r510383316 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -7238,6 +7246,9 @@ public boolean nextRaw(List

[GitHub] [hbase] gkanade commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
gkanade commented on a change in pull request #2483: URL: https://github.com/apache/hbase/pull/2483#discussion_r510383013 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -9143,4 +9162,8 @@ public void setReadRequestsCount(long

[GitHub] [hbase] gkanade commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
gkanade commented on a change in pull request #2483: URL: https://github.com/apache/hbase/pull/2483#discussion_r510382742 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java ## @@ -115,4 +116,6 @@ */ boolean nextRaw(List

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-714690375 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] gkanade commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
gkanade commented on a change in pull request #2483: URL: https://github.com/apache/hbase/pull/2483#discussion_r510381778 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -3498,6 +3501,18 @@ public ScanResponse scan(final

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-714686601 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25212) Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219261#comment-17219261 ] Andrew Kyle Purtell commented on HBASE-25212: - After upgrading to Java 11 realized I was

[GitHub] [hbase] apurtell removed a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell removed a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714639693 The unit test failures are interesting. These new test work reliably with Java 8, which is what I develop with and use in production. They do not appear to work on Java

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714676191 Deleted comment about JDK version. After upgrading to Java 11 realized I was just missing a change to HTU. Never mind.

[GitHub] [hbase] Apache-HBase commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-714673473 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-714669413 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-714668995 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25186) TestMasterRegionOnTwoFileSystems is failing after HBASE-25065

2020-10-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219233#comment-17219233 ] Hudson commented on HBASE-25186: Results for branch branch-2 [build #81 on

[GitHub] [hbase] symat commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-22 Thread GitBox
symat commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-714647401 I made this behaviour configurable, just pushed the change. (I also added new tests for it) What do you think?

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-714644766 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714639693 The unit test failures are interesting. These new test work reliably with Java 8, which is what I develop with and use in production. They do not appear to work on Java

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-22 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r510332100 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -435,6 +475,14 @@ private void

[jira] [Commented] (HBASE-25212) Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219207#comment-17219207 ] Andrew Kyle Purtell commented on HBASE-25212: - Unit test failures reported on the master PR

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714639693 The unit test failures are interesting. These new test work reliably with Java 8, which is what I develop with and use in production. They do not appear to work on Java

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714639693 The unit test failures are interesting. These new test work reliably with Java 8, which is what I develop with and use in production. They do not appear to work on Java 11

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-714636166 I see findbugs doesn't like my deliberate fall through in switch statements. In old school programming we'd do this intentionally because we think we are clever. Anyway will

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r510320642 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInterrupt.java ## @@ -0,0 +1,357 @@ +/* + * Licensed to the

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r510320411 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java ## @@ -7364,4 +7367,154 @@ protected

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r510320339 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java ## @@ -7364,4 +7367,154 @@ protected

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r510319462 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -6588,8 +6677,10 @@ protected RowLock

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r510319462 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -6588,8 +6677,10 @@ protected RowLock

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r510317299 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4550,6 +4619,10 @@ private void

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r510317538 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8748,6 +8863,11 @@ public void

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r510317299 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4550,6 +4619,10 @@ private void

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-22 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r510316643 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -1174,7 +1178,7 @@ public HStore call() throws

[GitHub] [hbase] symat commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-22 Thread GitBox
symat commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-714597486 >We should use the one in the hfile, otherwise the only way to change the config is to throw away your cluster and start over. That is a good point... I'll change

[GitHub] [hbase] wchevreuil commented on a change in pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-22 Thread GitBox
wchevreuil commented on a change in pull request #2579: URL: https://github.com/apache/hbase/pull/2579#discussion_r510244366 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -288,39 +258,26 @@ public boolean

[jira] [Comment Edited] (HBASE-25090) CompactionConfiguration logs unrealistic store file sizes

2020-10-22 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219100#comment-17219100 ] Zhuoyue Huang edited comment on HBASE-25090 at 10/22/20, 3:30 PM: -- I

[jira] [Commented] (HBASE-25090) CompactionConfiguration logs unrealistic store file sizes

2020-10-22 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219100#comment-17219100 ] Zhuoyue Huang commented on HBASE-25090: --- I guess this is not a bug.    {code:java} size [128 MB,

[GitHub] [hbase] sguggilam commented on pull request #2578: HBASE-24768 Clear cached service kerberos ticket in case of SASL fail…

2020-10-22 Thread GitBox
sguggilam commented on pull request #2578: URL: https://github.com/apache/hbase/pull/2578#issuecomment-714555919 @apurtell @abhishek-chouhan Please review This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-714553561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-22 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-714551007 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] busbey commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-22 Thread GitBox
busbey commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-714540943 We should use the one in the hfile, otherwise the only way to change the config is to throw away your cluster and start over. I think a DEBUG message of what hash we're

[jira] [Resolved] (HBASE-25214) about hbase introduced fasterxml‘s jackson versions and vulnerabilities

2020-10-22 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-25214. - Resolution: Duplicate This is a duplicate of HBASE-24802. Please follow our work over there.

[GitHub] [hbase] Apache9 commented on a change in pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-22 Thread GitBox
Apache9 commented on a change in pull request #2569: URL: https://github.com/apache/hbase/pull/2569#discussion_r510202074 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java ## @@ -100,6 +101,12 @@ protected Flow

[jira] [Updated] (HBASE-25207) Revisit the implementation and usage of RegionStates.include

2020-10-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25207: -- Fix Version/s: 2.2.7 2.4.0 2.3.3

[jira] [Resolved] (HBASE-25207) Revisit the implementation and usage of RegionStates.include

2020-10-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25207. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.2+. Thanks [~brfrn169] for

  1   2   >