[GitHub] [hbase] Apache9 merged pull request #2581: HBASE-25201 YouAreDeadException should be moved to hbase-server module

2020-10-27 Thread GitBox
Apache9 merged pull request #2581: URL: https://github.com/apache/hbase/pull/2581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache-HBase commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-717739141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33

[GitHub] [hbase] Apache9 merged pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-27 Thread GitBox
Apache9 merged pull request #2538: URL: https://github.com/apache/hbase/pull/2538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache-HBase commented on pull request #2581: HBASE-25201 YouAreDeadException should be moved to hbase-server module

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2581: URL: https://github.com/apache/hbase/pull/2581#issuecomment-717734279 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47

[GitHub] [hbase] Apache-HBase commented on pull request #2592: HBASE-25223 Use try-with-resources statement

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2592: URL: https://github.com/apache/hbase/pull/2592#issuecomment-717729462 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

[GitHub] [hbase] Apache-HBase commented on pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2591: URL: https://github.com/apache/hbase/pull/2591#issuecomment-717714818 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m 24s

[GitHub] [hbase] Apache-HBase commented on pull request #2592: HBASE-25223 Use try-with-resources statement

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2592: URL: https://github.com/apache/hbase/pull/2592#issuecomment-717713506 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 22s

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-717713276 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 32

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-717712968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2

[GitHub] [hbase] virajjasani commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-27 Thread GitBox
virajjasani commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-717712647 @ndimiduk I don't have any specific concern, it's just that I am almost not familiar with Quota's code path, so anyone with familiarity in that area should feel good to get th

[GitHub] [hbase] Apache-HBase commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-717706876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2592: HBASE-25223 Use try-with-resources statement

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2592: URL: https://github.com/apache/hbase/pull/2592#issuecomment-717696111 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-717687844 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-717686721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #2581: HBASE-25201 YouAreDeadException should be moved to hbase-server module

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2581: URL: https://github.com/apache/hbase/pull/2581#issuecomment-717685083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32

[GitHub] [hbase] iamminji commented on a change in pull request #2592: HBASE-25223 Use try-with-resources statement

2020-10-27 Thread GitBox
iamminji commented on a change in pull request #2592: URL: https://github.com/apache/hbase/pull/2592#discussion_r513170799 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/CreateSnapshot.java ## @@ -67,24 +67,14 @@ protected void processOptions(Command

[GitHub] [hbase] saintstack commented on a change in pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

2020-10-27 Thread GitBox
saintstack commented on a change in pull request #2580: URL: https://github.com/apache/hbase/pull/2580#discussion_r513163262 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MutableRegionInfo.java ## @@ -254,8 +254,10 @@ public MutableRegionInfo setSplit

[GitHub] [hbase] Apache-HBase commented on pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2580: URL: https://github.com/apache/hbase/pull/2580#issuecomment-717676260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m 40

[GitHub] [hbase] Apache-HBase commented on pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2580: URL: https://github.com/apache/hbase/pull/2580#issuecomment-717674498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-717673278 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40

[GitHub] [hbase] nyl3532016 commented on pull request #2581: HBASE-25201 YouAreDeadException should be moved to hbase-server module

2020-10-27 Thread GitBox
nyl3532016 commented on pull request #2581: URL: https://github.com/apache/hbase/pull/2581#issuecomment-717672916 @Apache9 The YouAreDeadException is only used in server module, Should we move it to hbase-server? This is an

[GitHub] [hbase] Apache-HBase commented on pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2580: URL: https://github.com/apache/hbase/pull/2580#issuecomment-717672672 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] Reidddddd commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
Reidd commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r513154120 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4569,13 +4665,29 @@ private void doMiniBatchMutate(Batc

[GitHub] [hbase] jojochuang commented on a change in pull request #2592: HBASE-25223 Use try-with-resources statement

2020-10-27 Thread GitBox
jojochuang commented on a change in pull request #2592: URL: https://github.com/apache/hbase/pull/2592#discussion_r513153293 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/CreateSnapshot.java ## @@ -67,24 +67,14 @@ protected void processOptions(Comma

[GitHub] [hbase] Apache-HBase commented on pull request #2591: HBASE-24859: Optimize in-memory representation for HBase map reduce table splits

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2591: URL: https://github.com/apache/hbase/pull/2591#issuecomment-717657954 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 52s

[GitHub] [hbase] Apache-HBase commented on pull request #2592: HBASE-25223 Use try-with-resources statement

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2592: URL: https://github.com/apache/hbase/pull/2592#issuecomment-717657441 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-717652660 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-717649548 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] iamminji opened a new pull request #2592: HBASE-25223 Use try-with-resources statement

2020-10-27 Thread GitBox
iamminji opened a new pull request #2592: URL: https://github.com/apache/hbase/pull/2592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Created] (HBASE-25223) Use try-with-resources statement in snapshot package

2020-10-27 Thread minjikim (Jira)
minjikim created HBASE-25223: Summary: Use try-with-resources statement in snapshot package Key: HBASE-25223 URL: https://issues.apache.org/jira/browse/HBASE-25223 Project: HBase Issue Type: Impr

[GitHub] [hbase] Apache9 commented on a change in pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-27 Thread GitBox
Apache9 commented on a change in pull request #2498: URL: https://github.com/apache/hbase/pull/2498#discussion_r513131185 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -3069,27 +3073,33 @@ private RegionScannerImpl getScanner(

[jira] [Work started] (HBASE-24859) Optimize in-memory representation of mapreduce TableSplit objects

2020-10-27 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24859 started by Sandeep Pal. --- > Optimize in-memory representation of mapreduce TableSplit objects > ---

[GitHub] [hbase] brfrn169 commented on a change in pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-27 Thread GitBox
brfrn169 commented on a change in pull request #2498: URL: https://github.com/apache/hbase/pull/2498#discussion_r513103294 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -3069,27 +3073,33 @@ private RegionScannerImpl getScanner

[jira] [Updated] (HBASE-24859) Optimize in-memory representation of mapreduce TableSplit objects

2020-10-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24859: - Summary: Optimize in-memory representation of mapreduce TableSplit objects (was

[jira] [Updated] (HBASE-24859) Optimize in-memory representation for mapreduce TableSplit objects

2020-10-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24859: - Summary: Optimize in-memory representation for mapreduce TableSplit objects (wa

[jira] [Updated] (HBASE-24859) Optimize in-memory representation for HBase map reduce table splits

2020-10-27 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-24859: Summary: Optimize in-memory representation for HBase map reduce table splits (was: Improve the st

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-27 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513103884 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1129,7 +1129,18 @@ public static final int MASTER__META_TRANS

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-27 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513103545 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/** +

[jira] [Updated] (HBASE-24859) Improve the storage cost for HBase map reduce table splits

2020-10-27 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-24859: Description: It has been observed that when the table has too many regions, MR jobs consume a lot

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-27 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513103178 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/** +

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-27 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513102647 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSelector.java ## @@ -0,0 +1,46 @@ +/** + * Lice

[GitHub] [hbase] sandeepvinayak opened a new pull request #2591: HBASE-24859: Improve the storage cost for HBase map reduce table splits

2020-10-27 Thread GitBox
sandeepvinayak opened a new pull request #2591: URL: https://github.com/apache/hbase/pull/2591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (HBASE-24859) Improve the storage cost for HBase map reduce table splits

2020-10-27 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-24859: Summary: Improve the storage cost for HBase map reduce table splits (was: Remove the empty region

[GitHub] [hbase] infraio commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-27 Thread GitBox
infraio commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-717610489 @ddupg Need to fix the spotbugs warnings: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2579/5/artifact/yetus-general-check/output/branch-spotbugs-hba

[jira] [Commented] (HBASE-24246) Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overlap listing, and configuration

2020-10-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221817#comment-17221817 ] Hudson commented on HBASE-24246: Results for branch branch-2.2 [build #108 on b

[jira] [Commented] (HBASE-25220) Backport HBASE-24246 "Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overlap listing, and configuration" to b

2020-10-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221816#comment-17221816 ] Hudson commented on HBASE-25220: Results for branch branch-2.2 [build #108 on b

[jira] [Commented] (HBASE-24369) Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed immediately

2020-10-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221819#comment-17221819 ] Hudson commented on HBASE-24369: Results for branch branch-2.2 [build #108 on b

[jira] [Commented] (HBASE-25219) Backport HBASE-24369 "Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed immediately" to branch-2.2

2020-10-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221818#comment-17221818 ] Hudson commented on HBASE-25219: Results for branch branch-2.2 [build #108 on b

[GitHub] [hbase] Apache-HBase commented on pull request #2590: HBASE-25221 Backport HBASE-24368 Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2590: URL: https://github.com/apache/hbase/pull/2590#issuecomment-717581658 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-717581510 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-717581134 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32

[GitHub] [hbase] Apache-HBase commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-717566262 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28

[GitHub] [hbase] saintstack commented on pull request #2590: HBASE-25221 Backport HBASE-24368 Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null

2020-10-27 Thread GitBox
saintstack commented on pull request #2590: URL: https://github.com/apache/hbase/pull/2590#issuecomment-717557944 Should have called the original patch excellent... this one does have some nice addition though. This is an au

[GitHub] [hbase] saintstack commented on a change in pull request #2590: HBASE-25221 Backport HBASE-24368 Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null

2020-10-27 Thread GitBox
saintstack commented on a change in pull request #2590: URL: https://github.com/apache/hbase/pull/2590#discussion_r513044269 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/HBCKServerCrashProcedure.java ## @@ -169,4 +170,16 @@ public boolean v

[GitHub] [hbase] Apache-HBase commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-717531508 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-717522576 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

[jira] [Comment Edited] (HBASE-24637) Reseek regression related to filter SKIP hinting

2020-10-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221703#comment-17221703 ] Andrew Kyle Purtell edited comment on HBASE-24637 at 10/27/20, 7:47 PM: --

[jira] [Comment Edited] (HBASE-24637) Reseek regression related to filter SKIP hinting

2020-10-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221703#comment-17221703 ] Andrew Kyle Purtell edited comment on HBASE-24637 at 10/27/20, 7:46 PM: --

[jira] [Commented] (HBASE-24637) Reseek regression related to filter SKIP hinting

2020-10-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221703#comment-17221703 ] Andrew Kyle Purtell commented on HBASE-24637: - [~ram_krish] We definitely do

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-717490523 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512965703 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4569,13 +4665,29 @@ private void doMiniBatchMutate(Batch

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512957365 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4569,13 +4665,29 @@ private void doMiniBatchMutate(Batch

[GitHub] [hbase] Apache-HBase commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-717465734 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 52

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-27 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512937688 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4569,13 +4665,29 @@ private void doMiniBatchMutate(Batch

[GitHub] [hbase] saintstack commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-27 Thread GitBox
saintstack commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r512903424 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -89,7 +90,10 @@ private final int loca

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-717428389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] ndimiduk commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-27 Thread GitBox
ndimiduk commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-717427401 If you've unwound the changes to IA.LimitedPrivate classes, then this should be good to go. I've kicked off another build of this PR. Before merge, please squash down the commits

[jira] [Created] (HBASE-25222) Add a cost function to move the daughter regions of a recent split to different region servers

2020-10-27 Thread Sandeep Pal (Jira)
Sandeep Pal created HBASE-25222: --- Summary: Add a cost function to move the daughter regions of a recent split to different region servers Key: HBASE-25222 URL: https://issues.apache.org/jira/browse/HBASE-25222

[GitHub] [hbase] Apache-HBase commented on pull request #2590: HBASE-25221 Backport HBASE-24368 Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2590: URL: https://github.com/apache/hbase/pull/2590#issuecomment-717391671 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 0s

[GitHub] [hbase] busbey commented on a change in pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-27 Thread GitBox
busbey commented on a change in pull request #2308: URL: https://github.com/apache/hbase/pull/2308#discussion_r512742281 ## File path: pom.xml ## @@ -1633,8 +1633,8 @@ 2.4.1 1.3.8 -2.1.11 -1.0.18 +2.1.40 Review comment: Only certain versions

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-717266866 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 21

[GitHub] [hbase] Apache9 commented on a change in pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

2020-10-27 Thread GitBox
Apache9 commented on a change in pull request #2538: URL: https://github.com/apache/hbase/pull/2538#discussion_r512718904 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/MasterStoppedException.java ## @@ -0,0 +1,28 @@ +/** Review comment: Th

[jira] [Updated] (HBASE-25173) Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25173: -- Fix Version/s: 3.0.0-alpha-1 > Remove owner related methods in TableDescriptor/TableDescriptorBuilder

[jira] [Commented] (HBASE-25173) Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221453#comment-17221453 ] Duo Zhang commented on HBASE-25173: --- Merged to master. Thanks [~wenfeiyi666] for cont

[GitHub] [hbase] Apache9 merged pull request #2541: HBASE-25173 Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-27 Thread GitBox
Apache9 merged pull request #2541: URL: https://github.com/apache/hbase/pull/2541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache9 commented on a change in pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

2020-10-27 Thread GitBox
Apache9 commented on a change in pull request #2580: URL: https://github.com/apache/hbase/pull/2580#discussion_r512711209 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MutableRegionInfo.java ## @@ -254,8 +254,10 @@ public MutableRegionInfo setSplit(bo

[GitHub] [hbase] Apache9 commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-27 Thread GitBox
Apache9 commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r512682721 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java ## @@ -181,9 +185,18 @@ public void newDead(ServerName sn)

[GitHub] [hbase] nkalmar commented on a change in pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-27 Thread GitBox
nkalmar commented on a change in pull request #2308: URL: https://github.com/apache/hbase/pull/2308#discussion_r512693063 ## File path: pom.xml ## @@ -1633,8 +1633,8 @@ 2.4.1 1.3.8 -2.1.11 -1.0.18 +2.1.40 Review comment: Changed it. -

[GitHub] [hbase] nkalmar commented on a change in pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-27 Thread GitBox
nkalmar commented on a change in pull request #2308: URL: https://github.com/apache/hbase/pull/2308#discussion_r512690037 ## File path: pom.xml ## @@ -1633,8 +1633,8 @@ 2.4.1 1.3.8 -2.1.11 -1.0.18 +2.1.40 Review comment: No, that's 2.1.31. We

[GitHub] [hbase] Apache9 commented on a change in pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-27 Thread GitBox
Apache9 commented on a change in pull request #2498: URL: https://github.com/apache/hbase/pull/2498#discussion_r512669482 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CheckAndMutate.java ## @@ -312,83 +331,178 @@ public Row getAction() { return

[jira] [Updated] (HBASE-25221) Backport HBASE-24368 "Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null"

2020-10-27 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-25221: -- Status: Patch Available (was: Open) > Backport HBASE-24368 "Let HBCKSCP clear 'Unknown Server

[GitHub] [hbase] petersomogyi opened a new pull request #2590: HBASE-25221 Backport HBASE-24368 Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null

2020-10-27 Thread GitBox
petersomogyi opened a new pull request #2590: URL: https://github.com/apache/hbase/pull/2590 hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/GCMultipleMergedRegionsProcedure.java Edit a log. hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure

[jira] [Created] (HBASE-25221) Backport HBASE-24368 "Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null"

2020-10-27 Thread Peter Somogyi (Jira)
Peter Somogyi created HBASE-25221: - Summary: Backport HBASE-24368 "Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null" Key: HBASE-25221 URL: https://issues.apache.org/jira/brow

[jira] [Commented] (HBASE-24637) Reseek regression related to filter SKIP hinting

2020-10-27 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221309#comment-17221309 ] ramkrishna.s.vasudevan commented on HBASE-24637: [~larsh] and [~apurtell

[jira] [Updated] (HBASE-25217) [Metrics] Add metrics for Call in IPC response queue

2020-10-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25217: -- Fix Version/s: 1.7.0 3.0.0-alpha-1 > [Metrics] Add metrics for Call in IPC response

[jira] [Updated] (HBASE-25003) Backport HBASE-24350 and HBASE-24779 to branch-2.2 & branch-2.3

2020-10-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25003: - Fix Version/s: (was: 2.3.3) 2.3.4 > Backport HBASE-24350 and HBASE-24779

[jira] [Commented] (HBASE-15992) Preserve original KeeperException when converted to external exceptions

2020-10-27 Thread freedom1993 feng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221250#comment-17221250 ] freedom1993 feng commented on HBASE-15992: -- Is this problem solved? > Preserve

[GitHub] [hbase] Apache-HBase commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-27 Thread GitBox
Apache-HBase commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-717049117 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5