[GitHub] [hbase] Apache-HBase commented on pull request #2452: HBASE-25071 ReplicationServer support start ReplicationSource internal

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2452: URL: https://github.com/apache/hbase/pull/2452#issuecomment-721557915 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2623: HBASE-25240 gson format of RpcServer.logResponse is abnormal

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2623: URL: https://github.com/apache/hbase/pull/2623#issuecomment-721550119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio commented on a change in pull request #2535: HBASE-25116 RegionMonitor support RegionTask count normalize

2020-11-03 Thread GitBox
infraio commented on a change in pull request #2535: URL: https://github.com/apache/hbase/pull/2535#discussion_r517125577 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java ## @@ -1422,6 +1424,10 @@ public RegionMonitor(Connection

[GitHub] [hbase] infraio commented on a change in pull request #2535: HBASE-25116 RegionMonitor support RegionTask count normalize

2020-11-03 Thread GitBox
infraio commented on a change in pull request #2535: URL: https://github.com/apache/hbase/pull/2535#discussion_r517125696 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1504,6 +1504,13 @@ public static final String

[GitHub] [hbase] Apache-HBase commented on pull request #2614: HBASE-25216 The client zk syncer should deal with meta replica count …

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2614: URL: https://github.com/apache/hbase/pull/2614#issuecomment-721540399 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2452: HBASE-25071 ReplicationServer support start ReplicationSource internal

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2452: URL: https://github.com/apache/hbase/pull/2452#issuecomment-721538497 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2623: HBASE-25240 gson format of RpcServer.logResponse is abnormal

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2623: URL: https://github.com/apache/hbase/pull/2623#issuecomment-721533741 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2623: HBASE-25240 gson format of RpcServer.logResponse is abnormal

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2623: URL: https://github.com/apache/hbase/pull/2623#issuecomment-721530666 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2452: HBASE-25071 ReplicationServer support start ReplicationSource internal

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2452: URL: https://github.com/apache/hbase/pull/2452#issuecomment-721515636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721514318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25242) Add Increment/Append support to RowMutations

2020-11-03 Thread Toshihiro Suzuki (Jira)
Toshihiro Suzuki created HBASE-25242: Summary: Add Increment/Append support to RowMutations Key: HBASE-25242 URL: https://issues.apache.org/jira/browse/HBASE-25242 Project: HBase Issue

[jira] [Commented] (HBASE-24210) Add Increment, Append and CheckAndMutate support to RowMutations

2020-11-03 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225851#comment-17225851 ] Toshihiro Suzuki commented on HBASE-24210: -- It looks like this change will make things too

[jira] [Commented] (HBASE-24996) Support CheckAndMutate in Region.batchMutate()

2020-11-03 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225850#comment-17225850 ] Toshihiro Suzuki commented on HBASE-24996: -- It looks like this change will make things too

[jira] [Resolved] (HBASE-24210) Add Increment, Append and CheckAndMutate support to RowMutations

2020-11-03 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki resolved HBASE-24210. -- Resolution: Won't Fix > Add Increment, Append and CheckAndMutate support to

[jira] [Resolved] (HBASE-24996) Support CheckAndMutate in Region.batchMutate()

2020-11-03 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki resolved HBASE-24996. -- Resolution: Won't Fix > Support CheckAndMutate in Region.batchMutate() >

[GitHub] [hbase] brfrn169 edited a comment on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-11-03 Thread GitBox
brfrn169 edited a comment on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-721511433 It looks like this change will make things too complicated and it has big side effects and incompatible changes. So I will give it up. Closing it.

[GitHub] [hbase] brfrn169 closed pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-11-03 Thread GitBox
brfrn169 closed pull request #2498: URL: https://github.com/apache/hbase/pull/2498 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] brfrn169 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-11-03 Thread GitBox
brfrn169 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-721511433 It looks like this change will make things too complicated and it has big side effects, so I will give it up. Closing it.

[GitHub] [hbase] Apache-HBase commented on pull request #2614: HBASE-25216 The client zk syncer should deal with meta replica count …

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2614: URL: https://github.com/apache/hbase/pull/2614#issuecomment-721505951 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2623: HBASE-25240 gson format of RpcServer.logResponse is abnormal

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2623: URL: https://github.com/apache/hbase/pull/2623#issuecomment-721498699 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721496809 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #2614: HBASE-25216 The client zk syncer should deal with meta replica count …

2020-11-03 Thread GitBox
Apache9 commented on a change in pull request #2614: URL: https://github.com/apache/hbase/pull/2614#discussion_r517078074 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSeparateClientZKCluster.java ## @@ -255,7 +260,20 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2452: HBASE-25071 ReplicationServer support start ReplicationSource internal

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2452: URL: https://github.com/apache/hbase/pull/2452#issuecomment-721491103 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache9 commented on a change in pull request #2614: HBASE-25216 The client zk syncer should deal with meta replica count …

2020-11-03 Thread GitBox
Apache9 commented on a change in pull request #2614: URL: https://github.com/apache/hbase/pull/2614#discussion_r517077805 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/zksyncer/ClientZKSyncer.java ## @@ -145,8 +177,7 @@ private final void

[jira] [Updated] (HBASE-25235) Cleanup the deprecated methods in TimeRange

2020-11-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25235: -- Hadoop Flags: Incompatible change,Reviewed Release Note: Removed all the public constructors of

[jira] [Resolved] (HBASE-25235) Cleanup the deprecated methods in TimeRange

2020-11-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25235. --- Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed Merged to master. Thanks [~janh] and

[GitHub] [hbase] Apache9 merged pull request #2616: HBASE-25235 Cleanup the deprecated methods in TimeRange

2020-11-03 Thread GitBox
Apache9 merged pull request #2616: URL: https://github.com/apache/hbase/pull/2616 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on a change in pull request #2616: HBASE-25235 Cleanup the deprecated methods in TimeRange

2020-11-03 Thread GitBox
Apache9 commented on a change in pull request #2616: URL: https://github.com/apache/hbase/pull/2616#discussion_r517070761 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java ## @@ -18,24 +18,23 @@ package org.apache.hadoop.hbase.io; -import

[GitHub] [hbase] Apache9 commented on a change in pull request #2616: HBASE-25235 Cleanup the deprecated methods in TimeRange

2020-11-03 Thread GitBox
Apache9 commented on a change in pull request #2616: URL: https://github.com/apache/hbase/pull/2616#discussion_r517070822 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java ## @@ -162,10 +162,9 @@ public Append addColumn(byte[] family, byte[]

[GitHub] [hbase] Apache9 commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
Apache9 commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721481888 > You've addressed all my concerns, thank you. > > I'm sorry I didn't notice this earlier, but I think it's better if this is merged into the feature branch and we land the

[GitHub] [hbase] WenFeiYi commented on a change in pull request #2623: HBASE-25240 gson format of RpcServer.logResponse is abnormal

2020-11-03 Thread GitBox
WenFeiYi commented on a change in pull request #2623: URL: https://github.com/apache/hbase/pull/2623#discussion_r517068885 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/GsonUtil.java ## @@ -43,7 +43,7 @@ private GsonUtil() { */ public static

[jira] [Commented] (HBASE-25053) WAL replay should ignore 0-length files

2020-11-03 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225808#comment-17225808 ] niuyulin commented on HBASE-25053: -- [~stack] mind help review this pr and see if this issue can be

[jira] [Commented] (HBASE-25116) RegionMonitor support RegionTask count normalize

2020-11-03 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225806#comment-17225806 ] niuyulin commented on HBASE-25116: -- yes, If the region num is too large , the canary slows the cluster. 

[GitHub] [hbase] Apache9 commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
Apache9 commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517058850 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -196,8 +201,44 @@ private boolean

[GitHub] [hbase] Apache9 commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
Apache9 commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517057999 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,302 @@ +/** + *

[GitHub] [hbase] ndimiduk commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
ndimiduk commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517057141 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,302 @@ +/** + *

[GitHub] [hbase] ndimiduk commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
ndimiduk commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517056790 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721466030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-721457938 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517042696 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -433,9 +474,24 @@ private void

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517042290 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,302 @@ +/** + *

[GitHub] [hbase] saintstack commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
saintstack commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517036330 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -433,9 +474,24 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721453161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25241) Add integration test for meta replica load balance mode

2020-11-03 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-25241: Summary: Add integration test for meta replica load balance mode Key: HBASE-25241 URL: https://issues.apache.org/jira/browse/HBASE-25241 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #251: URL: https://github.com/apache/hbase/pull/251#issuecomment-721445328 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 45s

[GitHub] [hbase] huaxiangsun commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721441167 Upload a new one to address Nick's comments which did not show up at the front page (embedded in the patch).

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-721440531 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-721437620 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517023873 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516974213 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517022727 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721435677 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r517020877 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[jira] [Updated] (HBASE-25212) Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25212: Hadoop Flags: Reviewed Release Note: If hbase.regionserver.close.wait.abort

[GitHub] [hbase] apurtell merged pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
apurtell merged pull request #2576: URL: https://github.com/apache/hbase/pull/2576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] apurtell merged pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
apurtell merged pull request #2575: URL: https://github.com/apache/hbase/pull/2575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] apurtell merged pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
apurtell merged pull request #2574: URL: https://github.com/apache/hbase/pull/2574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-721425126 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-721423952 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-721414618 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
ndimiduk commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516988960 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[jira] [Commented] (HBASE-25228) Delete dev-support/jenkins_precommit_jira_yetus.sh

2020-11-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225712#comment-17225712 ] Hudson commented on HBASE-25228: Results for branch branch-1.4 [build #18 on

[jira] [Commented] (HBASE-25090) CompactionConfiguration logs unrealistic store file sizes

2020-11-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225713#comment-17225713 ] Hudson commented on HBASE-25090: Results for branch branch-1.4 [build #18 on

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516982360 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516981858 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516979833 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[jira] [Commented] (HBASE-25228) Delete dev-support/jenkins_precommit_jira_yetus.sh

2020-11-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225706#comment-17225706 ] Hudson commented on HBASE-25228: Results for branch branch-2.2 [build #113 on

[jira] [Commented] (HBASE-24859) Optimize in-memory representation of mapreduce TableSplit objects

2020-11-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225707#comment-17225707 ] Hudson commented on HBASE-24859: Results for branch branch-2.2 [build #113 on

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516977060 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721391478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516974213 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,293 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516969889 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -444,6 +503,8 @@ private void

[GitHub] [hbase] huaxiangsun commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721374482 @Apache9 @saintstack @ndimiduk Latest patch uploaded which addresses Duo's latest comments, please help to review, thanks.

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-721373351 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516953887 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -82,14 +84,18 @@ static String

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516953355 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceSimpleSelector.java ## @@ -0,0 +1,302 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516951109 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -82,14 +84,18 @@ static String

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-721369282 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] saintstack closed pull request #2547: HBASE-25185 Remove the usage of MetaTableAccessor in hbase-balancer

2020-11-03 Thread GitBox
saintstack closed pull request #2547: URL: https://github.com/apache/hbase/pull/2547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
apurtell commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-721353246 Last commit on PR branch addresses remaining feedback, going to commit shortly. This is an automated message

[GitHub] [hbase] apurtell commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
apurtell commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-721353189 Last commit on PR branch addresses remaining feedback, going to commit shortly. This is an automated message

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-721352963 Last commit on PR branch addresses remaining feedback, going to commit shortly. This is an automated

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-11-03 Thread GitBox
apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-721352963 Last patch addresses remaining feedback, going to commit shortly. This is an automated message from the Apache

[jira] [Assigned] (HBASE-25190) Create an hbase-tool module and move here standalone tools bundled with core

2020-11-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reassigned HBASE-25190: - Assignee: Michael Stack (was: Duo Zhang) Took back my issue and resolved as won't fix

[jira] [Resolved] (HBASE-25190) Create an hbase-tool module and move here standalone tools bundled with core

2020-11-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25190. --- Resolution: Won't Fix > Create an hbase-tool module and move here standalone tools bundled

[GitHub] [hbase] saintstack closed pull request #2552: HBASE-25190 Create an hbase-tool module and move here standalone tool…

2020-11-03 Thread GitBox
saintstack closed pull request #2552: URL: https://github.com/apache/hbase/pull/2552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-25116) RegionMonitor support RegionTask count normalize

2020-11-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225631#comment-17225631 ] Michael Stack commented on HBASE-25116: --- So, running the canary slows the cluster so we add a

[jira] [Commented] (HBASE-24960) reduce invalid subprocedure task

2020-11-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225629#comment-17225629 ] Michael Stack commented on HBASE-24960: --- [~Bo Cui] Have you seen the feedback on

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-11-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225620#comment-17225620 ] Nick Dimiduk commented on HBASE-24749: -- bq. I have a question on branching, since this feature will

[GitHub] [hbase] Apache-HBase commented on pull request #2602: HBASE-25229 Instantiate BucketCache before RSs create their ephemeral nodes

2020-11-03 Thread GitBox
Apache-HBase commented on pull request #2602: URL: https://github.com/apache/hbase/pull/2602#issuecomment-721302083 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m

[jira] [Commented] (HBASE-25228) Delete dev-support/jenkins_precommit_jira_yetus.sh

2020-11-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225598#comment-17225598 ] Hudson commented on HBASE-25228: Results for branch branch-2 [build #92 on

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-11-03 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225590#comment-17225590 ] Tak-Lon (Stephen) Wu commented on HBASE-24749: -- Hi guys, we're about to sending out

[GitHub] [hbase] HorizonNet commented on a change in pull request #2616: HBASE-25235 Cleanup the deprecated methods in TimeRange

2020-11-03 Thread GitBox
HorizonNet commented on a change in pull request #2616: URL: https://github.com/apache/hbase/pull/2616#discussion_r516851115 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java ## @@ -162,10 +162,9 @@ public Append addColumn(byte[] family,

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-03 Thread GitBox
huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r516851437 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -82,14 +84,18 @@ static String

[jira] [Resolved] (HBASE-25210) RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

2020-11-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25210. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to

[GitHub] [hbase] saintstack merged pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

2020-11-03 Thread GitBox
saintstack merged pull request #2580: URL: https://github.com/apache/hbase/pull/2580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HBASE-25181) Configure hash algorithm in wrapped encryption keys

2020-11-03 Thread Mate Szalay-Beko (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mate Szalay-Beko updated HBASE-25181: - Description: Currently we are using MD5 hash algorithm to store a hash for encryption

[jira] [Commented] (HBASE-24200) Upgrade to Yetus 0.12.0

2020-11-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225558#comment-17225558 ] Hudson commented on HBASE-24200: Results for branch branch-2.3 [build #98 on

[jira] [Commented] (HBASE-25228) Delete dev-support/jenkins_precommit_jira_yetus.sh

2020-11-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225559#comment-17225559 ] Hudson commented on HBASE-25228: Results for branch branch-2.3 [build #98 on

[jira] [Resolved] (HBASE-24859) Optimize in-memory representation of mapreduce TableSplit objects

2020-11-03 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada resolved HBASE-24859. -- Fix Version/s: 2.3.4 2.2.7 2.4.0

  1   2   >