Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-744167021
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-744166399
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248737#comment-17248737
]
Xiaolin Ha commented on HBASE-25334:
I run branch-2 TestRSGroupsFallback.testFallbac
sunhelly opened a new pull request #2775:
URL: https://github.com/apache/hbase/pull/2775
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-25334:
---
Attachment: 1607918235175-image.png
> TestRSGroupsFallback.testFallback is flaky
> -
infraio commented on pull request #2772:
URL: https://github.com/apache/hbase/pull/2772#issuecomment-744123579
> > This needs a thorough check. When we write to Hfile stream, if the top
level says write tags as true, we have to write the tags length even if it is
0. In a stream we might wr
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248648#comment-17248648
]
Michael Stack commented on HBASE-25334:
---
Looks like I did a bad job backporting...
Apache-HBase commented on pull request #2774:
URL: https://github.com/apache/hbase/pull/2774#issuecomment-743995993
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35
ramkrish86 commented on pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#issuecomment-743992180
`A Cell implementation that does lazy length caching internally? Then we'd
not need comparator knowing about implementation? What you think Ram?`
Caching everything internall
ramkrish86 commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r541903289
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
##
@@ -76,7 +77,7 @@
* length and actual tag bytes length.
*/
@Interf
ramkrish86 commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r541903216
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/ContiguousCellFormat.java
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software F
ramkrish86 commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r541903064
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java
##
@@ -51,35 +53,38 @@
*/
public static final CellCompar
ramkrish86 commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r541902661
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java
##
@@ -51,35 +53,38 @@
*/
public static final CellCompar
ramkrish86 commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r541902477
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyOnlyKeyValue.java
##
@@ -292,4 +287,49 @@ public long heapSize() {
}
ramkrish86 commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r541902443
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyOnlyKeyValue.java
##
@@ -292,4 +287,49 @@ public long heapSize() {
}
ramkrish86 commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r541902122
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyOnlyKeyValue.java
##
@@ -161,11 +161,11 @@ private int getTimestampOffset(
cuibo01 closed pull request #2774:
URL: https://github.com/apache/hbase/pull/2774
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Apache-HBase commented on pull request #2767:
URL: https://github.com/apache/hbase/pull/2767#issuecomment-743979502
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m 55s
Apache-HBase commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-743975832
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 10s
19 matches
Mail list logo
