infraio commented on a change in pull request #2663:
URL: https://github.com/apache/hbase/pull/2663#discussion_r543113766
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##
@@ -130,6 +132,13 @@
*/
public static final Strin
Apache9 commented on pull request #2748:
URL: https://github.com/apache/hbase/pull/2748#issuecomment-745112571
Any other concerns? @saintstack
Thanks.
This is an automated message from the Apache Git Service.
To respo
ramkrish86 commented on pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#issuecomment-745111755
Sure Stack let me close this. But before that I will ensure I read all your
comments and address them in the other PR including some profiling.
--
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249534#comment-17249534
]
ramkrishna.s.vasudevan commented on HBASE-24850:
bq.Can we have compare(
Apache-HBase commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745110530
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249533#comment-17249533
]
ramkrishna.s.vasudevan commented on HBASE-24850:
The branching and the p
Apache9 commented on pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#issuecomment-745110067
What about just add a flag in report duty to tell master whether the region
server is ready to take regions?
This
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249532#comment-17249532
]
ramkrishna.s.vasudevan commented on HBASE-24850:
bq.I thought BBKV was d
Apache-HBase commented on pull request #2766:
URL: https://github.com/apache/hbase/pull/2766#issuecomment-745106747
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49
ramkrish86 commented on a change in pull request #2663:
URL: https://github.com/apache/hbase/pull/2663#discussion_r543102351
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##
@@ -130,6 +132,13 @@
*/
public static final St
ramkrish86 commented on a change in pull request #2663:
URL: https://github.com/apache/hbase/pull/2663#discussion_r543101694
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##
@@ -728,7 +739,7 @@ public boolean next(List outResul
Apache9 commented on pull request #2779:
URL: https://github.com/apache/hbase/pull/2779#issuecomment-745103309
Please fix the checkstyle issue?
This is an automated message from the Apache Git Service.
To respond to the messa
sandeepvinayak commented on a change in pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#discussion_r543090129
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -64,6 +65,9 @@
public st
sandeepvinayak commented on a change in pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#discussion_r543090129
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -64,6 +65,9 @@
public st
bharathv commented on a change in pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#discussion_r543078007
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -64,6 +65,9 @@
public static f
sandeepvinayak commented on a change in pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#discussion_r543074326
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -455,36 +458,45 @@ public s
virajjasani commented on pull request #2756:
URL: https://github.com/apache/hbase/pull/2756#issuecomment-745070903
> @virajjasani Good by you sir?
All good sir. I just looked at Jira conversations and it seems this is not
breaking data compatibility (good to know) but this PR can be
Apache-HBase commented on pull request #2779:
URL: https://github.com/apache/hbase/pull/2779#issuecomment-745056148
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-745055055
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37
sandeepvinayak commented on a change in pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#discussion_r543049473
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -455,36 +458,45 @@ public s
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-745047990
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37
Apache-HBase commented on pull request #2768:
URL: https://github.com/apache/hbase/pull/2768#issuecomment-745047603
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-745047579
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-745047006
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38
Apache-HBase commented on pull request #2768:
URL: https://github.com/apache/hbase/pull/2768#issuecomment-745046853
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s
cuibo01 opened a new pull request #2779:
URL: https://github.com/apache/hbase/pull/2779
…ication default value is true, we don't use ) causes logcleaner can not
clean oldWALs, which resulits in oldWALs too large (more than 2TB)
-
cuibo01 closed pull request #2774:
URL: https://github.com/apache/hbase/pull/2774
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
anoopsjohn commented on pull request #2772:
URL: https://github.com/apache/hbase/pull/2772#issuecomment-745040994
Checking all related parts. Will report back.. Pls dont merge. I saw some
diff from branch2.1 where it was tags len based write(as in patch) .. may be in
master its changed.
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-745039560
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 28
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-745039226
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-745038941
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249465#comment-17249465
]
Xiaolin Ha edited comment on HBASE-25334 at 12/15/20, 3:54 AM:
---
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249465#comment-17249465
]
Xiaolin Ha commented on HBASE-25334:
[~stack] Yes, they are the same reason. They ne
infraio commented on a change in pull request #2663:
URL: https://github.com/apache/hbase/pull/2663#discussion_r543015759
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##
@@ -728,7 +739,7 @@ public boolean next(List outResult,
infraio commented on a change in pull request #2663:
URL: https://github.com/apache/hbase/pull/2663#discussion_r543015308
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##
@@ -130,6 +132,13 @@
*/
public static final Strin
infraio commented on pull request #2772:
URL: https://github.com/apache/hbase/pull/2772#issuecomment-745014773
So this should be a bug. Any thoughts @anoopsjohn
This is an automated message from the Apache Git Service.
To re
Apache-HBase commented on pull request #2768:
URL: https://github.com/apache/hbase/pull/2768#issuecomment-745012173
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249445#comment-17249445
]
Anoop Sam John commented on HBASE-24850:
[~ram_krish] As per the perf test anal
Apache-HBase commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745010105
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s
nyl3532016 commented on a change in pull request #2741:
URL: https://github.com/apache/hbase/pull/2741#discussion_r542993866
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
##
@@ -380,143 +378,146 @@ public static Cell getMidpoint
Apache-HBase commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-744848653
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 54
GeorryHuang commented on pull request #2772:
URL: https://github.com/apache/hbase/pull/2772#issuecomment-744808656
> So only TagRewriteCell forgot the check of tags.length? Can yuu paste some
code to show this. Thanks.
>
> And the HBase QA failed. Please take a look about this.
shahrs87 commented on pull request #2766:
URL: https://github.com/apache/hbase/pull/2766#issuecomment-744729370
The failing test
org.apache.hadoop.hbase.replication.TestVerifyReplicationAdjunct passed
locally.
```
[INFO]
[INFO] ---
Apache-HBase commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-744721253
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38
Apache-HBase commented on pull request #2766:
URL: https://github.com/apache/hbase/pull/2766#issuecomment-744720727
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 13s
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-744710565
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 12
sandeepvinayak commented on a change in pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#discussion_r542772730
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -455,36 +458,45 @@ public s
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-744702928
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31
gjacoby126 commented on a change in pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#discussion_r542727432
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -455,36 +458,45 @@ public stati
Apache-HBase commented on pull request #2776:
URL: https://github.com/apache/hbase/pull/2776#issuecomment-744677054
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32
Apache-HBase commented on pull request #2776:
URL: https://github.com/apache/hbase/pull/2776#issuecomment-744670518
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s
Apache-HBase commented on pull request #2766:
URL: https://github.com/apache/hbase/pull/2766#issuecomment-744657689
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33
Apache-HBase commented on pull request #2767:
URL: https://github.com/apache/hbase/pull/2767#issuecomment-744653150
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 15s
saintstack commented on pull request #2759:
URL: https://github.com/apache/hbase/pull/2759#issuecomment-744644569
You going to put up new changes @huaxiangsun ?
This is an automated message from the Apache Git Service.
To re
saintstack commented on pull request #2756:
URL: https://github.com/apache/hbase/pull/2756#issuecomment-744643074
@virajjasani Good by you sir?
This is an automated message from the Apache Git Service.
To respond to the mess
saintstack commented on pull request #2753:
URL: https://github.com/apache/hbase/pull/2753#issuecomment-744640880
Ok. Still +1 on this @huaxiangsun
This is an automated message from the Apache Git Service.
To respond to the
saintstack commented on pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#issuecomment-744638945
@ramkrish86 Should we close this in favor of #2776 ?
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/HBASE-24754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-24754:
Fix Version/s: 2.5.0
3.0.0-alpha-1
> Bulk load performance is d
saintstack commented on a change in pull request #2742:
URL: https://github.com/apache/hbase/pull/2742#discussion_r542631191
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##
@@ -1015,17 +1016,17 @@ private void moveServerR
saintstack commented on pull request #2741:
URL: https://github.com/apache/hbase/pull/2741#issuecomment-744633516
@nyl3532016 You good w/ this change? If so, would like to add you as a
sign-off. Thanks.
This is an automated
saintstack closed pull request #2733:
URL: https://github.com/apache/hbase/pull/2733
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
saintstack commented on pull request #2733:
URL: https://github.com/apache/hbase/pull/2733#issuecomment-744631798
Manually merged. Closing
This is an automated message from the Apache Git Service.
To respond to the message, p
saintstack commented on pull request #2734:
URL: https://github.com/apache/hbase/pull/2734#issuecomment-744631562
Manually merged. Closing
This is an automated message from the Apache Git Service.
To respond to the message, p
saintstack closed pull request #2734:
URL: https://github.com/apache/hbase/pull/2734
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
saintstack commented on pull request #2776:
URL: https://github.com/apache/hbase/pull/2776#issuecomment-744631056
Be careful @ramkrish86 .. you are missing the JIRA from this PR summary.
This is an automated message from the
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-744630875
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33
Apache-HBase commented on pull request #2777:
URL: https://github.com/apache/hbase/pull/2777#issuecomment-744615469
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 27
saintstack commented on a change in pull request #2776:
URL: https://github.com/apache/hbase/pull/2776#discussion_r542594504
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
##
@@ -1396,7 +1403,14 @@ public int getQualifierOffset() {
* @return
Apache-HBase commented on pull request #2777:
URL: https://github.com/apache/hbase/pull/2777#issuecomment-744611861
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34
Apache-HBase commented on pull request #2777:
URL: https://github.com/apache/hbase/pull/2777#issuecomment-744611660
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30
[
https://issues.apache.org/jira/browse/HBASE-24791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249172#comment-17249172
]
Huaxiang Sun commented on HBASE-24791:
--
Sorry, was trying to watch and clicked "Ass
[
https://issues.apache.org/jira/browse/HBASE-24791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-24791:
Assignee: Yechao Chen (was: Huaxiang Sun)
> Improve HFileOutputFormat2 to avoid always c
[
https://issues.apache.org/jira/browse/HBASE-24791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-24791:
Assignee: Huaxiang Sun (was: Yechao Chen)
> Improve HFileOutputFormat2 to avoid always c
Apache-HBase commented on pull request #2776:
URL: https://github.com/apache/hbase/pull/2776#issuecomment-744608307
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 13
[
https://issues.apache.org/jira/browse/HBASE-25383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandeep Pal updated HBASE-25383:
Description:
Currently, we cannot update the peer-based config even if we change the value
of the
sandeepvinayak opened a new pull request #2778:
URL: https://github.com/apache/hbase/pull/2778
Currently, we cannot update the peer based config even if we change the
value of config.
Secondly, once the configuration is added, there is not smooth way to remove
the peer config.
This
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249154#comment-17249154
]
Michael Stack edited comment on HBASE-25334 at 12/14/20, 5:39 PM:
Tak-Lon (Stephen) Wu created HBASE-25399:
Summary: Write HBCK tools to rebuild the tracking
Key: HBASE-25399
URL: https://issues.apache.org/jira/browse/HBASE-25399
Project: HBase
Issu
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249154#comment-17249154
]
Michael Stack commented on HBASE-25334:
---
[~Xiaolin Ha] is the failure like that in
Tak-Lon (Stephen) Wu created HBASE-25398:
Summary: Cleanup unused/unneeded temporarily HFiles
Key: HBASE-25398
URL: https://issues.apache.org/jira/browse/HBASE-25398
Project: HBase
I
Tak-Lon (Stephen) Wu created HBASE-25397:
Summary: Migrate hbase:storefile system table into editable meta
Key: HBASE-25397
URL: https://issues.apache.org/jira/browse/HBASE-25397
Project: HBase
Tak-Lon (Stephen) Wu created HBASE-25396:
Summary: Integtration with Direct insert into data/cf directory
Key: HBASE-25396
URL: https://issues.apache.org/jira/browse/HBASE-25396
Project: HBase
Tak-Lon (Stephen) Wu created HBASE-25395:
Summary: Introduce PersistedStoreEngine and
PersistedStoreFileManager
Key: HBASE-25395
URL: https://issues.apache.org/jira/browse/HBASE-25395
Project
[
https://issues.apache.org/jira/browse/HBASE-25318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mate Szalay-Beko updated HBASE-25318:
-
Description:
Currently IntegrationTestImportTsv is generating HFiles under the working
[
https://issues.apache.org/jira/browse/HBASE-25318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-25318 started by Mate Szalay-Beko.
> Configure where IntegrationTestImportTsv generates HFiles
> -
symat opened a new pull request #2777:
URL: https://github.com/apache/hbase/pull/2777
Currently IntegrationTestImportTsv is generating HFiles under the working
directory of the hdfs user executing the tool, before bulkloading it into HBase.
Assuming you encrypt the HBase root directo
[
https://issues.apache.org/jira/browse/HBASE-25318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mate Szalay-Beko updated HBASE-25318:
-
Summary: Configure where IntegrationTestImportTsv generates HFiles (was:
Config option
Tak-Lon (Stephen) Wu created HBASE-25394:
Summary: Support Snapshot related operation with direct insert
HFiles into data/CF directory
Key: HBASE-25394
URL: https://issues.apache.org/jira/browse/HBASE-2539
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249144#comment-17249144
]
Xiaolin Ha commented on HBASE-25334:
Oh, in the CI test result that [~stack] attache
Tak-Lon (Stephen) Wu created HBASE-25393:
Summary: Support split and merge region with direct insert into CF
directory
Key: HBASE-25393
URL: https://issues.apache.org/jira/browse/HBASE-25393
P
Tak-Lon (Stephen) Wu created HBASE-25392:
Summary: Direct insert compacted HFiles into data directory.
Key: HBASE-25392
URL: https://issues.apache.org/jira/browse/HBASE-25392
Project: HBase
Tak-Lon (Stephen) Wu created HBASE-25391:
Summary: Flush directly into data directory, skip rename when
committing flush
Key: HBASE-25391
URL: https://issues.apache.org/jira/browse/HBASE-25391
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249134#comment-17249134
]
Michael Stack commented on HBASE-24850:
---
I thought BBKV was default in branch-2? S
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-744581079
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-744579367
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35
Apache-HBase commented on pull request #2775:
URL: https://github.com/apache/hbase/pull/2775#issuecomment-744577308
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35
saintstack commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r542540107
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/ContiguousCellFormat.java
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software F
saintstack commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r542538789
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java
##
@@ -51,35 +53,38 @@
*/
public static final CellCompar
saintstack commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r542537865
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyOnlyKeyValue.java
##
@@ -292,4 +287,49 @@ public long heapSize() {
}
Apache-HBase commented on pull request #2766:
URL: https://github.com/apache/hbase/pull/2766#issuecomment-744567696
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32
1 - 100 of 144 matches
Mail list logo
