pankaj72981 commented on a change in pull request #2757:
URL: https://github.com/apache/hbase/pull/2757#discussion_r544084954
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##
@@ -2436,10 +2442,8 @@ public boolean
Apache-HBase commented on pull request #2781:
URL: https://github.com/apache/hbase/pull/2781#issuecomment-745855626
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Apache-HBase commented on pull request #2776:
URL: https://github.com/apache/hbase/pull/2776#issuecomment-745854947
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
ramkrish86 commented on a change in pull request #2663:
URL: https://github.com/apache/hbase/pull/2663#discussion_r544080617
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##
@@ -130,6 +132,13 @@
*/
public static final
ramkrish86 commented on a change in pull request #2757:
URL: https://github.com/apache/hbase/pull/2757#discussion_r544077373
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##
@@ -2436,10 +2442,8 @@ public boolean
sandeepvinayak commented on a change in pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#discussion_r544037912
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java
##
@@ -200,8 +198,8 @@ public void
Apache-HBase commented on pull request #2743:
URL: https://github.com/apache/hbase/pull/2743#issuecomment-745802752
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2743:
URL: https://github.com/apache/hbase/pull/2743#issuecomment-745801283
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #2743:
URL: https://github.com/apache/hbase/pull/2743#issuecomment-745798099
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2742:
URL: https://github.com/apache/hbase/pull/2742#issuecomment-745793465
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-25365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250119#comment-17250119
]
Baiqiang Zhao commented on HBASE-25365:
---
The PR for branch-2 has been uploaded, please review
Apache9 commented on pull request #2748:
URL: https://github.com/apache/hbase/pull/2748#issuecomment-745783187
Thank you. Let me create a feature branch to land this change.
This is an automated message from the Apache Git
huaxiangsun commented on pull request #2759:
URL: https://github.com/apache/hbase/pull/2759#issuecomment-745782832
> You going to put up new changes @huaxiangsun ?
Yeah, I am going to put up a new patch.
This is an
huaxiangsun merged pull request #2753:
URL: https://github.com/apache/hbase/pull/2753
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
huaxiangsun commented on a change in pull request #2781:
URL: https://github.com/apache/hbase/pull/2781#discussion_r543993675
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java
##
@@ -102,6 +102,7 @@ public void
huaxiangsun merged pull request #2768:
URL: https://github.com/apache/hbase/pull/2768
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bharathv commented on a change in pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#discussion_r543981842
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -454,37 +453,39 @@ public static
Apache-HBase commented on pull request #2781:
URL: https://github.com/apache/hbase/pull/2781#issuecomment-745776836
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-24754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250107#comment-17250107
]
ramkrishna.s.vasudevan commented on HBASE-24754:
[~stack]
What needs to be done from
Apache-HBase commented on pull request #2762:
URL: https://github.com/apache/hbase/pull/2762#issuecomment-745771727
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250105#comment-17250105
]
ramkrishna.s.vasudevan commented on HBASE-24850:
bq.Lets get this JIRA landed. Next
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250103#comment-17250103
]
ramkrishna.s.vasudevan commented on HBASE-24850:
Attached two inlining output generated
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250104#comment-17250104
]
ramkrishna.s.vasudevan commented on HBASE-24850:
[~stack] - fyi.
> CellComparator perf
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-24850:
---
Attachment: flamegraph_opt.svg
> CellComparator perf improvement
>
[
https://issues.apache.org/jira/browse/HBASE-25334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250101#comment-17250101
]
Michael Stack commented on HBASE-25334:
---
Running w/ your new PR. It looks good. Let me get some
Apache-HBase commented on pull request #2742:
URL: https://github.com/apache/hbase/pull/2742#issuecomment-745766940
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-24850:
---
Attachment: flamegraph.svg
> CellComparator perf improvement
>
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-24850:
---
Attachment: op_withopt
op_withnoopt
> CellComparator perf
saintstack opened a new pull request #2781:
URL: https://github.com/apache/hbase/pull/2781
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Michael Stack created HBASE-25400:
-
Summary: [Flakey Tests] branch-2 TestRegionMoveAndAbandon
Key: HBASE-25400
URL: https://issues.apache.org/jira/browse/HBASE-25400
Project: HBase
Issue
saintstack commented on pull request #2748:
URL: https://github.com/apache/hbase/pull/2748#issuecomment-745761294
We have to remove htrace. A noop OTel seems fine replacement. At least if no
uptake, it doesn't get in the way. +1
[
https://issues.apache.org/jira/browse/HBASE-25365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25365.
---
Fix Version/s: 3.0.0-alpha-1
Hadoop Flags: Reviewed
Resolution: Fixed
Merged to
saintstack merged pull request #2742:
URL: https://github.com/apache/hbase/pull/2742
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Apache-HBase commented on pull request #2742:
URL: https://github.com/apache/hbase/pull/2742#issuecomment-745733390
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
caroliney14 commented on a change in pull request #2762:
URL: https://github.com/apache/hbase/pull/2762#discussion_r543848809
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##
@@ -3549,11 +3554,24 @@ public void
caroliney14 commented on a change in pull request #2762:
URL: https://github.com/apache/hbase/pull/2762#discussion_r543848809
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##
@@ -3549,11 +3554,24 @@ public void
caroliney14 commented on a change in pull request #2762:
URL: https://github.com/apache/hbase/pull/2762#discussion_r543846000
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##
@@ -3549,11 +3554,24 @@ public void
caroliney14 commented on a change in pull request #2762:
URL: https://github.com/apache/hbase/pull/2762#discussion_r543844166
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##
@@ -3549,11 +3554,24 @@ public void
caroliney14 commented on a change in pull request #2762:
URL: https://github.com/apache/hbase/pull/2762#discussion_r543842413
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##
@@ -3549,11 +3554,24 @@ public void
caroliney14 commented on pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#issuecomment-745713635
@Apache9 There is already an `online` flag which is set in the RS after RS
finishes all its setup work in `handleReportForDuty`, which essentially does
what you are
Apache9 commented on pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#issuecomment-745710484
> @Apache9 Okay I see. So you are suggesting a background task in RS instead
of in Master. That will also require new RPC logic in Master. I am not sure if
there is much of a
caroliney14 commented on pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#issuecomment-745709824
@Apache9 Okay I see. So you are suggesting a background task in RS instead
of in Master. That will also require new RPC logic in Master. I am not sure if
there is much of a
Apache9 commented on pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#issuecomment-745706784
Oh, what I mean is the periodical report from RS to master, maybe it is
called regionServerReport? FWIW, I think it will be better to let the region
server tell master directly,
caroliney14 commented on pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#issuecomment-745705944
@Apache9 At the time of `reportForDuty`, there is no way to know whether RS
is ready to take regions. After Master acknowledges the `reportForDuty` and
sends the response
darocaro removed a comment on pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#issuecomment-745705575
@Apache9 At the time of `reportForDuty`, there is no way to know whether RS
is ready to take regions. After Master acknowledges the `reportForDuty` and
sends the
darocaro commented on pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#issuecomment-745705575
@Apache9 At the time of `reportForDuty`, there is no way to know whether RS
is ready to take regions. After Master acknowledges the `reportForDuty` and
sends the response back
[
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250035#comment-17250035
]
Caroline commented on HBASE-25032:
--
[~anoop.hbase] Once Master acknowledges the reportForDuty and sends
Apache9 commented on pull request #2748:
URL: https://github.com/apache/hbase/pull/2748#issuecomment-745689175
> I don't seem to be able to find the "In-Memory Exporter: keeps the data in
memory, useful for debugging." in the OTel codebase (need to look harder I
suppose) Hopefully its a
Apache-HBase commented on pull request #2768:
URL: https://github.com/apache/hbase/pull/2768#issuecomment-745586788
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2768:
URL: https://github.com/apache/hbase/pull/2768#issuecomment-745585012
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2768:
URL: https://github.com/apache/hbase/pull/2768#issuecomment-745523009
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745490807
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pankaj Kumar updated HBASE-25378:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Legacy comparator in Hfile
[
https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pankaj Kumar updated HBASE-25378:
-
Fix Version/s: (was: 2.3.4)
> Legacy comparator in Hfile trailer will fail to load
>
[
https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249857#comment-17249857
]
Pankaj Kumar commented on HBASE-25378:
--
Pushed to master & branch-2. Thanks everyone for the
pankaj72981 merged pull request #2756:
URL: https://github.com/apache/hbase/pull/2756
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249838#comment-17249838
]
Michael Stack commented on HBASE-24850:
---
bq. When we use a file system based cache even there is i
[
https://issues.apache.org/jira/browse/HBASE-25389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25389.
---
Fix Version/s: 2.4.1
2.5.0
3.0.0-alpha-1
Hadoop
saintstack merged pull request #2773:
URL: https://github.com/apache/hbase/pull/2773
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Apache-HBase commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745455904
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2767:
URL: https://github.com/apache/hbase/pull/2767#issuecomment-745450995
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
wchevreuil commented on a change in pull request #79:
URL:
https://github.com/apache/hbase-operator-tools/pull/79#discussion_r543538474
##
File path:
hbase-hbck2/src/main/java/org/apache/hbase/MissingTableDescriptorGenerator.java
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the
Apache-HBase commented on pull request #79:
URL:
https://github.com/apache/hbase-operator-tools/pull/79#issuecomment-745404212
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: |
saintstack commented on pull request #2748:
URL: https://github.com/apache/hbase/pull/2748#issuecomment-745400931
I don't seem to be able to find the "In-Memory Exporter: keeps the data in
memory, useful for debugging." in the OTel codebase (need to look harder I
suppose) Hopefully its a
symat opened a new pull request #79:
URL: https://github.com/apache/hbase-operator-tools/pull/79
We have been in a situation, when we saw many ServerCrashProcedure to be
blocked, because of the AssignProcedure is blocked because of the missing
.tabledesc files.
```
saintstack commented on a change in pull request #2742:
URL: https://github.com/apache/hbase/pull/2742#discussion_r543478935
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##
@@ -1015,17 +1016,17 @@ private void
[
https://issues.apache.org/jira/browse/HBASE-25297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-25297 started by Mate Szalay-Beko.
> [HBCK2] Regenerate missing table descriptors by hbck2
>
Apache-HBase commented on pull request #2780:
URL: https://github.com/apache/hbase/pull/2780#issuecomment-745380362
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
ZhaoBQ commented on a change in pull request #2742:
URL: https://github.com/apache/hbase/pull/2742#discussion_r543456800
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##
@@ -1015,17 +1016,17 @@ private void
Apache-HBase commented on pull request #2780:
URL: https://github.com/apache/hbase/pull/2780#issuecomment-745370550
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745351141
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
shahrs87 commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745339881
TestIncrementalBackupWithBulkLoad succeeds locally.
```
[INFO] ---
[INFO] T E S T S
[INFO]
shahrs87 removed a comment on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745331709
TestIncrementalBackup succeeds locally
```
[INFO] ---
[INFO] T E S T S
[INFO]
shahrs87 commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745331709
TestIncrementalBackup succeeds locally
```
[INFO] ---
[INFO] T E S T S
[INFO]
virajjasani commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745296200
@shahrs87 `TestIncrementalBackupWithBulkLoad` looks suspicious, it's
throwing NPE for the past 2 builds:
Apache-HBase commented on pull request #2780:
URL: https://github.com/apache/hbase/pull/2780#issuecomment-745285722
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
sanjeetnishad95 opened a new pull request #2780:
URL: https://github.com/apache/hbase/pull/2780
…present.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Apache-HBase commented on pull request #2766:
URL: https://github.com/apache/hbase/pull/2766#issuecomment-745253592
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-745235770
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-745235437
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2767:
URL: https://github.com/apache/hbase/pull/2767#issuecomment-745206880
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2745:
URL: https://github.com/apache/hbase/pull/2745#issuecomment-745189438
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-745166963
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-25130 started by Rahul Kumar.
---
> Masters in-memory serverHoldings map is not cleared during hbck repair
>
ramkrish86 commented on a change in pull request #2663:
URL: https://github.com/apache/hbase/pull/2663#discussion_r543167155
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##
@@ -130,6 +132,13 @@
*/
public static final
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-745143339
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-745142386
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-745140675
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
88 matches
Mail list logo
