[GitHub] [hbase] Apache-HBase commented on pull request #2794: HBASE-25423 Support dynamic update configurations about HTrace

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2794: URL: https://github.com/apache/hbase/pull/2794#issuecomment-748575436 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache9 commented on pull request #2790: HBASE-25401 Add trace support for async call in rpc client

2020-12-19 Thread GitBox
Apache9 commented on pull request #2790: URL: https://github.com/apache/hbase/pull/2790#issuecomment-748573504 PTAL @saintstack This patch shows how we pass Span across different threads, and also how to propagate it through RPC. And also added a UT to confirm that the above

[GitHub] [hbase] sunhelly opened a new pull request #2794: HBASE-25423 Support dynamic update configurations about HTrace

2020-12-19 Thread GitBox
sunhelly opened a new pull request #2794: URL: https://github.com/apache/hbase/pull/2794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Created] (HBASE-25423) Support dynamic update configurations about HTrace

2020-12-19 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-25423: -- Summary: Support dynamic update configurations about HTrace Key: HBASE-25423 URL: https://issues.apache.org/jira/browse/HBASE-25423 Project: HBase Issue Type: Im

[jira] [Updated] (HBASE-25419) Remove deprecated methods in RpcServer implementation

2020-12-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25419: -- Release Note: Removed all the call methods except call(RpcCall, MonitoredRPCHandler) in RpcServerInter

[jira] [Updated] (HBASE-25422) update_all_config should not be executed by non-admin user!!!

2020-12-19 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25422: -- Priority: Critical (was: Major) > update_all_config should not be executed by non-admin user!!! > ---

[jira] [Updated] (HBASE-25422) update_all_config should not be executed by non-admin user!!!

2020-12-19 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25422: -- Summary: update_all_config should not be executed by non-admin user!!! (was: update_all_config can be execute

[jira] [Created] (HBASE-25422) update_all_config can be executed by non-admin user

2020-12-19 Thread lujie (Jira)
lujie created HBASE-25422: - Summary: update_all_config can be executed by non-admin user Key: HBASE-25422 URL: https://issues.apache.org/jira/browse/HBASE-25422 Project: HBase Issue Type: Bug

[GitHub] [hbase] Apache-HBase commented on pull request #2003: HBASE-24633 Remove data locality and StoreFileCostFunction for replic…

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2003: URL: https://github.com/apache/hbase/pull/2003#issuecomment-748560768 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #2003: HBASE-24633 Remove data locality and StoreFileCostFunction for replic…

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2003: URL: https://github.com/apache/hbase/pull/2003#issuecomment-748560749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] Apache-HBase commented on pull request #2791: HBASE-25419 Remove deprecated methods in RpcServer implementation

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2791: URL: https://github.com/apache/hbase/pull/2791#issuecomment-748559947 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 52s

[GitHub] [hbase] Apache-HBase commented on pull request #2791: HBASE-25419 Remove deprecated methods in RpcServer implementation

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2791: URL: https://github.com/apache/hbase/pull/2791#issuecomment-748559874 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 46s

[jira] [Resolved] (HBASE-25419) Remove deprecated methods in RpcServer implementation

2020-12-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25419. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~stack] and [~Ddupg] for r

[GitHub] [hbase] Apache-HBase commented on pull request #2791: HBASE-25419 Remove deprecated methods in RpcServer implementation

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2791: URL: https://github.com/apache/hbase/pull/2791#issuecomment-748559719 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s

[GitHub] [hbase] Apache9 merged pull request #2791: HBASE-25419 Remove deprecated methods in RpcServer implementation

2020-12-19 Thread GitBox
Apache9 merged pull request #2791: URL: https://github.com/apache/hbase/pull/2791 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache9 commented on pull request #2793: HBASE-25421 There is no limit on the column length when creating a table

2020-12-19 Thread GitBox
Apache9 commented on pull request #2793: URL: https://github.com/apache/hbase/pull/2793#issuecomment-748558878 Please open a PR against master branch? Thanks. This is an automated message from the Apache Git Service. T

[jira] [Updated] (HBASE-25421) There is no limit on the column length when creating a table

2020-12-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25421: -- Fix Version/s: 2.5.0 > There is no limit on the column length when creating a table >

[jira] [Resolved] (HBASE-25420) Some minor improvements in rpc implementation

2020-12-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25420. --- Fix Version/s: 2.4.1 2.5.0 2.3.4 3.0.0-alpha

[jira] [Updated] (HBASE-25420) Some minor improvements in rpc implementation

2020-12-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25420: -- Priority: Minor (was: Major) > Some minor improvements in rpc implementation > --

[GitHub] [hbase] Apache9 merged pull request #2792: HBASE-25420 Some minor improvements in rpc implementation

2020-12-19 Thread GitBox
Apache9 merged pull request #2792: URL: https://github.com/apache/hbase/pull/2792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache9 commented on a change in pull request #2792: HBASE-25420 Some minor improvements in rpc implementation

2020-12-19 Thread GitBox
Apache9 commented on a change in pull request #2792: URL: https://github.com/apache/hbase/pull/2792#discussion_r546314334 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.java ## @@ -103,8 +103,8 @@ private void writeRequest(ChannelHan

[GitHub] [hbase] Apache9 commented on a change in pull request #2792: HBASE-25420 Some minor improvements in rpc implementation

2020-12-19 Thread GitBox
Apache9 commented on a change in pull request #2792: URL: https://github.com/apache/hbase/pull/2792#discussion_r546314207 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.java ## @@ -103,8 +103,8 @@ private void writeRequest(ChannelHan

[GitHub] [hbase] saintstack commented on pull request #2729: Remove the use of term segregate

2020-12-19 Thread GitBox
saintstack commented on pull request #2729: URL: https://github.com/apache/hbase/pull/2729#issuecomment-748547958 Patch is also incomplete needs some more work done ``` $ grep -ri segregate hbase-*/src hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeLo

[GitHub] [hbase] Apache-HBase commented on pull request #2793: HBASE-25421 There is no limit on the column length when creating a table

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2793: URL: https://github.com/apache/hbase/pull/2793#issuecomment-748547145 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s

[GitHub] [hbase] lidingshengHHU opened a new pull request #2793: HBASE-25421 There is no limit on the column length when creating a table

2020-12-19 Thread GitBox
lidingshengHHU opened a new pull request #2793: URL: https://github.com/apache/hbase/pull/2793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Created] (HBASE-25421) There is no limit on the column length when creating a table

2020-12-19 Thread LiDingSheng (Jira)
LiDingSheng created HBASE-25421: --- Summary: There is no limit on the column length when creating a table Key: HBASE-25421 URL: https://issues.apache.org/jira/browse/HBASE-25421 Project: HBase I

[jira] [Commented] (HBASE-25368) Filter out more invalid encoded name in isEncodedRegionName(byte[] regionName)

2020-12-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252292#comment-17252292 ] Hudson commented on HBASE-25368: Results for branch master [build #161 on build

[jira] [Commented] (HBASE-25356) HBaseAdmin#getRegion() needs to filter out non-regionName and non-encodedRegionName

2020-12-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252290#comment-17252290 ] Hudson commented on HBASE-25356: Results for branch branch-2.3 [build #126 on b

[jira] [Resolved] (HBASE-25404) Procedures table Id under master web UI gets word break to single character

2020-12-19 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25404. --- Fix Version/s: 2.4.1 2.3.4 3.0.0-alpha-1 Hadoop Fl

[GitHub] [hbase] saintstack merged pull request #2783: HBASE-25404 Procedures table Id under master web UI gets word break to single character

2020-12-19 Thread GitBox
saintstack merged pull request #2783: URL: https://github.com/apache/hbase/pull/2783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack commented on a change in pull request #2784: [PATCH] Add "regexstringnocase" to ParseFilter for case-insensitivity

2020-12-19 Thread GitBox
saintstack commented on a change in pull request #2784: URL: https://github.com/apache/hbase/pull/2784#discussion_r546279930 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java ## @@ -244,6 +244,13 @@ public static final byte [] regex

[jira] [Commented] (HBASE-25356) HBaseAdmin#getRegion() needs to filter out non-regionName and non-encodedRegionName

2020-12-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252263#comment-17252263 ] Hudson commented on HBASE-25356: Results for branch branch-2.4 [build #12 on bu

[jira] [Commented] (HBASE-25293) Followup jira to address the client handling issue when chaning from meta replica to non-meta-replica at the server side.

2020-12-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252262#comment-17252262 ] Hudson commented on HBASE-25293: Results for branch branch-2.4 [build #12 on bu

[GitHub] [hbase] saintstack commented on a change in pull request #2785: HBASE-25371: When openRegion fails during initial verification(before…

2020-12-19 Thread GitBox
saintstack commented on a change in pull request #2785: URL: https://github.com/apache/hbase/pull/2785#discussion_r546277864 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java ## @@ -135,4 +139,36 @@ public void testNonExistentReg

[GitHub] [hbase] saintstack commented on a change in pull request #2792: HBASE-25420 Some minor improvements in rpc implementation

2020-12-19 Thread GitBox
saintstack commented on a change in pull request #2792: URL: https://github.com/apache/hbase/pull/2792#discussion_r546268987 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.java ## @@ -103,8 +103,8 @@ private void writeRequest(Channel

[jira] [Commented] (HBASE-25293) Followup jira to address the client handling issue when chaning from meta replica to non-meta-replica at the server side.

2020-12-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252251#comment-17252251 ] Hudson commented on HBASE-25293: Results for branch branch-2 [build #132 on bui

[GitHub] [hbase] saintstack commented on a change in pull request #2776: Using ContiguousCellFormat as a marker alone

2020-12-19 Thread GitBox
saintstack commented on a change in pull request #2776: URL: https://github.com/apache/hbase/pull/2776#discussion_r546265019 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java ## @@ -920,6 +930,14 @@ public static boolean matchingColumn(final Cell le

[GitHub] [hbase] saintstack commented on a change in pull request #2776: Using ContiguousCellFormat as a marker alone

2020-12-19 Thread GitBox
saintstack commented on a change in pull request #2776: URL: https://github.com/apache/hbase/pull/2776#discussion_r546259601 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java ## @@ -125,38 +442,174 @@ public final int compareFamilies(Cell

[GitHub] [hbase] saintstack commented on a change in pull request #2776: Using ContiguousCellFormat as a marker alone

2020-12-19 Thread GitBox
saintstack commented on a change in pull request #2776: URL: https://github.com/apache/hbase/pull/2776#discussion_r546259482 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java ## @@ -57,29 +57,287 @@ public final int compare(final Cell a,

[GitHub] [hbase] saintstack commented on a change in pull request #2776: Using ContiguousCellFormat as a marker alone

2020-12-19 Thread GitBox
saintstack commented on a change in pull request #2776: URL: https://github.com/apache/hbase/pull/2776#discussion_r546259202 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java ## @@ -1598,16 +1621,21 @@ public static boolean matchingRows(final Cell l

[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-748495765 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s

[GitHub] [hbase] Apache-HBase commented on pull request #2791: HBASE-25419 Remove deprecated methods in RpcServer implementation

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2791: URL: https://github.com/apache/hbase/pull/2791#issuecomment-748487447 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] Apache-HBase commented on pull request #2792: HBASE-25420 Some minor improvements in rpc implementation

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2792: URL: https://github.com/apache/hbase/pull/2792#issuecomment-748487206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #2791: HBASE-25419 Remove deprecated methods in RpcServer implementation

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2791: URL: https://github.com/apache/hbase/pull/2791#issuecomment-748486719 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 3s

[GitHub] [hbase] Apache-HBase commented on pull request #2792: HBASE-25420 Some minor improvements in rpc implementation

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2792: URL: https://github.com/apache/hbase/pull/2792#issuecomment-748486658 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-748478846 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 1

[GitHub] [hbase] Apache-HBase commented on pull request #2792: HBASE-25420 Some minor improvements in rpc implementation

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2792: URL: https://github.com/apache/hbase/pull/2792#issuecomment-748473316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[jira] [Commented] (HBASE-25383) HBase doesn't update and remove the peer config from hbase.replication.source.custom.walentryfilters if the config is already set on the peer.

2020-12-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252181#comment-17252181 ] Hudson commented on HBASE-25383: Results for branch master [build #160 on build

[GitHub] [hbase] Apache-HBase commented on pull request #2791: HBASE-25419 Remove deprecated methods in RpcServer implementation

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2791: URL: https://github.com/apache/hbase/pull/2791#issuecomment-748471567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15

[jira] [Commented] (HBASE-25368) Filter out more invalid encoded name in isEncodedRegionName(byte[] regionName)

2020-12-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252175#comment-17252175 ] Duo Zhang commented on HBASE-25368: --- This breaks TestAdmin2.testCloseRegionIfInvalidRe

[GitHub] [hbase] Apache9 opened a new pull request #2792: HBASE-25420 Some minor improvements in rpc implementation

2020-12-19 Thread GitBox
Apache9 opened a new pull request #2792: URL: https://github.com/apache/hbase/pull/2792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2790: HBASE-25401 Add trace support for async call in rpc client

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2790: URL: https://github.com/apache/hbase/pull/2790#issuecomment-748467060 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[jira] [Created] (HBASE-25420) Some minor improvements in rpc implementation

2020-12-19 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25420: - Summary: Some minor improvements in rpc implementation Key: HBASE-25420 URL: https://issues.apache.org/jira/browse/HBASE-25420 Project: HBase Issue Type: Improveme

[GitHub] [hbase] Apache9 opened a new pull request #2791: HBASE-25419 Remove deprecated methods in RpcServer implementation

2020-12-19 Thread GitBox
Apache9 opened a new pull request #2791: URL: https://github.com/apache/hbase/pull/2791 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (HBASE-25419) Remove deprecated methods in RpcServer implementation

2020-12-19 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25419: - Summary: Remove deprecated methods in RpcServer implementation Key: HBASE-25419 URL: https://issues.apache.org/jira/browse/HBASE-25419 Project: HBase Issue Type: S

[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-748461507 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21

[GitHub] [hbase] Apache-HBase commented on pull request #2790: HBASE-25401 Add trace support for async call in rpc client

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2790: URL: https://github.com/apache/hbase/pull/2790#issuecomment-748454229 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s

[GitHub] [hbase] Apache-HBase commented on pull request #2790: HBASE-25401 Add trace support for async call in rpc client

2020-12-19 Thread GitBox
Apache-HBase commented on pull request #2790: URL: https://github.com/apache/hbase/pull/2790#issuecomment-748442223 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29