[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-752352381 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache9 merged pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
Apache9 merged pull request #2813: URL: https://github.com/apache/hbase/pull/2813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-752351807 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio commented on a change in pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
infraio commented on a change in pull request #2813: URL: https://github.com/apache/hbase/pull/2813#discussion_r549953052 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java ## @@ -218,50 +220,62 @@ private static Result

[jira] [Commented] (HBASE-25434) SlowDelete & SlowPut metric value should use updateDelete & updatePut

2020-12-29 Thread xijiawen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256318#comment-17256318 ] xijiawen commented on HBASE-25434: -- [~vjasani] the relate pr :

[jira] [Commented] (HBASE-25435) Slow metric value can be configured

2020-12-29 Thread xijiawen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256317#comment-17256317 ] xijiawen commented on HBASE-25435: -- @Viraj Jasani please review the pr ,thank you very much! > Slow

[jira] [Commented] (HBASE-25434) SlowDelete & SlowPut metric value should use updateDelete & updatePut

2020-12-29 Thread xijiawen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256316#comment-17256316 ] xijiawen commented on HBASE-25434: -- Thanks a lot,[~vjasani] please review the pr ! > SlowDelete &

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-752324065 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
Apache9 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752316984 > > I guess the problem is that, since you set ulimit to a very low value, once there is no new thred allowed, the 'kill' command itself can not be executed either... > >

[GitHub] [hbase] cuibo01 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752316846 > Could you please try other options to see if it works? i will continue to analyze. thank you @Apache9

[GitHub] [hbase] cuibo01 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752316659 > I guess the problem is that, since you set ulimit to a very low value, once there is no new thred allowed, the 'kill' command itself can not be executed either... if

[jira] [Resolved] (HBASE-25452) Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat

2020-12-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25452. --- Fix Version/s: 2.4.1 2.5.0 2.3.4

[GitHub] [hbase] Apache9 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
Apache9 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752314818 Could you please try other options to see if it works? This is an automated message from the Apache Git Service.

[GitHub] [hbase] cuibo01 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752314346 > I guess the problem is that, since you set ulimit to a very low value, once there is no new thred allowed, the 'kill' command itself can not be executed either... but I

[GitHub] [hbase] Apache9 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
Apache9 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752313702 https://www.codementor.io/@suryab/outofmemoryerror-related-jvm-arguments-w6e4vgipt This is an automated message

[GitHub] [hbase] Apache9 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
Apache9 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752313202 I guess the problem is that, since you set ulimit to a very low value, once there is no new thred allowed, the 'kill' command itself can not be executed either...

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-752312627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
Apache9 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752312107 So the problem is OnOutOfMemoryError flag does not work for "Unable to create new native thread"? This is an

[GitHub] [hbase] cuibo01 edited a comment on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 edited a comment on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752310671 i tested "unable to create new native thread" by "ulimit -u 100", but jvm didn't stop.. i tested '-XX:OnOutOfMemoryError="kill -9"' %p or

[GitHub] [hbase] cuibo01 edited a comment on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 edited a comment on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752310671 i tested "unable to create new native thread" by "ulimit -u 100", but jvm didn't stop.. i tested '-XX:OnOutOfMemoryError="kill -9"' %p or

[GitHub] [hbase] cuibo01 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752310671 i tested unable to "create new native thread" by "ulimit -u 100", but jvm didn't stop.. This is an automated

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2020-12-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256242#comment-17256242 ] Hudson commented on HBASE-25432: Results for branch branch-2.4 [build #17 on

[GitHub] [hbase] cuibo01 edited a comment on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 edited a comment on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752300485 > So we need to find out why this opinion does not work first? OOME can happen at any place and break the assumptions in code, there is no way to fix it cleanly just by

[GitHub] [hbase] cuibo01 edited a comment on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 edited a comment on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752300485 > So we need to find out why this opinion does not work first? OOME can happen at any place and break the assumptions in code, there is no way to fix it cleanly just by

[GitHub] [hbase] cuibo01 edited a comment on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 edited a comment on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752300485 > So we need to find out why this opinion does not work first? OOME can happen at any place and break the assumptions in code, there is no way to fix it cleanly just by

[GitHub] [hbase] cuibo01 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752300485 > So we need to find out why this opinion does not work first? OOME can happen at any place and break the assumptions in code, there is no way to fix it cleanly just by adding

[GitHub] [hbase] Apache9 merged pull request #2826: HBASE-25452 Use MatcherAssert.assertThat instead of org.junit.Assert.…

2020-12-29 Thread GitBox
Apache9 merged pull request #2826: URL: https://github.com/apache/hbase/pull/2826 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on a change in pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-29 Thread GitBox
Apache9 commented on a change in pull request #2825: URL: https://github.com/apache/hbase/pull/2825#discussion_r549907829 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -832,7 +832,7 @@ private void

[GitHub] [hbase] Apache9 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
Apache9 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752297484 > > In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the

[GitHub] [hbase] infraio commented on a change in pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-29 Thread GitBox
infraio commented on a change in pull request #2825: URL: https://github.com/apache/hbase/pull/2825#discussion_r549906989 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -832,7 +832,7 @@ private void

[GitHub] [hbase] cuibo01 edited a comment on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 edited a comment on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752295992 > In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the

[GitHub] [hbase] cuibo01 edited a comment on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 edited a comment on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752295992 > In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the

[GitHub] [hbase] cuibo01 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752295992 > In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the

[GitHub] [hbase] cuibo01 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752294308 > Have we observed errors other than OOME which cause the TimeoutExecutorThread to hang there? now, we have not seen anything else except OOM, but we think there are

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-752292504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2020-12-29 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r549894991 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreContext.java ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-752220837 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-752220552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2825: URL: https://github.com/apache/hbase/pull/2825#issuecomment-752209081 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-752208401 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2020-12-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256099#comment-17256099 ] Hudson commented on HBASE-25432: Results for branch branch-2 [build #140 on

[GitHub] [hbase] Apache-HBase commented on pull request #2826: HBASE-25452 Use MatcherAssert.assertThat instead of org.junit.Assert.…

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2826: URL: https://github.com/apache/hbase/pull/2826#issuecomment-752189196 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2826: HBASE-25452 Use MatcherAssert.assertThat instead of org.junit.Assert.…

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2826: URL: https://github.com/apache/hbase/pull/2826#issuecomment-752187104 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2752: HBASE-25374 Make REST Client connection and socket time out configurable

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2752: URL: https://github.com/apache/hbase/pull/2752#issuecomment-752180025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-752179320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2752: HBASE-25374 Make REST Client connection and socket time out configurable

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2752: URL: https://github.com/apache/hbase/pull/2752#issuecomment-752178070 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2752: HBASE-25374 Make REST Client connection and socket time out configurable

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2752: URL: https://github.com/apache/hbase/pull/2752#issuecomment-752178011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2020-12-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256077#comment-17256077 ] Hudson commented on HBASE-25432: Results for branch branch-2.3 [build #133 on

[jira] [Updated] (HBASE-25379) Make retry pause time configurable for regionserver short operation RPC (reportRegionStateTransition/reportProcedureDone)

2020-12-29 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25379: - Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master & branch-2,

[jira] [Updated] (HBASE-25379) Make retry pause time configurable for regionserver short operation RPC (reportRegionStateTransition/reportProcedureDone)

2020-12-29 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25379: - Fix Version/s: 2.5.0 > Make retry pause time configurable for regionserver short operation RPC

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-752161500 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-752159121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] pankaj72981 merged pull request #2757: HBASE-25379 Make retry pause time configurable for regionserver short operation RPC (reportRegionStateTransition/reportProcedureDone)

2020-12-29 Thread GitBox
pankaj72981 merged pull request #2757: URL: https://github.com/apache/hbase/pull/2757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2825: URL: https://github.com/apache/hbase/pull/2825#issuecomment-752149204 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-752142724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2826: HBASE-25452 Use MatcherAssert.assertThat instead of org.junit.Assert.…

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2826: URL: https://github.com/apache/hbase/pull/2826#issuecomment-752141139 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
Apache9 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752115741 Have we observed errors other than OOME which cause the TimeoutExecutorThread to hang there? This is an

[GitHub] [hbase] Apache9 opened a new pull request #2826: HBASE-25452 Use MatcherAssert.assertThat instead of org.junit.Assert.…

2020-12-29 Thread GitBox
Apache9 opened a new pull request #2826: URL: https://github.com/apache/hbase/pull/2826 …assertThat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2020-12-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256022#comment-17256022 ] Hudson commented on HBASE-25432: Results for branch branch-1 [build #70 on

[jira] [Updated] (HBASE-25452) Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat

2020-12-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25452: -- Component/s: test > Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat >

[jira] [Work started] (HBASE-25452) Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat

2020-12-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25452 started by Duo Zhang. - > Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat >

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-752107416 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-25452) Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat

2020-12-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25452: - Assignee: Duo Zhang > Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat >

[GitHub] [hbase] Apache-HBase commented on pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2825: URL: https://github.com/apache/hbase/pull/2825#issuecomment-752084793 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-752081175 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2823: URL: https://github.com/apache/hbase/pull/2823#issuecomment-752072879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2020-12-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255991#comment-17255991 ] Hudson commented on HBASE-25432: Results for branch master [build #167 on

[jira] [Commented] (HBASE-24850) CellComparator perf improvement

2020-12-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255990#comment-17255990 ] Hudson commented on HBASE-24850: Results for branch master [build #167 on

[GitHub] [hbase] Apache9 commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
Apache9 commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-752069981 Any other concerns? Thanks. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2823: URL: https://github.com/apache/hbase/pull/2823#issuecomment-752068665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2825: URL: https://github.com/apache/hbase/pull/2825#issuecomment-752063490 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-752062563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] cuibo01 edited a comment on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 edited a comment on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752061346 > In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the

[GitHub] [hbase] cuibo01 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-752061346 > In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the

[GitHub] [hbase] Apache-HBase commented on pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2821: URL: https://github.com/apache/hbase/pull/2821#issuecomment-752058347 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] cuibo01 commented on a change in pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
cuibo01 commented on a change in pull request #2824: URL: https://github.com/apache/hbase/pull/2824#discussion_r549684381 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java ## @@ -306,15 +315,22 @@ public

[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2020-12-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25432: - Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [hbase] virajjasani merged pull request #2820: HBASE-25432 : branch-1 backport (Update SecureTestUtil)

2020-12-29 Thread GitBox
virajjasani merged pull request #2820: URL: https://github.com/apache/hbase/pull/2820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2823: URL: https://github.com/apache/hbase/pull/2823#issuecomment-752037550 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2821: URL: https://github.com/apache/hbase/pull/2821#issuecomment-752034007 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-752030328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2825: URL: https://github.com/apache/hbase/pull/2825#issuecomment-752028286 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] leyangyueshan commented on a change in pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-29 Thread GitBox
leyangyueshan commented on a change in pull request #2823: URL: https://github.com/apache/hbase/pull/2823#discussion_r549653075 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java ## @@ -53,6 +54,8 @@ private Timer

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-752019234 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24850) CellComparator perf improvement

2020-12-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255897#comment-17255897 ] Hudson commented on HBASE-24850: Results for branch branch-2.4 [build #16 on

[GitHub] [hbase] Apache9 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
Apache9 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-751997962 In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the assumptions

[GitHub] [hbase] Apache-HBase commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-751995597 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] pankaj72981 commented on a change in pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-29 Thread GitBox
pankaj72981 commented on a change in pull request #2824: URL: https://github.com/apache/hbase/pull/2824#discussion_r549604769 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java ## @@ -306,15 +315,22 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-29 Thread GitBox
Apache-HBase commented on pull request #2825: URL: https://github.com/apache/hbase/pull/2825#issuecomment-751987038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m