[GitHub] [hbase] Apache-HBase commented on pull request #2938: HBASE-25559 Terminate threads of oldsources while RS is closing

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2938: URL: https://github.com/apache/hbase/pull/2938#issuecomment-775746630 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2938: HBASE-25559 Terminate threads of oldsources while RS is closing

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2938: URL: https://github.com/apache/hbase/pull/2938#issuecomment-775741974 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25562) ReplicationSourceWALReader log and handle exception immediately without retrying

2021-02-08 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-25562: Description: In [this piece of code about retrying in

[jira] [Created] (HBASE-25562) ReplicationSourceWALReader log and handle exception immediately without retrying

2021-02-08 Thread Sun Xin (Jira)
Sun Xin created HBASE-25562: --- Summary: ReplicationSourceWALReader log and handle exception immediately without retrying Key: HBASE-25562 URL: https://issues.apache.org/jira/browse/HBASE-25562 Project:

[GitHub] [hbase] YutSean commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
YutSean commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775726066 I checked branch-1 already uses thrift 0.13.0 This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-25557) hbase thirdparty jdk bytecode enforcement shouldn't check test dependencies

2021-02-08 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25557: Resolution: Fixed Status: Resolved (was: Patch Available) > hbase thirdparty jdk

[GitHub] [hbase-thirdparty] busbey closed pull request #47: HBASE-25557 jdk bytecode enforcement shouldn't check test dependencies.

2021-02-08 Thread GitBox
busbey closed pull request #47: URL: https://github.com/apache/hbase-thirdparty/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775710135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] aimiebell commented on a change in pull request #2936: HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
aimiebell commented on a change in pull request #2936: URL: https://github.com/apache/hbase/pull/2936#discussion_r572623068 ## File path: hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java ## @@ -11,7 +11,7 @@ * An AlreadyExists

[jira] [Resolved] (HBASE-25507) Leak of ESTABLISHED sockets when compaction encountered "java.io.IOException: Invalid HFile block magic"

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25507. --- Fix Version/s: 2.4.2 2.3.5 3.0.0-alpha-1 Hadoop

[GitHub] [hbase] saintstack merged pull request #2882: HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "…

2021-02-08 Thread GitBox
saintstack merged pull request #2882: URL: https://github.com/apache/hbase/pull/2882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] YutSean commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
YutSean commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775684404 I find the problem. I compile the thrift file locally with java 8, so that the generated code cannot pass the check. I have regenerated the code with java 7.

[GitHub] [hbase] Apache-HBase commented on pull request #2938: HBASE-25559 Terminate threads of oldsources while RS is closing

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2938: URL: https://github.com/apache/hbase/pull/2938#issuecomment-775684207 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] pankaj72981 commented on pull request #2752: HBASE-25374 Make REST Client connection and socket time out configurable

2021-02-08 Thread GitBox
pankaj72981 commented on pull request #2752: URL: https://github.com/apache/hbase/pull/2752#issuecomment-775674203 > @pankaj72981 See above sir ohh.. missed this one, pardon me @saintstack sir. Will check it today.

[GitHub] [hbase] saintstack commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
saintstack commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775671930 > While we update the thrift version from 0.98 to 0.13.0, which needs java version at least 52, this will lead to the javadoc failures Where does the update from 0.98

[jira] [Resolved] (HBASE-24772) Use GetoptLong or OptionParser in hbase-shell

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24772. --- Fix Version/s: 2.5.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[GitHub] [hbase] saintstack merged pull request #2918: HBASE-24772 Use GetoptLong or OptionParser in hbase-shell

2021-02-08 Thread GitBox
saintstack merged pull request #2918: URL: https://github.com/apache/hbase/pull/2918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] laxmanlax edited a comment on pull request #2918: HBASE-24772 Use GetoptLong or OptionParser in hbase-shell

2021-02-08 Thread GitBox
laxmanlax edited a comment on pull request #2918: URL: https://github.com/apache/hbase/pull/2918#issuecomment-775662762 @saintstack I updated the code and tried `> hbase shell ` on my devbox it works for me This is an

[GitHub] [hbase] ddupg commented on pull request #2938: HBASE-25559 Terminate threads of oldsources while RS is closing

2021-02-08 Thread GitBox
ddupg commented on pull request #2938: URL: https://github.com/apache/hbase/pull/2938#issuecomment-775665509 Thanks @wchevreuil @virajjasani @saintstack for reviwing, I added a UT for this PR, please take a look. This is an

[GitHub] [hbase] laxmanlax commented on pull request #2918: HBASE-24772 Use GetoptLong or OptionParser in hbase-shell

2021-02-08 Thread GitBox
laxmanlax commented on pull request #2918: URL: https://github.com/apache/hbase/pull/2918#issuecomment-775662762 @saintstack I updated the code and tried > hbase shell on my devbox it works for me This is an automated

[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775661707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anoopsjohn commented on pull request #2772: HBASE-25387 TagRewriteCell's getSerializedSize() method gets the size…

2021-02-08 Thread GitBox
anoopsjohn commented on pull request #2772: URL: https://github.com/apache/hbase/pull/2772#issuecomment-775660516 Totally missed this.. Will see E2E.. We are not consistent wrt handling these. Let me go through all parts. Will report back in a day or 2.

[GitHub] [hbase] taklwu commented on pull request #2931: HBASE-25395 Introduce PersistedStoreEngine and PersistedStoreFileManager

2021-02-08 Thread GitBox
taklwu commented on pull request #2931: URL: https://github.com/apache/hbase/pull/2931#issuecomment-775649940 @joshelser this patch is ready for review, and if you have any person in your mind could review it, please tag them as well, thanks a lot.

[GitHub] [hbase] YutSean commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
YutSean commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775645152 While we update the thrift version from 0.98 to 0.13.0, which needs java version at least 52, this will lead to the javadoc failures. Have no idea how to solve this.

[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775639866 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sunhelly commented on a change in pull request #2882: HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "…

2021-02-08 Thread GitBox
sunhelly commented on a change in pull request #2882: URL: https://github.com/apache/hbase/pull/2882#discussion_r572552465 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -345,7 +345,17 @@ private InternalScanner

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #81: report dirty metadata in meta table

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #81: URL: https://github.com/apache/hbase-operator-tools/pull/81#issuecomment-775622278 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase] YutSean commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
YutSean commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775621007 I fixed the code style and the unit test failure results from the wrong version of Java. This is an automated

[GitHub] [hbase-operator-tools] Mengqi777 opened a new pull request #81: report dirty metadata in meta table

2021-02-08 Thread GitBox
Mengqi777 opened a new pull request #81: URL: https://github.com/apache/hbase-operator-tools/pull/81 Our cluster has experienced such problems: a table has been deleted but meta table still storage metadata about this table, thoese metadata show in hbck ui until I delete them.

[GitHub] [hbase] Apache-HBase commented on pull request #2930: HBASE-25542 Add client detail to scan name so when lease expires, we …

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2930: URL: https://github.com/apache/hbase/pull/2930#issuecomment-775598923 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2930: HBASE-25542 Add client detail to scan name so when lease expires, we …

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2930: URL: https://github.com/apache/hbase/pull/2930#issuecomment-775569426 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2930: HBASE-25542 Add client detail to scan name so when lease expires, we …

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2930: URL: https://github.com/apache/hbase/pull/2930#issuecomment-775516077 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25512) May throw StringIndexOutOfBoundsException when construct illegal tablename error

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281424#comment-17281424 ] Michael Stack commented on HBASE-25512: --- Had to revert and reapply to add the JIRA ID missing on

[jira] [Resolved] (HBASE-25542) Add client detail to scan name so when lease expires, we have clue on who was scanning

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25542. --- Fix Version/s: 2.4.2 2.5.0 3.0.0-alpha-1 Hadoop

[GitHub] [hbase] saintstack merged pull request #2930: HBASE-25542 Add client detail to scan name so when lease expires, we …

2021-02-08 Thread GitBox
saintstack merged pull request #2930: URL: https://github.com/apache/hbase/pull/2930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] clarax commented on pull request #2930: HBASE-25542 Add client detail to scan name so when lease expires, we …

2021-02-08 Thread GitBox
clarax commented on pull request #2930: URL: https://github.com/apache/hbase/pull/2930#issuecomment-775504964 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] saintstack commented on pull request #2930: HBASE-25542 Add client detail to scan name so when lease expires, we …

2021-02-08 Thread GitBox
saintstack commented on pull request #2930: URL: https://github.com/apache/hbase/pull/2930#issuecomment-775495131 @clarax Thanks for review. #1 is good idea. #2 is too hard to do... Make the call and then have the lease expire. PITA just to see an improved log.

[jira] [Commented] (HBASE-25553) It is better for ReplicationTracker.getListOfRegionServers to return ServerName instead of String

2021-02-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281404#comment-17281404 ] Hudson commented on HBASE-25553: Results for branch branch-2.2 [build #167 on

[GitHub] [hbase] Apache-HBase commented on pull request #2931: HBASE-25395 Introduce PersistedStoreEngine and PersistedStoreFileManager

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2931: URL: https://github.com/apache/hbase/pull/2931#issuecomment-775486117 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2931: HBASE-25395 Introduce PersistedStoreEngine and PersistedStoreFileManager

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2931: URL: https://github.com/apache/hbase/pull/2931#issuecomment-775481982 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Resolved] (HBASE-25512) May throw StringIndexOutOfBoundsException when construct illegal tablename error

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25512. --- Fix Version/s: (was: 1.7.0) Hadoop Flags: Reviewed Resolution: Fixed Pushed

[GitHub] [hbase] saintstack merged pull request #2884: HBASE-25512 May throw StringIndexOutOfBoundsException when construct illegal tablename error

2021-02-08 Thread GitBox
saintstack merged pull request #2884: URL: https://github.com/apache/hbase/pull/2884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on a change in pull request #2882: HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "…

2021-02-08 Thread GitBox
saintstack commented on a change in pull request #2882: URL: https://github.com/apache/hbase/pull/2882#discussion_r572389663 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -345,7 +345,17 @@ private

[GitHub] [hbase] saintstack commented on pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

2021-02-08 Thread GitBox
saintstack commented on pull request #2780: URL: https://github.com/apache/hbase/pull/2780#issuecomment-775476450 @sanjeetnishad95 Any chance of addressing Pankaj's suggestions? Thanks. This is an automated message from the

[GitHub] [hbase] saintstack commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-02-08 Thread GitBox
saintstack commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-775475663 @caroliney14 Any update? This is a nice PR. Would be sweet to bring home. This is an automated message from

[GitHub] [hbase] saintstack commented on pull request #2752: HBASE-25374 Make REST Client connection and socket time out configurable

2021-02-08 Thread GitBox
saintstack commented on pull request #2752: URL: https://github.com/apache/hbase/pull/2752#issuecomment-775473647 @pankaj72981 See above sir This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (HBASE-25519) BLOCKSIZE needs to support pretty print

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25519. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. It won't go back to

[jira] [Updated] (HBASE-25519) BLOCKSIZE needs to support pretty print

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25519: -- Fix Version/s: 3.0.0-alpha-1 > BLOCKSIZE needs to support pretty print >

[GitHub] [hbase] saintstack merged pull request #2894: HBASE-25519 BLOCKSIZE needs to support pretty print

2021-02-08 Thread GitBox
saintstack merged pull request #2894: URL: https://github.com/apache/hbase/pull/2894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on a change in pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-08 Thread GitBox
saintstack commented on a change in pull request #2922: URL: https://github.com/apache/hbase/pull/2922#discussion_r572381154 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java ## @@ -196,13 +259,14 @@ public void

[jira] [Resolved] (HBASE-25550) More readable Competition Time

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25550. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to branch-2 and master. Shout if you

[jira] [Updated] (HBASE-25550) More readable Competition Time

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25550: -- Fix Version/s: 2.5.0 > More readable Competition Time > -- > >

[GitHub] [hbase] saintstack merged pull request #2925: HBASE-25550 More readable Competition Time

2021-02-08 Thread GitBox
saintstack merged pull request #2925: URL: https://github.com/apache/hbase/pull/2925 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2942: HBASE-25561 Added ignored test for async connection that runs retries…

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2942: URL: https://github.com/apache/hbase/pull/2942#issuecomment-775464225 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2942: HBASE-25561 Added ignored test for async connection that runs retries…

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2942: URL: https://github.com/apache/hbase/pull/2942#issuecomment-775459970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2942: HBASE-25561 Added ignored test for async connection that runs retries…

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2942: URL: https://github.com/apache/hbase/pull/2942#issuecomment-775457782 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] clarax commented on pull request #2930: HBASE-25542 Add client detail to scan name so when lease expires, we …

2021-02-08 Thread GitBox
clarax commented on pull request #2930: URL: https://github.com/apache/hbase/pull/2930#issuecomment-775456335 Thank you for adding this info for trouble shooting lease expiration. I have two concerns here that might need to be addressed: 1. Can we also log user name like

[GitHub] [hbase] saintstack commented on a change in pull request #2801: HBASE-25433 There is no limit on the table name length when creating a table

2021-02-08 Thread GitBox
saintstack commented on a change in pull request #2801: URL: https://github.com/apache/hbase/pull/2801#discussion_r572354056 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java ## @@ -242,6 +255,9 @@ public static void isLegalNamespaceName(final

[GitHub] [hbase] saintstack commented on pull request #2772: HBASE-25387 TagRewriteCell's getSerializedSize() method gets the size…

2021-02-08 Thread GitBox
saintstack commented on pull request #2772: URL: https://github.com/apache/hbase/pull/2772#issuecomment-775436524 @anoopsjohn What you thinking here boss? This is an automated message from the Apache Git Service. To respond

[jira] [Resolved] (HBASE-25560) Remove unused parameter named peerId in the constructor method of CatalogReplicationSourcePeer

2021-02-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25560. --- Fix Version/s: 2.5.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[GitHub] [hbase] saintstack merged pull request #2939: HBASE-25560 Remove unused parameter named peerId in the constructor m…

2021-02-08 Thread GitBox
saintstack merged pull request #2939: URL: https://github.com/apache/hbase/pull/2939 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack opened a new pull request #2942: HBASE-25561 Added ignored test for async connection that runs retries…

2021-02-08 Thread GitBox
saintstack opened a new pull request #2942: URL: https://github.com/apache/hbase/pull/2942 … just so can check how long it takes and that retrying is happening This is an automated message from the Apache Git Service. To

[jira] [Created] (HBASE-25561) Added ignored test for async connection that runs retries just so can check how long it takes and that retrying is happening

2021-02-08 Thread Michael Stack (Jira)
Michael Stack created HBASE-25561: - Summary: Added ignored test for async connection that runs retries just so can check how long it takes and that retrying is happening Key: HBASE-25561 URL:

[GitHub] [hbase] Apache-HBase commented on pull request #2931: HBASE-25395 Introduce PersistedStoreEngine and PersistedStoreFileManager

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2931: URL: https://github.com/apache/hbase/pull/2931#issuecomment-775395190 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Resolved] (HBASE-25500) Add metric for age of oldest wal in region server replication queue.

2021-02-08 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah resolved HBASE-25500. -- Resolution: Duplicate Dup of HBASE-25539 > Add metric for age of oldest wal in region server

[GitHub] [hbase] Apache-HBase commented on pull request #2883: HBASE-25492: Create table with rsgroup

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2883: URL: https://github.com/apache/hbase/pull/2883#issuecomment-775355393 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2883: HBASE-25492: Create table with rsgroup

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2883: URL: https://github.com/apache/hbase/pull/2883#issuecomment-775353027 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2883: HBASE-25492: Create table with rsgroup

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2883: URL: https://github.com/apache/hbase/pull/2883#issuecomment-775351811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25553) It is better for ReplicationTracker.getListOfRegionServers to return ServerName instead of String

2021-02-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281278#comment-17281278 ] Hudson commented on HBASE-25553: Results for branch branch-2 [build #172 on

[GitHub] [hbase] arshadmohammad commented on a change in pull request #2883: HBASE-25492: Create table with rsgroup

2021-02-08 Thread GitBox
arshadmohammad commented on a change in pull request #2883: URL: https://github.com/apache/hbase/pull/2883#discussion_r572252196 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java ## @@ -508,7 +508,7 @@ public void

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-02-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281249#comment-17281249 ] Viraj Jasani commented on HBASE-23887: -- [~pustota] In fact, I was just going through your PR only

[GitHub] [hbase] pustota2009 closed pull request #1257: HBASE-23887 Up to 3x increase BlockCache performance

2021-02-08 Thread GitBox
pustota2009 closed pull request #1257: URL: https://github.com/apache/hbase/pull/1257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-02-08 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281245#comment-17281245 ] Danil Lipovoy edited comment on HBASE-23887 at 2/8/21, 5:34 PM:

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-02-08 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281245#comment-17281245 ] Danil Lipovoy commented on HBASE-23887: --- [~vjasani] could you please take a look at the PR 

[jira] [Commented] (HBASE-25553) It is better for ReplicationTracker.getListOfRegionServers to return ServerName instead of String

2021-02-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281228#comment-17281228 ] Hudson commented on HBASE-25553: Results for branch branch-2.3 [build #165 on

[GitHub] [hbase] Apache-HBase commented on pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2934: URL: https://github.com/apache/hbase/pull/2934#issuecomment-775248382 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2934: URL: https://github.com/apache/hbase/pull/2934#issuecomment-775244557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2939: HBASE-25560 Remove unused parameter named peerId in the constructor m…

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2939: URL: https://github.com/apache/hbase/pull/2939#issuecomment-775223425 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2939: HBASE-25560 Remove unused parameter named peerId in the constructor m…

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2939: URL: https://github.com/apache/hbase/pull/2939#issuecomment-775222650 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on pull request #2918: HBASE-24772 Use GetoptLong or OptionParser in hbase-shell

2021-02-08 Thread GitBox
virajjasani commented on pull request #2918: URL: https://github.com/apache/hbase/pull/2918#issuecomment-775218247 @bitoffdev would you like to take a look? This is an automated message from the Apache Git Service. To

[jira] [Commented] (HBASE-25543) When configuration "hadoop.security.authorization" is set to false, the system will still try to authorize an RPC and raise AccessDeniedException

2021-02-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281131#comment-17281131 ] Hudson commented on HBASE-25543: Results for branch branch-1 [build #82 on

[GitHub] [hbase] virajjasani commented on a change in pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-08 Thread GitBox
virajjasani commented on a change in pull request #2922: URL: https://github.com/apache/hbase/pull/2922#discussion_r572088450 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java ## @@ -182,12 +182,75 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775208329 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m

[GitHub] [hbase] Apache-HBase commented on pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2934: URL: https://github.com/apache/hbase/pull/2934#issuecomment-775166472 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] YutSean opened a new pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
YutSean opened a new pull request #2941: URL: https://github.com/apache/hbase/pull/2941 https://issues.apache.org/jira/browse/HBASE-21674 The admin operations of Thrift2 are not implement. They will be implemented in the future.

[GitHub] [hbase] YutSean closed pull request #2940: HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
YutSean closed pull request #2940: URL: https://github.com/apache/hbase/pull/2940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-25553) It is better for ReplicationTracker.getListOfRegionServers to return ServerName instead of String

2021-02-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281034#comment-17281034 ] Hudson commented on HBASE-25553: Results for branch master [build #205 on

[GitHub] [hbase] Apache-HBase commented on pull request #2937: HBASE-25558:Adding audit log for execMasterService

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2937: URL: https://github.com/apache/hbase/pull/2937#issuecomment-775133869 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2940: HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2940: URL: https://github.com/apache/hbase/pull/2940#issuecomment-775131624 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m

[GitHub] [hbase] Apache-HBase commented on pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2934: URL: https://github.com/apache/hbase/pull/2934#issuecomment-775129639 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2934: URL: https://github.com/apache/hbase/pull/2934#issuecomment-775124052 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2938: HBASE-25559 Terminate threads of oldsources while RS is closing

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2938: URL: https://github.com/apache/hbase/pull/2938#issuecomment-775116348 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2938: HBASE-25559 Terminate threads of oldsources while RS is closing

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2938: URL: https://github.com/apache/hbase/pull/2938#issuecomment-775106911 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2939: HBASE-25560 Remove unused parameter named peerId in the constructor m…

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2939: URL: https://github.com/apache/hbase/pull/2939#issuecomment-775101701 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] pankaj72981 commented on a change in pull request #2883: HBASE-25492: Create table with rsgroup

2021-02-08 Thread GitBox
pankaj72981 commented on a change in pull request #2883: URL: https://github.com/apache/hbase/pull/2883#discussion_r571978144 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java ## @@ -508,7 +508,7 @@ public void

[GitHub] [hbase] YutSean opened a new pull request #2940: HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
YutSean opened a new pull request #2940: URL: https://github.com/apache/hbase/pull/2940 https://issues.apache.org/jira/browse/HBASE-21674 Admin operations of Thrift2 are not finished. There will be implemented in the future.

[GitHub] [hbase] Apache-HBase commented on pull request #2937: HBASE-25558:Adding audit log for execMasterService

2021-02-08 Thread GitBox
Apache-HBase commented on pull request #2937: URL: https://github.com/apache/hbase/pull/2937#issuecomment-775085355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] YutSean closed pull request #2936: HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
YutSean closed pull request #2936: URL: https://github.com/apache/hbase/pull/2936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (HBASE-23970) TestUsersOperationsWithSecureHadoop fails when an existing ticket is present

2021-02-08 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 reassigned HBASE-23970: --- Assignee: (was: wenfeiyi666) > TestUsersOperationsWithSecureHadoop fails when an

[jira] [Updated] (HBASE-25560) Remove unused parameter named peerId in the constructor method of CatalogReplicationSourcePeer

2021-02-08 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-25560: Affects Version/s: 2.4.2 3.0.0-alpha-1 > Remove unused parameter named peerId in

  1   2   >