[GitHub] [hbase] Apache-HBase commented on pull request #2543: HBASE-25184 Move RegionLocationFinder to hbase-balancer

2021-03-14 Thread GitBox
Apache-HBase commented on pull request #2543: URL: https://github.com/apache/hbase/pull/2543#issuecomment-799160549 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14

[jira] [Comment Edited] (HBASE-25664) Adding replication peer should handle the undeleted queue exception

2021-03-14 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301425#comment-17301425 ] Sandeep Pal edited comment on HBASE-25664 at 3/15/21, 6:43 AM: ---

[jira] [Commented] (HBASE-25664) Adding replication peer should handle the undeleted queue exception

2021-03-14 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301425#comment-17301425 ] Sandeep Pal commented on HBASE-25664: - [~zhangduo] That is why I specifically mentio

[GitHub] [hbase] Apache9 commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

2021-03-14 Thread GitBox
Apache9 commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-799150469 The log4j2 logging framework provided a log4j-1.2-api brigde, so we can use this dependency to replace the log4j dependency. -

[jira] [Commented] (HBASE-25664) Adding replication peer should handle the undeleted queue exception

2021-03-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301411#comment-17301411 ] Duo Zhang commented on HBASE-25664: --- {quote} This is because queue removal depends upo

[GitHub] [hbase] Apache9 commented on pull request #2543: HBASE-25184 Move RegionLocationFinder to hbase-balancer

2021-03-14 Thread GitBox
Apache9 commented on pull request #2543: URL: https://github.com/apache/hbase/pull/2543#issuecomment-799143391 Thanks @nyl3532016 ! Will merge tomorrow if no other objections. This is an automated message from the Apac

[jira] [Commented] (HBASE-25664) Adding replication peer should handle the undeleted queue exception

2021-03-14 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301401#comment-17301401 ] Sandeep Pal commented on HBASE-25664: - I believe it is this _"It is still being dele

[GitHub] [hbase] Apache-HBase commented on pull request #2543: HBASE-25184 Move RegionLocationFinder to hbase-balancer

2021-03-14 Thread GitBox
Apache-HBase commented on pull request #2543: URL: https://github.com/apache/hbase/pull/2543#issuecomment-799128305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5

[jira] [Commented] (HBASE-25664) Adding replication peer should handle the undeleted queue exception

2021-03-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301377#comment-17301377 ] Duo Zhang commented on HBASE-25664: --- This may cause trouble for the RemovePeerProcedur

[jira] [Commented] (HBASE-25664) Adding replication peer should handle the undeleted queue exception

2021-03-14 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301369#comment-17301369 ] Sandeep Pal commented on HBASE-25664: - [~zhangduo]Do you mean deleting the replicati

[GitHub] [hbase] Apache-HBase commented on pull request #2543: HBASE-25184 Move RegionLocationFinder to hbase-balancer

2021-03-14 Thread GitBox
Apache-HBase commented on pull request #2543: URL: https://github.com/apache/hbase/pull/2543#issuecomment-799066076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 45

[GitHub] [hbase] nyl3532016 commented on pull request #2543: HBASE-25184 Move RegionLocationFinder to hbase-balancer

2021-03-14 Thread GitBox
nyl3532016 commented on pull request #2543: URL: https://github.com/apache/hbase/pull/2543#issuecomment-799060555 LGTM +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (HBASE-25664) Adding replication peer should handle the undeleted queue exception

2021-03-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301342#comment-17301342 ] Duo Zhang commented on HBASE-25664: --- The operation could be time consuming so I do not

[jira] [Updated] (HBASE-25664) Adding replication peer should handle the undeleted queue exception

2021-03-14 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-25664: Description: Currently, if we try to add a peer and there is a replication queue existing for tha

[jira] [Created] (HBASE-25664) Adding replication peer should handle the undeleted queue exception

2021-03-14 Thread Sandeep Pal (Jira)
Sandeep Pal created HBASE-25664: --- Summary: Adding replication peer should handle the undeleted queue exception Key: HBASE-25664 URL: https://issues.apache.org/jira/browse/HBASE-25664 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

2021-03-14 Thread GitBox
Apache-HBase commented on pull request #3049: URL: https://github.com/apache/hbase/pull/3049#issuecomment-798920683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 17

[GitHub] [hbase] Apache-HBase commented on pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

2021-03-14 Thread GitBox
Apache-HBase commented on pull request #3049: URL: https://github.com/apache/hbase/pull/3049#issuecomment-798919105 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18

[GitHub] [hbase] Apache-HBase commented on pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

2021-03-14 Thread GitBox
Apache-HBase commented on pull request #3049: URL: https://github.com/apache/hbase/pull/3049#issuecomment-798893058 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 44

[GitHub] [hbase] Apache-HBase commented on pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

2021-03-14 Thread GitBox
Apache-HBase commented on pull request #3049: URL: https://github.com/apache/hbase/pull/3049#issuecomment-798882814 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s

[GitHub] [hbase] Apache-HBase commented on pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

2021-03-14 Thread GitBox
Apache-HBase commented on pull request #3049: URL: https://github.com/apache/hbase/pull/3049#issuecomment-798877588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15