[GitHub] [hbase] Apache-HBase commented on pull request #3069: HBASE-25683 Simplify UTs using DummyServer

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3069: URL: https://github.com/apache/hbase/pull/3069#issuecomment-803522718 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10

[GitHub] [hbase] sandeepvinayak opened a new pull request #3076: HBASE-25627: HBase replication should have a metric to represent if the source is stuck getting initialized

2021-03-20 Thread GitBox
sandeepvinayak opened a new pull request #3076: URL: https://github.com/apache/hbase/pull/3076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[jira] [Commented] (HBASE-25679) Size of log queue metric is incorrect in branch-1/branch-2

2021-03-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305604#comment-17305604 ] Hudson commented on HBASE-25679: Results for branch branch-2.4 [build #78 on bu

[GitHub] [hbase] Apache-HBase commented on pull request #3073: HBASE-25678 Support nonce operations for Increment/Append in RowMutations and CheckAndMutate

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3073: URL: https://github.com/apache/hbase/pull/3073#issuecomment-803496136 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] Apache-HBase commented on pull request #3073: HBASE-25678 Support nonce operations for Increment/Append in RowMutations and CheckAndMutate

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3073: URL: https://github.com/apache/hbase/pull/3073#issuecomment-803495402 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16

[GitHub] [hbase] Apache-HBase commented on pull request #3073: HBASE-25678 Support nonce operations for Increment/Append in RowMutations and CheckAndMutate

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3073: URL: https://github.com/apache/hbase/pull/3073#issuecomment-803477458 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49

[jira] [Updated] (HBASE-25686) [hbtop] Add some javadoc

2021-03-20 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-25686: - Fix Version/s: 1.7.0 > [hbtop] Add some javadoc > > >

[jira] [Updated] (HBASE-25686) [hbtop] Add some javadoc

2021-03-20 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-25686: - Fix Version/s: 2.5.0 3.0.0-alpha-1 > [hbtop] Add some javadoc > -

[jira] [Updated] (HBASE-25686) [hbtop] Add some javadoc

2021-03-20 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-25686: - Priority: Minor (was: Major) > [hbtop] Add some javadoc > > >

[jira] [Commented] (HBASE-25576) Should not use a byte array as a key of HashMap or an element of HashSet

2021-03-20 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305581#comment-17305581 ] Toshihiro Suzuki commented on HBASE-25576: -- [~swaroopa] Thank you for your inte

[jira] [Updated] (HBASE-25576) Should not use a byte array as a key of HashMap or an element of HashSet

2021-03-20 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-25576: - Summary: Should not use a byte array as a key of HashMap or an element of HashSet (was:

[jira] [Updated] (HBASE-25576) Should not use a byte array as a key of HashMap or an element of HashSet

2021-03-20 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-25576: - Description: I sometimes face the code where we use a byte array as a key of HashMap (C

[jira] [Commented] (HBASE-25629) Reimplement TestCurrentHourProvider to not depend on unstable TZs

2021-03-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305575#comment-17305575 ] Hudson commented on HBASE-25629: Results for branch branch-2.2 [build #193 on b

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-803470762 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 15s

RE: [jira] [Work started] (HBASE-25568) Upgrade Thrift jar to fix CVE-2020-13949

2021-03-20 Thread Situ Shigh
On 2021/02/15 13:02:00 "Pankaj Kumar (Jira)" wrote: > > [ https://issues.apache.org/jira/browse/HBASE-25568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Work on HBASE-25568 started by Pankaj Kumar. > > > Upgrade Thrift jar

[jira] [Commented] (HBASE-25679) Size of log queue metric is incorrect in branch-1/branch-2

2021-03-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305566#comment-17305566 ] Michael Stack commented on HBASE-25679: --- Thanks for fixing 'fix version' [~shahrs8

[jira] [Resolved] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

2021-03-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25594. --- Resolution: Fixed Pushed addendum on branch-2.4+ > graceful_stop.sh fails to unload regions

[jira] [Reopened] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

2021-03-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-25594: --- Reopen to apply addendum below {code} commit 326835e8372cc83092e0ec127650438ff153476a (HEAD -> m

[jira] [Commented] (HBASE-25668) TestCurrentHourProvider fails 100% in branch-2.3

2021-03-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305561#comment-17305561 ] Michael Stack commented on HBASE-25668: --- Thank you [~psomogyi] > TestCurrentHour

[jira] [Commented] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

2021-03-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305562#comment-17305562 ] Michael Stack commented on HBASE-25594: --- Thanks again[~psomogyi] > graceful_s

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-803460788 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-803440978 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[jira] [Resolved] (HBASE-25629) Reimplement TestCurrentHourProvider to not depend on unstable TZs

2021-03-20 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-25629. --- Fix Version/s: 2.3.5 2.2.7 Resolution: Fixed > Reimplement TestCur

[jira] [Commented] (HBASE-25668) TestCurrentHourProvider fails 100% in branch-2.3

2021-03-20 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305529#comment-17305529 ] Peter Somogyi commented on HBASE-25668: --- Done. > TestCurrentHourProvider fails 10

[jira] [Commented] (HBASE-25679) Size of log queue metric is incorrect in branch-1/branch-2

2021-03-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305528#comment-17305528 ] Hudson commented on HBASE-25679: Results for branch branch-2 [build #205 on bui

[jira] [Commented] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

2021-03-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305527#comment-17305527 ] Hudson commented on HBASE-25594: Results for branch branch-2 [build #205 on bui

[jira] [Reopened] (HBASE-25629) Reimplement TestCurrentHourProvider to not depend on unstable TZs

2021-03-20 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reopened HBASE-25629: --- Reopening to backport fix to branch-2.3 and branch-2.2. > Reimplement TestCurrentHourProvider t

[GitHub] [hbase] Apache-HBase commented on pull request #3075: HBASE-25688 Use CustomRequestLog instead of Slf4jRequestLog for jetty

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3075: URL: https://github.com/apache/hbase/pull/3075#issuecomment-803400221 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3075: HBASE-25688 Use CustomRequestLog instead of Slf4jRequestLog for jetty

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3075: URL: https://github.com/apache/hbase/pull/3075#issuecomment-803399593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 39

[GitHub] [hbase] Apache-HBase commented on pull request #3075: HBASE-25688 Use CustomRequestLog instead of Slf4jRequestLog for jetty

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3075: URL: https://github.com/apache/hbase/pull/3075#issuecomment-803399093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #3075: HBASE-25688 Use CustomRequestLog instead of Slf4jRequestLog for jetty

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3075: URL: https://github.com/apache/hbase/pull/3075#issuecomment-803380337 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 7

[GitHub] [hbase] Apache-HBase commented on pull request #3075: HBASE-25688 Use CustomRequestLog instead of Slf4jRequestLog for jetty

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3075: URL: https://github.com/apache/hbase/pull/3075#issuecomment-803377622 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s

[GitHub] [hbase] Apache-HBase commented on pull request #3075: HBASE-25688 Use CustomRequestLog instead of Slf4jRequestLog for jetty

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3075: URL: https://github.com/apache/hbase/pull/3075#issuecomment-803374517 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s

[jira] [Commented] (HBASE-24776) [hbtop] Support Batch mode

2021-03-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305467#comment-17305467 ] Hudson commented on HBASE-24776: Results for branch branch-1 [build #99 on buil

[jira] [Commented] (HBASE-25258) Backport HBASE-24776 "[hbtop] Support Batch mode" to branch-1

2021-03-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305466#comment-17305466 ] Hudson commented on HBASE-25258: Results for branch branch-1 [build #99 on buil

[jira] [Commented] (HBASE-25679) Size of log queue metric is incorrect in branch-1/branch-2

2021-03-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305465#comment-17305465 ] Hudson commented on HBASE-25679: Results for branch branch-1 [build #99 on buil

[GitHub] [hbase] Apache9 opened a new pull request #3075: HBASE-25688 Use CustomRequestLog instead of Slf4jRequestLog for jetty

2021-03-20 Thread GitBox
Apache9 opened a new pull request #3075: URL: https://github.com/apache/hbase/pull/3075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[jira] [Updated] (HBASE-25688) Use CustomRequestLog instead of Slf4jRequestLog for jetty

2021-03-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25688: -- Component/s: UI logging > Use CustomRequestLog instead of Slf4jRequestLog for jetty >

[jira] [Created] (HBASE-25688) Use CustomRequestLog instead of Slf4jRequestLog for jetty

2021-03-20 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25688: - Summary: Use CustomRequestLog instead of Slf4jRequestLog for jetty Key: HBASE-25688 URL: https://issues.apache.org/jira/browse/HBASE-25688 Project: HBase Issue Typ

[GitHub] [hbase] Apache9 commented on pull request #2543: HBASE-25184 Move RegionLocationFinder to hbase-balancer

2021-03-20 Thread GitBox
Apache9 commented on pull request #2543: URL: https://github.com/apache/hbase/pull/2543#issuecomment-803324895 OK, good, all green. The new error prone is because of a method which is only used by UTs and there is a RestrictedApi annotation to limit its usage so it should be OK. Any

[GitHub] [hbase] Apache-HBase commented on pull request #3074: HBASE-25687 Backport "HBASE-25681 Add a switch for server/table query…

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3074: URL: https://github.com/apache/hbase/pull/3074#issuecomment-803272834 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s

[GitHub] [hbase] Apache-HBase commented on pull request #3074: HBASE-25687 Backport "HBASE-25681 Add a switch for server/table query…

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3074: URL: https://github.com/apache/hbase/pull/3074#issuecomment-803272298 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] Apache-HBase commented on pull request #3009: HBASE-25627: HBase replication should have a metric to represent if the source is stuck getting initialized

2021-03-20 Thread GitBox
Apache-HBase commented on pull request #3009: URL: https://github.com/apache/hbase/pull/3009#issuecomment-803270483 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[GitHub] [hbase] Reidddddd commented on a change in pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-20 Thread GitBox
Reidd commented on a change in pull request #3066: URL: https://github.com/apache/hbase/pull/3066#discussion_r597544473 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -3053,21 +3057,24 @@ private void scan(HBaseRpcCon