[GitHub] [hbase] virajjasani commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-14 Thread GitBox
virajjasani commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r632898870 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws I

[GitHub] [hbase] virajjasani commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-14 Thread GitBox
virajjasani commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r632898870 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws I

[jira] [Commented] (HBASE-25884) NPE while getting Balancer decisions

2021-05-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344951#comment-17344951 ] Hudson commented on HBASE-25884: Results for branch branch-2.4 [build #118 on b

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-841585883 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-841585645 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-841570261 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58

[GitHub] [hbase] Apache9 commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-14 Thread GitBox
Apache9 commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-841558634 > Test failures seem related? Yes, should be related. Let me see how to fix the UTs. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-14 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-841546694 Pushed a rebase on master and a fix for the latest findbugs warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [hbase] Apache-HBase commented on pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3271: URL: https://github.com/apache/hbase/pull/3271#issuecomment-841543688 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s

[GitHub] [hbase] apurtell edited a comment on pull request #3244: HBASE-25869 WAL value compression

2021-05-14 Thread GitBox
apurtell edited a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-841533295 > Thanks for the detailed perf results, SNAPPY seems like the sweet spot. Avg append time took a good hit? (10x IIUC?), something to be concerned about? The extra la

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-14 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-841533295 > Thanks for the detailed perf results, SNAPPY seems like the sweet spot. Avg append time took a good hit? (10x IIUC?), something to be concerned about? The extra latency i

[GitHub] [hbase] Apache-HBase commented on pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3271: URL: https://github.com/apache/hbase/pull/3271#issuecomment-841497369 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31

[jira] [Updated] (HBASE-25823) TestSlowLogAccessor.testHigherSlowLogs repeatable failure

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25823: Fix Version/s: (was: 2.4.3) 2.4.4 > TestSlowLogAccessor.tes

[jira] [Updated] (HBASE-25588) Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25588: Fix Version/s: (was: 2.4.3) 2.4.4 > Excessive logging of "h

[jira] [Updated] (HBASE-25698) Persistent IllegalReferenceCountException at scanner open when using TinyLfuBlockCache

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25698: Fix Version/s: (was: 2.4.3) 2.4.4 > Persistent IllegalRefer

[jira] [Updated] (HBASE-25729) Upgrade to latest hbase-thirdparty

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25729: Fix Version/s: (was: 2.4.3) 2.4.4 > Upgrade to latest hbase

[jira] [Updated] (HBASE-25624) Bound LoadBalancer's RegionLocationFinder cache

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25624: Fix Version/s: (was: 2.4.3) 2.4.4 > Bound LoadBalancer's Re

[jira] [Updated] (HBASE-25694) Improve the shell's 'status replication' command output

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25694: Fix Version/s: (was: 2.4.3) 2.4.4 > Improve the shell's 'st

[jira] [Updated] (HBASE-25521) Change ChoreService and ScheduledChore to IA.Private

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25521: Fix Version/s: (was: 2.4.3) 2.4.4 > Change ChoreService and

[jira] [Updated] (HBASE-25613) [Branch-2 and Master]Handle the NoNode exception in remove log replication in a better way then just log WARN

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25613: Fix Version/s: (was: 2.4.3) 2.4.4 > [Branch-2 and Master]Ha

[jira] [Updated] (HBASE-25433) There is no limit on the table name length when creating a table

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25433: Fix Version/s: (was: 2.4.3) 2.4.4 > There is no limit on th

[jira] [Updated] (HBASE-25343) Avoid the failed meta replica region temporarily in Load Balance mode

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25343: Fix Version/s: (was: 2.4.3) 2.4.4 > Avoid the failed meta r

[jira] [Updated] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25774: Fix Version/s: (was: 2.3.5.1) 2.3.6 > ServerManager.getOnli

[jira] [Updated] (HBASE-25876) Add retry if we fail to read all bytes of the protobuf magic marker

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25876: Fix Version/s: (was: 2.4.4) 2.4.3 > Add retry if we fail to

[jira] [Updated] (HBASE-25867) Extra doc around ITBLL

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25867: Fix Version/s: (was: 2.4.4) 2.4.3 > Extra doc around ITBLL

[jira] [Updated] (HBASE-25859) Reference class incorrectly parses the protobuf magic marker

2021-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25859: Fix Version/s: (was: 2.4.4) 2.4.3 > Reference class incorre

[GitHub] [hbase] bharathv commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-14 Thread GitBox
bharathv commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-841467863 Thanks for the detailed perf results, SNAPPY seems like the sweet spot. Avg append time took a good hit? (10x IIUC?), something to be concerned about? Btw, is this ready fo

[GitHub] [hbase] bharathv commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-14 Thread GitBox
bharathv commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-841465139 Test failures seem related? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [hbase] bharathv commented on a change in pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-14 Thread GitBox
bharathv commented on a change in pull request #3268: URL: https://github.com/apache/hbase/pull/3268#discussion_r632754042 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -959,11 +960,19 @@ public void stop() { /** * Cr

[GitHub] [hbase] Apache-HBase commented on pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3271: URL: https://github.com/apache/hbase/pull/3271#issuecomment-841440050 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 46

[GitHub] [hbase-operator-tools] joshelser commented on pull request #86: HBASE-25874 [hbase-operator-tools]Add tool for identifying 'unknown s…

2021-05-14 Thread GitBox
joshelser commented on pull request #86: URL: https://github.com/apache/hbase-operator-tools/pull/86#issuecomment-841434334 Belated +1 from me. Thanks for the dryRun option, Wellington. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] Apache-HBase commented on pull request #3261: HBASE-25880 remove files from filesCompacting when clear compaction queue

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-841428077 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13

[GitHub] [hbase] Apache-HBase commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-841426474 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s

[GitHub] [hbase] bharathv commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-14 Thread GitBox
bharathv commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r632711780 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[GitHub] [hbase] Apache-HBase commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-841419709 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[jira] [Commented] (HBASE-25884) NPE while getting Balancer decisions

2021-05-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344798#comment-17344798 ] Hudson commented on HBASE-25884: Results for branch branch-2 [build #251 on bui

[GitHub] [hbase] Apache-HBase commented on pull request #3261: HBASE-25880 remove files from filesCompacting when clear compaction queue

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-841398708 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2

[jira] [Updated] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-14 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25861: - Status: Patch Available (was: Open) > Correct the usage of Configuration#addDeprecation > -

[jira] [Updated] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-14 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25861: - Affects Version/s: 2.5.0 3.0.0-alpha-1 > Correct the usage of Configurati

[GitHub] [hbase] ndimiduk commented on pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-14 Thread GitBox
ndimiduk commented on pull request #3271: URL: https://github.com/apache/hbase/pull/3271#issuecomment-841371859 FYI @ZhaoBQ , looks like your patch applies well enough to branch-2. Can you confirm that it can be applied without modification -- the configs you manipulate in this branch don'

[GitHub] [hbase] ndimiduk opened a new pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-14 Thread GitBox
ndimiduk opened a new pull request #3271: URL: https://github.com/apache/hbase/pull/3271 Signed-off-by: Nick Dimiduk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [hbase] Apache-HBase commented on pull request #3270: HBASE-25870 Validate only direct ancestors instead of entire history for a particular backup

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3270: URL: https://github.com/apache/hbase/pull/3270#issuecomment-841362419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [hbase] ndimiduk commented on pull request #3270: HBASE-25870 Validate only direct ancestors instead of entire history for a particular backup

2021-05-14 Thread GitBox
ndimiduk commented on pull request #3270: URL: https://github.com/apache/hbase/pull/3270#issuecomment-841362100 Re-applies original patch (#3246) after revert (#3269), with git summary updated. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] ndimiduk merged pull request #3270: HBASE-25870 Validate only direct ancestors instead of entire history for a particular backup

2021-05-14 Thread GitBox
ndimiduk merged pull request #3270: URL: https://github.com/apache/hbase/pull/3270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] ndimiduk opened a new pull request #3270: HBASE-25870 Validate only direct ancestors instead of entire history for a particular backup

2021-05-14 Thread GitBox
ndimiduk opened a new pull request #3270: URL: https://github.com/apache/hbase/pull/3270 Co-authored-by: Mallikarjun Signed-off-by: stack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] Apache-HBase commented on pull request #3269: Revert "HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…"

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3269: URL: https://github.com/apache/hbase/pull/3269#issuecomment-841358847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[jira] [Updated] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-14 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25861: - Fix Version/s: 3.0.0-alpha-1 > Correct the usage of Configuration#addDeprecation > -

[GitHub] [hbase] Apache-HBase commented on pull request #3269: Revert "HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…"

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3269: URL: https://github.com/apache/hbase/pull/3269#issuecomment-841358729 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s

[GitHub] [hbase] ndimiduk merged pull request #3269: Revert "HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…"

2021-05-14 Thread GitBox
ndimiduk merged pull request #3269: URL: https://github.com/apache/hbase/pull/3269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] ndimiduk opened a new pull request #3269: Revert "HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…"

2021-05-14 Thread GitBox
ndimiduk opened a new pull request #3269: URL: https://github.com/apache/hbase/pull/3269 Headsup @rda3mon , our policy is that commit summary start with the JIRA ID and the text matches the jira summary. Reverting this so it can be re-applied according to policy. Reverts apache/hbas

[GitHub] [hbase] ndimiduk merged pull request #3249: HBASE-25861 Correct the usage of Configuration#addDeprecation

2021-05-14 Thread GitBox
ndimiduk merged pull request #3249: URL: https://github.com/apache/hbase/pull/3249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Reopened] (HBASE-23595) HMaster abort when write to meta failed

2021-05-14 Thread Esteban Gutierrez (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Esteban Gutierrez reopened HBASE-23595: --- > HMaster abort when write to meta failed > --- > >

[jira] [Commented] (HBASE-23595) HMaster abort when write to meta failed

2021-05-14 Thread Esteban Gutierrez (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344694#comment-17344694 ] Esteban Gutierrez commented on HBASE-23595: --- I've run into this issue a couple

[jira] [Commented] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344691#comment-17344691 ] Reid Chan commented on HBASE-25890: --- I want to find out where is the script located h

[GitHub] [hbase] Apache-HBase commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-841337718 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32

[jira] [Commented] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344684#comment-17344684 ] Hudson commented on HBASE-25890: Results for branch branch-1 [build #126 on bui

[jira] [Commented] (HBASE-25879) [branch-1] Update CHANGES.txt and tag 1.7.0RC0 to the most recent commit

2021-05-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344683#comment-17344683 ] Hudson commented on HBASE-25879: Results for branch branch-1 [build #126 on bui

[GitHub] [hbase] Apache-HBase commented on pull request #3249: HBASE-25861 Correct the usage of Configuration#addDeprecation

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3249: URL: https://github.com/apache/hbase/pull/3249#issuecomment-841316830 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s

[GitHub] [hbase] Apache9 commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-14 Thread GitBox
Apache9 commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-841303798 As `ServerMetrics` is IA.Public, so do not want to add more methods to it only for an intrnal optimization. The trick is straight forward, in `regionServerStartup`, the `La

[GitHub] [hbase] Apache-HBase commented on pull request #3261: HBASE-25880 remove files from filesCompacting when clear compaction queue

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-841302722 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1

[GitHub] [hbase] Apache9 opened a new pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-14 Thread GitBox
Apache9 opened a new pull request #3268: URL: https://github.com/apache/hbase/pull/3268 …ed regionServerReport yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[jira] [Updated] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25032: -- Summary: Do not assign regions to region server which has not called regionServerReport yet (was: Wai

[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3266: URL: https://github.com/apache/hbase/pull/3266#issuecomment-841294935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s

[GitHub] [hbase] Apache-HBase commented on pull request #3267: HBASE-25872 Add documentation for LoadBalancer about synchronization

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3267: URL: https://github.com/apache/hbase/pull/3267#issuecomment-841284259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55

[GitHub] [hbase] Apache-HBase commented on pull request #3262: HBASE-25883 The regionFinder may be used in XXXAsignment method so sh…

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3262: URL: https://github.com/apache/hbase/pull/3262#issuecomment-841283809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37

[GitHub] [hbase] Apache-HBase commented on pull request #3267: HBASE-25872 Add documentation for LoadBalancer about synchronization

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3267: URL: https://github.com/apache/hbase/pull/3267#issuecomment-841282989 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] Apache-HBase commented on pull request #3267: HBASE-25872 Add documentation for LoadBalancer about synchronization

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3267: URL: https://github.com/apache/hbase/pull/3267#issuecomment-841280046 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28

[GitHub] [hbase] Apache-HBase commented on pull request #3262: HBASE-25883 The regionFinder may be used in XXXAsignment method so sh…

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3262: URL: https://github.com/apache/hbase/pull/3262#issuecomment-841277857 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #3262: HBASE-25883 The regionFinder may be used in XXXAsignment method so sh…

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3262: URL: https://github.com/apache/hbase/pull/3262#issuecomment-841277155 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] frostruan commented on a change in pull request #3261: HBASE-25880 remove files from filesCompacting when clear compaction queue

2021-05-14 Thread GitBox
frostruan commented on a change in pull request #3261: URL: https://github.com/apache/hbase/pull/3261#discussion_r631736048 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1953,6 +1954,24 @@ private void addToCompactingFiles(Col

[GitHub] [hbase] Apache-HBase commented on pull request #3249: HBASE-25861 Correct the usage of Configuration#addDeprecation

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3249: URL: https://github.com/apache/hbase/pull/3249#issuecomment-841266230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10

[GitHub] [hbase] Apache9 opened a new pull request #3267: HBASE-25872 Add documentation for LoadBalancer about synchronization

2021-05-14 Thread GitBox
Apache9 opened a new pull request #3267: URL: https://github.com/apache/hbase/pull/3267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[jira] [Updated] (HBASE-25883) The regionFinder and rackManager fields in BaseLoadBalancer should be volatile

2021-05-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25883: -- Summary: The regionFinder and rackManager fields in BaseLoadBalancer should be volatile (was: The reg

[jira] [Updated] (HBASE-25883) The regionFinder and rackManager fields in BaseLoadBalancer should be volatile

2021-05-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25883: -- Description: As they may be changed after intialization by calling onConfigurationChange, we need to m

[jira] [Commented] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344609#comment-17344609 ] Reid Chan commented on HBASE-25890: --- The build command in {{mvninstall}} is {code} mv

[jira] [Commented] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344605#comment-17344605 ] Reid Chan commented on HBASE-25890: --- the -U didn't take effect in {{mvninstall}}. Chec

[jira] [Issue Comment Deleted] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25890: -- Comment: was deleted (was: After PR#3265, the 2nd warning ".* cached in the local repository" is gone

[jira] [Commented] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344591#comment-17344591 ] Reid Chan commented on HBASE-25890: --- After PR#3265, the 2nd warning ".* cached in the

[jira] [Commented] (HBASE-25858) [branch-1] make hbase-thrift optional in hbase-assembly module

2021-05-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344589#comment-17344589 ] Reid Chan commented on HBASE-25858: --- Filed HBASE-25890, cc [~apurtell] > [branch-1] m

[GitHub] [hbase] Apache-HBase commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-841235550 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s

[GitHub] [hbase] virajjasani edited a comment on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-14 Thread GitBox
virajjasani edited a comment on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-841232549 @apurtell @bharathv @shahrs87 As we had a little chat over Disruptor's constructor (as per 3.4.2 version) when I mentioned about ExecutorService being deprecated fro

[GitHub] [hbase] virajjasani commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-14 Thread GitBox
virajjasani commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-841232549 @apurtell @bharathv @shahrs87 As we had a little chat over Disruptor's constructor (as per 3.4.2 version) when I mentioned about ExecutorService being deprecated from it's

[GitHub] [hbase] virajjasani commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-14 Thread GitBox
virajjasani commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r632509358 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws I

[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3266: URL: https://github.com/apache/hbase/pull/3266#issuecomment-841213751 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s

[GitHub] [hbase] nyl3532016 opened a new pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-14 Thread GitBox
nyl3532016 opened a new pull request #3266: URL: https://github.com/apache/hbase/pull/3266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3249: HBASE-25861 Correct the usage of Configuration#addDeprecation

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3249: URL: https://github.com/apache/hbase/pull/3249#issuecomment-841160089 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[jira] [Resolved] (HBASE-25884) NPE while getting Balancer decisions

2021-05-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25884. -- Hadoop Flags: Reviewed Resolution: Fixed Thanks for the review [~stack] [~zhangduo] [~mn

[jira] [Commented] (HBASE-25790) NamedQueue 'BalancerRejection' for recent history of balancer skipping

2021-05-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344502#comment-17344502 ] Viraj Jasani commented on HBASE-25790: -- [~GeorryHuang] Nothing to worry here, this

[GitHub] [hbase] Reidddddd merged pull request #3265: HBASE-25890 [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread GitBox
Reidd merged pull request #3265: URL: https://github.com/apache/hbase/pull/3265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] Apache-HBase commented on pull request #3265: HBASE-25890 [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #3265: URL: https://github.com/apache/hbase/pull/3265#issuecomment-841136703 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 12

[jira] [Commented] (HBASE-25790) NamedQueue 'BalancerRejection' for recent history of balancer skipping

2021-05-14 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344492#comment-17344492 ] Zhuoyue Huang commented on HBASE-25790: --- [~vjasani]  Thanks for reviewing. BTW, is

[GitHub] [hbase] Reidddddd opened a new pull request #3265: HBASE-25890 [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread GitBox
Reidd opened a new pull request #3265: URL: https://github.com/apache/hbase/pull/3265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #2380: HBASE-25010 `assert` on allocated buffer sizes before making calls to `Unsafe.copyMemory`

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #2380: URL: https://github.com/apache/hbase/pull/2380#issuecomment-841120741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[jira] [Resolved] (HBASE-25874) [hbase-operator-tools]Add tool for identifying "unknown servers" from master logs, then submit SCPs for each of those.

2021-05-14 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25874. -- Release Note: RegionsOnUnknownServersRecoverer parses the master log to identi

[GitHub] [hbase] Apache-HBase commented on pull request #2380: HBASE-25010 `assert` on allocated buffer sizes before making calls to `Unsafe.copyMemory`

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #2380: URL: https://github.com/apache/hbase/pull/2380#issuecomment-841119349 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] Apache-HBase commented on pull request #2885: HBASE-25510 Optimize TableName.valueOf from O(n) to O(1)

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #2885: URL: https://github.com/apache/hbase/pull/2885#issuecomment-841119416 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #2885: HBASE-25510 Optimize TableName.valueOf from O(n) to O(1)

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #2885: URL: https://github.com/apache/hbase/pull/2885#issuecomment-841118308 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38

[GitHub] [hbase-operator-tools] wchevreuil merged pull request #86: HBASE-25874 [hbase-operator-tools]Add tool for identifying 'unknown s…

2021-05-14 Thread GitBox
wchevreuil merged pull request #86: URL: https://github.com/apache/hbase-operator-tools/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [hbase] Apache-HBase commented on pull request #2885: HBASE-25510 Optimize TableName.valueOf from O(n) to O(1)

2021-05-14 Thread GitBox
Apache-HBase commented on pull request #2885: URL: https://github.com/apache/hbase/pull/2885#issuecomment-841115570 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59

[jira] [Updated] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25890: -- Description: {code} [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve depen

  1   2   >