[jira] [Commented] (HBASE-25791) UI of master-status to show a recent history of that why balancer was rejected to run

2021-05-17 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346622#comment-17346622 ] Zhuoyue Huang commented on HBASE-25791: --- {quote}When setting "hbase.master.loadbal

[GitHub] [hbase] Apache-HBase commented on pull request #3025: HBASE-25517 Support parallel balance RSGroups

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3025: URL: https://github.com/apache/hbase/pull/3025#issuecomment-842885478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #3025: HBASE-25517 Support parallel balance RSGroups

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3025: URL: https://github.com/apache/hbase/pull/3025#issuecomment-842883411 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-842880689 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] Apache-HBase commented on pull request #3275: HBASE-25791 UI of master-status to show a recent history of that why …

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3275: URL: https://github.com/apache/hbase/pull/3275#issuecomment-842873253 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-17 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r634042915 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -18,37 +18,117 @@ package org.apache.ha

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-842838602 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 1s

[GitHub] [hbase] Apache-HBase commented on pull request #3260: HBASE-25882 TableSkewCostFunction may cost unnecessary calculation st…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3260: URL: https://github.com/apache/hbase/pull/3260#issuecomment-842822527 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42

[GitHub] [hbase] Apache-HBase commented on pull request #3025: HBASE-25517 Support parallel balance RSGroups

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3025: URL: https://github.com/apache/hbase/pull/3025#issuecomment-842816053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35

[jira] [Commented] (HBASE-25791) UI of master-status to show a recent history of that why balancer was rejected to run

2021-05-17 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346573#comment-17346573 ] Xiaolin Ha commented on HBASE-25791: When setting "hbase.master.loadbalance.bytable"

[jira] [Comment Edited] (HBASE-25888) Backup tests are categorically flakey

2021-05-17 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346564#comment-17346564 ] Mallikarjun edited comment on HBASE-25888 at 5/18/21, 3:55 AM: ---

[jira] [Commented] (HBASE-25888) Backup tests are categorically flakey

2021-05-17 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346571#comment-17346571 ] Mallikarjun commented on HBASE-25888: - [~ndimiduk]  Let me try to reproduce zookeepe

[jira] [Comment Edited] (HBASE-25888) Backup tests are categorically flakey

2021-05-17 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346564#comment-17346564 ] Mallikarjun edited comment on HBASE-25888 at 5/18/21, 3:45 AM: ---

[jira] [Comment Edited] (HBASE-25888) Backup tests are categorically flakey

2021-05-17 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346564#comment-17346564 ] Mallikarjun edited comment on HBASE-25888 at 5/18/21, 3:44 AM: ---

[jira] [Commented] (HBASE-25888) Backup tests are categorically flakey

2021-05-17 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346564#comment-17346564 ] Mallikarjun commented on HBASE-25888: - [~ndimiduk] I see the link is no longer valid

[GitHub] [hbase] Apache-HBase commented on pull request #3275: HBASE-25791 UI of master-status to show a recent history of that why …

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3275: URL: https://github.com/apache/hbase/pull/3275#issuecomment-842801776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8

[jira] [Commented] (HBASE-25791) UI of master-status to show a recent history of that why balancer was rejected to run

2021-05-17 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346559#comment-17346559 ] Zhuoyue Huang commented on HBASE-25791: --- Added a tab in the navigation bar that le

[jira] [Updated] (HBASE-25791) UI of master-status to show a recent history of that why balancer was rejected to run

2021-05-17 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25791: -- Attachment: image-2021-05-18-11-31-21-001.png > UI of master-status to show a recent history o

[GitHub] [hbase] GeorryHuang opened a new pull request #3275: HBASE-25791 UI of master-status to show a recent history of that why …

2021-05-17 Thread GitBox
GeorryHuang opened a new pull request #3275: URL: https://github.com/apache/hbase/pull/3275 …balancer was rejected to run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-842788620 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[jira] [Resolved] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-17 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25032. --- Fix Version/s: 2.4.4 2.3.6 Release Note: After this change a region server

[GitHub] [hbase] ZhaoBQ commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-17 Thread GitBox
ZhaoBQ commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-842787994 Thanks @pankaj72981 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346539#comment-17346539 ] Hudson commented on HBASE-25875: Results for branch branch-2.4 [build #120 on b

[GitHub] [hbase] ZhaoBQ commented on a change in pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-17 Thread GitBox
ZhaoBQ commented on a change in pull request #3271: URL: https://github.com/apache/hbase/pull/3271#discussion_r633983618 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java ## @@ -77,6 +81,39 @@ private static void checkDefaultsVersion(Conf

[jira] [Commented] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-17 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346534#comment-17346534 ] Reid Chan commented on HBASE-25890: --- ping [~andrew.purt...@gmail.com]w > [branch-1] a

[jira] [Work started] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception

2021-05-17 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25848 started by Sandeep Pal. --- > Add flexibility to backup replication in case replication filter throws an > e

[GitHub] [hbase] Apache-HBase commented on pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3271: URL: https://github.com/apache/hbase/pull/3271#issuecomment-842766351 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 0

[jira] [Updated] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception

2021-05-17 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-25848: Description: There may be situations when the wal entry filter might result in some temporary issu

[GitHub] [hbase] Apache-HBase commented on pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3271: URL: https://github.com/apache/hbase/pull/3271#issuecomment-842739436 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 43

[GitHub] [hbase] Apache9 merged pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-17 Thread GitBox
Apache9 merged pull request #3268: URL: https://github.com/apache/hbase/pull/3268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [hbase] Apache-HBase commented on pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3271: URL: https://github.com/apache/hbase/pull/3271#issuecomment-842651270 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hbase] Apache-HBase commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-842602653 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s

[GitHub] [hbase] ndimiduk commented on a change in pull request #3271: Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

2021-05-17 Thread GitBox
ndimiduk commented on a change in pull request #3271: URL: https://github.com/apache/hbase/pull/3271#discussion_r633826411 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java ## @@ -77,6 +81,39 @@ private static void checkDefaultsVersion(Co

[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-17 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r633805051 ## File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto ## @@ -32,6 +32,8 @@ message WALHeader { optional bool has_tag_compression

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-842584702 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-842582540 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 54s

[jira] [Updated] (HBASE-25893) Corruption in recovered WAL in WALSplitter

2021-05-17 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25893: - Description: Recently we encountered RS aborts due to NPE while replaying edits from split logs

[jira] [Updated] (HBASE-25893) Corruption in recovered WAL in WALSplitter

2021-05-17 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25893: - Description: Recently we encountered RS aborts due to NPE while replaying edits from split logs

[GitHub] [hbase] Apache-HBase commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-842558798 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28

[jira] [Updated] (HBASE-25893) Corruption in recovered WAL in WALSplitter

2021-05-17 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25893: - Description: Recently we encountered RS aborts due to NPE while replaying edits from split logs

[GitHub] [hbase] Apache-HBase commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-842557055 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 53s

[GitHub] [hbase] shahrs87 commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
shahrs87 commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r633785598 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[GitHub] [hbase] Apache-HBase commented on pull request #3140: HBASE-25720 Sync WAL stuck when prepare flush cache will prevent flus…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3140: URL: https://github.com/apache/hbase/pull/3140#issuecomment-842541333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [hbase] Apache-HBase commented on pull request #3272: HBASE-25875 RegionServer failed to start with IllegalThreadStateException due to race condition in AuthenticationTokenSecretManager

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3272: URL: https://github.com/apache/hbase/pull/3272#issuecomment-842108674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [hbase] ZhaoBQ commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-17 Thread GitBox
ZhaoBQ commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-842223896 Sorry to disturb you @pankaj72981 , could this issue be finished? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hbase] Apache9 merged pull request #3267: HBASE-25872 Add documentation for LoadBalancer about synchronization

2021-05-17 Thread GitBox
Apache9 merged pull request #3267: URL: https://github.com/apache/hbase/pull/3267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [hbase] shahrs87 commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
shahrs87 commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r633637658 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[GitHub] [hbase] Apache-HBase commented on pull request #3273: HBASE-25892: 'False' should be 'True' in auditlog of listLabels

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3273: URL: https://github.com/apache/hbase/pull/3273#issuecomment-842314911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [hbase] pankaj72981 commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-17 Thread GitBox
pankaj72981 commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-842400625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queri

[GitHub] [hbase] pankaj72981 merged pull request #3250: HBASE-25875 RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-17 Thread GitBox
pankaj72981 merged pull request #3250: URL: https://github.com/apache/hbase/pull/3250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [hbase] bharathv commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
bharathv commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r633693619 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[GitHub] [hbase] pankaj72981 merged pull request #3272: HBASE-25875 RegionServer failed to start with IllegalThreadStateException due to race condition in AuthenticationTokenSecretManager

2021-05-17 Thread GitBox
pankaj72981 merged pull request #3272: URL: https://github.com/apache/hbase/pull/3272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [hbase] Apache-HBase commented on pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3139: URL: https://github.com/apache/hbase/pull/3139#issuecomment-841971335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-84291 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

[GitHub] [hbase] saintstack commented on a change in pull request #3261: HBASE-25880 remove files from filesCompacting when clear compaction queue

2021-05-17 Thread GitBox
saintstack commented on a change in pull request #3261: URL: https://github.com/apache/hbase/pull/3261#discussion_r633285717 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java ## @@ -794,13 +795,30 @@ void shutdownLongCompactions(){

[GitHub] [hbase] Apache-HBase commented on pull request #3140: HBASE-25720 Sync WAL stuck when prepare flush cache will prevent flus…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3140: URL: https://github.com/apache/hbase/pull/3140#issuecomment-842396746 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36

[GitHub] [hbase] Apache9 commented on a change in pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-17 Thread GitBox
Apache9 commented on a change in pull request #3268: URL: https://github.com/apache/hbase/pull/3268#discussion_r633416141 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java ## @@ -76,7 +76,7 @@ private MasterServices maste

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-17 Thread GitBox
nyl3532016 commented on a change in pull request #3266: URL: https://github.com/apache/hbase/pull/3266#discussion_r633308440 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java ## @@ -253,6 +256,12 @@ private void init(final int nMasterNodes,

[GitHub] [hbase] pankaj72981 commented on pull request #3250: HBASE-25875 RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-17 Thread GitBox
pankaj72981 commented on pull request #3250: URL: https://github.com/apache/hbase/pull/3250#issuecomment-842048393 Test case failures are not relevant, passing locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] Apache-HBase commented on pull request #3025: HBASE-25517 Support parallel balance RSGroups

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3025: URL: https://github.com/apache/hbase/pull/3025#issuecomment-842162337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[jira] [Updated] (HBASE-25893) Corruption in recovered WAL in WALSplitter

2021-05-17 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25893: - Priority: Critical (was: Major) > Corruption in recovered WAL in WALSplitter >

[jira] [Created] (HBASE-25893) Corruption in recovered WAL in WALSplitter

2021-05-17 Thread Rushabh Shah (Jira)
Rushabh Shah created HBASE-25893: Summary: Corruption in recovered WAL in WALSplitter Key: HBASE-25893 URL: https://issues.apache.org/jira/browse/HBASE-25893 Project: HBase Issue Type: Improv

[GitHub] [hbase] saintstack commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-17 Thread GitBox
saintstack commented on a change in pull request #3266: URL: https://github.com/apache/hbase/pull/3266#discussion_r633274298 ## File path: hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/CompactionServerTests.java ## @@ -0,0 +1,4 @@ +package org.apac

[GitHub] [hbase] saintstack commented on a change in pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-17 Thread GitBox
saintstack commented on a change in pull request #3268: URL: https://github.com/apache/hbase/pull/3268#discussion_r633272880 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java ## @@ -76,7 +76,7 @@ private MasterServices ma

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-17 Thread GitBox
anoopsjohn commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r633042493 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java ## @@ -890,4 +892,60 @@ public void testDBEShipped() throws IOE

[GitHub] [hbase] Apache-HBase commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-842520261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[jira] [Commented] (HBASE-25883) The regionFinder and rackManager fields in BaseLoadBalancer should be volatile

2021-05-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346322#comment-17346322 ] Hudson commented on HBASE-25883: Results for branch branch-2 [build #252 on bui

[jira] [Commented] (HBASE-25872) Add documentation for LoadBalancer about synchronization

2021-05-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346323#comment-17346323 ] Hudson commented on HBASE-25872: Results for branch branch-2 [build #252 on bui

[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346325#comment-17346325 ] Hudson commented on HBASE-25875: Results for branch branch-2 [build #252 on bui

[GitHub] [hbase] bharathv commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
bharathv commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r633735534 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[jira] [Updated] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-17 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25875: - Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Updated] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-17 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25875: - Fix Version/s: 2.4.4 > RegionServer failed to start due to IllegalThreadStateException in > Aut

[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-17 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346294#comment-17346294 ] Pankaj Kumar commented on HBASE-25875: -- Thanks [~apurtell], pushed to branch-2.4.

[GitHub] [hbase] shahrs87 commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
shahrs87 commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r633704835 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[GitHub] [hbase] shahrs87 commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
shahrs87 commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r633704835 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346264#comment-17346264 ] Andrew Kyle Purtell commented on HBASE-25875: - The branch is open. Please co

[GitHub] [hbase] bharathv commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
bharathv commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r633693619 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[GitHub] [hbase] Apache-HBase commented on pull request #3273: HBASE-25892: 'False' should be 'True' in auditlog of listLabels

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3273: URL: https://github.com/apache/hbase/pull/3273#issuecomment-842470391 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-84291 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

[GitHub] [hbase] Apache-HBase commented on pull request #3273: HBASE-25892: 'False' should be 'True' in auditlog of listLabels

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3273: URL: https://github.com/apache/hbase/pull/3273#issuecomment-842436282 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s

[GitHub] [hbase] Apache-HBase commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-842430488 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2

[GitHub] [hbase] Apache-HBase commented on pull request #3025: HBASE-25517 Support parallel balance RSGroups

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3025: URL: https://github.com/apache/hbase/pull/3025#issuecomment-842429777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36

[GitHub] [hbase] Apache-HBase commented on pull request #3025: HBASE-25517 Support parallel balance RSGroups

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3025: URL: https://github.com/apache/hbase/pull/3025#issuecomment-842428446 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s

[GitHub] [hbase] pankaj72981 commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-17 Thread GitBox
pankaj72981 commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-842428012 @saintstack Do you want to have a look on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hbase] shahrs87 commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
shahrs87 commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r633638065 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[GitHub] [hbase] shahrs87 commented on a change in pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-17 Thread GitBox
shahrs87 commented on a change in pull request #3264: URL: https://github.com/apache/hbase/pull/3264#discussion_r633637658 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java ## @@ -1120,8 +1120,18 @@ public void shutdown() throws IOEx

[GitHub] [hbase] pankaj72981 commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-17 Thread GitBox
pankaj72981 commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-842400625 Oh my bad, i missed this nice change. Let me push this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [hbase] Apache9 opened a new pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-17 Thread GitBox
Apache9 opened a new pull request #3274: URL: https://github.com/apache/hbase/pull/3274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[jira] [Updated] (HBASE-25873) Refactor and cleanup the code for CostFunction

2021-05-17 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25873: -- Summary: Refactor and cleanup the code for CostFunction (was: Revisit the implementation of CostFunct

[jira] [Updated] (HBASE-25873) Refactor and cleanup the code for CostFunction

2021-05-17 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25873: -- Description: For later performance improvements. > Refactor and cleanup the code for CostFunction > --

[GitHub] [hbase] Apache-HBase commented on pull request #3140: HBASE-25720 Sync WAL stuck when prepare flush cache will prevent flus…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3140: URL: https://github.com/apache/hbase/pull/3140#issuecomment-842396746 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36

[GitHub] [hbase] Apache-HBase commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-842386508 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39

[jira] [Updated] (HBASE-25322) Redundant Reference file in bottom region of split

2021-05-17 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25322: --- Parent: HBASE-25302 Issue Type: Sub-task (was: Improvement) > Redundant Reference file in b

[jira] [Updated] (HBASE-25302) [Umbrella]Fast split regions and lightweight compaction with stripe store engine

2021-05-17 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25302: --- Summary: [Umbrella]Fast split regions and lightweight compaction with stripe store engine (was: Fas

[jira] [Updated] (HBASE-25302) Fast split regions and lightweight compaction with stripe store engine

2021-05-17 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25302: --- Issue Type: Umbrella (was: Improvement) > Fast split regions and lightweight compaction with stripe

[GitHub] [hbase] Apache-HBase commented on pull request #3268: HBASE-25032 Do not assign regions to region server which has not call…

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3268: URL: https://github.com/apache/hbase/pull/3268#issuecomment-842329260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39

[jira] [Commented] (HBASE-25872) Add documentation for LoadBalancer about synchronization

2021-05-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346171#comment-17346171 ] Hudson commented on HBASE-25872: Results for branch master [build #295 on build

[GitHub] [hbase] Apache-HBase commented on pull request #3025: HBASE-25517 Support parallel balance RSGroups

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3025: URL: https://github.com/apache/hbase/pull/3025#issuecomment-842325288 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[GitHub] [hbase] Apache-HBase commented on pull request #3273: HBASE-25892: 'False' should be 'True' in auditlog of listLabels

2021-05-17 Thread GitBox
Apache-HBase commented on pull request #3273: URL: https://github.com/apache/hbase/pull/3273#issuecomment-842314911 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 37

[jira] [Updated] (HBASE-25892) 'False' should be 'True' in auditlog of listLabels

2021-05-17 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25892: -- Description: In method `listLabels` at line 932, it should be {code:java} logResult(true, "listLabels", "Listi

  1   2   >