[GitHub] [hbase] Apache-HBase commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-858332090 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] saintstack commented on a change in pull request #3371: HBASE-25984: Avoid premature reuse of sync futures in FSHLog [DRAFT]

2021-06-09 Thread GitBox
saintstack commented on a change in pull request #3371: URL: https://github.com/apache/hbase/pull/3371#discussion_r648866811 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java ## @@ -263,6 +263,14 @@ public AsyncFSWAL(FileSystem f

[jira] [Commented] (HBASE-25596) Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL

2021-06-09 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360571#comment-17360571 ] Sandeep Pal commented on HBASE-25596: - I will try to write a UT for this.  >>To be

[jira] [Commented] (HBASE-25391) Flush directly into data directory, skip rename when committing flush

2021-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360560#comment-17360560 ] Michael Stack commented on HBASE-25391: --- Yeah, what [~anoop.hbase]  said. Trying t

[jira] [Commented] (HBASE-25987) Make SSL keystore type configurable for HBase ThriftServer

2021-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360558#comment-17360558 ] Hudson commented on HBASE-25987: Results for branch branch-2.4 [build #139 on b

[jira] [Commented] (HBASE-25391) Flush directly into data directory, skip rename when committing flush

2021-06-09 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360553#comment-17360553 ] Anoop Sam John commented on HBASE-25391: Can we have a Release Notes pls? So thi

[GitHub] [hbase] mnpoonia opened a new pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-09 Thread GitBox
mnpoonia opened a new pull request #3372: URL: https://github.com/apache/hbase/pull/3372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (HBASE-25596) Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL

2021-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360531#comment-17360531 ] Duo Zhang commented on HBASE-25596: --- To be more clear, if we hit EOFException, it mean

[jira] [Commented] (HBASE-25596) Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL

2021-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360530#comment-17360530 ] Duo Zhang commented on HBASE-25596: --- Have you seen what I said above? In ProtobufLogRe

[jira] [Commented] (HBASE-25596) Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL

2021-06-09 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360525#comment-17360525 ] Sandeep Pal commented on HBASE-25596: - [~zhangduo] This is where I think we will not

[jira] [Resolved] (HBASE-25967) The readRequestsCount does not calculate when the outResults is empty

2021-06-09 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang resolved HBASE-25967. Resolution: Fixed > The readRequestsCount does not calculate when the outResults is empty > --

[jira] [Updated] (HBASE-25967) The readRequestsCount does not calculate when the outResults is empty

2021-06-09 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-25967: --- Fix Version/s: 2.4.5 3.0.0-alpha-2 2.3.6 2.5

[jira] [Commented] (HBASE-25967) The readRequestsCount does not calculate when the outResults is empty

2021-06-09 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360520#comment-17360520 ] Zheng Wang commented on HBASE-25967: Pushed to 2.3+ > The readRequestsCount does no

[jira] [Commented] (HBASE-25981) JVM crash when displaying regionserver UI

2021-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360516#comment-17360516 ] Hudson commented on HBASE-25981: Results for branch branch-2 [build #273 on bui

[jira] [Commented] (HBASE-25987) Make SSL keystore type configurable for HBase ThriftServer

2021-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360517#comment-17360517 ] Hudson commented on HBASE-25987: Results for branch branch-2 [build #273 on bui

[jira] [Created] (HBASE-25991) do compaction on compaction server

2021-06-09 Thread Yulin Niu (Jira)
Yulin Niu created HBASE-25991: - Summary: do compaction on compaction server Key: HBASE-25991 URL: https://issues.apache.org/jira/browse/HBASE-25991 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] bsglz merged pull request #3351: HBASE-25967 The readRequestsCount does not calculate when the outResu…

2021-06-09 Thread GitBox
bsglz merged pull request #3351: URL: https://github.com/apache/hbase/pull/3351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-09 Thread GitBox
tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-858211968 Hi @saintstack @Apache9 , could you please help me merge the code if there are no other problems. Thanks a lot. -- This is an automated message from the Apache Git Service. To r

[GitHub] [hbase] Apache-HBase commented on pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3370: URL: https://github.com/apache/hbase/pull/3370#issuecomment-858211397 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s

[GitHub] [hbase] Apache-HBase commented on pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3370: URL: https://github.com/apache/hbase/pull/3370#issuecomment-858207861 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s

[GitHub] [hbase] Apache-HBase commented on pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3370: URL: https://github.com/apache/hbase/pull/3370#issuecomment-858203641 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[jira] [Resolved] (HBASE-25920) Support Hadoop 3.3.1

2021-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25920. --- Hadoop Flags: Reviewed Release Note: Fixes to make unit tests pass and to make it so an h

[jira] [Commented] (HBASE-25920) Support Hadoop 3.3.1

2021-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360460#comment-17360460 ] Michael Stack commented on HBASE-25920: --- So, w/ HBASE-25989 in place, I can't get

[GitHub] [hbase] Apache-HBase commented on pull request #3371: HBASE-25984: Avoid premature reuse of sync futures in FSHLog [DRAFT]

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3371: URL: https://github.com/apache/hbase/pull/3371#issuecomment-858154207 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s

[GitHub] [hbase] Apache-HBase commented on pull request #3371: HBASE-25984: Avoid premature reuse of sync futures in FSHLog [DRAFT]

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3371: URL: https://github.com/apache/hbase/pull/3371#issuecomment-858149359 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[GitHub] [hbase] Apache-HBase commented on pull request #3371: HBASE-25984: Avoid premature reuse of sync futures in FSHLog [DRAFT]

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3371: URL: https://github.com/apache/hbase/pull/3371#issuecomment-858148811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #3371: HBASE-25984: Avoid premature reuse of sync futures in FSHLog [DRAFT]

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3371: URL: https://github.com/apache/hbase/pull/3371#issuecomment-858126807 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s

[GitHub] [hbase] Apache-HBase commented on pull request #3371: HBASE-25984: Avoid premature reuse of sync futures in FSHLog [DRAFT]

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3371: URL: https://github.com/apache/hbase/pull/3371#issuecomment-858118713 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[GitHub] [hbase] Apache-HBase commented on pull request #3371: HBASE-25984: Avoid premature reuse of sync futures in FSHLog [DRAFT]

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3371: URL: https://github.com/apache/hbase/pull/3371#issuecomment-858117335 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[GitHub] [hbase] bharathv commented on a change in pull request #3371: HBASE-25984: Avoid premature reuse of sync futures in FSHLog [DRAFT]

2021-06-09 Thread GitBox
bharathv commented on a change in pull request #3371: URL: https://github.com/apache/hbase/pull/3371#discussion_r648697770 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java ## @@ -263,6 +263,14 @@ public AsyncFSWAL(FileSystem fs,

[GitHub] [hbase] Apache-HBase commented on pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3370: URL: https://github.com/apache/hbase/pull/3370#issuecomment-858110699 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 42s

[GitHub] [hbase] Apache-HBase commented on pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3370: URL: https://github.com/apache/hbase/pull/3370#issuecomment-858110120 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s

[jira] [Commented] (HBASE-25984) FSHLog WAL lockup with sync future reuse [RS deadlock]

2021-06-09 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360389#comment-17360389 ] Andrew Kyle Purtell commented on HBASE-25984: - FWIW I would prefer we use Th

[jira] [Commented] (HBASE-25984) FSHLog WAL lockup with sync future reuse [RS deadlock]

2021-06-09 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360383#comment-17360383 ] Bharath Vissapragada commented on HBASE-25984: -- After reading the AsyncFSWA

[GitHub] [hbase] Apache-HBase commented on pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3370: URL: https://github.com/apache/hbase/pull/3370#issuecomment-858095173 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] bharathv opened a new pull request #3371: HBASE-25984: Avoid premature reuse of sync futures in FSHLog [DRAFT]

2021-06-09 Thread GitBox
bharathv opened a new pull request #3371: URL: https://github.com/apache/hbase/pull/3371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (HBASE-25969) Cleanup netty-all transitive includes

2021-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360363#comment-17360363 ] Hudson commented on HBASE-25969: Results for branch master [build #319 on build

[jira] [Commented] (HBASE-25981) JVM crash when displaying regionserver UI

2021-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360364#comment-17360364 ] Hudson commented on HBASE-25981: Results for branch master [build #319 on build

[jira] [Commented] (HBASE-25769) Update default weight of cost functions

2021-06-09 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360329#comment-17360329 ] Clara Xiong commented on HBASE-25769: - We cannot set bytable on because we are domin

[jira] [Commented] (HBASE-25666) Explain why balancer is skipping runs

2021-06-09 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360324#comment-17360324 ] Clara Xiong commented on HBASE-25666: - I reopened this Jira to add more logging but

[jira] [Commented] (HBASE-25981) JVM crash when displaying regionserver UI

2021-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360316#comment-17360316 ] Hudson commented on HBASE-25981: Results for branch branch-2.4 [build #138 on b

[jira] [Commented] (HBASE-25729) Upgrade to latest hbase-thirdparty

2021-06-09 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360312#comment-17360312 ] Pankaj Kumar commented on HBASE-25729: -- I too feel it is little risky to upgrade th

[jira] [Commented] (HBASE-25729) Upgrade to latest hbase-thirdparty

2021-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360303#comment-17360303 ] Michael Stack commented on HBASE-25729: --- [~apurtell] and [~pankajkumar]  See above

[jira] [Commented] (HBASE-25990) Add donated buildbots for jenkins

2021-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360300#comment-17360300 ] Michael Stack commented on HBASE-25990: --- After running the script, reached out to

[GitHub] [hbase] ben-manes commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-06-09 Thread GitBox
ben-manes commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r648556289 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean containsBlock(Blo

[GitHub] [hbase] ben-manes commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-06-09 Thread GitBox
ben-manes commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r648556289 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean containsBlock(Blo

[GitHub] [hbase] virajjasani commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-06-09 Thread GitBox
virajjasani commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r648542799 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean containsBlock(B

[GitHub] [hbase] virajjasani commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-06-09 Thread GitBox
virajjasani commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r648564135 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean containsBlock(B

[jira] [Commented] (HBASE-25969) Cleanup netty-all transitive includes

2021-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360272#comment-17360272 ] Hudson commented on HBASE-25969: Results for branch branch-2 [build #272 on bui

[GitHub] [hbase] Apache-HBase commented on pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3370: URL: https://github.com/apache/hbase/pull/3370#issuecomment-857942546 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 37s

[GitHub] [hbase] Apache-HBase commented on pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3350: URL: https://github.com/apache/hbase/pull/3350#issuecomment-857938738 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[GitHub] [hbase] ben-manes commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-06-09 Thread GitBox
ben-manes commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r648556289 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean containsBlock(Blo

[GitHub] [hbase] Apache-HBase commented on pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3370: URL: https://github.com/apache/hbase/pull/3370#issuecomment-857933746 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3370: URL: https://github.com/apache/hbase/pull/3370#issuecomment-857933462 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s

[jira] [Resolved] (HBASE-25971) FanOutOneBlockAsyncDFSOutputHelper stuck when run against hadoop-3.3.1-RC3

2021-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25971. --- Resolution: Not A Problem Resolving as 'Not a problem'. This seems to have been some issue a

[jira] [Commented] (HBASE-25920) Support Hadoop 3.3.1

2021-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360255#comment-17360255 ] Michael Stack commented on HBASE-25920: --- TestLogRolling fails most of the time. I

[GitHub] [hbase] virajjasani commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-06-09 Thread GitBox
virajjasani commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r648542799 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean containsBlock(B

[GitHub] [hbase] virajjasani commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-06-09 Thread GitBox
virajjasani commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r648542799 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean containsBlock(B

[jira] [Commented] (HBASE-25990) Add donated buildbots for jenkins

2021-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360253#comment-17360253 ] Michael Stack commented on HBASE-25990: --- !https://lh5.googleusercontent.com/m8S_cq

[jira] [Created] (HBASE-25990) Add donated buildbots for jenkins

2021-06-09 Thread Michael Stack (Jira)
Michael Stack created HBASE-25990: - Summary: Add donated buildbots for jenkins Key: HBASE-25990 URL: https://issues.apache.org/jira/browse/HBASE-25990 Project: HBase Issue Type: Task

[GitHub] [hbase] Apache-HBase commented on pull request #3368: HBASE-25989 FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdf…

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3368: URL: https://github.com/apache/hbase/pull/3368#issuecomment-857904181 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6

[GitHub] [hbase] Apache-HBase commented on pull request #3369: HBASE-25859 Reference class incorrectly parses the protobuf magic marker

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3369: URL: https://github.com/apache/hbase/pull/3369#issuecomment-857897042 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #3368: HBASE-25989 FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdf…

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3368: URL: https://github.com/apache/hbase/pull/3368#issuecomment-857896720 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #3368: HBASE-25989 FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdf…

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3368: URL: https://github.com/apache/hbase/pull/3368#issuecomment-857895440 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1

[GitHub] [hbase] clarax opened a new pull request #3370: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-06-09 Thread GitBox
clarax opened a new pull request #3370: URL: https://github.com/apache/hbase/pull/3370 This is to reapply https://github.com/apache/hbase/pull/3067 since the trunk is significantly refactored. The old PR was merged but reverted for flaky test. Will work from here on the flaky tests. --

[GitHub] [hbase] catalin-luca commented on pull request #3369: HBASE-25859 Reference class incorrectly parses the protobuf magic marker

2021-06-09 Thread GitBox
catalin-luca commented on pull request #3369: URL: https://github.com/apache/hbase/pull/3369#issuecomment-857887955 This is a back port of: https://issues.apache.org/jira/browse/HBASE-25859 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] catalin-luca opened a new pull request #3369: HBASE-25859 Reference class incorrectly parses the protobuf magic marker

2021-06-09 Thread GitBox
catalin-luca opened a new pull request #3369: URL: https://github.com/apache/hbase/pull/3369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [hbase-filesystem] steveloughran commented on pull request #23: HBASE-25900. HBoss tests compile/failure against Hadoop 3.3.1

2021-06-09 Thread GitBox
steveloughran commented on pull request #23: URL: https://github.com/apache/hbase-filesystem/pull/23#issuecomment-857882775 (i.e. the change in tagging was to let people editing it know of an external use) -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [hbase-filesystem] steveloughran commented on pull request #23: HBASE-25900. HBoss tests compile/failure against Hadoop 3.3.1

2021-06-09 Thread GitBox
steveloughran commented on pull request #23: URL: https://github.com/apache/hbase-filesystem/pull/23#issuecomment-857882046 I didn't mark it as evolving Until the change went in. Before then it was tagged as private I only marked it as limited public/evolving afterwards as * I'd f

[GitHub] [hbase] saintstack commented on pull request #3368: HBASE-25989 FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdf…

2021-06-09 Thread GitBox
saintstack commented on pull request #3368: URL: https://github.com/apache/hbase/pull/3368#issuecomment-857876036 For example, https://stackoverflow.com/questions/7007831/instantiate-nested-static-class-using-class-forname A test for this is tough because would need to change assert

[GitHub] [hbase] saintstack opened a new pull request #3368: HBASE-25989 FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdf…

2021-06-09 Thread GitBox
saintstack opened a new pull request #3368: URL: https://github.com/apache/hbase/pull/3368 …s 3.3+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[jira] [Created] (HBASE-25989) FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdfs 3.3+

2021-06-09 Thread Michael Stack (Jira)
Michael Stack created HBASE-25989: - Summary: FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdfs 3.3+ Key: HBASE-25989 URL: https://issues.apache.org/jira/browse/HBASE-25989 Project: HBase

[jira] [Updated] (HBASE-25987) Make SSL keystore type configurable for HBase ThriftServer

2021-06-09 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25987: - Affects Version/s: 2.5.0 3.0.0-alpha-1

[jira] [Resolved] (HBASE-25987) Make SSL keystore type configurable for HBase ThriftServer

2021-06-09 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25987. -- Resolution: Fixed Merged into master and base 2 branches. Thanks for the contr

[jira] [Updated] (HBASE-25987) Make SSL keystore type configurable for HBase ThriftServer

2021-06-09 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25987: - Fix Version/s: 2.4.5 2.3.6 2.5.0

[jira] [Commented] (HBASE-25988) Store the store file list by a file

2021-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360169#comment-17360169 ] Duo Zhang commented on HBASE-25988: --- Attached a design doc. PTAL. > Store the store f

[GitHub] [hbase] wchevreuil merged pull request #3367: HBASE-25987 Make SSL keystore type configurable for HBase ThriftServer

2021-06-09 Thread GitBox
wchevreuil merged pull request #3367: URL: https://github.com/apache/hbase/pull/3367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Resolved] (HBASE-25391) Flush directly into data directory, skip rename when committing flush

2021-06-09 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25391. -- Resolution: Fixed > Flush directly into data directory, skip rename when commi

[jira] [Resolved] (HBASE-25950) add basic compaction server metric

2021-06-09 Thread Yulin Niu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yulin Niu resolved HBASE-25950. --- Resolution: Fixed > add basic compaction server metric > -- > >

[jira] [Commented] (HBASE-25950) add basic compaction server metric

2021-06-09 Thread Yulin Niu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360153#comment-17360153 ] Yulin Niu commented on HBASE-25950: --- push to branch HBASE-25714, thanks [~zhangduo]'s 

[GitHub] [hbase] nyl3532016 merged pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-09 Thread GitBox
nyl3532016 merged pull request #3350: URL: https://github.com/apache/hbase/pull/3350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [hbase] Apache-HBase commented on pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3350: URL: https://github.com/apache/hbase/pull/3350#issuecomment-857770624 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10

[GitHub] [hbase] Apache-HBase commented on pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3350: URL: https://github.com/apache/hbase/pull/3350#issuecomment-857751323 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s

[jira] [Updated] (HBASE-25988) Store the store file list by a file

2021-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25988: -- Summary: Store the store file list by a file (was: Store store file list by plain file) > Store the

[GitHub] [hbase] Apache-HBase commented on pull request #3297: HBASE-25905 Limit the shutdown time of WAL

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3297: URL: https://github.com/apache/hbase/pull/3297#issuecomment-857727778 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[jira] [Updated] (HBASE-25988) Store store file list by plain file

2021-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25988: -- Summary: Store store file list by plain file (was: Store hfile list by plain file) > Store store fil

[GitHub] [hbase] Apache-HBase commented on pull request #3297: HBASE-25905 Limit the shutdown time of WAL

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3297: URL: https://github.com/apache/hbase/pull/3297#issuecomment-857723606 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache9 commented on a change in pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-09 Thread GitBox
Apache9 commented on a change in pull request #3350: URL: https://github.com/apache/hbase/pull/3350#discussion_r648332915 ## File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/CompactionServerListTmpl.jamon ## @@ -72,28 +74,18 @@ Arrays.sort(serverNames

[GitHub] [hbase] Apache9 commented on a change in pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-09 Thread GitBox
Apache9 commented on a change in pull request #3350: URL: https://github.com/apache/hbase/pull/3350#discussion_r648289833 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/CompactionServerMetricsBuilder.java ## @@ -0,0 +1,231 @@ +/** + * Copyright The Apache Sof

[jira] [Updated] (HBASE-25988) Store hfile list by plain file

2021-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25988: -- Component/s: HFile > Store hfile list by plain file > -- > >

[jira] [Commented] (HBASE-25984) FSHLog WAL lockup with sync future reuse [RS deadlock]

2021-06-09 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360044#comment-17360044 ] Viraj Jasani commented on HBASE-25984: -- [~bharathv] I think you can create PR. Supp

[jira] [Work started] (HBASE-25988) Store hfile list by plain file

2021-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25988 started by Duo Zhang. - > Store hfile list by plain file > -- > >

[jira] [Assigned] (HBASE-25988) Store hfile list by plain file

2021-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25988: - Assignee: Duo Zhang > Store hfile list by plain file > -- > >

[GitHub] [hbase] Apache-HBase commented on pull request #3312: HBASE-25923 Region state stuck in PENDING_OPEN

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3312: URL: https://github.com/apache/hbase/pull/3312#issuecomment-857661023 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 59s

[GitHub] [hbase] Apache-HBase commented on pull request #3297: HBASE-25905 Limit the shutdown time of WAL

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3297: URL: https://github.com/apache/hbase/pull/3297#issuecomment-857633060 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[jira] [Commented] (HBASE-25981) JVM crash when displaying regionserver UI

2021-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360002#comment-17360002 ] Hudson commented on HBASE-25981: Results for branch branch-2.3 [build #233 on b

[GitHub] [hbase] symat commented on pull request #3367: HBASE-25987 Make SSL keystore type configurable for HBase ThriftServer

2021-06-09 Thread GitBox
symat commented on pull request #3367: URL: https://github.com/apache/hbase/pull/3367#issuecomment-857618922 thanks for the quick review, @wchevreuil ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] sunhelly commented on a change in pull request #3297: HBASE-25905 Limit the shutdown time of WAL

2021-06-09 Thread GitBox
sunhelly commented on a change in pull request #3297: URL: https://github.com/apache/hbase/pull/3297#discussion_r648200987 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -986,14 +996,43 @@ public void shutdown() throw

[jira] [Created] (HBASE-25988) Store hfile list by plain file

2021-06-09 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25988: - Summary: Store hfile list by plain file Key: HBASE-25988 URL: https://issues.apache.org/jira/browse/HBASE-25988 Project: HBase Issue Type: Sub-task Rep

[GitHub] [hbase] Apache-HBase commented on pull request #3366: HBASE-25985 ReplicationSourceWALReader#run - Reset sleepMultiplier in loop once out of any IOE

2021-06-09 Thread GitBox
Apache-HBase commented on pull request #3366: URL: https://github.com/apache/hbase/pull/3366#issuecomment-857561696 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

  1   2   >