[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-864735948 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-864732320 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3404: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

Apache-HBase commented on pull request #3404: URL: https://github.com/apache/hbase/pull/3404#issuecomment-864729807 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25596) Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL

[ https://issues.apache.org/jira/browse/HBASE-25596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366375#comment-17366375 ] Hudson commented on HBASE-25596: Results for branch branch-2.4 [build #146 on

[jira] [Commented] (HBASE-25992) Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596

[ https://issues.apache.org/jira/browse/HBASE-25992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366374#comment-17366374 ] Hudson commented on HBASE-25992: Results for branch branch-2.4 [build #146 on

[GitHub] [hbase] Reidddddd commented on pull request #3387: HBASE-26004: port HBASE-26001 (cell level tags invisible in atomic operations when access control is on)to branch-1

Reidd commented on pull request #3387: URL: https://github.com/apache/hbase/pull/3387#issuecomment-864723257 > This looks strange. I just removed a useless import but did not change the order. OK, It means the original order is wrong. Let it be then -- This is an automated

[GitHub] [hbase] YutSean commented on pull request #3387: HBASE-26004: port HBASE-26001 (cell level tags invisible in atomic operations when access control is on)to branch-1

YutSean commented on pull request #3387: URL: https://github.com/apache/hbase/pull/3387#issuecomment-864721961 This looks strange. I just removed a useless import but did not change the order. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

[ https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366366#comment-17366366 ] Anoop Sam John commented on HBASE-26013: An issue with table level read metric right? RS level

[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-864699215 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864696694 Hi @nyl3532016 , could you please do another review? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864696305 org.apache.hadoop.hbase.TestJMXListener.(?) org.apache.hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas.xml.[failed-to-read] These failed unit tests are

[GitHub] [hbase] Apache-HBase commented on pull request #3404: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

Apache-HBase commented on pull request #3404: URL: https://github.com/apache/hbase/pull/3404#issuecomment-864690297 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

[ https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-26013: -- Priority: Minor (was: Major) > Get operations readRows metrics becomes zero after HBASE-25677 >

[jira] [Commented] (HBASE-25968) Request compact to compaction server

[ https://issues.apache.org/jira/browse/HBASE-25968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366356#comment-17366356 ] Yulin Niu commented on HBASE-25968: --- push to branch HBASE-25714, thanks [~zhangduo]'s reviewing >

[jira] [Resolved] (HBASE-25968) Request compact to compaction server

[ https://issues.apache.org/jira/browse/HBASE-25968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yulin Niu resolved HBASE-25968. --- Resolution: Fixed > Request compact to compaction server > > >

[GitHub] [hbase] Apache-HBase commented on pull request #3378: HBASE-25968 Request compact to compaction server

Apache-HBase commented on pull request #3378: URL: https://github.com/apache/hbase/pull/3378#issuecomment-864688672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] nyl3532016 merged pull request #3378: HBASE-25968 Request compact to compaction server

nyl3532016 merged pull request #3378: URL: https://github.com/apache/hbase/pull/3378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-864687887 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3403: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

Apache-HBase commented on pull request #3403: URL: https://github.com/apache/hbase/pull/3403#issuecomment-864686779 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Reidddddd commented on pull request #3387: HBASE-26004: port HBASE-26001 (cell level tags invisible in atomic operations when access control is on)to branch-1

Reidd commented on pull request #3387: URL: https://github.com/apache/hbase/pull/3387#issuecomment-864686115 @YutSean checksytle still has warnings sir -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3378: HBASE-25968 Request compact to compaction server

nyl3532016 commented on a change in pull request #3378: URL: https://github.com/apache/hbase/pull/3378#discussion_r655042055 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -3762,6 +3766,40 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-864682965 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3402: HBASE-25130 - Fix master in-memory server holding map after:

Apache-HBase commented on pull request #3402: URL: https://github.com/apache/hbase/pull/3402#issuecomment-864682316 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] YutSean commented on pull request #3403: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

YutSean commented on pull request #3403: URL: https://github.com/apache/hbase/pull/3403#issuecomment-864670998 I think the UT failure is not related to the change. Have trigger the QA once again. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-864638599 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

Apache-HBase commented on pull request #251: URL: https://github.com/apache/hbase/pull/251#issuecomment-864636630 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 39s

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-864629067 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-864625407 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-864625160 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-864624908 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-864621713 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-864620724 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-864608292 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-864608248 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-25992) Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596

[ https://issues.apache.org/jira/browse/HBASE-25992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366246#comment-17366246 ] Hudson commented on HBASE-25992: Results for branch branch-2 [build #281 on

[jira] [Commented] (HBASE-25596) Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL

[ https://issues.apache.org/jira/browse/HBASE-25596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366247#comment-17366247 ] Hudson commented on HBASE-25596: Results for branch branch-2 [build #281 on

[GitHub] [hbase] Apache9 commented on a change in pull request #3378: HBASE-25968 Request compact to compaction server

Apache9 commented on a change in pull request #3378: URL: https://github.com/apache/hbase/pull/3378#discussion_r654932817 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1966,6 +2021,34 @@ public boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

Apache-HBase commented on pull request #3405: URL: https://github.com/apache/hbase/pull/3405#issuecomment-864527219 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25961) Backport HBASE-25596 and HBASE-25992 to branch-2.3

[ https://issues.apache.org/jira/browse/HBASE-25961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25961: -- Summary: Backport HBASE-25596 and HBASE-25992 to branch-2.3 (was: Backport HBASE-25596 to

[jira] [Updated] (HBASE-25961) Backport HBASE-25596 to branch-2.3

[ https://issues.apache.org/jira/browse/HBASE-25961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25961: -- Component/s: Replication > Backport HBASE-25596 to branch-2.3 > -- >

[jira] [Resolved] (HBASE-25992) Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596

[ https://issues.apache.org/jira/browse/HBASE-25992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25992. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.4+. Thanks all for reviewing. >

[jira] [Updated] (HBASE-25992) Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596

[ https://issues.apache.org/jira/browse/HBASE-25992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25992: -- Fix Version/s: 2.4.5 2.5.0 3.0.0-alpha-1 > Polish the

[GitHub] [hbase] Apache9 merged pull request #3376: HBASE-25992 Polish the ReplicationSourceWALReader code for 2.x after …

Apache9 merged pull request #3376: URL: https://github.com/apache/hbase/pull/3376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please