[GitHub] [hbase] Apache-HBase commented on pull request #3459: HBASE-26065 StripeStoreFileManager does not need to throw IOException…

2021-07-04 Thread GitBox
Apache-HBase commented on pull request #3459: URL: https://github.com/apache/hbase/pull/3459#issuecomment-873838343 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

2021-07-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374557#comment-17374557 ] Hudson commented on HBASE-22923: Results for branch branch-2.3 [build #251 on b

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

2021-07-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374552#comment-17374552 ] Hudson commented on HBASE-22923: Results for branch branch-2 [build #293 on bui

[jira] [Created] (HBASE-26066) The page for hbase on downloads.apache.org is incorrect

2021-07-04 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26066: - Summary: The page for hbase on downloads.apache.org is incorrect Key: HBASE-26066 URL: https://issues.apache.org/jira/browse/HBASE-26066 Project: HBase Issue Type:

[GitHub] [hbase] Apache9 opened a new pull request #3459: HBASE-26065 StripeStoreFileManager does not need to throw IOException…

2021-07-04 Thread GitBox
Apache9 opened a new pull request #3459: URL: https://github.com/apache/hbase/pull/3459 … for most methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Created] (HBASE-26065) StripeStoreFileManager does not need to throw IOException for most methods

2021-07-04 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26065: - Summary: StripeStoreFileManager does not need to throw IOException for most methods Key: HBASE-26065 URL: https://issues.apache.org/jira/browse/HBASE-26065 Project: HBase

[jira] [Work stopped] (HBASE-26064) Introduce a StoreFileTrackingManager to abstract the store file tracking logic

2021-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26064 stopped by Duo Zhang. - > Introduce a StoreFileTrackingManager to abstract the store file tracking logic > --

[jira] [Commented] (HBASE-26064) Introduce a StoreFileTrackingManager to abstract the store file tracking logic

2021-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374544#comment-17374544 ] Duo Zhang commented on HBASE-26064: --- OK, after some investigating, I think we'd better

[jira] [Resolved] (HBASE-26033) Complement admin operations in Thrift2 after HBASE-21674

2021-07-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-26033. --- Hadoop Flags: Reviewed Resolution: Fixed > Complement admin operations in Thrift2 after HBASE-

[jira] [Updated] (HBASE-26033) Complement admin operations in Thrift2 after HBASE-21674

2021-07-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-26033: -- Labels: thrift (was: ) > Complement admin operations in Thrift2 after HBASE-21674 > -

[jira] [Updated] (HBASE-26033) Complement admin operations in Thrift2 after HBASE-21674

2021-07-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-26033: -- Fix Version/s: 1.7.1 > Complement admin operations in Thrift2 after HBASE-21674 >

[GitHub] [hbase] Reidddddd merged pull request #3428: HBASE-26033 complement the admin operations in thrift2 after HBASE-21674

2021-07-04 Thread GitBox
Reidd merged pull request #3428: URL: https://github.com/apache/hbase/pull/3428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (HBASE-26036) DBB released too early and dirty data for some operations

2021-07-04 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374486#comment-17374486 ] Xiaolin Ha commented on HBASE-26036: Hi, [~zhangduo], we can see that inner the HRei

[GitHub] [hbase] Apache-HBase commented on pull request #3437: HBASE-26037 Implement namespace and table level access control for thrift & thrift2

2021-07-04 Thread GitBox
Apache-HBase commented on pull request #3437: URL: https://github.com/apache/hbase/pull/3437#issuecomment-873763382 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

[GitHub] [hbase] Apache-HBase commented on pull request #3437: HBASE-26037 Implement namespace and table level access control for thrift & thrift2

2021-07-04 Thread GitBox
Apache-HBase commented on pull request #3437: URL: https://github.com/apache/hbase/pull/3437#issuecomment-873761619 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55

[GitHub] [hbase] Apache-HBase commented on pull request #3437: HBASE-26037 Implement namespace and table level access control for thrift & thrift2

2021-07-04 Thread GitBox
Apache-HBase commented on pull request #3437: URL: https://github.com/apache/hbase/pull/3437#issuecomment-873761062 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-04 Thread GitBox
nyl3532016 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r663617140 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java ## @@ -19,41 +18,446 @@ package org.apac

[jira] [Commented] (HBASE-26064) Introduce a StoreFileTrackingManager to abstract the store file tracking logic

2021-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374475#comment-17374475 ] Duo Zhang commented on HBASE-26064: --- Looking at the code, I think this class could jus

[jira] [Assigned] (HBASE-26064) Introduce a StoreFileTrackingManager to abstract the store file tracking logic

2021-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26064: - Assignee: Duo Zhang > Introduce a StoreFileTrackingManager to abstract the store file tracking

[jira] [Work started] (HBASE-26064) Introduce a StoreFileTrackingManager to abstract the store file tracking logic

2021-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26064 started by Duo Zhang. - > Introduce a StoreFileTrackingManager to abstract the store file tracking logic > --

[jira] [Work stopped] (HBASE-25988) Store the store file list by a file

2021-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25988 stopped by Duo Zhang. - > Store the store file list by a file > --- > >

[jira] [Updated] (HBASE-26064) Introduce a StoreFileTrackingManager to abstract the store file tracking logic

2021-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26064: -- Description: As mentioned in the parent issue, we could abstract a storefile metadata system, then we

[jira] [Created] (HBASE-26064) Introduce a StoreFileTrackingManager to abstract the store file tracking logic

2021-07-04 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26064: - Summary: Introduce a StoreFileTrackingManager to abstract the store file tracking logic Key: HBASE-26064 URL: https://issues.apache.org/jira/browse/HBASE-26064 Project: HBa

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

2021-07-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374436#comment-17374436 ] Hudson commented on HBASE-22923: Results for branch branch-1 [build #143 on bui

[GitHub] [hbase] Apache-HBase commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

2021-07-04 Thread GitBox
Apache-HBase commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873664771 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s

[GitHub] [hbase] Apache-HBase commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

2021-07-04 Thread GitBox
Apache-HBase commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873663565 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 49

[GitHub] [hbase] Apache-HBase commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

2021-07-04 Thread GitBox
Apache-HBase commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873662810 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28

[jira] [Commented] (HBASE-26062) SIGSEGV in AsyncFSWAL consume

2021-07-04 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374321#comment-17374321 ] Anoop Sam John commented on HBASE-26062: The mentioned traces are from write to

[GitHub] [hbase] mokai87 commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

2021-07-04 Thread GitBox
mokai87 commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873616414 I think it is enough to trim the cluster key when it's not null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] Apache9 commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

2021-07-04 Thread GitBox
Apache9 commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873610356 > The cluster key must no be null. I have met a problem in master-slave cluster replication, user misconfigured the cluster key like CLUSTER_KEY => "zk1.com:2181:/hbase " . the zn

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2021-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374288#comment-17374288 ] Duo Zhang commented on HBASE-24749: --- Recently some guys in our company introduced how

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-04 Thread GitBox
nyl3532016 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r663503610 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java ## @@ -19,41 +18,446 @@ package org.apac

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-04 Thread GitBox
nyl3532016 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r663465541 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -3540,6 +3546,13 @@ public ThroughputController