[GitHub] [hbase] sunhelly closed pull request #3569: HBASE-26170 addendum make TestRequestTooBigException smaller

2021-08-07 Thread GitBox
sunhelly closed pull request #3569: URL: https://github.com/apache/hbase/pull/3569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894738936 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894737855 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26142) NullPointerException when set 'hbase.hregion.memstore.mslab.indexchunksize.percent' to zero

2021-08-07 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395450#comment-17395450 ] chenglei commented on HBASE-26142: -- [~zhangduo],thank you very much for the review. >

[jira] [Commented] (HBASE-26179) TestRequestTooBigException spends too much time to finish

2021-08-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395433#comment-17395433 ] Hudson commented on HBASE-26179: Results for branch branch-2.4 [build #176 on

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894729307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894722593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894717057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3566: HBASE-26172 Deprecated MasterRegistry and allow getBootstrapNodes to …

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3566: URL: https://github.com/apache/hbase/pull/3566#issuecomment-894709736 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894707945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3566: HBASE-26172 Deprecated MasterRegistry and allow getBootstrapNodes to …

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3566: URL: https://github.com/apache/hbase/pull/3566#issuecomment-894704435 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3566: HBASE-26172 Deprecated MasterRegistry and allow getBootstrapNodes to …

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3566: URL: https://github.com/apache/hbase/pull/3566#issuecomment-894691739 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] clarax commented on pull request #3570: HBASE-24643 Improve data structure and algorithm for BalanceClusterSt…

2021-08-07 Thread GitBox
clarax commented on pull request #3570: URL: https://github.com/apache/hbase/pull/3570#issuecomment-894685117 > Wrong jira id? And mind explain why this is faster? Locating an element in array is always O(1), what is the advantage of changing it to a HashSet? I opened

[GitHub] [hbase] Apache-HBase commented on pull request #3566: HBASE-26172 Deprecated MasterRegistry and allow getBootstrapNodes to …

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3566: URL: https://github.com/apache/hbase/pull/3566#issuecomment-894682746 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894679413 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3566: HBASE-26172 Deprecated MasterRegistry and allow getBootstrapNodes to …

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3566: URL: https://github.com/apache/hbase/pull/3566#issuecomment-894675910 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894672848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-26179) TestRequestTooBigException spends too much time to finish

2021-08-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26179. --- Fix Version/s: 2.3.7 2.4.6 3.0.0-alpha-2

[GitHub] [hbase] Apache9 commented on pull request #3569: HBASE-26170 addendum make TestRequestTooBigException smaller

2021-08-07 Thread GitBox
Apache9 commented on pull request #3569: URL: https://github.com/apache/hbase/pull/3569#issuecomment-894665831 Oh, please see HBASE-26179. I've already merged the patch... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] Apache9 merged pull request #3571: HBASE-26179 TestRequestTooBigException spends too much time to finish

2021-08-07 Thread GitBox
Apache9 merged pull request #3571: URL: https://github.com/apache/hbase/pull/3571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3566: HBASE-26172 Deprecated MasterRegistry and allow getBootstrapNodes to …

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3566: URL: https://github.com/apache/hbase/pull/3566#issuecomment-894662415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #3570: HBASE-24643 Improve data structure and algorithm for BalanceClusterSt…

2021-08-07 Thread GitBox
Apache9 commented on pull request #3570: URL: https://github.com/apache/hbase/pull/3570#issuecomment-894659814 Wrong jira id? And mind explain why this is faster? Locating an element in array is always O(1), what is the advantage of changing it to a HashSet? -- This is an automated

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894657884 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3571: HBASE-26179 TestRequestTooBigException spends too much time to finish

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3571: URL: https://github.com/apache/hbase/pull/3571#issuecomment-894655081 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3571: HBASE-26179 TestRequestTooBigException spends too much time to finish

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3571: URL: https://github.com/apache/hbase/pull/3571#issuecomment-894654385 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26182) Allow disabling refresh of connection registry endpoint

2021-08-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26182: -- Description: One possible deployment in production is to use something like a lvs in front of all

[jira] [Created] (HBASE-26182) Allow disabling refresh of connection registry endpoint

2021-08-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26182: - Summary: Allow disabling refresh of connection registry endpoint Key: HBASE-26182 URL: https://issues.apache.org/jira/browse/HBASE-26182 Project: HBase Issue

[jira] [Created] (HBASE-26181) Region server and master could use itself as ConnectionRegistry

2021-08-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26181: - Summary: Region server and master could use itself as ConnectionRegistry Key: HBASE-26181 URL: https://issues.apache.org/jira/browse/HBASE-26181 Project: HBase

[jira] [Created] (HBASE-26180) Introduce a initial refresh interval for RpcConnectionRegistry

2021-08-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26180: - Summary: Introduce a initial refresh interval for RpcConnectionRegistry Key: HBASE-26180 URL: https://issues.apache.org/jira/browse/HBASE-26180 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3571: HBASE-26179 TestRequestTooBigException spends too much time to finish

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3571: URL: https://github.com/apache/hbase/pull/3571#issuecomment-894641616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #3566: HBASE-26172 Deprecated MasterRegistry and allow getBootstrapNodes to …

2021-08-07 Thread GitBox
Apache9 commented on pull request #3566: URL: https://github.com/apache/hbase/pull/3566#issuecomment-894636843 The failed UT is because of HBASE-26172, it needs to much time to finish... Filed HBASE-26179 for it, the PR is ready https://github.com/apache/hbase/pull/3571 -- This

[jira] [Updated] (HBASE-26179) TestRequestTooBigException spends too much time to finish

2021-08-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26179: -- Summary: TestRequestTooBigException spends too much time to finish (was: TestRequestTooBigException

[jira] [Commented] (HBASE-26179) TestRequestTooBigException costs too much memory

2021-08-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395185#comment-17395185 ] Duo Zhang commented on HBASE-26179: --- I think the problem is that we add a 1 times loop in

[jira] [Created] (HBASE-26179) TestRequestTooBigException costs too much memory

2021-08-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26179: - Summary: TestRequestTooBigException costs too much memory Key: HBASE-26179 URL: https://issues.apache.org/jira/browse/HBASE-26179 Project: HBase Issue Type:

[GitHub] [hbase] Apache9 commented on a change in pull request #3566: HBASE-26172 Deprecated MasterRegistry and allow getBootstrapNodes to …

2021-08-07 Thread GitBox
Apache9 commented on a change in pull request #3566: URL: https://github.com/apache/hbase/pull/3566#discussion_r684612731 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -308,18 +310,35 @@ */ private static final

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894622016 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-894621430 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3570: HBASE-24643 Improve data structure and algorithm for BalanceClusterSt…

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3570: URL: https://github.com/apache/hbase/pull/3570#issuecomment-894616808 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3570: HBASE-24643 Improve data structure and algorithm for BalanceClusterSt…

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3570: URL: https://github.com/apache/hbase/pull/3570#issuecomment-894615679 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3570: HBASE-24643 Improve data structure and algorithm for BalanceClusterSt…

2021-08-07 Thread GitBox
Apache-HBase commented on pull request #3570: URL: https://github.com/apache/hbase/pull/3570#issuecomment-894613461 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] clarax commented on pull request #3570: HBASE-24643 Improve data structure and algorithm for BalanceClusterSt…

2021-08-07 Thread GitBox
clarax commented on pull request #3570: URL: https://github.com/apache/hbase/pull/3570#issuecomment-894612493 WIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To