[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-904374446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3599: HBASE-26173 Return only a sub set of region servers as bootstrap nodes

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3599: URL: https://github.com/apache/hbase/pull/3599#issuecomment-904371183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[jira] [Updated] (HBASE-23778) Region History Redo

2021-08-23 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23778: - Priority: Major (was: Minor) > Region History Redo > --- > > Ke

[GitHub] [hbase] Apache9 commented on a change in pull request #3613: HBASE-26214 Introduce a ConnectionRegistryEndpoint interface

2021-08-23 Thread GitBox
Apache9 commented on a change in pull request #3613: URL: https://github.com/apache/hbase/pull/3613#discussion_r694544813 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryEndpoint.java ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache

[jira] [Commented] (HBASE-23778) Region History Redo

2021-08-23 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403557#comment-17403557 ] Viraj Jasani commented on HBASE-23778: -- Revisited this today, it seems now this can

[GitHub] [hbase] Apache9 commented on a change in pull request #3601: HBASE-26180 Introduce a initial refresh interval for RpcConnectionReg…

2021-08-23 Thread GitBox
Apache9 commented on a change in pull request #3601: URL: https://github.com/apache/hbase/pull/3601#discussion_r694536476 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegistryEndpointsRefresher.java ## @@ -60,9 +63,20 @@ public synchronized void stop

[jira] [Resolved] (HBASE-26182) Allow disabling refresh of connection registry endpoint

2021-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26182. --- Resolution: Fixed Pushed to master and branch-2. Thanks [~bharathv] for reviewing. > Allow disabli

[jira] [Updated] (HBASE-26182) Allow disabling refresh of connection registry endpoint

2021-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26182: -- Fix Version/s: 3.0.0-alpha-2 2.5.0 Hadoop Flags: Reviewed Release Note: Se

[jira] [Assigned] (HBASE-26182) Allow disabling refresh of connection registry endpoint

2021-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26182: - Assignee: Duo Zhang > Allow disabling refresh of connection registry endpoint > ---

[GitHub] [hbase] Apache9 merged pull request #3605: HBASE-26182 Allow disabling refresh of connection registry endpoint

2021-08-23 Thread GitBox
Apache9 merged pull request #3605: URL: https://github.com/apache/hbase/pull/3605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [hbase] Apache-HBase commented on pull request #3620: HBASE-26135 Backport HBASE-25616 "Upgrade opentelemetry to 1.0.0" to branch-2

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3620: URL: https://github.com/apache/hbase/pull/3620#issuecomment-904344951 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2

[GitHub] [hbase] Apache9 commented on a change in pull request #3599: HBASE-26173 Return only a sub set of region servers as bootstrap nodes

2021-08-23 Thread GitBox
Apache9 commented on a change in pull request #3599: URL: https://github.com/apache/hbase/pull/3599#discussion_r694516032 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -320,6 +321,10 @@ */ private static final boo

[GitHub] [hbase] taklwu opened a new pull request #3620: HBASE-26135 Backport HBASE-25616 "Upgrade opentelemetry to 1.0.0" to branch-2

2021-08-23 Thread GitBox
taklwu opened a new pull request #3620: URL: https://github.com/apache/hbase/pull/3620 12/17 commits of HBASE-22120, original commits 8399293e21127df3ffdcb757242e4cb5964c7e99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-904321309 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20

[jira] [Updated] (HBASE-26134) Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26134: - Affects Version/s: 2.5.0 > Backport HBASE-25617 "Revisit the span names" to bran

[jira] [Commented] (HBASE-26134) Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403506#comment-17403506 ] Tak-Lon (Stephen) Wu commented on HBASE-26134: -- commit pushed https://gith

[jira] [Resolved] (HBASE-26134) Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-26134. -- Fix Version/s: 2.5.0 Hadoop Flags: Reviewed Resolution: Fixed > Ba

[GitHub] [hbase] taklwu merged pull request #3618: HBASE-26134 Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread GitBox
taklwu merged pull request #3618: URL: https://github.com/apache/hbase/pull/3618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [hbase] jojochuang commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-23 Thread GitBox
jojochuang commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-904300346 @saintstack why is this PR opened against branch-2.3, not master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] bharathv commented on a change in pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
bharathv commented on a change in pull request #3610: URL: https://github.com/apache/hbase/pull/3610#discussion_r694467398 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -655,22 +663,27 @@ private synchronized void fl

[GitHub] [hbase] Apache9 commented on a change in pull request #3613: HBASE-26214 Introduce a ConnectionRegistryEndpoint interface

2021-08-23 Thread GitBox
Apache9 commented on a change in pull request #3613: URL: https://github.com/apache/hbase/pull/3613#discussion_r694465357 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryEndpoint.java ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] bharathv commented on a change in pull request #3613: HBASE-26214 Introduce a ConnectionRegistryEndpoint interface

2021-08-23 Thread GitBox
bharathv commented on a change in pull request #3613: URL: https://github.com/apache/hbase/pull/3613#discussion_r694464233 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryEndpoint.java ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apach

[GitHub] [hbase] bharathv commented on a change in pull request #3601: HBASE-26180 Introduce a initial refresh interval for RpcConnectionReg…

2021-08-23 Thread GitBox
bharathv commented on a change in pull request #3601: URL: https://github.com/apache/hbase/pull/3601#discussion_r694459326 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistry.java ## @@ -51,6 +51,9 @@ /** Configuration key that cont

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-904284566 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-904282244 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache9 commented on a change in pull request #3601: HBASE-26180 Introduce a initial refresh interval for RpcConnectionReg…

2021-08-23 Thread GitBox
Apache9 commented on a change in pull request #3601: URL: https://github.com/apache/hbase/pull/3601#discussion_r69548 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegistryEndpointsRefresher.java ## @@ -60,9 +63,20 @@ public synchronized void stop

[GitHub] [hbase] Apache9 commented on a change in pull request #3613: HBASE-26214 Introduce a ConnectionRegistryEndpoint interface

2021-08-23 Thread GitBox
Apache9 commented on a change in pull request #3613: URL: https://github.com/apache/hbase/pull/3613#discussion_r694442114 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryEndpoint.java ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-904270431 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-904266202 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s

[jira] [Commented] (HBASE-26199) hbck2 should support remove deleted meta region

2021-08-23 Thread mengqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403454#comment-17403454 ] mengqi commented on HBASE-26199: [~anoop.hbase] thanks, we will upgrade hbase version to

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-904235803 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10

[jira] [Updated] (HBASE-26212) Allow AuthUtil automatic renewal to be disabled

2021-08-23 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-26212: --- Hadoop Flags: Reviewed Release Note: This change introduces a configuration property "hbase.clie

[jira] [Updated] (HBASE-26212) Allow AuthUtil automatic renewal to be disabled

2021-08-23 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-26212: --- Fix Version/s: 3.0.0-alpha-2 2.5.0 > Allow AuthUtil automatic renewal to be disab

[GitHub] [hbase] joshelser merged pull request #3619: HBASE-26212 Expose configuration to enable/disable AuthUtil

2021-08-23 Thread GitBox
joshelser merged pull request #3619: URL: https://github.com/apache/hbase/pull/3619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Created] (HBASE-26218) Better logging in CanaryTool

2021-08-23 Thread Caroline Zhou (Jira)
Caroline Zhou created HBASE-26218: - Summary: Better logging in CanaryTool Key: HBASE-26218 URL: https://issues.apache.org/jira/browse/HBASE-26218 Project: HBase Issue Type: Improvement

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-904213178 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #3619: HBASE-26212 Expose configuration to enable/disable AuthUtil

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3619: URL: https://github.com/apache/hbase/pull/3619#issuecomment-904210832 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 43

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-904210600 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #3619: HBASE-26212 Expose configuration to enable/disable AuthUtil

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3619: URL: https://github.com/apache/hbase/pull/3619#issuecomment-904207653 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53

[GitHub] [hbase] Apache-HBase commented on pull request #3619: HBASE-26212 Expose configuration to enable/disable AuthUtil

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3619: URL: https://github.com/apache/hbase/pull/3619#issuecomment-904202810 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hbase] bharathv commented on a change in pull request #3613: HBASE-26214 Introduce a ConnectionRegistryEndpoint interface

2021-08-23 Thread GitBox
bharathv commented on a change in pull request #3613: URL: https://github.com/apache/hbase/pull/3613#discussion_r694364701 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryEndpoint.java ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apach

[GitHub] [hbase] bharathv commented on a change in pull request #3613: HBASE-26214 Introduce a ConnectionRegistryEndpoint interface

2021-08-23 Thread GitBox
bharathv commented on a change in pull request #3613: URL: https://github.com/apache/hbase/pull/3613#discussion_r694364236 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryEndpoint.java ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apach

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-904190111 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s

[jira] [Commented] (HBASE-26212) Allow AuthUtil automatic renewal to be disabled

2021-08-23 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403422#comment-17403422 ] Josh Elser commented on HBASE-26212: Had to make a minor adjustment for the branch-2

[GitHub] [hbase] joshelser commented on pull request #3619: HBASE-26212 Expose configuration to enable/disable AuthUtil

2021-08-23 Thread GitBox
joshelser commented on pull request #3619: URL: https://github.com/apache/hbase/pull/3619#issuecomment-904188921 Had to make a minor adjustment for the branch-2 patch, so I put it up here for a new QA run. Don't think it needs extra reviews, so I'll merge if it comes back green. -- This

[GitHub] [hbase] joshelser opened a new pull request #3619: HBASE-26212 Expose configuration to enable/disable AuthUtil

2021-08-23 Thread GitBox
joshelser opened a new pull request #3619: URL: https://github.com/apache/hbase/pull/3619 In some situations, a caller may know that it is properly managing the Kerberos ticket to talk to HBase. In these situations, it's possible that AuthUtil still tries to do renewals, but just fails

[GitHub] [hbase] bharathv commented on a change in pull request #3601: HBASE-26180 Introduce a initial refresh interval for RpcConnectionReg…

2021-08-23 Thread GitBox
bharathv commented on a change in pull request #3601: URL: https://github.com/apache/hbase/pull/3601#discussion_r694352064 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegistryEndpointsRefresher.java ## @@ -60,9 +63,20 @@ public synchronized void sto

[GitHub] [hbase] bharathv commented on a change in pull request #3599: HBASE-26173 Return only a sub set of region servers as bootstrap nodes

2021-08-23 Thread GitBox
bharathv commented on a change in pull request #3599: URL: https://github.com/apache/hbase/pull/3599#discussion_r694343578 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -320,6 +321,10 @@ */ private static final bo

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-904155138 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-904154039 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13

[GitHub] [hbase] bbeaudreault commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-23 Thread GitBox
bbeaudreault commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-904136017 Hey all, here's an update: - I've rolled all of the original commits into 1 commit, and included fixes for @ndimiduk's latest review. - I've also added a new commit

[GitHub] [hbase] caroliney14 commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-23 Thread GitBox
caroliney14 commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-904125255 @Apache9 thanks for the review. I moved the lines you mentioned are too long to debug level logging instead. -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-904103627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] saintstack commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-23 Thread GitBox
saintstack commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-904036244 @jojochuang good by you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [hbase] Apache-HBase commented on pull request #3611: [branch-1] HBASE-26195 Abort RS if wal sync fails or times out

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3611: URL: https://github.com/apache/hbase/pull/3611#issuecomment-904012758 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 18s

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-904008302 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17

[GitHub] [hbase] Apache-HBase commented on pull request #3618: HBASE-26134 Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3618: URL: https://github.com/apache/hbase/pull/3618#issuecomment-903929617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22

[GitHub] [hbase] Apache-HBase commented on pull request #3618: HBASE-26134 Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3618: URL: https://github.com/apache/hbase/pull/3618#issuecomment-903929123 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44

[GitHub] [hbase] Apache-HBase commented on pull request #3618: HBASE-26134 Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3618: URL: https://github.com/apache/hbase/pull/3618#issuecomment-903923572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32

[jira] [Resolved] (HBASE-26133) Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to branch-2

2021-08-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-26133. -- Resolution: Fixed > Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to

[jira] [Commented] (HBASE-26133) Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to branch-2

2021-08-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403252#comment-17403252 ] Tak-Lon (Stephen) Wu commented on HBASE-26133: -- commit pushed to feature br

[jira] [Work started] (HBASE-26134) Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26134 started by Tak-Lon (Stephen) Wu. > Backport HBASE-25617 "Revisit the span names" to branch-2 > -

[jira] [Updated] (HBASE-26134) Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26134: - Description: _11/17 commits of HBASE-22120, original commit [{{8d68f8c}}|https:/

[jira] [Assigned] (HBASE-26134) Backport HBASE-25617 "Revisit the span names" to branch-2

2021-08-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-26134: Assignee: Tak-Lon (Stephen) Wu > Backport HBASE-25617 "Revisit the span n

[GitHub] [hbase] taklwu commented on pull request #3608: HBASE-26133 Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to branch-2

2021-08-23 Thread GitBox
taklwu commented on pull request #3608: URL: https://github.com/apache/hbase/pull/3608#issuecomment-903895449 those unit test failures are unrelated, pushing to feature branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public

2021-08-23 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403225#comment-17403225 ] Geoffrey Jacoby commented on HBASE-26158: - Sounds good. Thank you, I appreciate

[GitHub] [hbase] shahrs87 commented on pull request #3611: [branch-1] HBASE-26195 Abort RS if wal sync fails or times out

2021-08-23 Thread GitBox
shahrs87 commented on pull request #3611: URL: https://github.com/apache/hbase/pull/3611#issuecomment-903856516 @apurtell @bharathv @gjacoby126 Could you please review the PR ? This bug is only applicable to branch-1 and not master/branch-2. See the [comment here](https://issues.apac

[jira] [Commented] (HBASE-26199) hbck2 should support remove deleted meta region

2021-08-23 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403176#comment-17403176 ] Anoop Sam John commented on HBASE-26199: These are due to bugs in 2.x initial ve

[GitHub] [hbase] bbeaudreault closed pull request #3565: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned

2021-08-23 Thread GitBox
bbeaudreault closed pull request #3565: URL: https://github.com/apache/hbase/pull/3565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[GitHub] [hbase] bbeaudreault commented on pull request #3565: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned

2021-08-23 Thread GitBox
bbeaudreault commented on pull request #3565: URL: https://github.com/apache/hbase/pull/3565#issuecomment-903691330 Given the above and the fact that changes are needed here anyway, I'm going to close this for now while we investigate setting `hbase.table.max.rowsize` instead. If it doesn'

[GitHub] [hbase] bbeaudreault commented on pull request #3565: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned

2021-08-23 Thread GitBox
bbeaudreault commented on pull request #3565: URL: https://github.com/apache/hbase/pull/3565#issuecomment-903690738 Thank you for your comment Anoop. The problem we face is that we have hundreds of engineers using hbase in innumerable ways, on multi-tenant clusters. People shift teams, lea

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-903645349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-903638892 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[GitHub] [hbase] Apache-HBase commented on pull request #3616: HBASE-26077 Add heartbeat for ReplicationServer

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3616: URL: https://github.com/apache/hbase/pull/3616#issuecomment-903598217 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #3616: HBASE-26077 Add heartbeat for ReplicationServer

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3616: URL: https://github.com/apache/hbase/pull/3616#issuecomment-903595443 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s

[GitHub] [hbase] Apache-HBase commented on pull request #3614: HBASE-26213 Refactor AnnotationReadingPriorityFunction

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3614: URL: https://github.com/apache/hbase/pull/3614#issuecomment-903577266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s

[GitHub] [hbase] Apache-HBase commented on pull request #3613: HBASE-26214 Introduce a ConnectionRegistryEndpoint interface

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3613: URL: https://github.com/apache/hbase/pull/3613#issuecomment-903569416 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #3613: HBASE-26214 Introduce a ConnectionRegistryEndpoint interface

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3613: URL: https://github.com/apache/hbase/pull/3613#issuecomment-903567003 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11

[jira] [Commented] (HBASE-26208) Supports revoke @ns single permission

2021-08-23 Thread zhengsicheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403037#comment-17403037 ] zhengsicheng commented on HBASE-26208: -- [~stack] review code thank you!  > Support

[jira] [Resolved] (HBASE-26211) [hbase-connectors] Pushdown filters in Spark do not work correctly with long types

2021-08-23 Thread Balazs Meszaros (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros resolved HBASE-26211. - Resolution: Fixed [~hiliev] thanks for the contribution! I merged your fix. > [hbase-co

[jira] [Assigned] (HBASE-26211) [hbase-connectors] Pushdown filters in Spark do not work correctly with long types

2021-08-23 Thread Balazs Meszaros (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros reassigned HBASE-26211: --- Assignee: Hristo Iliev > [hbase-connectors] Pushdown filters in Spark do not work c

[jira] [Updated] (HBASE-26211) [hbase-connectors] Pushdown filters in Spark do not work correctly with long types

2021-08-23 Thread Balazs Meszaros (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-26211: Fix Version/s: hbase-connectors-1.1.0 > [hbase-connectors] Pushdown filters in Spark do no

[GitHub] [hbase-connectors] meszibalu commented on pull request #83: HBASE-26211 Fix decoding of Long values in NaiveEncoder

2021-08-23 Thread GitBox
meszibalu commented on pull request #83: URL: https://github.com/apache/hbase-connectors/pull/83#issuecomment-903554016 LGTM, thanks @hiliev! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase-connectors] meszibalu merged pull request #83: HBASE-26211 Fix decoding of Long values in NaiveEncoder

2021-08-23 Thread GitBox
meszibalu merged pull request #83: URL: https://github.com/apache/hbase-connectors/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [hbase] Apache-HBase commented on pull request #3608: HBASE-26133 Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to branch-2

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3608: URL: https://github.com/apache/hbase/pull/3608#issuecomment-903532452 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s

[GitHub] [hbase] Apache-HBase commented on pull request #3616: HBASE-26077 Add heartbeat for ReplicationServer

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3616: URL: https://github.com/apache/hbase/pull/3616#issuecomment-903524014 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41

[GitHub] [hbase] Apache-HBase commented on pull request #3614: HBASE-26213 Refactor AnnotationReadingPriorityFunction

2021-08-23 Thread GitBox
Apache-HBase commented on pull request #3614: URL: https://github.com/apache/hbase/pull/3614#issuecomment-903519929 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s