[GitHub] [hbase] Apache9 commented on a change in pull request #3646: HBASE-26229 Make L0 files compaction in StripeCompactionPolicy faster…

2021-08-31 Thread GitBox
Apache9 commented on a change in pull request #3646: URL: https://github.com/apache/hbase/pull/3646#discussion_r699920065 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/ExploringCompactionPolicy.java ## @@ -120,10 +119,26 @@ public Ex

[GitHub] [hbase] Apache-HBase commented on pull request #3651: HBASE-25773 TestSnapshotScannerHDFSAclController.setupBeforeClass is …

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3651: URL: https://github.com/apache/hbase/pull/3651#issuecomment-909930899 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3651: HBASE-25773 TestSnapshotScannerHDFSAclController.setupBeforeClass is …

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3651: URL: https://github.com/apache/hbase/pull/3651#issuecomment-909896376 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3651: HBASE-25773 TestSnapshotScannerHDFSAclController.setupBeforeClass is …

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3651: URL: https://github.com/apache/hbase/pull/3651#issuecomment-909896145 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-909888930 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[jira] [Updated] (HBASE-26229) Make L0 files compaction in StripeCompactionPolicy faster and size under control

2021-08-31 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-26229: --- Attachment: before.png > Make L0 files compaction in StripeCompactionPolicy faster and size under >

[jira] [Updated] (HBASE-26229) Make L0 files compaction in StripeCompactionPolicy faster and size under control

2021-08-31 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-26229: --- Attachment: after.png > Make L0 files compaction in StripeCompactionPolicy faster and size under >

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-909879558 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[jira] [Commented] (HBASE-26237) Improve computation complexity for primaryRegionCountSkewCostFunctio

2021-08-31 Thread Kulwant Singh (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407796#comment-17407796 ] Kulwant Singh commented on HBASE-26237: --- Hi [~claraxiong], I would like to work on

[GitHub] [hbase] ddupg commented on a change in pull request #3651: HBASE-25773 TestSnapshotScannerHDFSAclController.setupBeforeClass is …

2021-08-31 Thread GitBox
ddupg commented on a change in pull request #3651: URL: https://github.com/apache/hbase/pull/3651#discussion_r699823344 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestSnapshotScannerHDFSAclController.java ## @@ -99,9 +98,11 @@ public stati

[GitHub] [hbase] Apache9 commented on a change in pull request #3636: HBASE-26106 AbstractFSWALProvider#getArchivedLogPath doesn't look for wal file in all oldWALs directory.

2021-08-31 Thread GitBox
Apache9 commented on a change in pull request #3636: URL: https://github.com/apache/hbase/pull/3636#discussion_r699818774 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALInputFormat.java ## @@ -217,8 +217,9 @@ public boolean nextKeyValue() thro

[jira] [Commented] (HBASE-25642) Fix or stop warning about already cached block

2021-08-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407785#comment-17407785 ] Hudson commented on HBASE-25642: Results for branch branch-2.4 [build #189 on b

[GitHub] [hbase] Apache-HBase commented on pull request #3651: HBASE-25773 TestSnapshotScannerHDFSAclController.setupBeforeClass is …

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3651: URL: https://github.com/apache/hbase/pull/3651#issuecomment-909840871 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6

[GitHub] [hbase] Apache9 commented on a change in pull request #3651: HBASE-25773 TestSnapshotScannerHDFSAclController.setupBeforeClass is …

2021-08-31 Thread GitBox
Apache9 commented on a change in pull request #3651: URL: https://github.com/apache/hbase/pull/3651#discussion_r699811527 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestSnapshotScannerHDFSAclController.java ## @@ -99,9 +98,11 @@ public sta

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-909823177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[GitHub] [hbase] Apache9 commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-31 Thread GitBox
Apache9 commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-909798483 I'm OK with merging. Let's for one more day to see if @bharathv could come back and reply here. Thanks. -- This is an automated message from the Apache Git Service.

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-909793542 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s

[jira] [Commented] (HBASE-26245) Store region server list in master local region

2021-08-31 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407741#comment-17407741 ] Duo Zhang commented on HBASE-26245: --- Will try to implement a rough POC first to see if

[GitHub] [hbase] Apache9 commented on pull request #3643: HBASE-26157 Expose some IA.LimitedPrivate interface in TestingHBaseCl…

2021-08-31 Thread GitBox
Apache9 commented on pull request #3643: URL: https://github.com/apache/hbase/pull/3643#issuecomment-909787084 > @Apache9 - No objection to limiting the review on this PR to just the methods you already added. I'll approve this PR when the review on those are done, and we can do additional

[GitHub] [hbase] Apache9 commented on a change in pull request #3643: HBASE-26157 Expose some IA.LimitedPrivate interface in TestingHBaseCl…

2021-08-31 Thread GitBox
Apache9 commented on a change in pull request #3643: URL: https://github.com/apache/hbase/pull/3643#discussion_r699777147 ## File path: hbase-testing-util/src/test/java/org/apache/hadoop/hbase/testing/TestTestingHBaseClusterImplForCPs.java ## @@ -0,0 +1,107 @@ +/** + * License

[GitHub] [hbase] Apache9 commented on a change in pull request #3643: HBASE-26157 Expose some IA.LimitedPrivate interface in TestingHBaseCl…

2021-08-31 Thread GitBox
Apache9 commented on a change in pull request #3643: URL: https://github.com/apache/hbase/pull/3643#discussion_r699776750 ## File path: hbase-testing-util/src/main/java/org/apache/hadoop/hbase/testing/TestingHBaseCluster.java ## @@ -114,6 +120,41 @@ */ void start() thro

[GitHub] [hbase] Apache9 commented on a change in pull request #3643: HBASE-26157 Expose some IA.LimitedPrivate interface in TestingHBaseCl…

2021-08-31 Thread GitBox
Apache9 commented on a change in pull request #3643: URL: https://github.com/apache/hbase/pull/3643#discussion_r699775929 ## File path: hbase-testing-util/src/main/java/org/apache/hadoop/hbase/testing/TestingHBaseClusterImpl.java ## @@ -172,4 +179,38 @@ public void startRegion

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-909783738 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-909739941 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16

[GitHub] [hbase] Apache-HBase commented on pull request #3653: HBASE-26244 Avoid trim the error stack trace when running UT with maven

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3653: URL: https://github.com/apache/hbase/pull/3653#issuecomment-909738381 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 29

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-909716611 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #3637: HBASE-25853 Backport HBASE-22120 "Replace HTrace with OpenTelemetry" to branch-2

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3637: URL: https://github.com/apache/hbase/pull/3637#issuecomment-909712470 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 52s

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-909711097 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[GitHub] [hbase] Apache-HBase commented on pull request #3654: HBASE-26244 Avoid trim the error stack trace when running UT with maven

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3654: URL: https://github.com/apache/hbase/pull/3654#issuecomment-909708827 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-909708736 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 50

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-909706802 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] gjacoby126 closed pull request #3523: HBASE-26115 - ServerTestHBaseCluster interface for testing coprocs

2021-08-31 Thread GitBox
gjacoby126 closed pull request #3523: URL: https://github.com/apache/hbase/pull/3523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] gjacoby126 commented on pull request #3523: HBASE-26115 - ServerTestHBaseCluster interface for testing coprocs

2021-08-31 Thread GitBox
gjacoby126 commented on pull request #3523: URL: https://github.com/apache/hbase/pull/3523#issuecomment-909702659 Closing for now as HBASE-26157 is an alternate solution to the same problem -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] gjacoby126 commented on pull request #3643: HBASE-26157 Expose some IA.LimitedPrivate interface in TestingHBaseCl…

2021-08-31 Thread GitBox
gjacoby126 commented on pull request #3643: URL: https://github.com/apache/hbase/pull/3643#issuecomment-909692411 @Apache9 - No objection to limiting the review on this PR to just the methods you already added. I'll approve this PR when the review on those are done, and we can do additiona

[GitHub] [hbase] gjacoby126 commented on a change in pull request #3643: HBASE-26157 Expose some IA.LimitedPrivate interface in TestingHBaseCl…

2021-08-31 Thread GitBox
gjacoby126 commented on a change in pull request #3643: URL: https://github.com/apache/hbase/pull/3643#discussion_r699695497 ## File path: hbase-testing-util/src/main/java/org/apache/hadoop/hbase/testing/TestingHBaseCluster.java ## @@ -114,6 +120,41 @@ */ void start() t

[GitHub] [hbase] caroliney14 commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-31 Thread GitBox
caroliney14 commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-909687276 @Apache9 @bharathv do you have any more comments? if not, can we merge this one? thanks -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Comment Edited] (HBASE-25697) StochasticBalancer improvement for large scale clusters

2021-08-31 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406982#comment-17406982 ] Clara Xiong edited comment on HBASE-25697 at 8/31/21, 10:10 PM: --

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-909626312 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-909620998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5

[GitHub] [hbase] Apache-HBase commented on pull request #3637: HBASE-25853 Backport HBASE-22120 "Replace HTrace with OpenTelemetry" to branch-2

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3637: URL: https://github.com/apache/hbase/pull/3637#issuecomment-909605079 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 51

[GitHub] [hbase] Apache-HBase commented on pull request #3654: HBASE-26244 Avoid trim the error stack trace when running UT with maven

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3654: URL: https://github.com/apache/hbase/pull/3654#issuecomment-909601440 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-90981 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-909546255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #3653: HBASE-26244 Avoid trim the error stack trace when running UT with maven

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3653: URL: https://github.com/apache/hbase/pull/3653#issuecomment-909541738 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 26s

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-909537179 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-909534719 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-909532760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-909525387 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[jira] [Commented] (HBASE-24833) Bootstrap should not delete the META table directory if it's not partial

2021-08-31 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407591#comment-17407591 ] Tak-Lon (Stephen) Wu commented on HBASE-24833: -- Thanks Duo and Josh, it's b

[GitHub] [hbase] Apache-HBase commented on pull request #3637: HBASE-25853 Backport HBASE-22120 "Replace HTrace with OpenTelemetry" to branch-2

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3637: URL: https://github.com/apache/hbase/pull/3637#issuecomment-909512352 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-909506232 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-909491100 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s

[GitHub] [hbase] saintstack commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
saintstack commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-909490042 Update addresses review comments. Also is more conservative than previous patches (including original posters') regards when to cache filestatus. Posted this patch against mas

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-909489966 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s

[GitHub] [hbase] Apache-HBase commented on pull request #3652: HBASE-26242 Region never split when store file count larger than the …

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3652: URL: https://github.com/apache/hbase/pull/3652#issuecomment-909459430 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] Apache-HBase commented on pull request #3652: HBASE-26242 Region never split when store file count larger than the …

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3652: URL: https://github.com/apache/hbase/pull/3652#issuecomment-909433789 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38

[GitHub] [hbase] Apache-HBase commented on pull request #3640: HBASE-25588 Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3640: URL: https://github.com/apache/hbase/pull/3640#issuecomment-909433122 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #3640: HBASE-25588 Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3640: URL: https://github.com/apache/hbase/pull/3640#issuecomment-909422375 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[jira] [Comment Edited] (HBASE-24833) Bootstrap should not delete the META table directory if it's not partial

2021-08-31 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407524#comment-17407524 ] Josh Elser edited comment on HBASE-24833 at 8/31/21, 4:52 PM:

[jira] [Commented] (HBASE-24833) Bootstrap should not delete the META table directory if it's not partial

2021-08-31 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407524#comment-17407524 ] Josh Elser commented on HBASE-24833: I'm actually coming around to figure this out a

[GitHub] [hbase] apurtell commented on pull request #3636: HBASE-26106 AbstractFSWALProvider#getArchivedLogPath doesn't look for wal file in all oldWALs directory.

2021-08-31 Thread GitBox
apurtell commented on pull request #3636: URL: https://github.com/apache/hbase/pull/3636#issuecomment-909408064 I left a 'Changes Requested' review but if the comment is addressed at commit time we don't need another round of review from me. -- This is an automated message from the Apac

[GitHub] [hbase] apurtell commented on a change in pull request #3636: HBASE-26106 AbstractFSWALProvider#getArchivedLogPath doesn't look for wal file in all oldWALs directory.

2021-08-31 Thread GitBox
apurtell commented on a change in pull request #3636: URL: https://github.com/apache/hbase/pull/3636#discussion_r699503587 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALInputFormat.java ## @@ -217,8 +217,9 @@ public boolean nextKeyValue() thr

[jira] [Updated] (HBASE-26106) AbstractFSWALProvider#getArchivedLogPath doesn't look for wal file in all oldWALs directory.

2021-08-31 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26106: Status: Patch Available (was: Open) > AbstractFSWALProvider#getArchivedLogPath do

[GitHub] [hbase] apurtell commented on a change in pull request #3636: HBASE-26106 AbstractFSWALProvider#getArchivedLogPath doesn't look for wal file in all oldWALs directory.

2021-08-31 Thread GitBox
apurtell commented on a change in pull request #3636: URL: https://github.com/apache/hbase/pull/3636#discussion_r699501624 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALRecordReader.java ## @@ -335,13 +342,16 @@ private void testSplitWith

[jira] [Updated] (HBASE-25588) Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

2021-08-31 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25588: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Pa

[GitHub] [hbase] Apache-HBase commented on pull request #3640: HBASE-25588 Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3640: URL: https://github.com/apache/hbase/pull/3640#issuecomment-909401650 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s

[GitHub] [hbase] apurtell merged pull request #3640: HBASE-25588 Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

2021-08-31 Thread GitBox
apurtell merged pull request #3640: URL: https://github.com/apache/hbase/pull/3640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Updated] (HBASE-25642) Fix or stop warning about already cached block

2021-08-31 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25642: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Pa

[GitHub] [hbase] apurtell merged pull request #3638: HBASE-25642 Fix or stop warning about already cached block

2021-08-31 Thread GitBox
apurtell merged pull request #3638: URL: https://github.com/apache/hbase/pull/3638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (HBASE-26245) Store region server list in master local region

2021-08-31 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407503#comment-17407503 ] Duo Zhang commented on HBASE-26245: --- [~zyork] I think this could solve the problem whe

[jira] [Created] (HBASE-26245) Store region server list in master local region

2021-08-31 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26245: - Summary: Store region server list in master local region Key: HBASE-26245 URL: https://issues.apache.org/jira/browse/HBASE-26245 Project: HBase Issue Type: Brainst

[GitHub] [hbase] Apache-HBase commented on pull request #3654: HBASE-26244 Avoid trim the error stack trace when running UT with maven

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3654: URL: https://github.com/apache/hbase/pull/3654#issuecomment-909368165 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3650: [HBASE-26243]Fix typo for file "hbase-server/src/main/java/org/apache…

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3650: URL: https://github.com/apache/hbase/pull/3650#issuecomment-909355605 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 29

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-909353899 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #3653: HBASE-26244 Avoid trim the error stack trace when running UT with maven

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3653: URL: https://github.com/apache/hbase/pull/3653#issuecomment-909353107 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] comnetwork closed pull request #3653: HBASE-26244 Avoid trim the error stack trace when running UT with maven

2021-08-31 Thread GitBox
comnetwork closed pull request #3653: URL: https://github.com/apache/hbase/pull/3653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] apurtell commented on a change in pull request #3641: HBASE-26006 Update ref guide about the 2.4.x release line

2021-08-31 Thread GitBox
apurtell commented on a change in pull request #3641: URL: https://github.com/apache/hbase/pull/3641#discussion_r698589117 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -291,7 +291,7 @@ link:https://hadoop.apache.org/cve_list.html[CVEs] so we drop the supp

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-909336035 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 12s

[GitHub] [hbase] Apache-HBase commented on pull request #3652: HBASE-26242 Region never split when store file count larger than the …

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3652: URL: https://github.com/apache/hbase/pull/3652#issuecomment-909314034 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33

[GitHub] [hbase] Apache-HBase commented on pull request #3636: HBASE-26106 AbstractFSWALProvider#getArchivedLogPath doesn't look for wal file in all oldWALs directory.

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3636: URL: https://github.com/apache/hbase/pull/3636#issuecomment-908469579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] apurtell commented on pull request #3641: HBASE-26006 Update ref guide about the 2.4.x release line

2021-08-31 Thread GitBox
apurtell commented on pull request #3641: URL: https://github.com/apache/hbase/pull/3641#issuecomment-908445200 @busbey @Apache9 I cut and pasted the 2.3 section to 2.4 because I am not aware of any additional consideration you need to take for upgrading from 2.3 to 2.4. It s

[GitHub] [hbase] Apache-HBase commented on pull request #3637: HBASE-25853 Backport HBASE-22120 "Replace HTrace with OpenTelemetry" to branch-2

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3637: URL: https://github.com/apache/hbase/pull/3637#issuecomment-908847318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] shahrs87 commented on pull request #3635: HBASE-26103 Deprecate BufferedMutatorParams#pool method

2021-08-31 Thread GitBox
shahrs87 commented on pull request #3635: URL: https://github.com/apache/hbase/pull/3635#issuecomment-908507075 @saintstack @anoopsjohn Could you please review ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hbase] Apache9 commented on a change in pull request #3636: HBASE-26106 AbstractFSWALProvider#getArchivedLogPath doesn't look for wal file in all oldWALs directory.

2021-08-31 Thread GitBox
Apache9 commented on a change in pull request #3636: URL: https://github.com/apache/hbase/pull/3636#discussion_r699210819 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALRecordReader.java ## @@ -335,13 +342,16 @@ private void testSplitWithM

[GitHub] [hbase] Apache9 commented on pull request #3604: HBASE-26210 HBase Write should be doomed to hang when cell size excee…

2021-08-31 Thread GitBox
Apache9 commented on pull request #3604: URL: https://github.com/apache/hbase/pull/3604#issuecomment-909124543 Need sometime to dive into the code... Code with concurrent is always the most difficult to review... Let me read your reply carefully first to see if I can get insigh

[GitHub] [hbase] taklwu commented on pull request #3637: HBASE-25853 Backport HBASE-22120 "Replace HTrace with OpenTelemetry" to branch-2

2021-08-31 Thread GitBox
taklwu commented on pull request #3637: URL: https://github.com/apache/hbase/pull/3637#issuecomment-908498926 since hadoop3 unit tests passed once , I only look at the latest failure in hadoop2, those unrelated tests are `TestClusterScopeQuotaThrottle,TestReplicationEmptyWALRecovery` in hb

[GitHub] [hbase] Apache-HBase commented on pull request #3648: HBASE-26190 High rate logging of Bucket Allocator Allocation fails

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3648: URL: https://github.com/apache/hbase/pull/3648#issuecomment-908360611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-909173548 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s

[GitHub] [hbase] shahrs87 commented on a change in pull request #3636: HBASE-26106 AbstractFSWALProvider#getArchivedLogPath doesn't look for wal file in all oldWALs directory.

2021-08-31 Thread GitBox
shahrs87 commented on a change in pull request #3636: URL: https://github.com/apache/hbase/pull/3636#discussion_r698581631 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALRecordReader.java ## @@ -335,13 +342,16 @@ private void testSplitWith

[GitHub] [hbase] hapihu closed pull request #3649: [HBASE-26243]Fix typo for file "hbase-server/src/main/java/org/apache…

2021-08-31 Thread GitBox
hapihu closed pull request #3649: URL: https://github.com/apache/hbase/pull/3649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [hbase] bbeaudreault commented on a change in pull request #3630: HBASE-26147: Add a dry run mode to the balancer, where moves are calculated but not actually executed

2021-08-31 Thread GitBox
bbeaudreault commented on a change in pull request #3630: URL: https://github.com/apache/hbase/pull/3630#discussion_r698638962 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalanceResponse.java ## @@ -0,0 +1,126 @@ +/* + * + * Licensed to the Apache S

[GitHub] [hbase] Apache9 commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-08-31 Thread GitBox
Apache9 commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r699262490 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -17,23 +17,61 @@ */ pa

[GitHub] [hbase] gjacoby126 commented on pull request #3643: HBASE-26157 Expose some IA.LimitedPrivate interface in TestingHBaseCl…

2021-08-31 Thread GitBox
gjacoby126 commented on pull request #3643: URL: https://github.com/apache/hbase/pull/3643#issuecomment-908748107 Thanks for these, @Apache9 . These will be helpful for the cell tag tests I mentioned earlier. Another API sometimes needed when testing a coproc is access to the Copro

[GitHub] [hbase] KulwantSingh011 commented on pull request #3648: HBASE-26190 High rate logging of Bucket Allocator Allocation fails

2021-08-31 Thread GitBox
KulwantSingh011 commented on pull request #3648: URL: https://github.com/apache/hbase/pull/3648#issuecomment-908320198 @anoopsjohn Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] Apache-HBase commented on pull request #3651: HBASE-25773 TestSnapshotScannerHDFSAclController.setupBeforeClass is …

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3651: URL: https://github.com/apache/hbase/pull/3651#issuecomment-909190175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] Apache-HBase commented on pull request #3650: [HBASE-26243]Fix typo for file "hbase-server/src/main/java/org/apache…

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3650: URL: https://github.com/apache/hbase/pull/3650#issuecomment-909192707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] Apache-HBase commented on pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-08-31 Thread GitBox
Apache-HBase commented on pull request #3610: URL: https://github.com/apache/hbase/pull/3610#issuecomment-909039617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] bbeaudreault removed a comment on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-31 Thread GitBox
bbeaudreault removed a comment on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-908497743 @joshelser I created https://issues.apache.org/jira/browse/HBASE-26240 to fix the InterfaceAudience. I'll submit a PR for master/branch-2 once the existing PRs are me

[GitHub] [hbase] ndimiduk commented on pull request #3630: HBASE-26147: Add a dry run mode to the balancer, where moves are calculated but not actually executed

2021-08-31 Thread GitBox
ndimiduk commented on pull request #3630: URL: https://github.com/apache/hbase/pull/3630#issuecomment-908671179 I left a comment on one of Duo's line comments, but I'll repeat it here. I'm also surprised by this interpretation of the interaction between `IA.Public` and `IS.Evolving`.

[GitHub] [hbase] bbeaudreault commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-31 Thread GitBox
bbeaudreault commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-908497743 @joshelser I created https://issues.apache.org/jira/browse/HBASE-26240 to fix the InterfaceAudience. I'll submit a PR for master/branch-2 once the existing PRs are merged.

  1   2   >