[jira] [Created] (HBASE-26358) Put up 1.4.14RC0

2021-10-12 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26358: - Summary: Put up 1.4.14RC0 Key: HBASE-26358 URL: https://issues.apache.org/jira/browse/HBASE-26358 Project: HBase Issue Type: Sub-task Reporter: Duo Zha

[jira] [Created] (HBASE-26357) Generate CHANGES.txt for 1.4.14

2021-10-12 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26357: - Summary: Generate CHANGES.txt for 1.4.14 Key: HBASE-26357 URL: https://issues.apache.org/jira/browse/HBASE-26357 Project: HBase Issue Type: Sub-task Comp

[jira] [Created] (HBASE-26356) Set version as 2.1.10 in branch-2.1 in prep for first RC of 2.1.10

2021-10-12 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26356: - Summary: Set version as 2.1.10 in branch-2.1 in prep for first RC of 2.1.10 Key: HBASE-26356 URL: https://issues.apache.org/jira/browse/HBASE-26356 Project: HBase

[jira] [Updated] (HBASE-26356) Set version as 2.1.10 in branch-2.1 in prep for first RC of 2.1.10

2021-10-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26356: -- Component/s: pom build > Set version as 2.1.10 in branch-2.1 in prep for first RC of

[jira] [Created] (HBASE-26355) Release 1.4.14

2021-10-12 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26355: - Summary: Release 1.4.14 Key: HBASE-26355 URL: https://issues.apache.org/jira/browse/HBASE-26355 Project: HBase Issue Type: Task Reporter: Duo Zhang P

[GitHub] [hbase] Apache-HBase commented on pull request #3741: HBASE-26344 Fix Bug for MultiByteBuff.put(int, byte)

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3741: URL: https://github.com/apache/hbase/pull/3741#issuecomment-941899876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8

[GitHub] [hbase] Apache-HBase commented on pull request #3741: HBASE-26344 Fix Bug for MultiByteBuff.put(int, byte)

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3741: URL: https://github.com/apache/hbase/pull/3741#issuecomment-941890631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[GitHub] [hbase] Apache-HBase commented on pull request #3741: HBASE-26344 Fix Bug for MultiByteBuff.put(int, byte)

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3741: URL: https://github.com/apache/hbase/pull/3741#issuecomment-941890310 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #3741: HBASE-26344 Fix Bug for MultiByteBuff.put(int, byte)

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3741: URL: https://github.com/apache/hbase/pull/3741#issuecomment-941877091 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hbase] leyangyueshan removed a comment on pull request #3524: HBASE-26117 RIT counts should be configured when cluster is balancing

2021-10-12 Thread GitBox
leyangyueshan removed a comment on pull request #3524: URL: https://github.com/apache/hbase/pull/3524#issuecomment-941875427 > This is hard coded in the past? Oh no. > > And maybe it should be a percentage instead of a fixed value? Consider you have 10 regions, maybe 5 is too large b

[GitHub] [hbase] leyangyueshan commented on pull request #3524: HBASE-26117 RIT counts should be configured when cluster is balancing

2021-10-12 Thread GitBox
leyangyueshan commented on pull request #3524: URL: https://github.com/apache/hbase/pull/3524#issuecomment-941876104 @Apache9 Thanks, It’s should be configured!The percentage is complicated for business side I think。 -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] leyangyueshan commented on pull request #3524: HBASE-26117 RIT counts should be configured when cluster is balancing

2021-10-12 Thread GitBox
leyangyueshan commented on pull request #3524: URL: https://github.com/apache/hbase/pull/3524#issuecomment-941875427 > This is hard coded in the past? Oh no. > > And maybe it should be a percentage instead of a fixed value? Consider you have 10 regions, maybe 5 is too large but if yo

[GitHub] [hbase] Apache-HBase commented on pull request #3741: HBASE-26344 Fix Bug for MultiByteBuff.put(int, byte)

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3741: URL: https://github.com/apache/hbase/pull/3741#issuecomment-941868016 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58

[GitHub] [hbase] Apache-HBase commented on pull request #3741: HBASE-26344 Fix Bug for MultiByteBuff.put(int, byte)

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3741: URL: https://github.com/apache/hbase/pull/3741#issuecomment-941867866 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #86: HBASE-26354 [hbase-connectors] Added python client for HBase thrift service

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #86: URL: https://github.com/apache/hbase-connectors/pull/86#issuecomment-941864042 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache9 commented on a change in pull request #3746: HBASE-26348 Implement a special procedure to migrate rs group informa…

2021-10-12 Thread GitBox
Apache9 commented on a change in pull request #3746: URL: https://github.com/apache/hbase/pull/3746#discussion_r727654807 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableDescriptorProcedure.java ## @@ -0,0 +1,161 @@ +/** + * License

[GitHub] [hbase] GeorryHuang commented on pull request #3746: HBASE-26348 Implement a special procedure to migrate rs group informa…

2021-10-12 Thread GitBox
GeorryHuang commented on pull request #3746: URL: https://github.com/apache/hbase/pull/3746#issuecomment-941862472 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] GeorryHuang commented on a change in pull request #3746: HBASE-26348 Implement a special procedure to migrate rs group informa…

2021-10-12 Thread GitBox
GeorryHuang commented on a change in pull request #3746: URL: https://github.com/apache/hbase/pull/3746#discussion_r727654229 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableDescriptorProcedure.java ## @@ -0,0 +1,161 @@ +/** + * Lic

[GitHub] [hbase] Apache-HBase commented on pull request #3748: HBASE-26353 Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3748: URL: https://github.com/apache/hbase/pull/3748#issuecomment-941857673 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3748: HBASE-26353 Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3748: URL: https://github.com/apache/hbase/pull/3748#issuecomment-941856360 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33

[GitHub] [hbase] Apache9 commented on a change in pull request #3748: HBASE-26353 Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread GitBox
Apache9 commented on a change in pull request #3748: URL: https://github.com/apache/hbase/pull/3748#discussion_r727647509 ## File path: hbase-compression/hbase-compression-zstd/src/main/java/org/apache/hadoop/hbase/io/compress/zstd/ZstdCodec.java ## @@ -123,4 +137,42 @@ static

[GitHub] [hbase] Apache-HBase commented on pull request #3748: HBASE-26353 Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3748: URL: https://github.com/apache/hbase/pull/3748#issuecomment-941854864 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 52

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #86: HBASE-26354 [hbase-connectors] Added python client for HBase thrift service

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #86: URL: https://github.com/apache/hbase-connectors/pull/86#issuecomment-941846746 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache9 commented on pull request #3748: HBASE-26353 Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread GitBox
Apache9 commented on pull request #3748: URL: https://github.com/apache/hbase/pull/3748#issuecomment-941845844 > Note: Beware, if the dictionary is lost, the data will not be decompressable. Haven't read the code yet, but is it possible to copy the dict into the hbase storage so it

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #86: HBASE-26354 [hbase-connectors] Added python client for HBase thrift service

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #86: URL: https://github.com/apache/hbase-connectors/pull/86#issuecomment-941841232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-connectors] YutSean opened a new pull request #86: HBASE-26354 [hbase-connectors] Added python client for HBase thrift service

2021-10-12 Thread GitBox
YutSean opened a new pull request #86: URL: https://github.com/apache/hbase-connectors/pull/86 https://issues.apache.org/jira/browse/HBASE-26354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (HBASE-26353) Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26353: Description: ZStandard supports initialization of compressors and decompressors wi

[jira] [Updated] (HBASE-26353) Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26353: Description: ZStandard supports initialization of compressors and decompressors wi

[jira] [Created] (HBASE-26354) [hbase-connectors] Added python client for HBase thrift service

2021-10-12 Thread Yutong Xiao (Jira)
Yutong Xiao created HBASE-26354: --- Summary: [hbase-connectors] Added python client for HBase thrift service Key: HBASE-26354 URL: https://issues.apache.org/jira/browse/HBASE-26354 Project: HBase

[jira] [Updated] (HBASE-26353) Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26353: Status: Patch Available (was: Open) > Support loadable dictionaries in hbase-comp

[GitHub] [hbase] apurtell opened a new pull request #3748: HBASE-26353 Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread GitBox
apurtell opened a new pull request #3748: URL: https://github.com/apache/hbase/pull/3748 ZStandard supports initialization of compressors and decompressors with a precomputed dictionary, which can dramatically improve and speed up compression of tables with small values. For more details,

[jira] [Created] (HBASE-26353) Support loadable dictionaries in hbase-compression-zstd

2021-10-12 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-26353: --- Summary: Support loadable dictionaries in hbase-compression-zstd Key: HBASE-26353 URL: https://issues.apache.org/jira/browse/HBASE-26353 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3679: HBASE-26267 Don't try to recover WALs from a WAL dir which doesn't exist

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3679: URL: https://github.com/apache/hbase/pull/3679#issuecomment-941814572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2

[GitHub] [hbase] Apache-HBase commented on pull request #3721: HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker…

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3721: URL: https://github.com/apache/hbase/pull/3721#issuecomment-941798031 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 3

[GitHub] [hbase] joshelser commented on a change in pull request #3721: HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker…

2021-10-12 Thread GitBox
joshelser commented on a change in pull request #3721: URL: https://github.com/apache/hbase/pull/3721#discussion_r727605083 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTracker.java ## @@ -75,13 +76,13 @@ void replace(

[GitHub] [hbase] Apache-HBase commented on pull request #3679: HBASE-26267 Don't try to recover WALs from a WAL dir which doesn't exist

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3679: URL: https://github.com/apache/hbase/pull/3679#issuecomment-941782927 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s

[GitHub] [hbase] Apache-HBase commented on pull request #3721: HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker…

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3721: URL: https://github.com/apache/hbase/pull/3721#issuecomment-941736336 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] z-york commented on pull request #3679: HBASE-26267 Don't try to recover WALs from a WAL dir which doesn't exist

2021-10-12 Thread GitBox
z-york commented on pull request #3679: URL: https://github.com/apache/hbase/pull/3679#issuecomment-941670805 > > I had solved this by just creating the walsDir here if it didn't exist, is there a reason you decided to skip it instead of create the dir? If we just create the directory it w

[GitHub] [hbase] z-york commented on pull request #3712: HBASE-26320 Implement a separate thread pool for the LogCleaner

2021-10-12 Thread GitBox
z-york commented on pull request #3712: URL: https://github.com/apache/hbase/pull/3712#issuecomment-941634995 The unit test failures don't seem related and only fail on Java 11 it seems. @Apache9 Do you have any further comments? Thanks -- This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #3679: HBASE-26267 Don't try to recover WALs from a WAL dir which doesn't exist

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3679: URL: https://github.com/apache/hbase/pull/3679#issuecomment-941622587 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #3721: HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker…

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3721: URL: https://github.com/apache/hbase/pull/3721#issuecomment-941532157 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] joshelser commented on pull request #3679: HBASE-26267 Don't try to recover WALs from a WAL dir which doesn't exist

2021-10-12 Thread GitBox
joshelser commented on pull request #3679: URL: https://github.com/apache/hbase/pull/3679#issuecomment-941524435 Let me fix Duo's suggestion and then merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [hbase] Apache-HBase commented on pull request #3747: [HBASE-26351] Implement a table-based region grouping strategy for Re…

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3747: URL: https://github.com/apache/hbase/pull/3747#issuecomment-941444895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

[GitHub] [hbase] Apache-HBase commented on pull request #3747: [HBASE-26351] Implement a table-based region grouping strategy for Re…

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3747: URL: https://github.com/apache/hbase/pull/3747#issuecomment-941434451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1

[GitHub] [hbase] wchevreuil commented on a change in pull request #3721: HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker…

2021-10-12 Thread GitBox
wchevreuil commented on a change in pull request #3721: URL: https://github.com/apache/hbase/pull/3721#discussion_r727458552 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/MigrationStoreFileTracker.java ## @@ -89,14 +90,16 @@ voi

[GitHub] [hbase] Apache-HBase commented on pull request #3746: HBASE-26348 Implement a special procedure to migrate rs group informa…

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3746: URL: https://github.com/apache/hbase/pull/3746#issuecomment-941334517 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m 44

[GitHub] [hbase] Apache-HBase commented on pull request #3746: HBASE-26348 Implement a special procedure to migrate rs group informa…

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3746: URL: https://github.com/apache/hbase/pull/3746#issuecomment-941298464 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[jira] [Commented] (HBASE-26267) Master initialization fails if Master Region WAL dir is missing

2021-10-12 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427847#comment-17427847 ] Tak-Lon (Stephen) Wu commented on HBASE-26267: -- HBASE-24833 merged.  > Mas

[jira] [Updated] (HBASE-24833) Bootstrap should not delete the META table directory if it's not partial

2021-10-12 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-24833: - Fix Version/s: 2.5.0 > Bootstrap should not delete the META table directory if i

[jira] [Resolved] (HBASE-24833) Bootstrap should not delete the META table directory if it's not partial

2021-10-12 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-24833. -- Resolution: Fixed > Bootstrap should not delete the META table directory if it

[GitHub] [hbase] taklwu commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2021-10-12 Thread GitBox
taklwu commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-941241199 merged and if we need a new documentation, we can have a followup JIRA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [hbase] taklwu merged pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2021-10-12 Thread GitBox
taklwu merged pull request #2237: URL: https://github.com/apache/hbase/pull/2237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [hbase] nkalmar edited a comment on pull request #3737: HBASE-26340 - fix RegionSizeCalculator getLEngth to bytes instead of …

2021-10-12 Thread GitBox
nkalmar edited a comment on pull request #3737: URL: https://github.com/apache/hbase/pull/3737#issuecomment-941196132 I assumed Size class method get(Unit unit) will return the value in the given unit, but turns out it has just the same conversation basically, and we set it in MB so while

[GitHub] [hbase] Apache-HBase commented on pull request #3747: [HBASE-26351] Implement a table-based region grouping strategy for Re…

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3747: URL: https://github.com/apache/hbase/pull/3747#issuecomment-941203857 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m 9

[GitHub] [hbase] Apache-HBase commented on pull request #3746: HBASE-26348 Implement a special procedure to migrate rs group informa…

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3746: URL: https://github.com/apache/hbase/pull/3746#issuecomment-941201914 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] joshelser commented on a change in pull request #3743: HBASE-26350 Add a DEBUG when we fail the SASL handshake

2021-10-12 Thread GitBox
joshelser commented on a change in pull request #3743: URL: https://github.com/apache/hbase/pull/3743#discussion_r727333702 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java ## @@ -372,6 +372,7 @@ public void saslReadAndProcess(ByteB

[GitHub] [hbase] joshelser commented on a change in pull request #3743: HBASE-26350 Add a DEBUG when we fail the SASL handshake

2021-10-12 Thread GitBox
joshelser commented on a change in pull request #3743: URL: https://github.com/apache/hbase/pull/3743#discussion_r727332522 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java ## @@ -372,6 +372,7 @@ public void saslReadAndProcess(ByteB

[GitHub] [hbase] nkalmar edited a comment on pull request #3737: HBASE-26340 - fix RegionSizeCalculator getLEngth to bytes instead of …

2021-10-12 Thread GitBox
nkalmar edited a comment on pull request #3737: URL: https://github.com/apache/hbase/pull/3737#issuecomment-941196132 I assumed Size class method get(Unit unit) will return the value in teh given unit, but turns out it has just the same conversation basically, and we set it in MB so while

[GitHub] [hbase] nkalmar commented on pull request #3737: HBASE-26340 - fix RegionSizeCalculator getLEngth to bytes instead of …

2021-10-12 Thread GitBox
nkalmar commented on pull request #3737: URL: https://github.com/apache/hbase/pull/3737#issuecomment-941196132 I assumed Size class method get(Unit unit) will return the value in teh given unit, but turns out it has just the same conversation basically, and we set it in MB so while we do g

[GitHub] [hbase] attilapiros commented on pull request #3737: HBASE-26340 - fix RegionSizeCalculator getLEngth to bytes instead of …

2021-10-12 Thread GitBox
attilapiros commented on pull request #3737: URL: https://github.com/apache/hbase/pull/3737#issuecomment-941163910 Sorry I did not get this change. I think the calculated values will be the same before and after this PR. Especially as the tests are not updated, i.e.: https://git

[jira] [Commented] (HBASE-26351) Implement a table-based region grouping strategy for RegionGroupingProvider

2021-10-12 Thread fengxianjing (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427783#comment-17427783 ] fengxianjing commented on HBASE-26351: -- [~zhangduo] I have created a github PR,  pl

[GitHub] [hbase] shahrs87 commented on pull request #3577: HBASE-26185 Return mutable list in AssignmentManager#getExcludedServersForSystemTable

2021-10-12 Thread GitBox
shahrs87 commented on pull request #3577: URL: https://github.com/apache/hbase/pull/3577#issuecomment-941157793 @ndimiduk Will take care next time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HBASE-26351) Implement a table-based region grouping strategy for RegionGroupingProvider

2021-10-12 Thread fengxianjing (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fengxianjing updated HBASE-26351: - External issue URL: (was: https://reviews.apache.org/r/73648) > Implement a table-based region

[jira] [Updated] (HBASE-25773) TestSnapshotScannerHDFSAclController.setupBeforeClass is flaky

2021-10-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25773: - Fix Version/s: 2.4.8 2.3.7 > TestSnapshotScannerHDFSAclController.setupBefore

[GitHub] [hbase] xianjingfeng opened a new pull request #3747: [HBASE-26351] Implement a table-based region grouping strategy for Re…

2021-10-12 Thread GitBox
xianjingfeng opened a new pull request #3747: URL: https://github.com/apache/hbase/pull/3747 Implement a table-based region grouping strategy for RegionGroupingProvider -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] Apache9 commented on pull request #3746: HBASE-26348 Implement a special procedure to migrate rs group informa…

2021-10-12 Thread GitBox
Apache9 commented on pull request #3746: URL: https://github.com/apache/hbase/pull/3746#issuecomment-941150086 @GeorryHuang PTAL. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] Apache9 opened a new pull request #3746: HBASE-26348 Implement a special procedure to migrate rs group informa…

2021-10-12 Thread GitBox
Apache9 opened a new pull request #3746: URL: https://github.com/apache/hbase/pull/3746 …tion when upgrading -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [hbase] ndimiduk commented on pull request #3577: HBASE-26185 Return mutable list in AssignmentManager#getExcludedServersForSystemTable

2021-10-12 Thread GitBox
ndimiduk commented on pull request #3577: URL: https://github.com/apache/hbase/pull/3577#issuecomment-941147190 Thanks for the quick reply @shahrs87 . For future reference, our policy is that all commits' titles must match their Jira titles, and our convention for addendums is to append th

[GitHub] [hbase] shahrs87 commented on pull request #3577: HBASE-26185 Return mutable list in AssignmentManager#getExcludedServersForSystemTable

2021-10-12 Thread GitBox
shahrs87 commented on pull request #3577: URL: https://github.com/apache/hbase/pull/3577#issuecomment-941144839 > Was this supposed to be an addendum, or was it committed under the wrong JIRA ID? It was an addendum patch with the proper fix. @ndimiduk -- This is an automated mes

[GitHub] [hbase] ndimiduk commented on pull request #3577: HBASE-26185 Return mutable list in AssignmentManager#getExcludedServersForSystemTable

2021-10-12 Thread GitBox
ndimiduk commented on pull request #3577: URL: https://github.com/apache/hbase/pull/3577#issuecomment-941140844 @shahrs87 @virajjasani FYI, looks like the JIRA ID for this ticket is incorrect ; at least, the title of the commit and PR doesn't match that of the JIRA. Was this supposed to be

[jira] [Updated] (HBASE-26350) Missing server side debugging on failed SASL handshake

2021-10-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26350: - Fix Version/s: (was: 2.3.7) 2.3.8 > Missing server side debugging on fail

[GitHub] [hbase] ndimiduk commented on a change in pull request #3743: HBASE-26350 Add a DEBUG when we fail the SASL handshake

2021-10-12 Thread GitBox
ndimiduk commented on a change in pull request #3743: URL: https://github.com/apache/hbase/pull/3743#discussion_r727267763 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java ## @@ -372,6 +372,7 @@ public void saslReadAndProcess(ByteBu

[GitHub] [hbase] ndimiduk commented on a change in pull request #3743: HBASE-26350 Add a DEBUG when we fail the SASL handshake

2021-10-12 Thread GitBox
ndimiduk commented on a change in pull request #3743: URL: https://github.com/apache/hbase/pull/3743#discussion_r727266507 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java ## @@ -372,6 +372,7 @@ public void saslReadAndProcess(ByteBu

[jira] [Updated] (HBASE-26027) The calling of HTable.batch blocked at AsyncRequestFutureImpl.waitUntilDone caused by ArrayStoreException

2021-10-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26027: - Fix Version/s: (was: 2.3.7) 2.3.8 > The calling of HTable.batch blocked a

[jira] [Updated] (HBASE-22978) Online slow response log

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22978: - Attachment: NamedQueue_Framework_Design.pdf > Online slow response log > ---

[jira] [Updated] (HBASE-24718) Generic NamedQueue framework for recent in-memory history

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24718: - Attachment: (was: Screen Shot 2020-07-20 at 2.50.34 PM.png) > Generic NamedQueue framework f

[jira] [Updated] (HBASE-24718) Generic NamedQueue framework for recent in-memory history

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24718: - Attachment: NamedQueue_Framework_Design.pdf > Generic NamedQueue framework for recent in-memory

[jira] [Updated] (HBASE-24528) Improve balancer decision observability

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24528: - Attachment: NamedQueue_Framework_Design.pdf > Improve balancer decision observability >

[jira] [Updated] (HBASE-26345) Design doc for HBase NamedQueue framework

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26345: - Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Updated] (HBASE-26345) Design doc for HBase NamedQueue framework

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26345: - Attachment: NamedQueue_Framework_Design.pdf > Design doc for HBase NamedQueue framework > --

[jira] [Updated] (HBASE-26345) Design doc for HBase NamedQueue framework

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26345: - Attachment: (was: NamedQueue_DesignDoc.pdf) > Design doc for HBase NamedQueue framework > --

[jira] [Commented] (HBASE-26345) Design doc for HBase NamedQueue framework

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427755#comment-17427755 ] Viraj Jasani commented on HBASE-26345: -- Let me commit with this change. If any furt

[jira] [Updated] (HBASE-26345) Design doc for HBase NamedQueue framework

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26345: - Attachment: NamedQueue_DesignDoc.pdf > Design doc for HBase NamedQueue framework > -

[GitHub] [hbase] Apache-HBase commented on pull request #3745: HBASE-26284 Add HBase Thrift API to get all table names along with whether it is enabled or not

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3745: URL: https://github.com/apache/hbase/pull/3745#issuecomment-941098286 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6

[GitHub] [hbase] Apache-HBase commented on pull request #3745: HBASE-26284 Add HBase Thrift API to get all table names along with whether it is enabled or not

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3745: URL: https://github.com/apache/hbase/pull/3745#issuecomment-941097011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44

[jira] [Comment Edited] (HBASE-26345) Design doc for HBase NamedQueue framework

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427647#comment-17427647 ] Viraj Jasani edited comment on HBASE-26345 at 10/12/21, 3:02 PM: -

[jira] [Comment Edited] (HBASE-26345) Design doc for HBase NamedQueue framework

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427647#comment-17427647 ] Viraj Jasani edited comment on HBASE-26345 at 10/12/21, 3:00 PM: -

[GitHub] [hbase] Apache-HBase commented on pull request #3745: HBASE-26284 Add HBase Thrift API to get all table names along with whether it is enabled or not

2021-10-12 Thread GitBox
Apache-HBase commented on pull request #3745: URL: https://github.com/apache/hbase/pull/3745#issuecomment-941093292 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42

[jira] [Updated] (HBASE-26343) Extend RSGroup to support data isolation to achieve true multitenancy in Hbase

2021-10-12 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-26343: Description: RSGroups currently only provide isolation on serving layer, but not on the data laye

[jira] [Updated] (HBASE-26343) Extend RSGroup to support data isolation to achieve true multitenancy in Hbase

2021-10-12 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-26343: Description: RSGroups currently only provide isolation on serving layer, but not on the data laye

[GitHub] [hbase] horvathdora opened a new pull request #3745: HBASE-26284 Add HBase Thrift API to get all table names along with whether it is enabled or not

2021-10-12 Thread GitBox
horvathdora opened a new pull request #3745: URL: https://github.com/apache/hbase/pull/3745 (#3693) Signed-off-by: Norbert Kalmar Signed-off-by: Wellington Chevreuil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HBASE-26284) Add HBase Thrift API to get all table names along with whether it is enabled or not

2021-10-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427677#comment-17427677 ] Hudson commented on HBASE-26284: Results for branch master [build #410 on build

[GitHub] [hbase] comnetwork commented on pull request #3741: HBASE-26344 Fix Bug for MultiByteBuff.put(int, byte)

2021-10-12 Thread GitBox
comnetwork commented on pull request #3741: URL: https://github.com/apache/hbase/pull/3741#issuecomment-941009270 @Apache9 , sorry to ignore checkstyle error again, I would fix it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (HBASE-26312) Shell scan fails with timestamp

2021-10-12 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427658#comment-17427658 ] Anoop Sam John commented on HBASE-26312: Thanks.. I thought it was applied only

[jira] [Commented] (HBASE-26345) Design doc for HBase NamedQueue framework

2021-10-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427647#comment-17427647 ] Viraj Jasani commented on HBASE-26345: -- Thanks [~apurtell] for the review! {quote}T

[GitHub] [hbase] Apache9 commented on pull request #3741: HBASE-26344 Fix Bug for MultiByteBuff.put(int, byte)

2021-10-12 Thread GitBox
Apache9 commented on pull request #3741: URL: https://github.com/apache/hbase/pull/3741#issuecomment-940784786 Please fix the javac and checkstyle issues? Seems easy to fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and